July 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 04/12] d3drm: Implement IDirect3DRMDevice*::Add/DeleteDestroyCallback.
by Aaryaman Vasishta July 8, 2016

July 8, 2016

On Thu, Jul 7, 2016 at 7:22 PM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com > wrote: > > @@ -65,6 +65,7 @@ void d3drm_device_destroy(struct d3drm_device *device) > IDirectDraw_Release(device->ddraw); > IDirect3DRM_Release(device->d3drm); > } > + d3drm_object_cleanup((IDirect3DRMObject > *)&device->IDirect3DRMDevice_iface, &device->obj); > HeapFree(GetProcessHeap(), 0, device); > } > I should've probably put d3drm_object_cleanup at the beginning.

1 0

Re: [PATCH v2 3/3] winex11.drv: fix NULL pointer dereference (clang)
by Alexandre Julliard July 8, 2016

July 8, 2016

Kirill Smirnov <kirill.k.smirnov(a)gmail.com> writes: > @@ -1679,6 +1679,11 @@ static void xrender_put_image( Pixmap src_pixmap, Picture src_pict, Picture mask > } > else > { > + if (!physdev) > + { > + ERR("physdev is NULL\n"); > + return; > + } This should never happen. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] server: Move the \BaseNamedObjects symlink from \Sessions\0 to \Sessions\1\BaseNamedObjects.
by flan July 8, 2016

July 8, 2016

What is wrong with the patch? Right now the most glaring formatting issue I can find is inconsistent spacing in a variable declaration, but I'm asking just in case there are more problems I haven't noticed.

3 7

[PATCH] server: Move the \BaseNamedObjects symlink from \Sessions\0 to \Sessions\1\BaseNamedObjects.
by flan July 7, 2016

July 7, 2016

What is wrong with the patch? Right now the most glaring formatting issue I can find is inconsistent spacing in a variable declaration, but I'm asking just in case there are more problems I haven't noticed.

1 0

Re: [PATCH 01/12] d3drm: Store reference to IDirect3DRM in struct d3drm_device.
by Aaryaman Vasishta July 7, 2016

July 7, 2016

The end of the subject should have "d3drm_device_create" instead of "struct d3drm_device". On Thu, Jul 7, 2016 at 8:18 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of weeks, please resend the patch. >

1 0

Re: [PATCH] wininet: fix the bug can not save proxy bypass server into regedit by ie internet options dialog
by Alex Henrie July 7, 2016

July 7, 2016

Hi huangxuewei, Thanks for your interest in contributing to Wine! The Wine project requires you to use your real name (with capitalization and spaces) when submitting patches. It would also help to link to a bug report in the patch email, and to add tests to demonstrate that the behavior you want is the correct behavior. -Alex

1 0

Re: [PATCH] ws2_32: Allow user to enable IP dual stack (v4)
by Marvin July 7, 2016

July 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24060 Your paranoid android. === wvistau64 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: -559038737; 10048 expected if IPv6 binds to IPv4 as well). === w2008s64 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: -559038737; 10048 expected if IPv6 binds to IPv4 as well). sock: unhandled exception c0000005 at 00000000 === w7u (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w7pro64 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w8 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w864 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w1064 (32 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === wvistau64 (64 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: -559038737; 10048 expected if IPv6 binds to IPv4 as well). === w2008s64 (64 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: -559038737; 10048 expected if IPv6 binds to IPv4 as well). === w7pro64 (64 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w864 (64 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well). === w1064 (64 bit sock) === sock.c:6149: Test failed: IPV6_V6ONLY is enabled after bind. sock.c:6158: Test failed: Failed to disable IPV6_V6ONLY (LastError: 0; 10048 expected if IPv6 binds to IPv4 as well).

1 0

Re: [PATCH 3/3] mshtml: Export IElementSelector for all elements in compatibility mode >= IE8.
by Marvin July 7, 2016

July 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24059 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [10/10] webservices: Implement WsWriteBody.
by Marvin July 7, 2016

July 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24055 Your paranoid android. === build (build) === Make failed

1 0

Re: [09/10] webservices: Implement WsWriteEnvelopeEnd.
by Marvin July 7, 2016

July 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24054 Your paranoid android. === build (build) === Make failed

1 0