August 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 3/3] jscript: Added more tests.
by Marvin Aug. 5, 2016

Aug. 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24755 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: wininet: Return data available in current chunk in chunked_get_avail_data.
by Sebastian Lackner Aug. 5, 2016

Aug. 5, 2016

On 02.08.2016 15:33, Jacek Caban wrote: > > Based on patch by Hans Leidekker. > > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/wininet/http.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > It seems like this patch introduced test failures here: ../../../tools/runtest -q -P wine -T ../../.. -M wininet.dll -p wininet_test.exe.so http && touch http.ok http.c:815: Test failed: length = 12960, expected <= 8192

2 1

Re: [PATCH] dsound: Fix its vs it's typos
by Andrew Eikum Aug. 5, 2016

Aug. 5, 2016

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> On Thu, Aug 04, 2016 at 10:57:43AM +0300, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/dsound/sound3d.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/dsound/sound3d.c b/dlls/dsound/sound3d.c > index 840ab93..b416cdc 100644 > --- a/dlls/dsound/sound3d.c > +++ b/dlls/dsound/sound3d.c > @@ -294,12 +294,12 @@ if(0) > dsb->ds3db_ds3db.vVelocity.z == dsb->device->ds3dl.vVelocity.z)) > { > /* calculate length of ds3db_ds3db.vVelocity component which causes Doppler Effect > - NOTE: if buffer moves TOWARDS the listener, it's velocity component is NEGATIVE > - if buffer moves AWAY from listener, it's velocity component is POSITIVE */ > + NOTE: if buffer moves TOWARDS the listener, its velocity component is NEGATIVE > + if buffer moves AWAY from listener, its velocity component is POSITIVE */ > flBufferVel = ProjectVector(&dsb->ds3db_ds3db.vVelocity, &vDistance); > /* calculate length of ds3dl.vVelocity component which causes Doppler Effect > - NOTE: if listener moves TOWARDS the buffer, it's velocity component is POSITIVE > - if listener moves AWAY from buffer, it's velocity component is NEGATIVE */ > + NOTE: if listener moves TOWARDS the buffer, its velocity component is POSITIVE > + if listener moves AWAY from buffer, its velocity component is NEGATIVE */ > flListenerVel = ProjectVector(&dsb->device->ds3dl.vVelocity, &vDistance); > /* formula taken from Gianicoli D.: Physics, 4th edition: */ > /* FIXME: replace dsb->freq with appropriate frequency ! */ > -- > 2.8.1 > > >

1 0

Re: [PATCH 1/2] msvcp140: Take _Mtx_t and _Cnd_t directly
by Piotr Caban Aug. 5, 2016

Aug. 5, 2016

On 08/05/16 00:33, Daniel Lehman wrote: > +#if _MSVCP_VER >= 140 > +typedef _Mtx_t _Mtx_arg_t; > +#define D(m) (m) > +#define R(m) (m) > +#else > +typedef _Mtx_t *_Mtx_arg_t; > +#define D(m) (*(m)) > +#define R(m) (&(m)) > +#endif How about changing the defines names to something more meaningful, like e.g.: #define MTX_T_FROM_ARG(m) ... #define MTX_T_TO_ARG(m) ... ? Thanks, Piotr

1 0

Re: [PATCH 1/2] concrt140: Add concrt140 stub
by Piotr Caban Aug. 5, 2016

Aug. 5, 2016

On 08/05/16 00:33, Daniel Lehman wrote: > +MODULE = concrt140.dll > + > + > +C_SRCS = \ > + concrt140_main.c Do you need the concrt140_main.c file? I think the file may be added later (when needed). Thanks, Piotr

1 0

Re: usp10/tests: Reserve for InClass a byte for every character in teststr. (v3)
by Huw Davies Aug. 5, 2016

Aug. 5, 2016

On Fri, Aug 05, 2016 at 12:50:10AM +0200, Bernhard Übelacker wrote: > diff --git a/dlls/usp10/tests/usp10.c b/dlls/usp10/tests/usp10.c > index 6b2152f..971e275 100644 > --- a/dlls/usp10/tests/usp10.c > +++ b/dlls/usp10/tests/usp10.c > @@ -2900,7 +2900,7 @@ static void test_ScriptString(HDC hdc) > DWORD Flags = SSA_GLYPHS; > int ReqWidth = 100; > const int Dx[5] = {10, 10, 10, 10, 10}; > - const BYTE InClass = 0; > + static const BYTE InClass[8]; /* Array size needs to be at least equal to String_len */ And yet len == 10 in this case ;-) How about: static const BYTE InClass[ (sizeof(teststr) / sizeof(WCHAR)) - 1 ]; Of course now I've noticed Dx[5], that's clearly wrong. The sdk has it marked as _In_reads_opt_(cString), so I suggest marking this the same length too. Huw.

1 0

Re: [PATCH] ntdll: Call __finally blocks in __C_specific_handler
by Piotr Caban Aug. 5, 2016

Aug. 5, 2016

Hi, I was also trying to implement support for finally blocks. My implementation differs a little from yours. On 08/05/16 02:53, Daniel Lehman wrote: > + if (rec->ExceptionFlags & (EH_UNWINDING | EH_EXIT_UNWIND)) > + { > + for (i = 0; i < table->Count; i++) > + { > + if (context->Rip >= dispatch->ImageBase + table->ScopeRecord[i].BeginAddress && > + context->Rip < dispatch->ImageBase + table->ScopeRecord[i].EndAddress) > + { > + if (table->ScopeRecord[i].JumpTarget) continue; > + > + if (rec->ExceptionFlags & EH_TARGET_UNWIND && > + dispatch->TargetIp < dispatch->ImageBase + table->ScopeRecord[i].EndAddress) I was also checking if: dispatch->TargetIp >= dispatch->ImageBase + table->ScopeRecord[i].BeginAddress I'm not sure if this is needed. > + { > + break; > + } > + > + handler = (PC_LANGUAGE_EXCEPTION_HANDLER)(dispatch->ImageBase + table->ScopeRecord[i].HandlerAddress); Termination handlers have different signature. I was using following definition: typedef void (WINAPI *TERMINATION_HANDLER)( ULONG flags, ULONG64 frame ); I don't really know what is passed in first argument. I guess that it might be BYTE is_abnormal. On Windows flags were set to 0x1101 or 0x1201 in my test applications (I think that probably only least significant BYTE matters). Thanks, Piotr

1 0

Re: [PATCH 2/4] ucrtbase: Add __std_type_info_name implementation
by Sebastian Lackner Aug. 5, 2016

Aug. 5, 2016

On 04.08.2016 16:28, Piotr Caban wrote: > +static void CDECL type_info_entry_free(void *ptr) > +{ > + ptr = (char*)ptr - FIELD_OFFSET(type_info_entry, name); > + MSVCRT_free(ptr); > +} [...] > + else > + { > + type_info_entry *entry = (type_info_entry*)(name-FIELD_OFFSET(type_info_entry, name)); > + InterlockedPushEntrySList(header, &entry->entry); > + } Its up to you of course, but why not CONTAINING_RECORD in those two cases?

2 1

Re: usp10/tests: Reserve for InClass a byte for every character in teststr. (v3)
by Marvin Aug. 4, 2016

Aug. 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24733 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: urlmon/tests: Make use of todo_wine_if().
by Marvin Aug. 4, 2016

Aug. 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24731 Your paranoid android. === w7u (32 bit url) === url.c:3414: Test failed: bctx should be destroyed here

1 0