January 2017 - Wine-Devel - list.winehq.org

TestBot news
by Francois Gouget Jan. 21, 2017

Jan. 21, 2017

I have upgraded Debian on vm1 from 7 to 8.6 and the filesystem from ext3 to ext4. This gets it a non-antique version of the kernel and QEMU which includes Huw's fix for the ntdll:exception test. So there should be one less unfixable failure for VMs being run on vm1. That said I'm not really happy with the state of things on vm1: for some reason its reverts are much slower than they should be. For instance with the wvista VM doing 3 reverts in a row on otherwise idle machines gives me: vm1 56.361s 46.803s 46.569s vm2 10.206s 9.783s 9.912s vm3 9.583s 8.137s 8.004s One could think that vm2 has much better hardware but that's just not the case: PassMark Disk Disk Host CPU MT ST Type Speed vm1 Xeon E3-1230v2 8855 1940 HD 130 MB/s vm2 Opteron 6128 6959 n/a HD Raid0 144 MB/s vm3 Xeon E3-1226v3 7462 2127 SSD 354 MB/s All hosts have 16 GB of RAM. So vm2 has what looks like a somewhat slower processor and a marginally faster disk thanks to Raid0. That should not be sufficient for it to be 4 times faster, particularly given that vm3 has a disk that's over twice as fast is only marginally faster than vm2. Indeed during the revert vm1 shows no read traffic (lots of RAM to cache that), but a steady 6 MB/s stream of writes ! In contrast on vm2 writes quickly ramp up to 80 MB/s, then stop after ~5 seconds and QEMU just uses CPU for the last ~4 seconds. vm3 also shows it's not an AMD vs Intel thing. There may be some missing CPU feature on vm1 but if that's the case I don't see what. So there is still a mystery there and if anyone has an insight into it it would be appreciated. Despite that I have put vm1 back to active duty. But I decided to keep the wvistau64 VM on the vm2 host. This means vm1 essentially only has one VM to take care of and since most of the time it's going to be idle already it should not slow jobs down. I also applied all Windows updates up to 2016/07/25 to the w7u VM. This caused some new failures that Hans started tackling / fixed. Any other new failure on the 3 VMs affected by the upgrade (wvista, wvistau64 and w7u) should be fixable. The configuration of the other two vms, wvista and wvistau64 should be essentially unchanged. Finally I also performed a minor upgrade on vm3: from Debian 8.2 to 8.6. The goal was to see if the minor QEMU upgrade would be sufficient to get Windows 10 to stop crashing when running WineTest. It looks like that's not the case. So the next step will be to grab QEMU 2.7 from the Debian BackPorts but there's a dumb command line incompatibility with libvirt 1.2.9 and there's no easily installable alternative :-( Fortunately I have a qemu wrapper script that should bridge the gap. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

authz.dll
by André Hentschel Jan. 21, 2017

Jan. 21, 2017

Hi, while looking through the output of my wip script for detecting wrong spec file entries I came across authz.dll And here we have two suspicious functions: AuthzInitializeContextFromSid and AuthzInitializeContextFromToken Both have a parameter of type "LUID" (a struct, not a pointer) which is defined as: typedef struct _LUID { DWORD LowPart; LONG HighPart; } LUID, *PLUID; The spec-file says this is a long: @ stdcall AuthzInitializeContextFromSid(long ptr long ptr long ptr ptr) @ stdcall AuthzInitializeContextFromToken(long long long ptr long ptr ptr) I think a struct like this deserves two longs ("long long") in the spec file, right?

1 0

Wine and Valgrind / handling SIGILL
by Austin English Jan. 20, 2017

Jan. 20, 2017

Howdy all, Several months ago, a patch from Sebastian: commit 44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Feb 12 11:09:34 2015 +0100 winebuild: Do not access memory below ESP when restoring thread contexts. Based on a patch by John Reiser. for https://bugs.winehq.org/show_bug.cgi?id=14367 Caused problems for running Wine under Valgrind: https://bugs.kde.org/show_bug.cgi?id=344139 There are patches floating around for both Wine and Valgrind (see previous link), but from what I've seen so far, both projects aren't a fan of the current patches. Given that Wine developers like using Valgrind to check for problems, and I know Julian would like to use Wine with Valgrind, I feel like some solution to this problem can be found. Since my efforts at trying to run messages between the two projects hasn't solved it yet, I figured an email thread would work better ;). -- -Austin GPG: 14FB D7EA A041 937B

3 7

Wine-2.0-rc5 source code (Cppcheck 1.72)
by Игорь Чебаненко Jan. 20, 2017

Jan. 20, 2017

Wine source code scanning with Cppcheck.

1 0

Re: [PATCH 5/5] wined3d: Recognize another Radeon HD 4650 PCI device id.
by Henri Verbeet Jan. 19, 2017

Jan. 19, 2017

On 18 January 2017 at 21:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > For bug 34671, with thanks to winetaste(a)gmx.net for the relevant info. > This still doesn't make sense to me. In what cases does this make a difference? Which of those do we care about? > @@ -2018,8 +2019,8 @@ cards_amd_binary[] = > - {"HD 4670", CARD_AMD_RADEON_HD4600}, /* Radeon RV730 */ > - {"HD 4650", CARD_AMD_RADEON_HD4600}, /* Radeon RV730 */ > + {"HD 4670", CARD_AMD_RADEON_HD4650}, /* Radeon RV730 */ > + {"HD 4650", CARD_AMD_RADEON_HD4650}, /* Radeon RV730 */ This is arbitrary.

2 2

Re: [PATCH] setupapi: Stub CM_Open_DevNode_Key and CM_Get_Child
by Nikolay Sivov Jan. 19, 2017

Jan. 19, 2017

On 18.01.2017 22:40, Christoph Brill wrote: > Both are necessary to start Lord of the Rings Online as of January 2017 > > Signed-off-by: Christoph Brill <egore911(a)gmail.com> > --- > dlls/setupapi/setupapi.spec | 4 ++-- > dlls/setupapi/stubs.c | 22 ++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec > index 0eb8359ee1..5c57c23431 100644 > --- a/dlls/setupapi/setupapi.spec > +++ b/dlls/setupapi/setupapi.spec > @@ -53,7 +53,7 @@ > @ stub CM_Free_Res_Des > @ stub CM_Free_Res_Des_Ex > @ stub CM_Free_Res_Des_Handle > -@ stub CM_Get_Child > +@ stdcall CM_Get_Child(ptr long long) > @ stub CM_Get_Child_Ex > @ stub CM_Get_Class_Key_NameA > @ stub CM_Get_Class_Key_NameW > @@ -144,7 +144,7 @@ > @ stub CM_Open_Class_KeyW > @ stub CM_Open_Class_Key_ExA > @ stub CM_Open_Class_Key_ExW > -@ stub CM_Open_DevNode_Key > +@ stdcall CM_Open_DevNode_Key(long long long long ptr long) > @ stub CM_Open_DevNode_Key_Ex > @ stub CM_Query_And_Remove_SubTreeA > @ stub CM_Query_And_Remove_SubTreeW > diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c > index 6ecf240c86..1f76b08a3d 100644 > --- a/dlls/setupapi/stubs.c > +++ b/dlls/setupapi/stubs.c > @@ -79,6 +79,28 @@ CONFIGRET WINAPI CM_Disconnect_Machine(HMACHINE handle) > } > > /*********************************************************************** > + * CM_Open_DevNode_Key (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Open_DevNode_Key( > + DEVINST dnDevInst, REGSAM access, ULONG ulHardwareProfile, ULONG /*REGDISPOSITION*/ disposition, > + PHKEY phkDevice, ULONG ulFlags) > +{ > + FIXME("0x%08x 0x%08x 0x%08x 0x%08x %p 0x%08x : stub\n", dnDevInst, access, ulHardwareProfile, > + disposition, phkDevice, ulFlags); > + return CR_SUCCESS; > +} > + > +/*********************************************************************** > + * CM_Get_Child (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Get_Child( > + PDEVINST pdnDevInst, DEVINST dnDevInst, ULONG ulFlags) > +{ > + FIXME("%p 0x%08x 0x%08x: stub\n", pdnDevInst, dnDevInst, ulFlags); > + return CR_SUCCESS; > +} > + Hi, Christoph. Please add prototypes to corresponding public header too. This will also fix REGDISPOSITION case - no reason not to have proper typedef for it. Also please run ./tools/make_specfiles to update dependent dlls.

1 0

Re: iphlpapi/tests: Add test for AllocateAndGetTcpExTableFromStack
by Sebastian Lackner Jan. 18, 2017

Jan. 18, 2017

On 16.01.2017 17:55, André Hentschel wrote: > + ok( ret == ERROR_INVALID_PARAMETER || broken(ERROR_NOT_SUPPORTED) /* win2k */, "got %u\n", ret ); That is not how broken() works.

1 0

Re: regedit: Select a treeitem on right mouse click
by Nikolay Sivov Jan. 18, 2017

Jan. 18, 2017

On 17.01.2017 12:47, Hugh McMaster wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=14606 > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/childwnd.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c > index 08eeec1..c9a35be 100644 > --- a/programs/regedit/childwnd.c > +++ b/programs/regedit/childwnd.c > @@ -411,8 +411,19 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa > g_pChildWnd->nFocusPanel = 0; > break; > case NM_RCLICK: { > - POINT pt; > + POINT pt, client_pt; > + TVHITTESTINFO ht; > + HTREEITEM treeitem; > + HWND hTree = ((NMHDR *)lParam)->hwndFrom; > + > GetCursorPos(&pt); > + client_pt = pt; > + ScreenToClient(hWnd, &client_pt); > + ht.pt = client_pt; > + treeitem = (HTREEITEM)SendMessageA(hTree, TVM_HITTEST, 0, (LPARAM)&ht); > + if (!treeitem) return 1; > + SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)treeitem); > + > TrackPopupMenu(GetSubMenu(hPopupMenus, PM_NEW), > TPM_RIGHTBUTTON, pt.x, pt.y, 0, hFrameWnd, NULL); > break; > This looks like a workaround, according to https://bugs.winehq.org/show_bug.cgi?id=14606 you should be able to TVM_GETNEXTITEM with TVGN_CARET, as selection should happen automatically.

2 1

Re: [PATCH v2] shlwapi: Fix the return value of SHAddDataBlock
by Marvin Jan. 17, 2017

Jan. 17, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27838 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcrt: Implement nan
by Piotr Caban Jan. 17, 2017

Jan. 17, 2017

On 01/14/17 00:11, Daniel Lehman wrote: > +double CDECL MSVCR120_nan(const char *tagp) > +{ > + /* Windows ignores input (MSDN) and Linux crashes on NULL */ > + const char *dummy = "NAN"; > +#ifdef HAVE_NAN > + return nan(dummy); > +#else > + return strtod(dummy, NULL); > +#endif > +} Why can't you just "return NAN;" here? Thanks, Piotr

2 1

Wine po issue page broken?
by Julian Rüger Jan. 17, 2017

Jan. 17, 2017

Hi Francois and list, the po issue page http://fgouget.free.fr/wine-po/ has not updated for quite some time. It shows abb221fa81b60f53c14f6864bbfb9453455aeeeb as its latest commit id (that is the git commit id, right?), which is the release of 1.9.14, July 2016. First of all, did I miss something? I find that page quite useful, personally. What about the other translators? Seems there is not much interest...? http://source.winehq.org/transl/ is broken for me as well. It would be nice to hear from other translators, how much do you use these pages, would you like them to be fixed? If it's just me, please don't bother; otherwise it would be great if someone could look into it! All the best and a happy new year to everyone! Julian

6 9

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Marvin Jan. 17, 2017

Jan. 17, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27756 Your paranoid android. === w8 (32 bit visual) === visual.c:7986: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

3 2

Re: [2/2] iphlpapi: Use the new version of the IP_ADAPTER_UNICAST_ADDRESS structure (try 2)
by Hans Leidekker Jan. 16, 2017

Jan. 16, 2017

On Fri, 2017-01-13 at 13:27 +0100, André Hentschel wrote: > diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c > index 54f7a37..223d980 100644 > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -1065,6 +1065,13 @@ static ULONG adapterAddressesFromIndex(ULONG family, ULONG flags, IF_INDEX index > debugstr_ipv4(&sa->sin_addr.S_un.S_addr, addr_buf)); > fill_unicast_addr_data(aa, ua); > > + ua->OnLinkPrefixLength = 0; > + for (j = 0; j < sizeof(*v4masks) * 8; j++) > + { > + if (v4masks[i] & 1 << j) ua->OnLinkPrefixLength++; > + else break; > + } > + Please add a helper to compute prefix length instead of duplicating this code. This should probably wait until the code freeze is over.

3 6

Re: [PATCH] msvcrt: Trace clean_type_info_names_internal
by Piotr Caban Jan. 16, 2017

Jan. 16, 2017

On 01/12/17 23:57, Jarkko Korpi wrote: > > Signed-off-by: Jarkko Korpi <jarkko_korpi(a)hotmail.com> > > There are only 2 fixmes in the file, all others are traces. And the other fixme is printed only once. This is printed quite often. There are only 2 FIXMEs in the file because other functions are implemented. I don't think this FIXME is very annoying taking into account that it's mainly printed when the application exits. Is it causing any issues for you? I prefer to have it printed unless it breaks application or makes logs unusable. Thanks, Piotr

1 0

Re: wined3d: Do not set DDCAPS_ALIGNBOUNDARYSRC caps for ddraw.
by Henri Verbeet Jan. 16, 2017

Jan. 16, 2017

On 16 January 2017 at 15:07, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > The ALIGNBOUNDARYSRC flag suddenly appeared in c8901d6f6253f6c97610eb1068ac4ff89758ed0a, > although dwAlignBoundarySrc is not initialized. > It should be set to 0 by ddraw, although I could certainly see that causing issues.

1 0

Re: [PATCH v2 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Marvin Jan. 14, 2017

Jan. 14, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27774 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:259: SPI_SETSCREENSAVETIMEOUT failed for reason: 329. Indicating test failure and skipping remainder of test sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Nikolay Sivov Jan. 14, 2017

Jan. 14, 2017

On 14.01.2017 22:33, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/gdi32/gdi32.spec | 2 ++ > dlls/gdi32/gdiobj.c | 12 ++++++++++++ > dlls/user32/sysparams.c | 23 +++++++++++++++++------ > dlls/user32/tests/sysparams.c | 16 ++++++++++++++++ > include/wine/gdi_driver.h | 2 ++ > 5 files changed, 49 insertions(+), 6 deletions(-) > > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 7792731b9e..f9c3fb9293 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -518,6 +518,8 @@ > # GDI objects > @ cdecl __wine_make_gdi_object_system(long long) > @ cdecl __wine_set_visible_region(long long ptr ptr ptr) > +@ cdecl __wine_GDI_ReleaseObj(ptr) > +@ cdecl __wine_GDI_GetObjPtr(ptr long) > > # Graphics drivers > @ cdecl __wine_set_display_driver(long) > diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c > index 46b2241945..aa2ced1025 100644 > --- a/dlls/gdi32/gdiobj.c > +++ b/dlls/gdi32/gdiobj.c > @@ -880,6 +880,18 @@ void GDI_ReleaseObj( HGDIOBJ handle ) > LeaveCriticalSection( &gdi_section ); > } > > +/* Exports for user32, we need to be able to manipulate GDI objects where the official API doesn't allow us */ > + > +void* CDECL __wine_GDI_GetObjPtr( HGDIOBJ handle, WORD type ) > +{ > + return GDI_GetObjPtr( handle, type ); > +} > + > +void CDECL __wine_GDI_ReleaseObj( HGDIOBJ handle ) > +{ > + GDI_ReleaseObj( handle ); > +} > + > This is too much. If you only need to update object property while keeping same handle, you only need one additional call like __wine_set_gdi_object_color(), that should work for both brushes and pens, checking if it's a system object too, as an additional precaution. > +static void set_syscolors_gdi( INT index, COLORREF color ) > +{ > + HBRUSH brush = system_colors[index].brush; > + LOGBRUSH *brush_info; > + > + if(brush) > + { > + /* Since LOGBRUSH is the first member in BRUSHOBJ we just do a cast here */ > + brush_info = __wine_GDI_GetObjPtr( brush, OBJ_BRUSH ); > + if(brush_info->lbColor != color) > + brush_info->lbColor = color; > + __wine_GDI_ReleaseObj( brush ); > + } > +} > This looks very dirty.

2 1

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Marvin Jan. 14, 2017

Jan. 14, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27773 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:259: SPI_SETSCREENSAVETIMEOUT failed for reason: 329. Indicating test failure and skipping remainder of test sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/3] winemac: Export HTML Format clipboard data to the public.html pasteboard type.
by Sebastian Lackner Jan. 13, 2017

Jan. 13, 2017

On 13.01.2017 20:36, Ken Thomases wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > dlls/winemac.drv/clipboard.c | 68 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 67 insertions(+), 1 deletion(-) > > diff --git a/dlls/winemac.drv/clipboard.c b/dlls/winemac.drv/clipboard.c > index fdd1110..49a3ed3 100644 > --- a/dlls/winemac.drv/clipboard.c > +++ b/dlls/winemac.drv/clipboard.c > @@ -82,6 +82,7 @@ static CFDataRef export_bitmap_to_bmp(HANDLE data); > static CFDataRef export_dib_to_bmp(HANDLE data); > static CFDataRef export_enhmetafile(HANDLE data); > static CFDataRef export_hdrop_to_filenames(HANDLE data); > +static CFDataRef export_html(HANDLE data); > static CFDataRef export_metafilepict(HANDLE data); > static CFDataRef export_text_to_utf8(HANDLE data); > static CFDataRef export_unicodetext_to_utf8(HANDLE data); > @@ -186,7 +187,7 @@ static const struct > { wszJFIF, CFSTR("public.jpeg"), import_clipboard_data, export_clipboard_data }, > { wszPNG, CFSTR("public.png"), import_clipboard_data, export_clipboard_data }, > { wszHTMLFormat, NULL, import_clipboard_data, export_clipboard_data }, > - { wszHTMLFormat, CFSTR("public.html"), import_html, NULL, TRUE }, > + { wszHTMLFormat, CFSTR("public.html"), import_html, export_html, TRUE }, > { CFSTR_SHELLURLW, CFSTR("public.url"), import_utf8_to_text, export_text_to_utf8 }, > }; > > @@ -522,6 +523,28 @@ static HANDLE create_bitmap_from_dib(HANDLE dib) > > > /************************************************************************** > + * get_html_description_field > + * > + * Find the value of a field in an HTML Format description. > + */ > +static const char* get_html_description_field(const char* data, const char* keyword) > +{ > + const char* pos = data; > + > + while (pos && *pos && *pos != '<') > + { > + if (memcmp(pos, keyword, strlen(keyword)) == 0) Its not safe to use memcmp, it could read past the terminating \0 of data. > + return pos + strlen(keyword); > + > + pos = strchr(pos, '\n'); > + if (pos) pos++; > + } > + > + return NULL; > +} > + > + > +/************************************************************************** > * import_clipboard_data > * > * Generic import clipboard data routine. > @@ -1141,6 +1164,49 @@ done: > > > /************************************************************************** > + * export_html > + * > + * Export HTML Format to public.html data. > + * > + * FIXME: We should attempt to add an <a base> tag and convert windows paths. > + */ > +static CFDataRef export_html(HANDLE handle) > +{ > + CFDataRef ret; > + const char *data, *field_value; > + int fragmentstart, fragmentend; > + > + data = GlobalLock(handle); > + > + /* read the important fields */ > + field_value = get_html_description_field(data, "StartFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find StartFragment value\n"); > + goto failed; > + } > + fragmentstart = atoi(field_value); > + > + field_value = get_html_description_field(data, "EndFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find EndFragment value\n"); > + goto failed; > + } > + fragmentend = atoi(field_value); > + > + /* export only the fragment */ > + ret = CFDataCreate(NULL, (const UInt8*)&data[fragmentstart], fragmentend - fragmentstart); Some validation of those offsets wouldn't hurt. > + GlobalUnlock(handle); > + return ret; > + > +failed: > + GlobalUnlock(handle); > + return NULL; > +} > + > + > +/************************************************************************** > * export_metafilepict > * > * Export a metafile to data. >

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Henri Verbeet Jan. 13, 2017

Jan. 13, 2017

On 13 January 2017 at 12:53, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 > Strictly speaking that's not a regression, but I'm willing to risk it.

1 0

Re: [PATCH] wined3d: Add Iris Haswell PCI ids and descriptions
by André Hentschel Jan. 13, 2017

Jan. 13, 2017

Am 13.01.2017 um 06:42 schrieb Michael Cronenworth: > --- > dlls/wined3d/directx.c | 11 +++++++++++ > dlls/wined3d/wined3d_private.h | 9 +++++++++ > 2 files changed, 20 insertions(+) > Hi, you forgot to sign off your patch

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Bruno Jesus Jan. 13, 2017

Jan. 13, 2017

On Fri, Jan 13, 2017 at 9:53 AM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 Most likely also fixes https://bugs.winehq.org/show_bug.cgi?id=28874

1 0

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Józef Kucia Jan. 13, 2017

Jan. 13, 2017

On Fri, Jan 13, 2017 at 12:53 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d9/tests/visual.c | 81 ------------------------------------------------ > 1 file changed, 81 deletions(-) There is a typo in the subject prefix. It should read "d3d9/tests:".

1 0

Re: [tools] patches: Say "translation files" instead of "resource files".
by Henri Verbeet Jan. 13, 2017

Jan. 13, 2017

On 13 January 2017 at 05:47, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > @@ -69,7 +69,7 @@ my @legend = > [ "formatting", "<ul><li>The patch author's full name, email address, or Signed-off-by headers are incorrect or missing.</li>" . > "<li>Whitespace got mangled in transit.</li>" . > "<li>Indentation is messed up (usually from editing with a non-standard tab size).</li>" . > - "<li>8-bit chars got mangled in transit (usually when sending patches to resource files).</li>" . > + "<li>8-bit chars got mangled in transit (usually when sending patches to translation files).</li>" . I guess this is fine, and not to make too much of a point of it, but this might as well read "usually when not using git send-email".

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Dmitry Timoshkov Jan. 13, 2017

Jan. 13, 2017

Anton Romanov <theli.ua(a)gmail.com> wrote: > +todo_wine { > + enabled = 2; > + ret = getsockopt(v4, IPPROTO_IPV6, IPV6_V6ONLY, (char*)&enabled, &len); > + ok(!ret, "getsockopt(IPV6_ONLY) failed (LastError: %d)\n", WSAGetLastError()); > + ok(enabled == 1, "expected 1, got %d\n", enabled); > +} The 'todo_wine' statements should be added only around ok() call that will fail otherwise. This applies for other places in the patch as well. -- Dmitry.

2 4