January 2017 - Wine-Devel - list.winehq.org

Re: [PATCH v4] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin Jan. 12, 2017

Jan. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin Jan. 12, 2017

Jan. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27728 Your paranoid android. === build (build) === Patch failed to apply

1 0

TaskDialog implementation - Feedback needed
by Fabian Maurer Jan. 12, 2017

Jan. 12, 2017

Hello, As already mentioned in "commctl32: TaskDialog", I'm currently working on a full implementation for TaskDialogIndirect. Now that I have a working foundation, I figured I ask for feedback instead of having to rewrite it later. Since TaskDialogs are very dynamic, the approach is to create a dialog template in memory, and then show it as dialog box. I attached 3 patches which create a small dialog. Though it doesn't do much (or anything) yet, it should be very easy to start from there and add all the missing functionality piece by piece. Criticism welcome. Fabian

1 0

Re: [PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Sebastian Lackner Jan. 12, 2017

Jan. 12, 2017

On 12.01.2017 06:27, Anton Romanov wrote: > + > + bound = is_fd_bound(fd, &uaddr, &uaddrlen); > + release_sock_fd( s, fd ); > + if (uaddr.addr.sa_family == AF_INET && bound == 0) You might want to change the order here, uaddr is not initialized if is_fd_bound fails.

2 1

Re: [PATCH] wine.inf: Add Dynamic DST data for Asia/Tehran.
by Sebastian Lackner Jan. 12, 2017

Jan. 12, 2017

On 12.01.2017 14:08, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > loader/wine.inf.in | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > Could you please also add day-of-week information, like its done in all the other Dynamic DST entries? Besides that, I'm also not sure if we really need registry entries for dates back until 1991. I have intentionally left out such information in the past. Best regards, Sebastian

2 1

Re: [v2] oleaut32: Make the heap allocation functions static.
by Alexandre Julliard Jan. 12, 2017

Jan. 12, 2017

Francois Gouget <fgouget(a)free.fr> writes: > @@ -1600,26 +1600,26 @@ static void TLB_abort(void) > DebugBreak(); > } > > -void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > +static void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > { > void *ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > if (!ret) ERR("cannot allocate memory\n"); > return ret; > } There are standard functions that I expect we'd want to use in more places (right Michael?) -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: iphlpapi: Avoid sockaddr scope confusion
by Alexandre Julliard Jan. 11, 2017

Jan. 11, 2017

André Hentschel <nerv(a)dawncrow.de> writes: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/iphlpapi/iphlpapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't look to me like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] Disabling IPV6_V6ONLY on AF_INET succeeds in Windows starting with Vista
by Bruno Jesus Jan. 11, 2017

Jan. 11, 2017

On Tue, Jan 10, 2017 at 3:44 PM, Anton Romanov <theli.ua(a)gmail.com> wrote: > Fixes Magic The Gathering Online not able to login > --- > dlls/ws2_32/socket.c | 22 ++++++++++++++++++++++ > dlls/ws2_32/tests/sock.c | 24 +++++++++++++++++++++++- > 2 files changed, 45 insertions(+), 1 deletion(-) Hi, can you please open a bug report attaching a +winsock so we can discuss this further? Best wishes, Bruno

2 4

Re: Wine po issue page broken?
by Francois Gouget Jan. 11, 2017

Jan. 11, 2017

Lauri Kenttä wrote: > With proper spell checking, I could take a look at the Swedish > translation, but the Swedish spell checking on wine-po has always been > broken (includes dots in words and so produces hundreds of false > positives). I'm not sure the periods are an issue. The command I run is: aspell -l sv --encoding utf-8 And it seems to return the same result whether there is a trailing period or not: arraygränser. # arraygränser. 0 arraygränser # arraygränser 0 cmd-fönstret. # cmd-fönstret. 0 cmd-fönstret # cmd-fönstret 0 drivrutinsnivå. ? drivrutinsnivå. 0 0: driv drivrutinsnivå ? drivrutinsnivå 0 0: driv konsoll. & konsoll. 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors konsoll & konsoll 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

Re: [v2 PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27687 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH 1/2] ddraw/tests: Try to avoid killing the Intel (kernel) driver.
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27682 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Alexandre Julliard Jan. 10, 2017

Jan. 10, 2017

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/user32/tests/win.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) This doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:6758: Test failed: Unexpected text length, 7 win.c:6760: Test failed: Unexpected buffer contents, 0x20ac win.c:6769: Test failed: Unexpected text length, 18 win.c:6771: Test failed: Unexpected buffer contents make: *** [win.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/2] riched20: Only pass valid length to ME_InsertTextFromCursor
by Huw Davies Jan. 10, 2017

Jan. 10, 2017

On Mon, Jan 09, 2017 at 06:08:12PM +0100, Fabian Maurer wrote: > This only affects ME_SetText and fnTextSrv_TxSetText, > should make it a bit more readable. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/caret.c | 2 -- > dlls/riched20/editor.c | 4 +++- > dlls/riched20/txtsrv.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c > index 26af743518..94794890b6 100644 > --- a/dlls/riched20/caret.c > +++ b/dlls/riched20/caret.c > @@ -526,8 +526,6 @@ void ME_InsertTextFromCursor(ME_TextEditor *editor, int nCursor, > assert(style); > > assert(nCursor>=0 && nCursor<editor->nCursors); > - if (len == -1) > - len = lstrlenW(str); > > /* grow the text limit to fit our text */ > if(editor->nTextLimit < oldLen +len) > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 1ce444e604..8873861aee 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3323,7 +3323,9 @@ static void ME_SetText(ME_TextEditor *editor, void *text, BOOL unicode) > int len = -1; > > /* uses default style! */ > - if (!(editor->styleFlags & ES_MULTILINE)) > + if (editor->styleFlags & ES_MULTILINE) > + len = lstrlenW(wszText); > + else > { > WCHAR *p = wszText; > > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 307b484352..a21ef5a02f 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -288,7 +288,7 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_SetCursorToStart(This->editor, &cursor); > ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > if(pszText) > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > + ME_InsertTextFromCursor(This->editor, 0, pszText, lstrlenW(pszText), This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); I'm not convinced this is an improvement. Huw.

2 1

Re: [PATCH] wined3d: Add FIXME for WINED3D_BLT_WAIT.
by Henri Verbeet Jan. 10, 2017

Jan. 10, 2017

On 10 January 2017 at 15:02, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/wined3d/surface.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Why?

1 0

Re: imm32/tests: A spelling fix in an ok() message.
by Aric Stewart Jan. 10, 2017

Jan. 10, 2017

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: usp10: A spelling fix in a comment
by Aric Stewart Jan. 10, 2017

Jan. 10, 2017

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27674 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w1064 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test
by Huw Davies Jan. 9, 2017

Jan. 9, 2017

On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote: > It already works with a null-pointer, but will crash if len is -1. > Since null-pointer means no text, we just return to avoid crashes. > > v2: Followed suggestion by Nikolay Sivov, moved check and extend test Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where it was in your first version. However, the extended test is much better. Huw.

2 1

Wine slides for Linux user group?
by Austin English Jan. 7, 2017

Jan. 7, 2017

Howdy, Does anyone have some recentish slides I could build on for a local Linux user group presentation about Wine? Thanks

1 0

Re: ddraw/tests: A spelling fix in an ok() message.
by Marvin Jan. 7, 2017

Jan. 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27624 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ddraw/tests: Spelling fixes in a few comments.
by Marvin Jan. 7, 2017

Jan. 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27623 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: dxgi/tests: Some spelling fixes in ok() messages.
by Marvin Jan. 7, 2017

Jan. 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27612 Your paranoid android. === w7pro64 (32 bit device) === device.c:1445: Test failed: SetFullscreenState failed, hr 0x887a0004.

1 0

Re: [PATCH] d3dx11: Remove forward to d3dx11_43.
by Matteo Bruni Jan. 6, 2017

Jan. 6, 2017

2016-12-29 16:59 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/d3dx11_42/d3dx11_42.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx11_42/d3dx11_42.spec b/dlls/d3dx11_42/d3dx11_42.spec > index f97ec24..0a6350c 100644 > --- a/dlls/d3dx11_42/d3dx11_42.spec > +++ b/dlls/d3dx11_42/d3dx11_42.spec > @@ -29,7 +29,7 @@ > @ stub D3DX11FilterTexture > @ stub D3DX11GetImageInfoFromFileA > @ stub D3DX11GetImageInfoFromFileW > -@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) d3dx11_43.D3DX11GetImageInfoFromMemory > +@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) > @ stub D3DX11GetImageInfoFromResourceA > @ stub D3DX11GetImageInfoFromResourceW > @ stub D3DX11LoadTextureFromTexture Does that compile?

1 0

Re: [PATCH] d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub.
by Matteo Bruni Jan. 6, 2017

Jan. 6, 2017

2016-12-28 15:43 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: It's probably pretty safe but I'd prefer to defer this patch after 2.0.

1 0

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Henri Verbeet Jan. 6, 2017

Jan. 6, 2017

On 6 January 2017 at 08:07, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42159 > This isn't a regression, right? > @@ -2975,10 +2975,7 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > hr = ddraw_surface_create(ddraw, &surface_desc2, &impl, outer_unknown, 1); > wined3d_mutex_unlock(); > if (FAILED(hr)) > - { > - *surface = NULL; > return hr; > - } This does a bit more than the commit message says it does, this doesn't write to *surface on any error from ddraw_surface_create(). That may very well be correct, but that's not what the test tests. The test only tests that CreateSurface() doesn't crash on error with an invalid "surface" pointer, but that could also be because of e.g. an exception handler. If you want to prove that it doesn't (try to) write to the "surface" pointer, you should pass a valid pointer to CreateSurface() and test that it isn't modified after the call.

2 2