January 2017 - Wine-Devel - list.winehq.org

Re: [PATCH v4] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin Jan. 12, 2017

Jan. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin Jan. 12, 2017

Jan. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27728 Your paranoid android. === build (build) === Patch failed to apply

1 0

TaskDialog implementation - Feedback needed
by Fabian Maurer Jan. 12, 2017

Jan. 12, 2017

Hello, As already mentioned in "commctl32: TaskDialog", I'm currently working on a full implementation for TaskDialogIndirect. Now that I have a working foundation, I figured I ask for feedback instead of having to rewrite it later. Since TaskDialogs are very dynamic, the approach is to create a dialog template in memory, and then show it as dialog box. I attached 3 patches which create a small dialog. Though it doesn't do much (or anything) yet, it should be very easy to start from there and add all the missing functionality piece by piece. Criticism welcome. Fabian

1 0

Re: [PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Sebastian Lackner Jan. 12, 2017

Jan. 12, 2017

On 12.01.2017 06:27, Anton Romanov wrote: > + > + bound = is_fd_bound(fd, &uaddr, &uaddrlen); > + release_sock_fd( s, fd ); > + if (uaddr.addr.sa_family == AF_INET && bound == 0) You might want to change the order here, uaddr is not initialized if is_fd_bound fails.

2 1

Re: [PATCH] wine.inf: Add Dynamic DST data for Asia/Tehran.
by Sebastian Lackner Jan. 12, 2017

Jan. 12, 2017

On 12.01.2017 14:08, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > loader/wine.inf.in | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > Could you please also add day-of-week information, like its done in all the other Dynamic DST entries? Besides that, I'm also not sure if we really need registry entries for dates back until 1991. I have intentionally left out such information in the past. Best regards, Sebastian

2 1

Re: [v2] oleaut32: Make the heap allocation functions static.
by Alexandre Julliard Jan. 12, 2017

Jan. 12, 2017

Francois Gouget <fgouget(a)free.fr> writes: > @@ -1600,26 +1600,26 @@ static void TLB_abort(void) > DebugBreak(); > } > > -void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > +static void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > { > void *ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > if (!ret) ERR("cannot allocate memory\n"); > return ret; > } There are standard functions that I expect we'd want to use in more places (right Michael?) -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: iphlpapi: Avoid sockaddr scope confusion
by Alexandre Julliard Jan. 11, 2017

Jan. 11, 2017

André Hentschel <nerv(a)dawncrow.de> writes: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/iphlpapi/iphlpapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't look to me like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] Disabling IPV6_V6ONLY on AF_INET succeeds in Windows starting with Vista
by Bruno Jesus Jan. 11, 2017

Jan. 11, 2017

On Tue, Jan 10, 2017 at 3:44 PM, Anton Romanov <theli.ua(a)gmail.com> wrote: > Fixes Magic The Gathering Online not able to login > --- > dlls/ws2_32/socket.c | 22 ++++++++++++++++++++++ > dlls/ws2_32/tests/sock.c | 24 +++++++++++++++++++++++- > 2 files changed, 45 insertions(+), 1 deletion(-) Hi, can you please open a bug report attaching a +winsock so we can discuss this further? Best wishes, Bruno

2 4

Re: Wine po issue page broken?
by Francois Gouget Jan. 11, 2017

Jan. 11, 2017

Lauri Kenttä wrote: > With proper spell checking, I could take a look at the Swedish > translation, but the Swedish spell checking on wine-po has always been > broken (includes dots in words and so produces hundreds of false > positives). I'm not sure the periods are an issue. The command I run is: aspell -l sv --encoding utf-8 And it seems to return the same result whether there is a trailing period or not: arraygränser. # arraygränser. 0 arraygränser # arraygränser 0 cmd-fönstret. # cmd-fönstret. 0 cmd-fönstret # cmd-fönstret 0 drivrutinsnivå. ? drivrutinsnivå. 0 0: driv drivrutinsnivå ? drivrutinsnivå 0 0: driv konsoll. & konsoll. 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors konsoll & konsoll 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

Re: [v2 PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27687 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0