January 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] ddraw/tests: Try to avoid killing the Intel (kernel) driver.
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27682 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Alexandre Julliard Jan. 10, 2017

Jan. 10, 2017

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/user32/tests/win.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) This doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:6758: Test failed: Unexpected text length, 7 win.c:6760: Test failed: Unexpected buffer contents, 0x20ac win.c:6769: Test failed: Unexpected text length, 18 win.c:6771: Test failed: Unexpected buffer contents make: *** [win.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/2] riched20: Only pass valid length to ME_InsertTextFromCursor
by Huw Davies Jan. 10, 2017

Jan. 10, 2017

On Mon, Jan 09, 2017 at 06:08:12PM +0100, Fabian Maurer wrote: > This only affects ME_SetText and fnTextSrv_TxSetText, > should make it a bit more readable. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/caret.c | 2 -- > dlls/riched20/editor.c | 4 +++- > dlls/riched20/txtsrv.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c > index 26af743518..94794890b6 100644 > --- a/dlls/riched20/caret.c > +++ b/dlls/riched20/caret.c > @@ -526,8 +526,6 @@ void ME_InsertTextFromCursor(ME_TextEditor *editor, int nCursor, > assert(style); > > assert(nCursor>=0 && nCursor<editor->nCursors); > - if (len == -1) > - len = lstrlenW(str); > > /* grow the text limit to fit our text */ > if(editor->nTextLimit < oldLen +len) > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 1ce444e604..8873861aee 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3323,7 +3323,9 @@ static void ME_SetText(ME_TextEditor *editor, void *text, BOOL unicode) > int len = -1; > > /* uses default style! */ > - if (!(editor->styleFlags & ES_MULTILINE)) > + if (editor->styleFlags & ES_MULTILINE) > + len = lstrlenW(wszText); > + else > { > WCHAR *p = wszText; > > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 307b484352..a21ef5a02f 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -288,7 +288,7 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_SetCursorToStart(This->editor, &cursor); > ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > if(pszText) > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > + ME_InsertTextFromCursor(This->editor, 0, pszText, lstrlenW(pszText), This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); I'm not convinced this is an improvement. Huw.

2 1

Re: [PATCH] wined3d: Add FIXME for WINED3D_BLT_WAIT.
by Henri Verbeet Jan. 10, 2017

Jan. 10, 2017

On 10 January 2017 at 15:02, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/wined3d/surface.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Why?

1 0

Re: imm32/tests: A spelling fix in an ok() message.
by Aric Stewart Jan. 10, 2017

Jan. 10, 2017

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: usp10: A spelling fix in a comment
by Aric Stewart Jan. 10, 2017

Jan. 10, 2017

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin Jan. 10, 2017

Jan. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27674 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w1064 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test
by Huw Davies Jan. 9, 2017

Jan. 9, 2017

On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote: > It already works with a null-pointer, but will crash if len is -1. > Since null-pointer means no text, we just return to avoid crashes. > > v2: Followed suggestion by Nikolay Sivov, moved check and extend test Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where it was in your first version. However, the extended test is much better. Huw.

2 1

Wine slides for Linux user group?
by Austin English Jan. 7, 2017

Jan. 7, 2017

Howdy, Does anyone have some recentish slides I could build on for a local Linux user group presentation about Wine? Thanks

1 0

Re: ddraw/tests: A spelling fix in an ok() message.
by Marvin Jan. 7, 2017

Jan. 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27624 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0