October 2017 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

COM tracing ...
by Michael Meeks Aug. 21, 2018

Aug. 21, 2018

Hi guys, Rather a peripheral question; apologies for that - but I'd imagine there are experts here that may be able to help. I have a black-box problem - a Windows app dealing with confidential data that I can't easily touch (and thus can't get to run under Wine) - which does some small but critical automation of MS Office - using VBS / COM scripting. I'd -really- love some input on how best to trace that series of COM method calls on Windows itself ie. the (remote) service activation, and the RPC beyond that - particularly the method names, parameters etc. of the COM/OLE Office API. I've tried (so far): http://www.rohitab.com/apimonitor which, while closed, looks interesting; but traces a lot in a hard-to-search way and doesn't appear to do the trick. https://support.microsoft.com/en-us/help/926098/how-to-enable-com-and-com-d… Sounds useful: using Event Tracing for Windows (ETW) but has this rather unhelpful property: "The binary file must be formatted by Microsoft so that it can be analyzed. Please forward the .etl files to your support contact. ..." ;-) Component models used to be all the rage in my youth ;-) surely someone solved the "strace for COM calls" problem elegantly some-when ! Crazily - might it be possible to instrument, interpose and use Wine's COM impl. on Windows [ which sounds a bit 'exciting' ;-], or ? Anyhow - help much appreciated & sorry for the noise ! Regards, Michael. -- michael.meeks(a)collabora.com <><, Pseudo Engineer, itinerant idiot

2 4

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

Re: [PATCH] arm64: Use __builtin_ms_va_list and __attribute__((ms_abi)) on arm64
by André Hentschel Feb. 13, 2018

Feb. 13, 2018

Am 14.08.2017 um 12:35 schrieb Martin Storsjo: > Windows uses a different ABI for va_list on arm64 just like on x86_64. > > On x86_64, the calling convention for windows functions is completely > different from the one on other platforms. On arm64, they're mostly the > same, with the only exception being variadic functions (where all float > arguments are passed in integer registers, since the va_list is a single > pointer). > > Any functions using __builtin_ms_va_start need to be decorated with > __attribute__((ms_abi)). > > Add a check in configure for the support of __builtin_ms_va_list > (both features appared in clang at the same time, in the 5.0 release). > > This fixes running binaries that use e.g. printf style functions > (e.g. midl.exe from the windows 10 sdk), fixing > https://bugs.winehq.org/show_bug.cgi?id=38886. > > Signed-off-by: Martin Storsjo <martin(a)martin.st> > --- > clang 5.0, which this requires, isn't yet released, but is in RC2 and > will probably be released pretty soon. > --- > configure.ac | 7 +++++++ > include/msvcrt/crtdefs.h | 6 +++++- > include/windef.h | 6 +++++- > include/wine/test.h | 4 ++-- > 4 files changed, 19 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 7d52b24..c33221f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -179,6 +179,13 @@ case $host in > CFLAGS="$CFLAGS -marm" > AC_SUBST(TARGETFLAGS,"-marm") > ;; > + aarch64*) > + AC_MSG_CHECKING([whether $CC supports __builtin_ms_va_list]) > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdarg.h>]], [[void func(__builtin_ms_va_list *args);]])], > + [AC_MSG_RESULT([yes])], > + [AC_MSG_RESULT([no]) > + AC_MSG_ERROR([You need clang >= 5.0 to build Wine for arm64.])]) Hi, The upstreamed variadic function handling is terrific, thanks for that! I also like this patch as logical next step, I'm just a bit worried because it locks out current builds without upgrading to an RC... At the moment I'm doing winelib builds with gcc for Linux/ARM64 and clang builds for Android/ARM64. It's quite easy on Linux to pick up a new clang version, not sure how long it takes until clang5 is picked up in the Android NDK... On the other hand, there are not much people building Wine for ARM64, and those can pretty easily revert your patch until they are at clang5 OK... We need this improvement, I'll sign it off :) Now, we only need to convince distributions to avoid x18

3 4

Upcoming TestBot patches
by Francois Gouget Dec. 19, 2017

Dec. 19, 2017

For those that are interested I'm trying to regularly push my set of 'might be ready to send' patches on GitHub: https://github.com/fgouget/wine-tools/tree/future So feel free to have a look and / or test it. -- Francois Gouget <fgouget(a)codeweavers.com>

2 4

Wine tests
by Jeremy White Nov. 15, 2017

Nov. 15, 2017

Hey all, I thought I would start my annual harangue a little bit early this year. I thought I'd summarize the lens I see things with and then see if there is anything constructive we can do now, and then again when we meet in person. Then we'll also have drink to turn to if we end with nothing but despair. The ideal is that this page: http://test.winehq.org/data/ be covered entirely in green. That would indicate that our unit tests ran successfully on all tested systems. A further ideal is that it would have 'Mac' and 'Android' columns that were also green. The holy dream we all crave is that a 'make test' would work in a rational fashion. And the ultimate fantasy is that every patch sent would be tested not only on Windows if the tests change, but on Linux, Mac, and Android as well. (Alexandre does that by hand now, but it'd be nice to automate that test). A more reasonable ideal is that all of our tests would run successfully on a well curated list of 'rigorous' test machines. I don't believe that we have an official page for that; I maintain an unofficial one here: https://www.winehq.org/~jwhite/latest.html That is all of the 'newtb' Windows VMs excluding Windows 2000, Windows 8, and Windows 10. That list of failures has fluctuated; starting at about 40, and once getting down to as few as a dozen. It now stands at about 20, where it's been for a while. Nicely (?), we're down to only intermittent failures :-/. I think the instinct has been to fix all of the Windows tests; that once those are consistently green, then it would make sense to go after a well defined Linux rig and push it to green. CodeWeavers has a rack of hardware and we're happy to put any flavor of system in there (and have done so, with standard rigs for testing AMD and NVidia Linux boxes). A quick scan suggests that those rigs stand at about the same number of failures; low to mid teens. I think we are lacking several things: 1. Some help for Francois. He's basically doing all of this on his own. We could use some people willing to fight through Perl to help extend our capabilities. 2. The ability (will?) to drive the Windows tests to green. Is it time to articulate a kind of test that is expected to periodically fail? In other words, do we have tests that 'reasonably' fail, and so we should redefine that failure? Many years in the past, we had constructive sessions where I forcibly prevented people from going to the pub until we flipped a whole lot more bits to green. I can remember times when that worked quite nicely. But we haven't been as productive with that lately. Is it worth dedicating another block of time to it at the Wine conference? Would it work better if we prepared ahead of time? For example, let me suggest this: that developers start right now running winetest on machines they plan to bring to Wineconf. Then we can have that body of information available to us at the conference, and we can choose to attack issues that show commonality. Does that make sense? Any other prep work we should do? (Jacek and Piotr assure me that there will be plenty of beer for drowning sorrows, so that seems to be covered). Cheers, Jeremy

5 7

Setting a source directory in winedbg
by Mihai Todor Nov. 3, 2017

Nov. 3, 2017

Hi Everyone, I noticed that I can set the source directory via the `dir` command in winedbg, but, for some reason, it rejects absolute paths, like Z:\bla\blah, claiming that ":" is a syntax error. I tried to enclose the path in quotes / double quotes, but then the quote / double quote is rejected as a syntax error. I don't have sufficient knowledge of bison to grok the code in programs/winedbg/dbg.y, so is there a way to escape the colon symbol? As a workaround, I mapped my build directory under Wine, but that is really annoying. Thank you, Mihai Todor

1 1

Re: [v3] oleaut32: Add ARM support to DispCallFunc().
by Alexandre Julliard Nov. 2, 2017

Nov. 2, 2017

Donna Whisnant <dewhisna(a)dewtronics.com> writes: > Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls > to succeed on ARM platforms. This change specifically targets only > 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be > compatible with big-endian (ARMEB) platforms, but testing for that > platform should be completed before enabling. > > Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd > container to compile and run it on an x86-64 Host.. When running on > Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine > to function. It breaks the Android build: arm-linux-androideabi-gcc -c -o typelib.o ../../../wine/dlls/oleaut32/typelib.c -I. -I../../../wine/dlls/oleaut32 \ -I../../include -I../../../wine/include -D__WINESRC__ -D_OLEAUT32_ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret -D__ANDROID_API__=26 -marm {standard input}: Assembler messages: {standard input}:32: Error: selected processor does not support ARM mode `vldm r3!,{s0-s15}' Makefile:516: recipe for target 'typelib.o' failed make: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [PATCH 1/4] dx8vb: Add stubs for D3DX8 interface
by Henri Verbeet Nov. 1, 2017

Nov. 1, 2017

Perhaps this is sufficiently far removed from core Direct3D that nobody cares, but for what it's worth: On 31 October 2017 at 03:01, Fabian Maurer <dark.shadow4(a)web.de> wrote: > +typedef struct > +{ > + ID3DX8 ID3DX8_iface; > + LONG ref; > +} d3dx8; Please don't typedef structures just to save keystrokes. > +static HRESULT WINAPI d3dx8_QueryInterface(ID3DX8 *iface, REFIID riid, void **ppv) > +{ > + d3dx8 *This = impl_from_ID3DX8(iface); Please use lowercase variable names. > + > + TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppv); > + > + *ppv = NULL; > + > + if (IsEqualGUID(riid, &IID_IUnknown)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_ID3DX8)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_IPersistPropertyBag)) > + FIXME("No interface for IID_IPersistPropertyBag\n"); > + else if(IsEqualGUID(riid, &IID_IPersistStreamInit)) > + FIXME("No interface for IID_IPersistStreamInit\n"); > + else > + FIXME("No interface for %s\n", debugstr_guid(riid)); Not implementing an arbitrary interface is a WARN at best. > + > + if (*ppv) > + { > + IUnknown_AddRef((IUnknown *)(*ppv)); > + return S_OK; > + } > + > + return E_NOINTERFACE; > +} I think Nikolay already hinted at this, but this is fairly different from the canonical QueryInterface() implementation, especially for an object that only implements a single interface. > +static HRESULT WINAPI d3dx8_CreateFont(ID3DX8 *iface, Direct3DDevice8 *device, > + LONG hFont, D3DXFont **retFont) Please use lowercase parameter names, and avoid the stray 'h'. > +static HRESULT WINAPI d3dx8_AssembleShaderFromFile(ID3DX8 *iface, BSTR file, LONG flags, BSTR *log, > + D3DXBuffer **constants, D3DXBuffer **ppVertexShader) > +{ > + FIXME("(%s, %i, %p, %p, %p): stub!\n", debugstr_w(file), flags, log, constants, ppVertexShader); I certainly have my preferences when it comes to trace formatting, but I think "%i" is questionable for flags regardless of preference. > +static const ID3DX8Vtbl ID3DX8_Vtbl = "d3dx8_vtbl" > +HRESULT d3dx8_create(IUnknown *outer_unk, void **ppv) > +{ > + d3dx8 *object; > + > + TRACE("(%p,%p)\n", outer_unk, ppv); > + > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(d3dx8)); "sizeof(*object)"

4 6

Re: [PATCH] wmvcore/tests: Access IWMDRMReader(|2|3) interfaces on Windows.
by Nikolay Sivov Oct. 31, 2017

Oct. 31, 2017

On 24.10.2017 8:36, Jefferson Carpenter wrote: > +#if defined(__MINGW32__) || defined(__MINGW64__) > +#ifdef _WIN64 > + flagPtrAddr = (unsigned long long)(reader) - 24; > + flagMem[556] = 1; > +#elif _WIN32 > + flagPtrAddr = (unsigned int)(reader) - 12; > + flagMem[288] = 1; > +#endif > + *(unsigned char **)flagPtrAddr = flagMem; > +#endif Why would you need something like that to match potential Wine's implementation? How do applications access this thing?

3 10

Re: [PATCH 4/4] dx8vb: Implement Direct3D8 methods
by Stefan Dösinger Oct. 31, 2017

Oct. 31, 2017

Hi Fabian, Why do you need a proxy IDirect3D8 implementation in dx8vb? Is there any difference between dx8vb and d3d8? Stefan > Am 31.10.2017 um 00:31 schrieb Fabian Maurer <dark.shadow4(a)web.de>: > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/dx8vb/Makefile.in | 2 +- > dlls/dx8vb/directx8.c | 112 ++++++++++++++++++++++++++++++++++++++----------- > 2 files changed, 89 insertions(+), 25 deletions(-) > > diff --git a/dlls/dx8vb/Makefile.in b/dlls/dx8vb/Makefile.in > index 8438d022f4..33fe651503 100644 > --- a/dlls/dx8vb/Makefile.in > +++ b/dlls/dx8vb/Makefile.in > @@ -1,5 +1,5 @@ > MODULE = dx8vb.dll > -IMPORTS = uuid ole32 > +IMPORTS = uuid ole32 d3d8 > > C_SRCS = \ > d3dx8.c \ > diff --git a/dlls/dx8vb/directx8.c b/dlls/dx8vb/directx8.c > index 338862a4ff..dd50c86008 100644 > --- a/dlls/dx8vb/directx8.c > +++ b/dlls/dx8vb/directx8.c > @@ -21,6 +21,9 @@ > #include "config.h" > > #include "dx8vb_private.h" > +#define __WINE_D3D8TYPES_H > +#define __WINE_D3D8CAPS_H > +#include "d3d8.h" > #include "ocidl.h" > > #include "wine/debug.h" > @@ -36,6 +39,7 @@ typedef struct > typedef struct > { > Direct3D8 Direct3D8_iface; > + IDirect3D8 *direct3d8; > LONG ref; > } direct3d8; > > @@ -95,7 +99,10 @@ static ULONG WINAPI direct3d8_Release(Direct3D8 *iface) > TRACE("(%p/%p)->(): new ref %d\n", iface, This, ref); > > if (!ref) > + { > + IDirect3D8_Release(This->direct3d8); > HeapFree(GetProcessHeap(), 0, This); > + } > > return ref; > } > @@ -104,91 +111,145 @@ static ULONG WINAPI direct3d8_Release(Direct3D8 *iface) > > static HRESULT WINAPI direct3d8_RegisterSoftwareDevice(Direct3D8 *iface, void *initializeFunction) > { > - FIXME("(%p): stub!\n", initializeFunction); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return E_NOTIMPL; > + HRESULT ret = IDirect3D8_RegisterSoftwareDevice(This->direct3d8, initializeFunction); > + > + FIXME("(%p) -> (%x)\n", initializeFunction, ret); > + > + return ret; > } > > static int WINAPI direct3d8_GetAdapterCount(Direct3D8 *iface) > { > - FIXME("(): stub!\n"); > + direct3d8 *This = impl_from_Direct3D8(iface); > + > + int ret = IDirect3D8_GetAdapterCount(This->direct3d8); > + > + FIXME("() -> (%i)\n", ret); > > - return 0; > + return ret; > } > > static HRESULT WINAPI direct3d8_GetAdapterIdentifier(Direct3D8 *iface, int adapter, > LONG flags, D3DADAPTER_IDENTIFIER8 *identifier) > { > - FIXME("(%i, %i, %p): stub!\n", adapter, flags, identifier); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return E_NOTIMPL; > + HRESULT ret = IDirect3D8_GetAdapterIdentifier(This->direct3d8, adapter, flags, identifier); > + > + FIXME("(%i, %i, %p) -> (%x)\n", adapter, flags, identifier, ret); > + > + return ret; > } > > static int WINAPI direct3d8_GetAdapterModeCount(Direct3D8 *iface, int adapter) > { > - FIXME("(%i): stub!\n", adapter); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return 0; > + int ret = IDirect3D8_GetAdapterModeCount(This->direct3d8, adapter); > + > + FIXME("(%i) -> (%i)\n", adapter, ret); > + > + return ret; > } > > static HRESULT WINAPI direct3d8_EnumAdapterModes(Direct3D8 *iface, int adapter, int mode, D3DDISPLAYMODE *displayMode) > { > - FIXME("(%i, %i, %p): stub!\n", adapter, mode, displayMode); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return E_NOTIMPL; > + HRESULT ret = IDirect3D8_EnumAdapterModes(This->direct3d8, adapter, mode, displayMode); > + > + FIXME("(%i, %i, %p) -> (%x)\n", adapter, mode, displayMode, ret); > + > + return ret; > } > > static HRESULT WINAPI direct3d8_GetAdapterDisplayMode(Direct3D8 *iface, int adapter, D3DDISPLAYMODE *displayMode) > { > - FIXME("(%i, %p): stub!\n", adapter, displayMode); > + direct3d8 *This = impl_from_Direct3D8(iface); > + HRESULT ret; > > - return E_NOTIMPL; > + ret = IDirect3D8_GetAdapterDisplayMode(This->direct3d8, adapter, displayMode); > + > + TRACE("(%i, %p) -> (%x)\n", adapter, displayMode, ret); > + > + return ret; > } > > static LONG WINAPI direct3d8_CheckDeviceType(Direct3D8 *iface, int adapter, D3DDEVTYPE checkType, > D3DFORMAT displayFormat, D3DFORMAT backBufferFormat, LONG bWindowed) > { > - FIXME("(%i, %u, %u, %u, %i): stub!\n", adapter, checkType, displayFormat, backBufferFormat, bWindowed); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return 0; > + LONG ret = IDirect3D8_CheckDeviceType(This->direct3d8, adapter, checkType, > + displayFormat, backBufferFormat, bWindowed); > + > + FIXME("(%i, %u, %u, %u, %i) -> (%i)\n", adapter, checkType, displayFormat, backBufferFormat, bWindowed, ret); > + > + return ret; > } > > static LONG WINAPI direct3d8_CheckDeviceFormat(Direct3D8 *iface, int adapter, D3DDEVTYPE deviceType, > D3DFORMAT adapterFormat, LONG usage, D3DRESOURCETYPE rType, D3DFORMAT checkFormat) > { > - FIXME("(%i, %u, %u, %i, %u, %u): stub!\n", adapter, deviceType, adapterFormat, usage, rType, checkFormat); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return 0; > + LONG ret = IDirect3D8_CheckDeviceFormat(This->direct3d8, adapter, deviceType, > + adapterFormat, usage, rType, checkFormat); > + > + FIXME("(%i, %u, %u, %i, %u, %u) -> (%i)\n", adapter, deviceType, adapterFormat, usage, rType, checkFormat, ret); > + > + return ret; > } > > static LONG WINAPI direct3d8_CheckDeviceMultiSampleType(Direct3D8 *iface, int adapter, D3DDEVTYPE deviceType, > D3DFORMAT renderTargetFormat, LONG windowed, D3DMULTISAMPLE_TYPE multiSampleType) > { > - FIXME("(%i, %u, %u, %i, %u): stub!\n", adapter, deviceType, renderTargetFormat, windowed, multiSampleType); > + direct3d8 *This = impl_from_Direct3D8(iface); > + > + LONG ret = IDirect3D8_CheckDeviceMultiSampleType(This->direct3d8, adapter, deviceType, > + renderTargetFormat, windowed, multiSampleType); > + > + FIXME("(%i, %u, %u, %i, %u) -> (%i)\n", adapter, deviceType, renderTargetFormat, windowed, multiSampleType, ret); > > - return 0; > + return ret; > } > > static LONG WINAPI direct3d8_CheckDepthStencilMatch(Direct3D8 *iface, int adapter, D3DDEVTYPE deviceType, > D3DFORMAT adapterFormat, D3DFORMAT renderTargetFormat, D3DFORMAT depthStencilFormat) > { > - FIXME("(%i, %u, %u, %u, %u): stub!\n", adapter, deviceType, adapterFormat, renderTargetFormat, depthStencilFormat); > + direct3d8 *This = impl_from_Direct3D8(iface); > + > + LONG ret = IDirect3D8_CheckDepthStencilMatch(This->direct3d8, adapter, deviceType, adapterFormat, > + renderTargetFormat, depthStencilFormat); > + > + TRACE("(%i, %u, %u, %u, %u) ->(%i)\n", adapter, deviceType, adapterFormat, > + renderTargetFormat, depthStencilFormat, ret); > > - return 0; > + return ret; > } > > static HRESULT WINAPI direct3d8_GetDeviceCaps(Direct3D8 *iface, int adapter, D3DDEVTYPE deviceType, D3DCAPS8 *caps) > { > - FIXME("(%i, %u, %p): stub!\n", adapter, deviceType, caps); > + direct3d8 *This = impl_from_Direct3D8(iface); > > - return E_NOTIMPL; > + HRESULT ret = IDirect3D8_GetDeviceCaps(This->direct3d8, adapter, deviceType, caps); > + > + TRACE("(%i, %u, %p) -> (%x)\n", adapter, deviceType, caps, ret); > + > + return ret; > } > > static LONG WINAPI direct3d8_GetAdapterMonitor(Direct3D8 *iface, int adapter) > { > - FIXME("(%i): stub!\n", adapter); > + direct3d8 *This = impl_from_Direct3D8(iface); > + > + LONG ret = (LONG)IDirect3D8_GetAdapterMonitor(This->direct3d8, adapter); > + > + TRACE("(%i) -> (%i)!\n", adapter, ret); > > - return 0; > + return ret; > } > > static HRESULT WINAPI direct3d8_CreateDevice(Direct3D8 *iface, int adapter, D3DDEVTYPE deviceType, HWND hFocusWindow, > @@ -235,6 +296,9 @@ HRESULT direct3d8_create(Direct3D8 **ppv) > > object->Direct3D8_iface.lpVtbl = &Direct3D8_Vtbl; > object->ref = 1; > + object->direct3d8 = Direct3DCreate8(D3D_SDK_VERSION); > + if(!object->direct3d8) > + ERR("Can't create D3D8 object\n"); > > *ppv = &object->Direct3D8_iface; > > -- > 2.15.0 > > >

2 3

Re: [PATCH 1/4] dx8vb: Add stubs for D3DX8 interface
by Nikolay Sivov Oct. 31, 2017

Oct. 31, 2017

On Tue, Oct 31, 2017 at 2:31 AM, Fabian Maurer <dark.shadow4(a)web.de> wrote: > > main.c > > IDL_SRCS = dx8vb.idl > diff --git a/dlls/dx8vb/d3dx8.c b/dlls/dx8vb/d3dx8.c > new file mode 100644 > index 0000000000..2959849547 > --- /dev/null > +++ b/dlls/dx8vb/d3dx8.c > @@ -0,0 +1,861 @@ > + /* > + * Copyright 2017 Fabian Maurer > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +#define COBJMACROS > + > +#include "config.h" > + > +#include "dx8vb_private.h" > +#include "ocidl.h" > + > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(dx8vb); > + > +typedef struct > +{ > + ID3DX8 ID3DX8_iface; > + LONG ref; > +} d3dx8; > + > +static inline d3dx8 *impl_from_ID3DX8(ID3DX8 *iface) > +{ > + return CONTAINING_RECORD(iface, d3dx8, ID3DX8_iface); > +} > + > +/*** d3dx8 - IUnknown methods ***/ > + > Comment seems a bit useless, you're not going to use this file for anything else. > +static HRESULT WINAPI d3dx8_QueryInterface(ID3DX8 *iface, REFIID riid, > void **ppv) > +{ > + d3dx8 *This = impl_from_ID3DX8(iface); > + > + TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppv); > + > + *ppv = NULL; > + > + if (IsEqualGUID(riid, &IID_IUnknown)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_ID3DX8)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_IPersistPropertyBag)) > + FIXME("No interface for IID_IPersistPropertyBag\n"); > + else if(IsEqualGUID(riid, &IID_IPersistStreamInit)) > + FIXME("No interface for IID_IPersistStreamInit\n"); > + else > Where does this come from?

2 1

Re: [PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs
by Nikolay Sivov Oct. 31, 2017

Oct. 31, 2017

> > > static HRESULT WINAPI directx8_QueryInterface(IDirectX8 *iface, REFIID > riid, void **ppv) > @@ -237,9 +440,11 @@ static HRESULT WINAPI directx8_ > DirectPlayAddressCreate(IDirectX8 *iface, DirectP > > static HRESULT WINAPI directx8_Direct3DCreate(IDirectX8 *iface, > Direct3D8 **ret) > { > - FIXME("(%p): stub!\n", ret); > + HRESULT res = direct3d8_create(ret); > > - return E_NOTIMPL; > + TRACE("(%p) -> (%x)\n", ret, res); > + > + return res; > } > That's an unusual way to arrange things. Why don't you return as "return direct3d8_create();" ?

2 1

Wineconference keynote 2017
by Marcus Meissner Oct. 30, 2017

Oct. 30, 2017

Hi folks, I have uploaded Alexandres Wineconference 2017 Keynote to youtube: https://www.youtube.com/watch?v=AokFgDSLMWU&t=772s Ciao, Marcus

2 1

WineConf agenda
by Jacek Caban Oct. 29, 2017

Oct. 29, 2017

Hi all, It's getting close to WineConf and I think it's time to think about agenda. Does anyone have anything he'd like to talk about? Any ideas about conversations we should have? Feel free to add them to https://wiki.winehq.org/WineConf2017 Cheers, Jacek

4 4

Re: [v2] oleaut32: Add ARM support to DispCallFunc().
by Donna Whisnant Oct. 28, 2017

Oct. 28, 2017

V3 has been posted. Other comments are inlined below... > > Hi, > > thanks, but it seems I missed minor things last time: > > > + args = heap_alloc(sizeof(VARIANT) * cActuals + sizeof(DWORD) * 4 ); > > Try to be consistent with the spaces for each function call. > Sorry. That one came from a cut-and-paste of the i386 code and I missed fixing it. > > + case VT_R4: /* these must be 4-byte aligned, and put in 's' regs or stack, as they are single-floats */ > > + if (scount < 16) > > + regs.sd.s[scount++] = V_R4(arg); > > + else > > + args[argspos++] = V_UI4(arg); > > + break; > ... > > + case VT_VARIANT: > > + /* 8-byte align 'r' and/or stack: */ > > + if (rcount < 3) > > + { > > + rcount += (rcount % 2); > > + } > > + else > > + { > > + rcount = 4; > > + argspos += (argspos % 2); > > + } > ... > > + case VT_BOOL: /* VT_BOOL is 16-bit but BOOL is 32-bit, needs to be extended */ > > + if (rcount < 4) > > + regs.r[rcount++] = V_BOOL(arg); > > + else > > + args[argspos++] = V_BOOL(arg); > > + break; > > + default: > > + if (rcount < 4) > > + regs.r[rcount++] = V_UI4(arg); > > + else > > + args[argspos++] = V_UI4(arg); > > + break; > > + } > > Maybe one of those is not really conistent wrt curly brackets > That was actually intentional, as I made the 'if' in the VT_VARIANT case consistent with itself. All of the others cited needed no curly braces on either half of the 'if'. However, that one had to have curly braces on the 'else', so I made it consistent on the other side too and used curly braces throughout the 'if'. My usage of curly braces with respect to 'if' statements was to use them on both halves or neither half... But since you want them removed, I have removed the extra curly braces on that one in the v3 post. > > + case VT_CY: > > + V_UI8(pvargResult) = call_method(func, argspos, args, (DWORD*)&regs ); > > + break; > > + default: > > + V_UI4(pvargResult) = call_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > space issue again, maybe somewhere else too? > Oops, I missed that one space. Fixed. I didn't spot any others. The rest appear correct or are at least consistent throughout.

1 0

Re: [v2] oleaut32: Add ARM support to DispCallFunc().
by André Hentschel Oct. 28, 2017

Oct. 28, 2017

Am 26.10.2017 um 06:39 schrieb Donna Whisnant: > Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls > to succeed on ARM platforms. This change specifically targets only > 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be > compatible with big-endian (ARMEB) platforms, but testing for that > platform should be completed before enabling. > > Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd > container to compile and run it on an x86-64 Host.. When running on > Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine > to function. Hi, thanks, but it seems I missed minor things last time: > + args = heap_alloc(sizeof(VARIANT) * cActuals + sizeof(DWORD) * 4 ); Try to be consistent with the spaces for each function call. > + case VT_R4: /* these must be 4-byte aligned, and put in 's' regs or stack, as they are single-floats */ > + if (scount < 16) > + regs.sd.s[scount++] = V_R4(arg); > + else > + args[argspos++] = V_UI4(arg); > + break; ... > + case VT_VARIANT: > + /* 8-byte align 'r' and/or stack: */ > + if (rcount < 3) > + { > + rcount += (rcount % 2); > + } > + else > + { > + rcount = 4; > + argspos += (argspos % 2); > + } ... > + case VT_BOOL: /* VT_BOOL is 16-bit but BOOL is 32-bit, needs to be extended */ > + if (rcount < 4) > + regs.r[rcount++] = V_BOOL(arg); > + else > + args[argspos++] = V_BOOL(arg); > + break; > + default: > + if (rcount < 4) > + regs.r[rcount++] = V_UI4(arg); > + else > + args[argspos++] = V_UI4(arg); > + break; > + } Maybe one of those is not really conistent wrt curly brackets > + case VT_CY: > + V_UI8(pvargResult) = call_method(func, argspos, args, (DWORD*)&regs ); > + break; > + default: > + V_UI4(pvargResult) = call_method( func, argspos, args, (DWORD*)&regs ); > + break; space issue again, maybe somewhere else too? Otherwise I'm quite tempted to sign it off

1 0

Re: Fwd: Re: oleaut32: Add ARM support to DispCallFunc().
by Donna Whisnant Oct. 26, 2017

Oct. 26, 2017

Thanks. I did miss it, as I had subscribed to the patches list, but forgot to subscribe the devel list. And thanks for your feedback. One additional comment regarding the tests, as I didn't see mention of that in this thread. My code passes the tests for this DispCallFunc() function (I did verify that) except for the specialized case that tests for win64 functionality in DispCallFunc(). That test was designed to verify stdcall vs. cdecl on 32-bit x86 platforms. However, like the 64-bit x86, ARM (both 32 and 64) doesn't use stdcall in the traditional sense of stack cleaning. Thus, that test needs to be #ifdef'd out on ARM as it isn't valid. But I didn't like how that looked and it wasn't consistent with the existing 64-bit version. I thought a better solution would be to change it to only be there for "__i386__" instead, as I think that's the only mode that will ever need it. So if you are wondering why my patch set didn't touch the test code and why that particular test technically fails, that's why. I figured you guys can decide which way you want to tweak that... My other replies are inlined below... On Tue, Oct 24, 2017, at 13:37, André Hentschel wrote: > hi, just in case you missed it > > > -------- Weitergeleitete Nachricht -------- > Betreff: Re: oleaut32: Add ARM support to DispCallFunc(). > Datum: Mon, 23 Oct 2017 23:07:43 +0200 > Von: André Hentschel <nerv(a)dawncrow.de> > An: wine-devel(a)winehq.org > > Hi Donna and Welcome to the Wine Project! > > Whats your motivation for this patch? > You did a very good job for a firsttimer! > Thanks! While new to this project, I've been programming for over 37 years. My motivation on this patch was porting some ActiveX components over to ARM to run on a Raspberry Pi Zero W for a data logging device I'm designing for the CAN bus. Those components use IDispatch for invocation rather than the vtable, as they were designed to be extensible without requiring users to recompile their code, and this was the last piece of the puzzle to make them fully work on ARM. > Some more notes below: > > Am 22.10.2017 um 03:04 schrieb Donna Whisnant: > > Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls > > to succeed on ARM platforms. This change specifically targets only > > 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be > > compatible with 64-bit and/or big-endian (ARMEB) platforms, but testing > > for those other platforms should be completed before enabling. > > > > Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd > > container to compile and run it on an x86-64 Host.. When running on > > Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine > > to function. > > > > Signed-off-by: Donna Whisnant <dewhisna(a)dewtronics.com> > > --- > > dlls/oleaut32/typelib.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 219 insertions(+), 2 deletions(-) > > > > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > > index ebf6d85..d7ef212 100644 > > --- a/dlls/oleaut32/typelib.c > > +++ b/dlls/oleaut32/typelib.c > > @@ -6302,8 +6302,48 @@ static HRESULT WINAPI ITypeInfo_fnGetIDsOfNames( ITypeInfo2 *iface, > > return DISP_E_UNKNOWNNAME; > > } > > > > +#if defined(__arm__) && defined(__ARM_32BIT_STATE) && !defined(__ARMEB__) > > +/* Note: this may work OK on 64-bit and/or ARMEB, but has currently only been tested for 32-bit ARMEL */ > > While i doubt there is something risky here regarding endianess you can > keep the ARMEB check, but get rid of the 32bit check, it might be about > Thunk(16bit) vs. ARM(32bit) but I'm not sure. > Anyway, this won't work on 64bit, because the instruction set is totally > different, but it inspires me to do the 64bit version as soon this lands > upstream ;) > Interesting. Between the ARMEB/ARMEL modes and the 32/64 bit check, I would have left the 32-bit check and tossed the !ARMEB check, which is the opposite of your instructions. I'm fairly certain there isn't anything endian-specific. But as you pointed out, the instruction set on the 64-bit is different. So I'm confused why you say to get rid of the 32-bit check. Are you talking about removing the 'define' check for 32-bit or just the comment? Can you please clarify? > > > > -#ifdef __i386__ > > +extern LONGLONG call_method( void *func, int nb_stk_args, const DWORD *stk_args, const DWORD *reg_args ); > > +__ASM_GLOBAL_FUNC( call_method, > > + /* r0 = *func > > + * r1 = nb_stk_args > > + * r2 = *stk_args (pointer to 'nb_stk_args' DWORD values to push on stack) > > + * r3 = *reg_args (pointer to 8, 64-bit d0-d7 (double) values OR as 16, 32-bit s0-s15 (float) values, followed by 4, 32-bit (DWORD) r0-r3 values) > > + */ > > + > > + "push {fp, lr}\n\t" /* Save frame pointer and return address (stack still aligned to 8 bytes) */ > > + __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") > > + __ASM_CFI(".cfi_rel_offset %fp,0\n\t") > > + "add fp, sp, #4\n\t" /* Setup frame pointer */ > > Is this adjusted FP used somewhere? (I forgot a lot of things regarding > arm32...) > In my first version of the code, I was using r4 and r5 (which had to be saved/restored) and originally had slightly different arguments coming into the function (more than was fitting in the registers) and so I was setting up the frame for easier debugging. But then I remembered I have the 'ip' register to my disposal, and that was sufficient and allowed me to toss the saving of those other registers. And, my original function signature was passing both the floating point registers and the core registers in separate structures using separate pointers to them, but then I realized that could be a single structure with both, so I tossed the extra argument and everything would then fit into the registers alone for the call, meaning the stack frame itself isn't really needed anymore. However, it's still necessary to set 'fp', though, as it's needed for cleaning the stack on the return from the callee, but I could toss the +4 adjustment of it or use "#0" for the adjustment like the compiler probably would (as I think it maps to the same instruction binary). If I do that, the ASM_CFI macro usage could be dropped too as there would be nothing for them to report. > > + __ASM_CFI(".cfi_def_cfa_register %fp\n\t") > > + > > + "lsls r1, r1, #2\n\t" /* r1 = nb_stk_args * sizeof(DWORD) */ > > + "beq 1f\n\t" /* Skip allocation if no stack args */ > > + "add r2, r2, r1\n" /* Calculate ending address of incoming stack data */ > > + "2:\tldr ip, [r2, #-4]!\n\t" /* Get next value */ > > + "str ip, [sp, #-4]!\n\t" /* Push it on the stack */ > > + "subs r1, r1, #4\n\t" /* Decrement count */ > > + "bgt 2b\n\t" /* Loop till done */ > > + > > + "1:\tvldm r3!, {s0-s15}\n\t" /* Load the s0-s15/d0-d7 arguments */ > > + "mov ip, r0\n\t" /* Save the function call address to ip before we nuke r0 with arguments to pass */ > > + "ldm r3, {r0-r3}\n\t" /* Load the r0-r3 arguments */ > > + > > + "blx ip\n\t" /* Call the target function */ > > + > > + "sub sp, fp, #4\n\t" /* Clean the stack using 'fp' to allow for either stdcall or cdecl calls */ > > + __ASM_CFI(".cfi_def_cfa %sp,4\n\t") > > + "pop {fp, pc}\n\t" /* Restore FP and return */ > > + __ASM_CFI(".cfi_same_value %fp\n\t") /* Here for completeness and symmetry with other cpus, but won't be reached */ > > + ) > > + > > +/* same function but returning single/double floating point */ > > +static float (* const call_float_method)(void *, int, const DWORD *, const DWORD *) = (void *)call_method; > > +static double (* const call_double_method)(void *, int, const DWORD *, const DWORD *) = (void *)call_method; > > + > > +#elif defined(__i386__) > > > > extern LONGLONG call_method( void *func, int nb_args, const DWORD *args, int *stack_offset ); > > __ASM_GLOBAL_FUNC( call_method, > > @@ -6637,7 +6677,184 @@ DispCallFunc( > > void* pvInstance, ULONG_PTR oVft, CALLCONV cc, VARTYPE vtReturn, UINT cActuals, > > VARTYPE* prgvt, VARIANTARG** prgpvarg, VARIANT* pvargResult) > > { > > -#ifdef __i386__ > > +#if defined(__arm__) && defined(__ARM_32BIT_STATE) && !defined(__ARMEB__) > > +/* Note: this may work OK on 64-bit and/or ARMEB, but has currently only been tested for 32-bit ARMEL */ > > Same as above > > > + int argspos; > > + void *func; > > + UINT i; > > + DWORD *args; > > + struct { > > + union { > > + float s[16]; > > + double d[8]; > > + } sd; > > + DWORD r[4]; > > + } regs; > > + int rcount; /* 32-bit register index count */ > > + int scount; /* single-precision float register index count (will be incremented twice for doubles, plus alignment) */ > > + > > + TRACE("(%p, %ld, %d, %d, %d, %p, %p, %p (vt=%d))\n", > > + pvInstance, oVft, cc, vtReturn, cActuals, prgvt, prgpvarg, > > + pvargResult, V_VT(pvargResult)); > > You can go up to 100 chars per line, so be free to rearrange this > I could, but the trace line was a cut-and-paste from the i386 path that was already there and I figured consistency in the code was good. > > + > > + if (cc != CC_STDCALL && cc != CC_CDECL) > > + { > > + FIXME("unsupported calling convention %d\n",cc); > > + return E_INVALIDARG; > > + } > > + > > + argspos = 0; > > + rcount = 0; > > + scount = 0; > > + > > + /* Determine if we need to pass a pointer for the return value as arg 0. If so, do that */ > > + /* first as it will need to be in the 'r' registers: */ > > + switch (vtReturn) > > + { > > + case VT_DECIMAL: > > + case VT_VARIANT: > > + regs.r[rcount++] = (DWORD)pvargResult; /* arg 0 is a pointer to the result */ > > + break; > > + case VT_HRESULT: > > + WARN("invalid return type %u\n", vtReturn); > > + return E_INVALIDARG; > > + default: /* And all others are in 'r', 's', or 'd' registers or have no return value */ > > + break; > > + } > > + > > + if (pvInstance) > > + { > > + const FARPROC *vtable = *(FARPROC **)pvInstance; > > + func = vtable[oVft/sizeof(void *)]; > > + regs.r[rcount++] = (DWORD)pvInstance; /* the This pointer is always the first parameter */ > > + } > > + else func = (void *)oVft; > > + > > + /* maximum size for an argument is sizeof(VARIANT). Also allow for return pointer and stack alignment. */ > > + args = heap_alloc(sizeof(VARIANT) * cActuals + sizeof(DWORD) * 4 ); > > + > > + for (i = 0; i < cActuals; i++) > > + { > > + VARIANT *arg = prgpvarg[i]; > > + DWORD *pdwarg = (DWORD *)(arg); /* a reinterpret_cast of the variant, used for copying structures when they are split between registers and stack */ > > + int ntemp; /* Used for counting words split between registers and stack */ > > + > > + switch (prgvt[i]) > > + { > > + case VT_EMPTY: > > + break; > > + case VT_R4: /* these must be 4-byte aligned, and put in 's' regs or stack, as they are single-floats */ > > + if (scount < 16) > > + { > > + regs.sd.s[scount++] = V_R4(arg); > > + } else { > > + args[argspos++] = V_UI4(arg); > > + } > > I think no curly brackets are necessary here at all, but we usually don't > open them in the same line as the if/else statement for new code > Oh sorry. I thought I was being consistent with the rest of the code-base. I have the curly brace on the next line after the 'if', but didn't think about the 'else'. I will fix that and resubmit it. I personally like the curly braces even for single-line statements, though, as it keeps from either misreading it or accidentally adding something for the conditional and forgetting to add them. But I will fix the formatting. > > + break; > > + case VT_R8: /* these must be 8-byte aligned, and put in 'd' regs or stack, as they are double-floats */ > > + case VT_DATE: > > + if (scount < 15) > > + { > > + scount += (scount % 2); /* align scount to next whole double */ > > + regs.sd.d[scount/2] = V_R8(arg); > > + scount += 2; > > + } else { > > + scount = 16; /* Make sure we flag that all 's' regs are full */ > > + argspos += (argspos % 2); /* align argspos to 8-bytes */ > > + memcpy( &args[argspos], &V_R8(arg), sizeof(V_R8(arg)) ); > > + argspos += sizeof(V_R8(arg)) / sizeof(DWORD); > > + } > > + break; > > + case VT_I8: /* these must be 8-byte aligned, and put in 'r' regs or stack, as they are long-longs */ > > + case VT_UI8: > > + case VT_CY: > > + if (rcount < 3) > > + { > > + rcount += (rcount % 2); /* align rcount to 8-byte register pair */ > > + memcpy( &regs.r[rcount], &V_UI8(arg), sizeof(V_UI8(arg)) ); > > + rcount += sizeof(V_UI8(arg)) / sizeof(DWORD); > > + } else { > > + rcount = 4; /* Make sure we flag that all 'r' regs are full */ > > + argspos += (argspos % 2); /* align argspos to 8-bytes */ > > + memcpy( &args[argspos], &V_UI8(arg), sizeof(V_UI8(arg)) ); > > + argspos += sizeof(V_UI8(arg)) / sizeof(DWORD); > > + } > > + break; > > + case VT_DECIMAL: /* these structures are 8-byte aligned, and put in 'r' regs or stack, can be split between the two */ > > + case VT_VARIANT: > > + /* 8-byte align 'r' and/or stack: */ > > + if (rcount < 3) > > + { > > + rcount += (rcount % 2); > > + } else { > > + rcount = 4; > > + argspos += (argspos % 2); > > + } > > + ntemp = sizeof(*arg) / sizeof(DWORD); > > + while (ntemp > 0) > > + { > > + if (rcount < 4) > > + { > > + regs.r[rcount++] = *pdwarg++; > > + } else { > > + args[argspos++] = *pdwarg++; > > + } > > + --ntemp; > > + } > > + break; > > + case VT_BOOL: /* VT_BOOL is 16-bit but BOOL is 32-bit, needs to be extended */ > > + if (rcount < 4) > > + { > > + regs.r[rcount++] = V_BOOL(arg); > > + } else { > > + args[argspos++] = V_BOOL(arg); > > + } > > + break; > > + default: > > + if (rcount < 4) > > + { > > + regs.r[rcount++] = V_UI4(arg); > > + } else { > > + args[argspos++] = V_UI4(arg); > > + } > > + break; > > + } > > + TRACE("arg %u: type %s %s\n", i, debugstr_vt(prgvt[i]), debugstr_variant(arg)); > > + } > > + > > + argspos += (argspos % 2); /* Make sure stack function alignment is 8-byte */ > > + > > + TRACE("rcount: %d, scount: %d, argspos: %d\n", rcount, scount, argspos); > > + > > + switch (vtReturn) > > + { > > + case VT_EMPTY: /* EMPTY = no return value */ > > + case VT_DECIMAL: /* DECIMAL and VARIANT already have a pointer argument passed (see above) */ > > + case VT_VARIANT: > > + call_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > + case VT_R4: > > + V_R4(pvargResult) = call_float_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > + case VT_R8: > > + case VT_DATE: > > + V_R8(pvargResult) = call_double_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > + case VT_I8: > > + case VT_UI8: > > + case VT_CY: > > + V_UI8(pvargResult) = call_method(func, argspos, args, (DWORD*)&regs ); > > + break; > > + default: > > + V_UI4(pvargResult) = call_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > + } > > + heap_free( args ); > > + if (vtReturn != VT_VARIANT) V_VT(pvargResult) = vtReturn; > > + TRACE("retval: %s\n", debugstr_variant(pvargResult)); > > + return S_OK; > > + > > +#elif defined(__i386__) > > int argspos, stack_offset; > > void *func; > > UINT i; > > > > >

2 2

Re: [PATCH 4/4] d3d9/tests: Windows 10 15.07 doesn't detect external mode changes.
by Henri Verbeet Oct. 25, 2017

Oct. 25, 2017

On 19 October 2017 at 10:09, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This fixes this test failure: > http://test.winehq.org/data/9787af34b1c23deb67902fc7dbf2c8421b987048/win10_… > > What I have tried to debug or try to work around this issue: > *) Checked that the resolution is actually changed. It is changed from > 640x480 to 800x600. > *) IDirect3DSwapchain9Ex::GetDisplayModeEx sees the new mode. Calling > this method does not make Present see it though. > *) Replace Present with PresentEx. > *) Call flush_events before calling Present. > > I'm happy to try more ideas, but I think this is just broken in this > Windows build. It is working OK in my 17.03 VM, and I believe it was > working on 16.07 too, but I don't have 16.07 around anymore because it > auto updated to 17.03... Should we update the Windows 10 VMs at some point? Do we want to keep the old versions around?

3 2

Re: [PATCH 3/4] mshtml/tests: Skip postMessage test on IE7.
by Marvin Oct. 24, 2017

Oct. 24, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33746 Your paranoid android. === w7pro64 (32 bit htmldoc) === htmldoc.c:3118: Test failed: Incorrect error code: -2146697211 htmldoc.c:3123: Test failed: Page address: L"http://test.winehq.org/tests/winehq_snapshot/" htmldoc.c:5895: Test failed: expected OnChanged_1012 htmldoc.c:5896: Test failed: expected Exec_HTTPEQUIV htmldoc.c:5898: Test failed: expected Exec_SETTITLE htmldoc.c:5939: Test failed: expected FireNavigateComplete2

1 0

Re: [PATCH 2/3] gdiplus: Add internal string format properties used by EMF+ records
by Vincent Povirk Oct. 24, 2017

Oct. 24, 2017

I think the margins in default_drawstring_format should be 1/6. It's not currently used in GdipDrawString or GdipMeasureString, but that's something we may change in the future. Also, they're copied over to generic_default_format which would've had 1/6 margins previously.

1 0

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.
by Alexandre Julliard Oct. 24, 2017

Oct. 24, 2017

Hans Leidekker <hans(a)codeweavers.com> writes: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > configure.ac | 18 +++ > dlls/secur32/Makefile.in | 2 +- > dlls/secur32/kerberos.c | 276 +++++++++++++++++++++++++++++++++++++++++--- > dlls/secur32/secur32.c | 1 + > dlls/secur32/secur32_priv.h | 1 + > 5 files changed, 282 insertions(+), 16 deletions(-) I liked the idea of putting this in kerberos.dll. Have you given up on this? -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: [PATCH] cmd: Implement builtin mklink command
by Alexandre Julliard Oct. 24, 2017

Oct. 24, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + if(hard && !CreateHardLinkW(file1, file2, NULL)) > + WCMD_output_stderr(WCMD_LoadMessage(WCMD_READFAIL), file1); > + else if(!junction && !CreateSymbolicLinkW(file1, file2, isdir)) > + WCMD_output_stderr(WCMD_LoadMessage(WCMD_READFAIL), file1); > + else if(junction) > + WINE_TRACE("Juction links currently not supported.\n"); Surely the options have to be exclusive. It makes no sense to try to create multiple links for the same file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msxml/tests: Add test for \u escape sequences in regular expressions.
by Nikolay Sivov Oct. 24, 2017

Oct. 24, 2017

On 12.10.2017 22:37, Zebediah Figura wrote: > For bug #43581. > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > dlls/msxml3/tests/schema.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c > index ee84b92158..dc65811adb 100644 > --- a/dlls/msxml3/tests/schema.c > +++ b/dlls/msxml3/tests/schema.c > @@ -407,6 +407,15 @@ static const CHAR szOpenSeqXML2[] = "<test><x/><x/><y/><z/><z/><w/></test>"; > static const CHAR szOpenSeqXML3[] = "<test><w/><x/><x/><y/><z/><z/></test>"; > static const CHAR szOpenSeqXML4[] = "<test><x/><x/><y/><z/><z/><v/></test>"; > > +static const CHAR szUnicodeEscapeXDR[] = > +"<schema xmlns='http://www.w3.org/2001/XMLSchema'>" > +" <simpleType name='type1'>" > +" <restriction base='string'>" > +" <pattern value='\\u0020'/>" > +" </restriction>" > +" </simpleType>" > +"</schema>"; > + > #define check_ref_expr(expr, n) { \ > LONG ref = expr; \ > ok(ref == n, "expected %i refs, got %i\n", n, ref); \ > @@ -1154,6 +1163,23 @@ static void test_XDR_schemas(void) Is it XDR "feature" only, that they didn't add to XSDs? > IXMLDOMDocument2_Release(schema); > IXMLDOMSchemaCollection_Release(cache); > > + /* test for \u escapes */ > + schema = create_document_version(60, &IID_IXMLDOMDocument2); > + cache = create_cache_version(60, &IID_IXMLDOMSchemaCollection); > + if (!schema || !cache) > + { > + if (schema) IXMLDOMDocument2_Release(schema); > + if (cache) IXMLDOMSchemaCollection_Release(cache); > + return; > + } Is this really specific to msxml6? It's better to test on all of them to get a full picture, but probably all of them support this extension if 6th does. If you want to skip on unsupported class, just return after first failure, no need to check both pointers. > + > + ole_check(IXMLDOMDocument2_loadXML(schema, _bstr_(szUnicodeEscapeXDR), &b)); > + ok(b == VARIANT_TRUE, "failed to load XML string\n"); > + todo_wine ole_check(IXMLDOMSchemaCollection_add(cache, _bstr_(""), _variantdoc_(schema))); I think it's better to get rid of ole_check(), but it's up to you. > + > + IXMLDOMDocument2_Release(schema); > + IXMLDOMSchemaCollection_Release(cache); > + > free_bstrs(); > } > >

2 1

Re: oleaut32: Add ARM support to DispCallFunc().
by André Hentschel Oct. 23, 2017

Oct. 23, 2017

Hi Donna and Welcome to the Wine Project! Whats your motivation for this patch? You did a very good job for a firsttimer! Some more notes below: Am 22.10.2017 um 03:04 schrieb Donna Whisnant: > Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls > to succeed on ARM platforms. This change specifically targets only > 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be > compatible with 64-bit and/or big-endian (ARMEB) platforms, but testing > for those other platforms should be completed before enabling. > > Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd > container to compile and run it on an x86-64 Host.. When running on > Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine > to function. > > Signed-off-by: Donna Whisnant <dewhisna(a)dewtronics.com> > --- > dlls/oleaut32/typelib.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 219 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index ebf6d85..d7ef212 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -6302,8 +6302,48 @@ static HRESULT WINAPI ITypeInfo_fnGetIDsOfNames( ITypeInfo2 *iface, > return DISP_E_UNKNOWNNAME; > } > > +#if defined(__arm__) && defined(__ARM_32BIT_STATE) && !defined(__ARMEB__) > +/* Note: this may work OK on 64-bit and/or ARMEB, but has currently only been tested for 32-bit ARMEL */ While i doubt there is something risky here regarding endianess you can keep the ARMEB check, but get rid of the 32bit check, it might be about Thunk(16bit) vs. ARM(32bit) but I'm not sure. Anyway, this won't work on 64bit, because the instruction set is totally different, but it inspires me to do the 64bit version as soon this lands upstream ;) > > -#ifdef __i386__ > +extern LONGLONG call_method( void *func, int nb_stk_args, const DWORD *stk_args, const DWORD *reg_args ); > +__ASM_GLOBAL_FUNC( call_method, > + /* r0 = *func > + * r1 = nb_stk_args > + * r2 = *stk_args (pointer to 'nb_stk_args' DWORD values to push on stack) > + * r3 = *reg_args (pointer to 8, 64-bit d0-d7 (double) values OR as 16, 32-bit s0-s15 (float) values, followed by 4, 32-bit (DWORD) r0-r3 values) > + */ > + > + "push {fp, lr}\n\t" /* Save frame pointer and return address (stack still aligned to 8 bytes) */ > + __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") > + __ASM_CFI(".cfi_rel_offset %fp,0\n\t") > + "add fp, sp, #4\n\t" /* Setup frame pointer */ Is this adjusted FP used somewhere? (I forgot a lot of things regarding arm32...) > + __ASM_CFI(".cfi_def_cfa_register %fp\n\t") > + > + "lsls r1, r1, #2\n\t" /* r1 = nb_stk_args * sizeof(DWORD) */ > + "beq 1f\n\t" /* Skip allocation if no stack args */ > + "add r2, r2, r1\n" /* Calculate ending address of incoming stack data */ > + "2:\tldr ip, [r2, #-4]!\n\t" /* Get next value */ > + "str ip, [sp, #-4]!\n\t" /* Push it on the stack */ > + "subs r1, r1, #4\n\t" /* Decrement count */ > + "bgt 2b\n\t" /* Loop till done */ > + > + "1:\tvldm r3!, {s0-s15}\n\t" /* Load the s0-s15/d0-d7 arguments */ > + "mov ip, r0\n\t" /* Save the function call address to ip before we nuke r0 with arguments to pass */ > + "ldm r3, {r0-r3}\n\t" /* Load the r0-r3 arguments */ > + > + "blx ip\n\t" /* Call the target function */ > + > + "sub sp, fp, #4\n\t" /* Clean the stack using 'fp' to allow for either stdcall or cdecl calls */ > + __ASM_CFI(".cfi_def_cfa %sp,4\n\t") > + "pop {fp, pc}\n\t" /* Restore FP and return */ > + __ASM_CFI(".cfi_same_value %fp\n\t") /* Here for completeness and symmetry with other cpus, but won't be reached */ > + ) > + > +/* same function but returning single/double floating point */ > +static float (* const call_float_method)(void *, int, const DWORD *, const DWORD *) = (void *)call_method; > +static double (* const call_double_method)(void *, int, const DWORD *, const DWORD *) = (void *)call_method; > + > +#elif defined(__i386__) > > extern LONGLONG call_method( void *func, int nb_args, const DWORD *args, int *stack_offset ); > __ASM_GLOBAL_FUNC( call_method, > @@ -6637,7 +6677,184 @@ DispCallFunc( > void* pvInstance, ULONG_PTR oVft, CALLCONV cc, VARTYPE vtReturn, UINT cActuals, > VARTYPE* prgvt, VARIANTARG** prgpvarg, VARIANT* pvargResult) > { > -#ifdef __i386__ > +#if defined(__arm__) && defined(__ARM_32BIT_STATE) && !defined(__ARMEB__) > +/* Note: this may work OK on 64-bit and/or ARMEB, but has currently only been tested for 32-bit ARMEL */ Same as above > + int argspos; > + void *func; > + UINT i; > + DWORD *args; > + struct { > + union { > + float s[16]; > + double d[8]; > + } sd; > + DWORD r[4]; > + } regs; > + int rcount; /* 32-bit register index count */ > + int scount; /* single-precision float register index count (will be incremented twice for doubles, plus alignment) */ > + > + TRACE("(%p, %ld, %d, %d, %d, %p, %p, %p (vt=%d))\n", > + pvInstance, oVft, cc, vtReturn, cActuals, prgvt, prgpvarg, > + pvargResult, V_VT(pvargResult)); You can go up to 100 chars per line, so be free to rearrange this > + > + if (cc != CC_STDCALL && cc != CC_CDECL) > + { > + FIXME("unsupported calling convention %d\n",cc); > + return E_INVALIDARG; > + } > + > + argspos = 0; > + rcount = 0; > + scount = 0; > + > + /* Determine if we need to pass a pointer for the return value as arg 0. If so, do that */ > + /* first as it will need to be in the 'r' registers: */ > + switch (vtReturn) > + { > + case VT_DECIMAL: > + case VT_VARIANT: > + regs.r[rcount++] = (DWORD)pvargResult; /* arg 0 is a pointer to the result */ > + break; > + case VT_HRESULT: > + WARN("invalid return type %u\n", vtReturn); > + return E_INVALIDARG; > + default: /* And all others are in 'r', 's', or 'd' registers or have no return value */ > + break; > + } > + > + if (pvInstance) > + { > + const FARPROC *vtable = *(FARPROC **)pvInstance; > + func = vtable[oVft/sizeof(void *)]; > + regs.r[rcount++] = (DWORD)pvInstance; /* the This pointer is always the first parameter */ > + } > + else func = (void *)oVft; > + > + /* maximum size for an argument is sizeof(VARIANT). Also allow for return pointer and stack alignment. */ > + args = heap_alloc(sizeof(VARIANT) * cActuals + sizeof(DWORD) * 4 ); > + > + for (i = 0; i < cActuals; i++) > + { > + VARIANT *arg = prgpvarg[i]; > + DWORD *pdwarg = (DWORD *)(arg); /* a reinterpret_cast of the variant, used for copying structures when they are split between registers and stack */ > + int ntemp; /* Used for counting words split between registers and stack */ > + > + switch (prgvt[i]) > + { > + case VT_EMPTY: > + break; > + case VT_R4: /* these must be 4-byte aligned, and put in 's' regs or stack, as they are single-floats */ > + if (scount < 16) > + { > + regs.sd.s[scount++] = V_R4(arg); > + } else { > + args[argspos++] = V_UI4(arg); > + } I think no curly brackets are necessary here at all, but we usually don't open them in the same line as the if/else statement for new code > + break; > + case VT_R8: /* these must be 8-byte aligned, and put in 'd' regs or stack, as they are double-floats */ > + case VT_DATE: > + if (scount < 15) > + { > + scount += (scount % 2); /* align scount to next whole double */ > + regs.sd.d[scount/2] = V_R8(arg); > + scount += 2; > + } else { > + scount = 16; /* Make sure we flag that all 's' regs are full */ > + argspos += (argspos % 2); /* align argspos to 8-bytes */ > + memcpy( &args[argspos], &V_R8(arg), sizeof(V_R8(arg)) ); > + argspos += sizeof(V_R8(arg)) / sizeof(DWORD); > + } > + break; > + case VT_I8: /* these must be 8-byte aligned, and put in 'r' regs or stack, as they are long-longs */ > + case VT_UI8: > + case VT_CY: > + if (rcount < 3) > + { > + rcount += (rcount % 2); /* align rcount to 8-byte register pair */ > + memcpy( &regs.r[rcount], &V_UI8(arg), sizeof(V_UI8(arg)) ); > + rcount += sizeof(V_UI8(arg)) / sizeof(DWORD); > + } else { > + rcount = 4; /* Make sure we flag that all 'r' regs are full */ > + argspos += (argspos % 2); /* align argspos to 8-bytes */ > + memcpy( &args[argspos], &V_UI8(arg), sizeof(V_UI8(arg)) ); > + argspos += sizeof(V_UI8(arg)) / sizeof(DWORD); > + } > + break; > + case VT_DECIMAL: /* these structures are 8-byte aligned, and put in 'r' regs or stack, can be split between the two */ > + case VT_VARIANT: > + /* 8-byte align 'r' and/or stack: */ > + if (rcount < 3) > + { > + rcount += (rcount % 2); > + } else { > + rcount = 4; > + argspos += (argspos % 2); > + } > + ntemp = sizeof(*arg) / sizeof(DWORD); > + while (ntemp > 0) > + { > + if (rcount < 4) > + { > + regs.r[rcount++] = *pdwarg++; > + } else { > + args[argspos++] = *pdwarg++; > + } > + --ntemp; > + } > + break; > + case VT_BOOL: /* VT_BOOL is 16-bit but BOOL is 32-bit, needs to be extended */ > + if (rcount < 4) > + { > + regs.r[rcount++] = V_BOOL(arg); > + } else { > + args[argspos++] = V_BOOL(arg); > + } > + break; > + default: > + if (rcount < 4) > + { > + regs.r[rcount++] = V_UI4(arg); > + } else { > + args[argspos++] = V_UI4(arg); > + } > + break; > + } > + TRACE("arg %u: type %s %s\n", i, debugstr_vt(prgvt[i]), debugstr_variant(arg)); > + } > + > + argspos += (argspos % 2); /* Make sure stack function alignment is 8-byte */ > + > + TRACE("rcount: %d, scount: %d, argspos: %d\n", rcount, scount, argspos); > + > + switch (vtReturn) > + { > + case VT_EMPTY: /* EMPTY = no return value */ > + case VT_DECIMAL: /* DECIMAL and VARIANT already have a pointer argument passed (see above) */ > + case VT_VARIANT: > + call_method( func, argspos, args, (DWORD*)&regs ); > + break; > + case VT_R4: > + V_R4(pvargResult) = call_float_method( func, argspos, args, (DWORD*)&regs ); > + break; > + case VT_R8: > + case VT_DATE: > + V_R8(pvargResult) = call_double_method( func, argspos, args, (DWORD*)&regs ); > + break; > + case VT_I8: > + case VT_UI8: > + case VT_CY: > + V_UI8(pvargResult) = call_method(func, argspos, args, (DWORD*)&regs ); > + break; > + default: > + V_UI4(pvargResult) = call_method( func, argspos, args, (DWORD*)&regs ); > + break; > + } > + heap_free( args ); > + if (vtReturn != VT_VARIANT) V_VT(pvargResult) = vtReturn; > + TRACE("retval: %s\n", debugstr_variant(pvargResult)); > + return S_OK; > + > +#elif defined(__i386__) > int argspos, stack_offset; > void *func; > UINT i; >

1 0

Re: [3/4] include: Add twain 2.x header for use in data sources.
by Henri Verbeet Oct. 23, 2017

Oct. 23, 2017

On 20 October 2017 at 21:16, Vincent Povirk <vincent(a)codeweavers.com> wrote: > diff --git a/include/twain2.h b/include/twain2.h > new file mode 100644 > index 0000000..8455649 > --- /dev/null > +++ b/include/twain2.h > @@ -0,0 +1,2131 @@ > +/* ======================================================================== *\ > + > + Copyright (C) 2007 TWAIN Working Group: Adobe Systems Incorporated, > + AnyDoc Software Inc., Eastman Kodak Company, Fujitsu Computer Products > + of America, JFL Peripheral Solutions Inc., Ricoh Corporation, and > + Xerox Corporation. All rights reserved. > + > + Copyright (C) 1991, 1992 TWAIN Working Group: Aldus, Caere, Eastman-Kodak, > + Hewlett-Packard and Logitech Corporations. All rights reserved. > + > + Copyright (C) 1997 TWAIN Working Group: Bell+Howell, Canon, DocuMagix, > + Fujitsu, Genoa Technology, Hewlett-Packard, Kofax Imaging Products, and > + Ricoh Corporation. All rights reserved. > + > + Copyright (C) 1998 TWAIN Working Group: Adobe Systems Incorporated, > + Canon Information Systems, Eastman Kodak Company, > + Fujitsu Computer Products of America, Genoa Technology, > + Hewlett-Packard Company, Intel Corporation, Kofax Image Products, > + JFL Peripheral Solutions Inc., Ricoh Corporation, and Xerox Corporation. > + All rights reserved. > + > + Copyright (C) 2000 TWAIN Working Group: Adobe Systems Incorporated, > + Canon Information Systems, Digimarc Corporation, Eastman Kodak Company, > + Fujitsu Computer Products of America, Hewlett-Packard Company, > + JFL Peripheral Solutions Inc., Ricoh Corporation, and Xerox Corporation. > + All rights reserved. > + Doesn't the above essentially say we can't distribute this?

3 5

Re: [v2 PATCH 1/2] gdiplus/metafile: Implement EmfPlusRecordTypeSetClipRegion playback
by Vincent Povirk Oct. 23, 2017

Oct. 23, 2017

Is there a reason to clone the region instead of using it directly from the object table?

1 1

Re: [PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.
by Henri Verbeet Oct. 23, 2017

Oct. 23, 2017

On 22 October 2017 at 00:32, Zebediah Figura <z.figura12(a)gmail.com> wrote: > This should fix a persistent crash on one of the XP test machines. > > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- Why does it fail? It shouldn't. Does this run against Microsoft's ddraw, or against some VM replacement?

2 2

Re: [PATCH] msvcrt: Implement _memicmp_l()
by Marvin Oct. 23, 2017

Oct. 23, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33714 Your paranoid android. === wvistau64 (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w7u (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w1064 (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === wvistau64 (64 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w1064 (64 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL

1 0

Re: [PATCH] msvcrt: Implement _memicmp_l()
by Marvin Oct. 23, 2017

Oct. 23, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33712 Your paranoid android. === wxppro (32 bit string) === 09f0:string: unhandled exception c0000005 at 77C4835C === w2003std (32 bit string) === 05f0:string: unhandled exception c0000005 at 77BD929C

1 0

Re: [PATCH] comctl32: Add RegisterClassNameW stub
by Nikolay Sivov Oct. 22, 2017

Oct. 22, 2017

I don't think you need separate export to register classes. As a test create your own dll with such export, and see if it's called from test exe when some referenced class name is requested, as far as I remember this was only used in early versions.

2 3

Re: [PATCH 2/2] msi: Don't leak memory on failure.
by Nikolay Sivov Oct. 22, 2017

Oct. 22, 2017

On 21.10.2017 12:50, Pierre Schweitzer wrote: > row = MSI_CreateRecord(1); > if (!row) > + { > + msi_free(buffer); > return NULL; > + } > MSI_RecordSetStringW(row, 1, buffer); > msi_free(buffer); > return row; You can replace this with: --- row = MSI_CreateRecord(1); if (row) MSI_RecordSetStringW(row, 1, buffer); msi_free(buffer); return row; ---

2 2

Re: [PATCH 5/5] msi: Add more feature action tests
by Marvin Oct. 20, 2017

Oct. 20, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33689 Your paranoid android. === w2003std (32 bit package) === package.c:3763: Test failed: Expected ERROR_SUCCESS, got 1603 === w7u (32 bit package) === The task timed out

1 0

Re: [PATCH 4/5] msi: Add install test with no arguments on already installed product
by Marvin Oct. 20, 2017

Oct. 20, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33688 Your paranoid android. === w2003std (32 bit package) === package.c:3710: Test failed: Expected ERROR_SUCCESS, got 1603

1 0

Re: [resend PATCH 4/4] gdiplus/metafile: Implement EmfPlusRecordTypeSetClipRegion playback
by Vincent Povirk Oct. 20, 2017

Oct. 20, 2017

> + return GdipSetClipRegion(real_metafile->playback_graphics, real_metafile->objtable[region].u.region, > + (flags >> 8) & 0xf); This clip region needs to be intersected with the clip region from when the metafile began playing, similar to what we do for world transforms. Alternately, we could try to repurpose our existing code for handling gdi32 clipping and transforms. It just occurred to me that applications could tell the difference between those approaches, so we should probably have tests.

1 0

Re: [PATCH 12/14] mshtml: Don't use fire_event to dispatch script readystatechange event.
by Marvin Oct. 20, 2017

Oct. 20, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33685 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.
by Dmitry Timoshkov Oct. 20, 2017

Oct. 20, 2017

Hi Hans, Hans Leidekker <hans(a)codeweavers.com> wrote: > This series is based on a patch by Rob Shearman. Since during some time I was involved in the project that aims adding Kerberos support to Wine (it's still not fully finished yet, that's why we haven't published it yet) I have some comments on your approach. Our main target for testing was KerberosAuthenticationTester.exe from http://blog.michelbarneveld.nl/michel/archive/2009/12/05/kerberos-authentic… (the author doesn't provide the sources, but it's pretty trivial to get full C# source for the whole application, so understanding and debugging is not an issue). Another good test is klist.exe from (older) PSDK. Our team also decided to use Rob's patch as a base for SSP, and in addition we've also implemented Kerberos ticket management API. Main difference between your and our approaches is the architecture. We decided to add support for Kerberos using an approximation to what Windows has in place: implement Authentication Package (AP) manager in secur32 (LSA APIs) which dinamically loads APs listed in the registry. All the real code (both SSP and AP) is implemented in kerberos.dll, which dynamically loads libkrb5.so and gssapi_krb5.so. Did you consider moving the Kerberos support into separate kerberos AP/SSP dll? -- Dmitry.

2 16

Re: [2/3] ole32/tests: Add a test for IOleCache storage contents created by IPersistStorage_Save(). (v2)
by Huw Davies Oct. 20, 2017

Oct. 20, 2017

On Fri, Oct 20, 2017 at 09:58:57AM +0800, Dmitry Timoshkov wrote: > v2: Call IPersistStorage_Save() directly instead of OleSave(). > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 402 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 402 insertions(+) > > diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c > index 0773bbf189..9ed19f1f9b 100644 > --- a/dlls/ole32/tests/ole2.c > +++ b/dlls/ole32/tests/ole2.c > +static void check_storage_contents(IStorage *stg, const struct storage_def *stg_def, > + int *enumerated_streams, int *matched_streams) > +{ > + HRESULT hr; > + IEnumSTATSTG *enumstg; > + IStream *stream; > + STATSTG stat; > + int i, seen_stream[MAX_STREAM] = { 0 }; > + > + if (winetest_debug > 1) > + trace("check_storage_contents:\n=============================================\n"); > + > + *enumerated_streams = 0; > + *matched_streams = 0; > + > + hr = IStorage_Stat(stg, &stat, STATFLAG_NONAME); > + ok(hr == S_OK, "unexpected %#x\n", hr); > +todo_wine_if(!IsEqualCLSID(stg_def->clsid, &stat.clsid)) > + ok(IsEqualCLSID(stg_def->clsid, &stat.clsid), "expected %s, got %s\n", > + wine_dbgstr_guid(stg_def->clsid), wine_dbgstr_guid(&stat.clsid)); > + > + hr = IStorage_EnumElements(stg, 0, NULL, 0, &enumstg); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + for (;;) > + { > + ULONG bytes; > + int clipformat = -1; > + PresentationDataHeader header; > + char name[32]; > + BYTE data[256]; > + > + memset(&header, 0, sizeof(header)); > + > + hr = IEnumSTATSTG_Next(enumstg, 1, &stat, NULL); > + if(hr == S_FALSE) break; > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + if (winetest_debug > 1) > + trace("name %s, type %u, size %d, clsid %s\n", > + wine_dbgstr_w(stat.pwcsName), stat.type, stat.cbSize.u.LowPart, wine_dbgstr_guid(&stat.clsid)); > + > + ok(stat.type == STGTY_STREAM, "unexpected %#x\n", stat.type); > + > + WideCharToMultiByte(CP_ACP, 0, stat.pwcsName, -1, name, sizeof(name), NULL, NULL); > + > + hr = IStorage_OpenStream(stg, stat.pwcsName, NULL, STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + if (!memcmp(name, "\2OlePres", 7)) > + { > + clipformat = read_clipformat(stream); > + > + hr = IStream_Read(stream, &header, sizeof(header), &bytes); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + ok(bytes >= 24, "read %u bytes, expected to read %u bytes\n", bytes, sizeof(header)); > + You're using sizeof as an argument to a fprintf-like function which, for example, gives a warning on macOS. ole2.c:3532:82: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat] Also, while you're at it, couldn't that '24' be sizeof(header) instead? Huw.

2 2

Re: [3/3] ole32: Remove an optimization from DataCache_Save() that copies whole original storage.
by Marvin Oct. 20, 2017

Oct. 20, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33675 Your paranoid android. === wxppro (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2003std (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === wvistau64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2008s64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7u (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7pro64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w8 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w864 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w1064 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === wvistau64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2008s64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7pro64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w864 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w1064 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes

1 0

Re: [2/3] ole32/tests: Add a test for IOleCache storage contents created by IPersistStorage_Save(). (v3)
by Marvin Oct. 20, 2017

Oct. 20, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33674 Your paranoid android. === wxppro (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2003std (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === wvistau64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2008s64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7u (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7pro64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w8 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w864 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w1064 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === wvistau64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2008s64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7pro64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w864 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w1064 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes

1 0

Re: [PATCH 1/4] gdiplus/metafile: Partially implement EmfPlusPen support for playback
by Vincent Povirk Oct. 19, 2017

Oct. 19, 2017

Some of the size calculations don't seem to match. + if (pendata->PenDataFlags & PenDataTransform) + offset += sizeof(GpMatrix); + if (pendata->PenDataFlags & PenDataTransform) + { + FIXME("PenDataTransform is not supported.\n"); + offset += sizeof(EmfPlusTransformMatrix); + } + if (pendata->PenDataFlags & PenDataDashedLine) + { + EmfPlusDashedLineData *dashedline = (EmfPlusDashedLineData *)((BYTE *)data + offset); + + offset += FIELD_OFFSET(EmfPlusDashedLineData, data); + if (data_size <= offset) + return InvalidParameter; + + offset += dashedline->DashedLineDataSize; + } + if (pendata->PenDataFlags & PenDataDashedLine) + { + EmfPlusDashedLineData *dashedline = (EmfPlusDashedLineData *)((BYTE *)pendata + offset); + FIXME("PenDataDashedLine is not supported.\n"); + offset += dashedline->DashedLineDataSize; + }

2 1

Font rendering issues after some update.
by John Found Oct. 19, 2017

Oct. 19, 2017

After an update of the system, WINE stopped to render the fonts properly. Regardless of the registry or other system settings, following behaviour is observed: 1. The antialiasing is only grayscale. 2. The antialiasing is only if the font size is bigger than 14px. Smaller fonts are not smoothed at all. 3. The hinting seems to be switched off. At least for some fonts. The bitmap fonts or the fonts designed to not use smoothing (for example FixedSys Excelsior) look like usual. All this seems to not depend on any settings of the system configuration or WINE registry. Thinking that the problem is simply broken WINE/fontconfig/freetype I tried all possible configuration tweaks from Internet. Without any effect. I mean, the font rendering never changes even by pixel. I have second system, that worked fine, but after the today update (I am using it very rarely) the problem appeared as well. In the same time, all other Linux applications work normally, I can change the rendering options from the usual GUI applets. I can't say when exactly the problem appeared for the first time. But on this second system, the updated versions are: wine: from 2.4-1 to 2.18-1 fontconfig: from 2.12.1-4 to 2.12.6-1 freetype: from 2.7.1-1 to 2.8.1-1 Any ideas how to fix the problem? Or at least how to continue the research. -- http://fresh.flatassembler.net http://asm32.info John Found <johnfound(a)asm32.info>

2 3

Re: [PATCH 3/9] mshtml: Set current event target in fire_event_obj.
by Marvin Oct. 19, 2017

Oct. 19, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33648 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 2/2] user32: Implement IDI_SHIELD.
by Alexandre Julliard Oct. 19, 2017

Oct. 19, 2017

Alex Henrie <alexhenrie24(a)gmail.com> writes: > From 28d5fcc630dcf3ee9b559f05a9a0fb5d6c3e06bd Mon Sep 17 00:00:00 2001 > From: Alex Henrie <alexhenrie24(a)gmail.com> > Date: Thu, 19 Oct 2017 01:30:55 -0600 > Subject: [PATCH 2/2] user32: Implement IDI_SHIELD. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=43770 > > Steps to create these icons: Thanks! While you are at it, how about adding some colors to it? On a gray background it's going to be pretty much invisible. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] d3d9/tests: Windows 10 17.09 added an undocumented query type (v2).
by Henri Verbeet Oct. 19, 2017

Oct. 19, 2017

On 19 October 2017 at 10:09, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -5552,7 +5552,9 @@ static void test_query_support(void) > > for (i = 0; i < 40; ++i) > { > - if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE) > + /* Windows 10 17.09 (build 16299.19) added an undocumented query with an enum value of 0x16 (=22). > + * It returns D3D_OK when asking for support and E_FAIL when trying to actually create it. */ > + if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE || i == 0x16) This introduces a warning: device.c: In function ‘test_query_support’: device.c:5566:38: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE || i == 0x16)

1 0

Re: [PATCH 2/2] msi: Remove full reinstall special handling
by Hans Leidekker Oct. 19, 2017

Oct. 19, 2017

On Wed, 2017-10-18 at 17:25 +0200, Piotr Caban wrote: > This patch fixes "change office 2010 serial key" functionality. This code was introduced to fix the Enterprise Architect installer after I broke it with e2900c23c7f0b143078da780c9a0ff19a895bf45. (see https://bugs.winehq.org/show_bug.cgi?id=32387) Your patch breaks this installer again because the condition for entering the maintenance dialog tests the Preselected property. Given your test it seems that we shouldn't set REINSTALL at all (since it causes Preselected to be set) or that we should set it only after evaluating command line overrides.

2 1

Re: [3/3] ole32: Use a shortcut in DataCache_Save only if fSameAsLoad set to TRUE.
by Huw Davies Oct. 19, 2017

Oct. 19, 2017

On Wed, Sep 20, 2017 at 02:54:21PM +0300, Dmitry Timoshkov wrote: > This looks like a typo, and this patch makes saving data in a pretty complex > application work. > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/datacache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index 4e684b4189..c3383176f8 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -1663,7 +1663,7 @@ static HRESULT WINAPI DataCache_Save( > } > > /* this is a shortcut if nothing changed */ > - if (!dirty && !fSameAsLoad && This->presentationStorage) > + if (!dirty && fSameAsLoad && This->presentationStorage) > { > return IStorage_CopyTo(This->presentationStorage, 0, NULL, NULL, pStg); > } No, this isn't a typo. The idea is to copy the loaded storage to a fresh storage that is passed when fSameAsLoad is FALSE. I'm aware that there are issues related to the storage handling in both the cache and the default handler. That's on my list of things to look into, but feel free to investigate further. Huw.

2 7

Re: [1/2] ole32/tests: Add a test for OleSave() called for a IOleCache storage.
by Huw Davies Oct. 19, 2017

Oct. 19, 2017

On Thu, Oct 19, 2017 at 01:06:50PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 214 +++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 202 insertions(+), 12 deletions(-) This looks ok, but could you please call IPersistStorage_Save() directly rather than using the OleSave() helper? Also fix the function name to reflect that. Thanks, Huw.

2 2

Re: [2/2] ole32/tests: Add a test for IOleCache storage contents created by OleSave().
by Huw Davies Oct. 19, 2017

Oct. 19, 2017

On Thu, Oct 19, 2017 at 01:07:01PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 372 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 372 insertions(+) > Again, please use IPersistStorage_Save() in this one. Huw.

1 0

Re: [PATCH 3/4] d3d8/tests: Make test_reset more resilient against DPI scaling. (v2)
by Marvin Oct. 19, 2017

Oct. 19, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33639 Your paranoid android. === w1064 (32 bit device) === device.c:1532: Test failed: Reset failed, hr 0x80070057. device.c:1534: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1546: Test failed: D3DVIEWPORT->Width = 400. device.c:1547: Test failed: D3DVIEWPORT->Height = 300. 0864:device: unhandled exception c0000005 at 706EA86E

1 0

Re: [PATCH v2] user32: Add the IDI_SHIELD icon resource.
by Alexandre Julliard Oct. 19, 2017

Oct. 19, 2017

"Sergio Gómez Del Real" <sergio.g.delreal(a)gmail.com> writes: > Applications such as Fidibo > (https://bugs.winehq.org/show_bug.cgi?id=43770) ask for the IDI_SHIELD > OEM resource, for example by calling comctl32.LoadIconMetric. Because > the resource doesn't exist in user32, the function returns error and, > in the specific case of Fidibo, the application crashes. This patch > adds to user32.rc the appropriate lines and adds the file > oic_shield.svg, from which oic_shield.ico will be generated. > > NOTE: Tango's public domain network-wireless-encrypted.svg file was > used. Thanks to Alex Henrie for this. To generate a proper icon, we'd need multiple scaled images for the various sizes, and bitmaps for low-color resolutions, with the labels expected by the buildimage script. You can check how this is done in oic_winlogo.svg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/6] wined3d: Pack interpolation modes.
by Henri Verbeet Oct. 18, 2017

Oct. 18, 2017

On 18 October 2017 at 00:25, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static inline DWORD wined3d_extract_bits(const DWORD *bitstream, > + unsigned int offset, unsigned int count) > +{ > + const unsigned int word_bit_count = sizeof(*bitstream) * CHAR_BIT; > + const unsigned int idx = offset / word_bit_count; > + const unsigned int shift = offset % word_bit_count; > + DWORD mask = (1u << count) - 1; It's not an issue in this patch, but note that the above doesn't work for count > 31. We probably don't care about count > 32, but we may care about count == 32. Specifically, "1u << 32" is undefined, but in practice tends to evaluate as "1u << 0".

2 3

Re: [PATCH 2/4] d3d9/tests: Fix test_reset on Nvidia Windows 10.
by Stefan Dösinger Oct. 18, 2017

Oct. 18, 2017

> Am 18.10.2017 um 21:38 schrieb Stefan Dösinger <stefan(a)codeweavers.com>: > > The client rectangle is 204x150 on my system (real one, Nvidia GPU, not > qemu), even though we requested 200x150. Odd, but not really the concern > of this test. I had an epiphany where the odd behavior comes from: It was caused by my custom UI scaling factor of 172% (=165 DPI). Setting it to 150% (144 DPI), a value suggested by Windows, gives the expected window size. I still think the patch is a good idea because it makes the test more robust against such configurations. I’ll resend it tomorrow with an updated title and description.

1 0

Re: [PATCH] user32: Add the IDI_SHIELD icon resource.
by Alex Henrie Oct. 18, 2017

Oct. 18, 2017

> NOTE: oic_shield.svg is just a copy of oic_winlogo.svg. Could we use an actual shield icon instead? It was pretty easy for me to open Tango's network-wireless-encrypted.svg in Inkscape and edit it down to a plain shield. This icon is in the public domain, so it's fine to use it in Wine. -Alex

1 0

Re: [PATCH] winmm/tests: Give play from 0 to 0 more time to finish.
by Marvin Oct. 18, 2017

Oct. 18, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33612 Your paranoid android. === w864 (64 bit mci) === mci.c:995: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0000 from command play (nowait) mci.c:998: Test failed: mci pause wait returned MCIERR_NONAPPLICABLE_FUNCTION mci.c:1002: Test failed: mci status mode: stopped mci.c:1003: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0002 from command play mci.c:1004: Test failed: Expect message 0001 from status

2 1

Re: [1/2] kerberos: Add a stub for Kerberos5 Authentication Package. (v2)
by Alexandre Julliard Oct. 18, 2017

Oct. 18, 2017

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > When compiling without HAVE_KRB5_KRB5_H defined the compiler issues > a warning about libkrb5_handle not being used, libkrb5_handle will be > used later as a detection that libkrb5 is available. I'll move this to avoid the warning, it can be moved back when it's used. Though it may be cleaner to always check it inside the ifdef anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-2.0.3-rc2 Available
by Michael Stefaniuc Oct. 17, 2017

Oct. 17, 2017

Hello guys, I have pushed wine-2.0.3-rc3 (with tag) to https://github.com/mstefani/wine-stable Changes since rc1: - Removed the commit "gdi32: Return non-zero VREFRESH value for display devices." aka bug #43369 It is a no-op without cherry-picking some risky other patches. bye michael

1 0

Re: [PATCH 3/5] gdiplus: Add internal string format properties used by typographical format
by Vincent Povirk Oct. 17, 2017

Oct. 17, 2017

This removes margins when a NULL format is specified. If that change is correct, it should probably be in a separate patch and have a test case.

2 1

Re: [1/2] kerberos: Add a stub for Kerberos5 Authentication Package.
by Hans Leidekker Oct. 17, 2017

Oct. 17, 2017

Hi Dmitry, Thanks. Alexandre pointed out that we do not need to load libkrb5 dynamically because libgssapi_krb5 depends on libkrb5. So if libkrb5 is missing the SSP wouldn't be usable anyway. > diff --git a/configure.ac b/configure.ac > index 58737162a8..82faa4b943 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -422,6 +422,7 @@ AC_CHECK_HEADERS(\ > ieeefp.h \ > inet/mib2.h \ > io.h \ > + krb5/krb5.h \ > kstat.h \ > libproc.h \ > link.h \ > @@ -1625,6 +1626,14 @@ fi > WINE_NOTICE_WITH(gsm,[test "x$ac_cv_lib_soname_gsm" = "x"], > [libgsm ${notice_platform}development files not found, gsm 06.10 codec won't be supported.]) > > +dnl **** Check for krb5 **** > +if test "$ac_cv_header_krb5_krb5_h" = "yes" > +then > + WINE_CHECK_SONAME(krb5,krb5_init_context) > +fi > +WINE_NOTICE_WITH(krb5,[test "x$ac_cv_lib_soname_krb5" = "x"], > + [libkrb5 ${notice_platform}development files not found, krb5 won't be supported.]) > + There is pkgconfig support for krb5. I guess we want to use it. You need to guard the code that uses krb5 functions with an ifdef or it will fail to compile if the headers are missing.

4 5

Re: [PATCH] msvcp120: Fix _Xtime_diff_to_millis2 overflow behavior.
by Piotr Caban Oct. 17, 2017

Oct. 17, 2017

On 10/11/17 17:07, Stefan Dösinger wrote: > + {0x7FFFFFFFFFFFFFFF, 0, 0x7FFFFFFFFFFFFFFD, 0, 0}, /* Not an overflow */ Defining LONGLONG constants this way is not portable. > @@ -410,7 +410,13 @@ MSVCRT_long __cdecl _Xtime_diff_to_millis2(const xtime *t1, const xtime *t2) > diff_nsec = t1->nsec - t2->nsec; > ret = diff_sec * MILLISEC_PER_SEC + > (diff_nsec + NANOSEC_PER_MILLISEC - 1) / NANOSEC_PER_MILLISEC; > - return ret > 0 ? ret : 0; > + > + /* This function does not return negative numbers, except when they get created through > + * an integer overflow. */ > + if (diff_sec > ((LONGLONG)INT_MAX + NANOSEC_PER_MILLISEC - 1) / NANOSEC_PER_MILLISEC) > + return ret; > + else > + return ret > 0 ? ret : 0; > } It looks like the function should be treating negative time differences in special way. Except of that it seems to be ignoring overflows. I think that following code is much easier to read. Is something like this working for you? MSVCRT_long __cdecl _Xtime_diff_to_millis2(const xtime *t1, const xtime *t2) { LONGLONG diff_sec, diff_nsec; TRACE("(%p, %p)\n", t1, t2); diff_sec = t1->sec - t2->sec; diff_nsec = t1->nsec - t2->nsec; diff_sec += diff_nsec / NANOSEC_PER_SEC; diff_nsec %= NANOSEC_PER_SEC; if (diff_nsec < 0) { diff_sec -= 1; diff_nsec += NANOSEC_PER_SEC; } if (diff_sec<0 || (diff_sec==0 && diff_nsec<0)) return 0; return diff_sec * MILLISEC_PER_SEC + (diff_nsec + NANOSEC_PER_MILLISEC - 1) / NANOSEC_PER_MILLISEC; } Thanks, Piotr

2 4

Re: [PATCH] ntdll: Always restore TEB to x18 on aarch 64 on return from calls to builtins
by Stefan Dösinger Oct. 17, 2017

Oct. 17, 2017

Am 2017-10-13 um 09:52 schrieb Martin Storsjo: > This requires always enabling relaying of calls though. It also won't work for COM object calls, which aren't intercepted by +relay.

1 0

Re: [PATCH 1/2] mshtml: Use window event target instead of body only for selected event properties.
by Marvin Oct. 17, 2017

Oct. 17, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33544 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH] Revert "user32/combo: Set listbox popup height correctly and add tests."
by Marvin Oct. 16, 2017

Oct. 16, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33545 Your paranoid android. === build (build) === The test VM is powered off!

1 0

Re: [PATCH] winex11.drv: Fix misplaced parentheses.
by Alexandre Julliard Oct. 16, 2017

Oct. 16, 2017

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/winex11.drv/mouse.c | 2 +- > dlls/winex11.drv/systray.c | 2 +- > dlls/winex11.drv/window.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Not that it makes much difference, but the existing code is correct. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] regedit: Correctly import hex values with no data
by Marvin Oct. 16, 2017

Oct. 16, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33540 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH] reg/tests: Correctly import hex values with no data
by Marvin Oct. 16, 2017

Oct. 16, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33541 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.
by Alexandre Julliard Oct. 16, 2017

Oct. 16, 2017

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -2,8 +2,8 @@ MODULE = secur32.dll > IMPORTLIB = secur32 > IMPORTS = netapi32 advapi32 > DELAYIMPORTS = crypt32 > -EXTRAINCL = $(GNUTLS_CFLAGS) > -EXTRALIBS = $(SECURITY_LIBS) > +EXTRAINCL = $(GNUTLS_CFLAGS) $(GSSAPI_CFLAGS) > +EXTRALIBS = $(SECURITY_LIBS) $(GSSAPI_LIBS) Shouldn't the library be loaded dynamically? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: secur32/tests: Add tests for the Kerberos provider.
by Marvin Oct. 16, 2017

Oct. 16, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33537 Your paranoid android. === wxppro (32 bit kerberos) === kerberos.c:361: Test failed: got 00073bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 80090311 === w2003std (32 bit kerberos) === kerberos.c:361: Test failed: got 00073bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === wvistau64 (32 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w2008s64 (32 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w7u (32 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w7pro64 (32 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w8 (32 bit kerberos) === kerberos.c:361: Test failed: got 008f3bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w864 (32 bit kerberos) === kerberos.c:361: Test failed: got 008f3bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w1064 (32 bit kerberos) === kerberos.c:361: Test failed: got 008f3bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === wvistau64 (64 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w2008s64 (64 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w7pro64 (64 bit kerberos) === kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w864 (64 bit kerberos) === kerberos.c:361: Test failed: got 008f3bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e === w1064 (64 bit kerberos) === kerberos.c:361: Test failed: got 008f3bbf kerberos.c:149: Test failed: AcquireCredentialsHandleA returned 8009030e

1 0

Re: [PATCH] comctl32/tests: Fix treeview test failures on French Windows XP.
by Nikolay Sivov Oct. 16, 2017

Oct. 16, 2017

On 16.10.2017 6:33, Alex Henrie wrote: > The one testbot machine that's having trouble with these is the one XP > machine with a French locale: > http://test.winehq.org/data/de7220e2553764afd5cf8d463110d4ec5b1a6696/index_… > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/comctl32/tests/treeview.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index e7ce92cae8..26ba160c60 100644 > --- a/dlls/comctl32/tests/treeview.c > +++ b/dlls/comctl32/tests/treeview.c > @@ -220,6 +220,10 @@ static const struct message test_right_click_seq[] = { > { WM_RBUTTONDOWN, sent|wparam, MK_RBUTTON }, > { WM_CAPTURECHANGED, sent|defwinproc }, > { TVM_GETNEXTITEM, sent|wparam|lparam|defwinproc, TVGN_CARET, 0 }, > + /* the optional messages below are for French WinXP */ > + { WM_NCHITTEST, sent|optional }, > + { WM_SETCURSOR, sent|optional }, > + { WM_MOUSEFIRST, sent|optional }, > { 0 } > }; > > @@ -367,6 +371,9 @@ static const struct message parent_vk_return_seq[] = { > static const struct message parent_right_click_seq[] = { > { WM_NOTIFY, sent|id, 0, 0, NM_RCLICK }, > { WM_CONTEXTMENU, sent }, > + /* the optional messages below are for French WinXP */ > + { WM_NOTIFY, sent|optional }, > + { WM_SETCURSOR, sent|optional }, > { 0 } > }; > If it works, that's great, but comment makes no sense. I find it hard to believe UI language affects messages sent to windows, must be something else. Please resend without it.

1 0

Re: [v3 PATCH 2/3] gdiplus/metafile: Partially implement EmfPlusImage deserialization
by Nikolay Sivov Oct. 14, 2017

Oct. 14, 2017

On 13.10.2017 19:45, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > > v3: fail on indexed formats for now > > dlls/gdiplus/gdiplus_private.h | 1 + > dlls/gdiplus/metafile.c | 82 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 83 insertions(+) > Ignore that one please. Indexed case is trivial enough, I'll send complete version instead.

1 0

Re: [PATCH 1/2] dx8vb: Add D3DX8 coclass plus ID3DX8 interface and its dependencies
by Nikolay Sivov Oct. 14, 2017

Oct. 14, 2017

How exactly this is supposed to work? When you mentioned such dx8-vb style wrappers exist I thought about usual scripting way to create and access them, yet your idls don't define a type library and interface wrappers are not IDispatch descendants. Normal way is to create factory object using ProgID for example, in this case DXD8, and then all method are requested using IDispatch. Also, is it possible to reuse actual dx8 headers for enums and the like ? P.S. for enum members please use hex notation for fourcc values, and FORCE_DWORD things.

2 1

Regression bug in 2.18: Endless Legend broken
by Walter Woods Oct. 14, 2017

Oct. 14, 2017

Hi all, I'm posting to this list as a result of the instructions on the "AppDB Maintainers" page. Anyway, Endless Legend (https://appdb.winehq.org/objectManager.php?sClass= application&iId=16492) was broken somewhere between 2.17-staging and 2.18-staging. While the initial credits videos load alright, the game's own loading splashscreen (for the Tempest expansion) crashes without fail. If I run Wine 2.18-staging in a terminal, the error messages look like this: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #11: fixme:d3d_shader:print_glsl_info_log Vertex info fixme:d3d_shader:print_glsl_info_log ----------- fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[0].zw" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[1].zw" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[2]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[3]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[4]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[5]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[6]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[7]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[9]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[11]" might be used before being initialized err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols err:seh:setup_exception stack overflow 1600 bytes in thread 0096 eip 000000007bc62c85 esp 00000000053e0fd0 stack 0x53e0000-0x53e1000-0x54e0000 fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000003-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000003-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000019-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_BeginList 0x5385410 (0x1284e52c {92ca9dcd-5622-4bba-a805-5e9f541bd8c9} 0x1284e538): stub fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000003-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000003-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_QueryInterface not implemented for {00000019-0000-0000-c000-000000000046} (unknown) fixme:shell:CustomDestinationList_BeginList 0x5384490 (0x12a4e52c {92ca9dcd-5622-4bba-a805-5e9f541bd8c9} 0x12a4e538): stub If I run Wine 2.17-staging in a terminal, then I get only the following: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #263: fixme:d3d_shader:print_glsl_info_log Vertex info fixme:d3d_shader:print_glsl_info_log ----------- fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[2].zw" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[3].zw" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[5]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[6]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[7]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[8]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[9]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[10]" might be used before being initialized fixme:d3d_shader:print_glsl_info_log 0(19) : warning C7050: "vs_out[11]" might be used before being initialized So, it seems safe to assume that something in 2.18 causes all of those page faults. Cheers, Walt

2 1

Re: [PATCH] msvcrt: Add vf[w]printf_p & vf[w]printf_p_l.
by Piotr Caban Oct. 13, 2017

Oct. 13, 2017

Hi Gijs, I think support for MSVCRT_PRINTF_POSITIONAL_PARAMS flag may be integrated into helper. Thanks to it you will be able to implement vfprintf_p without changing all helper callers. I'm thinking about something like this: static int vfprintf_helper(DWORD options, MSVCRT_FILE* file, const char *format, MSVCRT__locale_t locale, __ms_va_list valist) { printf_arg args_ctx[MSVCRT__ARGMAX+1]; BOOL tmp_buf; int ret; if(!MSVCRT_CHECK_PMT( file != NULL )) return -1; if(!MSVCRT_CHECK_PMT( format != NULL )) return -1; if(options & MSVCRT_PRINTF_POSITIONAL_PARAMS) { memset(args_ctx, 0, sizeof(args_ctx)); ret = create_positional_ctx_a(args_ctx, format, valist); if(ret < 0) { MSVCRT__invalid_parameter(NULL, NULL, NULL, 0, 0); *MSVCRT__errno() = MSVCRT_EINVAL; return ret; } else if(!ret) otions &= ~MSVCRT_PRINTF_POSITIONAL_PARAMS; } MSVCRT__lock_file(file); tmp_buf = add_std_buffer(file); ret = pf_printf_a(puts_clbk_file_a, file, format, locale, options, options & MSVCRT_PRINTF_POSITIONAL_PARAMS ? arg_clbk_positional : arg_clbk_valist, options & MSVCRT_PRINTF_POSITIONAL_PARAMS ? args_ctx : NULL, &valist); if(tmp_buf) remove_std_buffer(file); MSVCRT__unlock_file(file); return ret; } Thanks, Piotr

2 1

Re: [PATCH] msi: Defer the appropriate standard actions to the install script.
by Hans Leidekker Oct. 13, 2017

Oct. 13, 2017

I get test failures: automation.c:2545: Test failed: Expected ERROR_SUCCESS, got 2 automation.c:2550: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2551: Test failed: Expected imaname, got H�2 automation.c:2556: Test failed: Expected ERROR_FILE_NOT_FOUND, got 6 automation.c:2561: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2562: Test failed: Expected 314, got 0 automation.c:2567: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2568: Test failed: Expected imaname, got H�2 automation.c:2573: Test failed: Expected ERROR_SUCCESS, got 2 Makefile:227: recipe for target 'automation.ok' failed make: *** [automation.ok] Error 9 This is the kind of patch that could use lots of tests, though it looks like you are working on it ;-) It would also be a good idea to check a few real installers, such as those for .NET and Office, if you haven't done so already.

2 1

Re: [v2 PATCH 2/3] gdiplus/metafile: Implement EmfPlusImage deserialization ImageDataTypeBitmap image type
by Vincent Povirk Oct. 13, 2017

Oct. 13, 2017

We should have a FIXME for indexed color formats.

2 2

Re: [PATCH 2/4] msvcp90: Call exception ctor in logic_error and runtime_error ctor.
by Piotr Caban Oct. 13, 2017

Oct. 13, 2017

Hi Daniel, this patch doesn't look right. The runtime_error class is supposed to override "what" virtual function. I'm attaching a simple test case that shows that name field should not be set to passed string (at least in msvcp60). Thanks, Piotr

2 2

Exported functions in tests
by Zebediah Figura Oct. 13, 2017

Oct. 13, 2017

Hello all, I was working on a test for MSI type 1 custom actions, i.e. functions exported from a given DLL and called by the install script. I've tested both with an independent file and in the Wine test environment, and I've found that I can successfully export functions from the executable itself with DECLSPEC_EXPORT, and MSI will successfully execute the function, as the attached patch demonstrates. The function returns ERROR_SUCCESS, and changing this to other values gets reflected in the install's error code appropriately. However, as soon as I add a function call to the custom action, the install fails with ERROR_INSTALL_FAILURE, and the function is never called—making it look, in all probability, like a page fault occurred. This is the case when compiling with mingw-w64, both inside the Wine test environment and in an independent file. Notably I have no trouble calling DLLs taken from real MSI packages in this way. I also have no trouble calling the function if I use GetModuleHandle() and GetProcAddress() directly, nor do I run into any trouble whatsoever running the custom action on Linux. It is specifically this environment—running this function as part of a custom action, on Windows. Does anyone know, or have a hunch, as to what the problem might be here? For what it's worth, it's known that native MSI uses a separate process to execute custom actions, although I don't know how this would lend any clue to what's going wrong. --Zeb

3 5

Re: [PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.
by Piotr Caban Oct. 13, 2017

Oct. 13, 2017

Hi Daniel, why do you need it? The class should be not used/exported in msvcirt. Thanks, Piotr

2 4

Re: [PATCH] server_ioctl_file() - Prefix printed hex values with '0x'
by Alexandre Julliard Oct. 12, 2017

Oct. 12, 2017

Chris Morgan <chmorgan(a)gmail.com> writes: > Avoids the ambiguity with non-alphanumeric hex values. > > Signed-off-by: Chris Morgan <chmorgan(a)gmail.com> > --- > dlls/ntdll/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index fd7f3dd..4d081b7 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -1567,7 +1567,7 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > SERVER_END_REQ; > > if (status == STATUS_NOT_SUPPORTED) > - FIXME("Unsupported ioctl %x (device=%x access=%x func=%x method=%x)\n", > + FIXME("Unsupported ioctl 0x%x (device=0x%x access=0x%x func=0x%x method=0x%x)\n", That's mostly a matter of taste, so I don't think it's necessary to change it. -- Alexandre Julliard julliard(a)winehq.org

3 2

fvwm d3d test failures
by Stefan Dösinger Oct. 12, 2017

Oct. 12, 2017

Hi Alexandre, Since I currently have my head wrapped around the d3d message tests I'd like to give your fvwm2 test failures another try. Can you send me the test failures you currently see? Here I see one failure mostly reliably (~90% of all runs) with fvwm2 in focus follows mouse mode. I think the particular test is not too important, so we can disable it, but I'd like to verify first that it is the same issue you have. Cheers, Stefan

3 3

Re: [PATCH 1/4] wined3d: Show the device window when changing fullscreen resolutions.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33502 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:3029: Test failed: Received WM_WINDOWPOSCHANGED but did not expect it, i=0.

2 1

Re: [PATCH 2/4] d3d8/tests: Test mode change messages.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33503 Your paranoid android. === w1064 (32 bit device) === device.c:1532: Test failed: Reset failed, hr 0x80070057. device.c:1534: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1546: Test failed: D3DVIEWPORT->Width = 400. device.c:1547: Test failed: D3DVIEWPORT->Height = 300. 0c08:device: unhandled exception c0000005 at 706FA86E

2 1

Re: [PATCH 3/4] gdiplus/metafile: Implement EmfPlusImage deserialization for ImageDataTypeBitmap image type
by Vincent Povirk Oct. 12, 2017

Oct. 12, 2017

We'll need a way to reuse this when deserializing texture brushes.

1 0

Re: [PATCH 2/4] gdiplus/metafile: Support solid brushes in EmfPlusRecordTypeObject record playback
by Vincent Povirk Oct. 12, 2017

Oct. 12, 2017

We'll need a way to reuse this when deserializing pen objects.

1 0

Re: [PATCH 3/3] mshtml/tests: Added script event argument test.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33498 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 2/3] mshtml/tests: Use winetest.js in events.html.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33497 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath === wvistau64 (64 bit events) === events.c:1006: Test failed: unexpected call img_onerror

1 0

Re: [1/2] twain_32: Add debug traces to TWAIN_UserSelect.
by Alistair Leslie-Hughes Oct. 11, 2017

Oct. 11, 2017

Hi Vincent, On 10/10/17 07:57, Vincent Povirk wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> > --- > dlls/twain_32/dsm_ctrl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/twain_32/dsm_ctrl.c b/dlls/twain_32/dsm_ctrl.c > index b71c112..54bd9fa 100644 > --- a/dlls/twain_32/dsm_ctrl.c > +++ b/dlls/twain_32/dsm_ctrl.c > @@ -263,12 +263,17 @@ TW_UINT16 TWAIN_UserSelect (pTW_IDENTITY pOrigin, TW_MEMREF pData) > { > pTW_IDENTITY selected = (pTW_IDENTITY)pData; > > + TRACE("DG_CONTROL/DAT_IDENTITY/MSG_USERSELECT SupportedGroups=0x%x ProductName=%s\n", > + selected->SupportedGroups, wine_dbgstr_a(selected->ProductName)); > + This patch makes the indentation of this function hard to read. Would it be better to just reformat this function to be like the reset of the file. Best Regards Alistair.

3 4

Please change WINE logo
by Farhad Mohammadi Majd Oct. 11, 2017

Oct. 11, 2017

Hello, the current WINE logo is really ugly in highest level! and has no concept, please change it with better one, I have a good sample: https://commons.wikimedia.org/wiki/File:Wine_bw.png It is really beautiful and Window$ logo shows its relationship with M$ Windows, I hope this logo is legal. .

7 17

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov Oct. 11, 2017

Oct. 11, 2017

On 11.10.2017 14:46, Vadim Druzhin wrote: > > >> Среда, 11 октября 2017, 12:53 +03:00 от Nikolay Sivov <nsivov(a)codeweavers.com>: >> >> On 10/11/2017 10:11 AM, Vadim Druzhin wrote: >> >>> Calculate approximated window size >>> when control does not have real items. >>> >>> Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) >>> >>> Signed-off-by: Vadim Druzhin < cdslow(a)mail.ru > >>> --- >>> dlls/comctl32/listview.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c >>> index 8114222 ..7e33f7c 100644 >>> --- a/dlls/comctl32/listview.c >>> +++ b/dlls/comctl32/listview.c >>> @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte >>> wWidth = rcBox.right - rcBox.left; >>> wHeight = (rcBox.bottom - rcBox.top) * nItemCount; >>> } >>> + else if (nItemCount > 0) >>> + { >>> + /* No real items, use approximation */ >>> + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); >>> + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; >>> + wWidth = infoPtr->nItemWidth; >>> + } >> Hi, Vadim. >> >> This doesn't look right. nItemCount less than -1 or 0 is acceptable too, >> only -1 has special meaning. Please add some tests to >> ./tests/listview.c:test_approximate_viewrect() first. Currently we only >> have some tests, and not that many, for LVS_ICON style. >>> else >>> { >>> /* use current height and width */ >>> -- >>> 2.5.5 >>> >> > For case with nItemCount less than -1 or 0 will be executed old code from else branch (return current window size). > Behavior changed only when nItemCount > 0 but infoPtr->nItemCount <= 0. Yes, my point is that limiting your new code to nItemCount > 0 does not look right. Anyway, like I said it need some tests first.

1 0

Re: [PATCH] mshtml: Added IDocumentEvent stub implementation.
by Marvin Oct. 11, 2017

Oct. 11, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33484 Your paranoid android. === wxppro (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 0a30:events: unhandled exception c0000005 at 0042E8B7 === w2003std (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 05f0:events: unhandled exception c0000005 at 0042E8B7

1 0

Re: [resend 1/2] comctl32: Preserve title when creating ListView window.
by Nikolay Sivov Oct. 11, 2017

Oct. 11, 2017

On 10/11/2017 10:10 AM, Vadim Druzhin wrote: > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 73eceff..8114222 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -9532,6 +9532,10 @@ static LRESULT LISTVIEW_NCCreate(HWND hwnd, const CREATESTRUCTW *lpcs) > if (!(infoPtr->hdpaPosX = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaPosY = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaColumns = DPA_Create(10))) goto fail; > + > + /* Preserve window title */ > + DefWindowProcW(hwnd, WM_SETTEXT, 0, (LPARAM)(lpcs->lpszName)); > + > return TRUE; This is fixed in git now, see https://source.winehq.org/git/wine.git/commit/ee7ddd1ed38a3b2f41bdb676f42e3…, so no need to resend. > fail: > -- > 2.5.5 >

1 0

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov Oct. 11, 2017

Oct. 11, 2017

On 10/11/2017 10:11 AM, Vadim Druzhin wrote: > Calculate approximated window size > when control does not have real items. > > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 8114222..7e33f7c 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte > wWidth = rcBox.right - rcBox.left; > wHeight = (rcBox.bottom - rcBox.top) * nItemCount; > } > + else if (nItemCount > 0) > + { > + /* No real items, use approximation */ > + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); > + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; > + wWidth = infoPtr->nItemWidth; > + } Hi, Vadim. This doesn't look right. nItemCount less than -1 or 0 is acceptable too, only -1 has special meaning. Please add some tests to ./tests/listview.c:test_approximate_viewrect() first. Currently we only have some tests, and not that many, for LVS_ICON style. > else > { > /* use current height and width */ > -- > 2.5.5 >

1 0

Re: [v2 PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Vincent Povirk Oct. 10, 2017

Oct. 10, 2017

Maybe instead of removing the check completely, we could provide a mask of bits to ignore, or an alternative accepted value?

2 1

Re: [PATCH] ws2_32/tests: Fix compilation warning
by Alexandre Julliard Oct. 10, 2017

Oct. 10, 2017

Fabian Maurer <dark.shadow4(a)web.de> writes: > Without that change, gcc gives the warning > "include/winsock.h:480:37: ‘readfds.fd_array[__i]’ > may be used uninitialized in this function" It looks initialized to me. What gcc version is that? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Marvin Oct. 10, 2017

Oct. 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33463 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2003std (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1.

1 0

Wine Swag Sticker Poll
by Aric Stewart Oct. 10, 2017

Oct. 10, 2017

Hello! So all the way back at wineconf I volunteered to be swag master for winehq. The idea is to have something that can be given away at trade shows, presentations, LUG visits and the like. Just something to help promote the visibility of the project. Jana here, CodeWeavers marketing director, has put together a sampling of designs to do as our first sticker and so now we are looking for some feedback on what people prefer. https://docs.google.com/forms/d/e/1FAIpQLSd5X_fXe9KSFAppRHz8kUo3XKeODyH5KeX… Rosanne? Could you direct me as to where this should be put up for the users as well? I am unfamiliar with how to communicate to our user base. The poll will run for as long as it feels like it needs to get some sort of winner. Comments and suggestions are always welcome! -aric

7 10

Re: [PATCH 1/2] msvcrt: Add vf[w]printf_s_l
by Piotr Caban Oct. 10, 2017

Oct. 10, 2017

It causes compilation warnings: ../../../wine_src/dlls/msvcr110/../msvcrt/file.c: In function 'MSVCRT_vfprintf_s': ../../../wine_src/dlls/msvcr110/../msvcrt/file.c:5100:12: warning: implicit declaration of function 'MSVCRT__vfprintf_s_l' [-Wimplicit-function-declaration] Thanks, Piotr

1 0

Re: [PATCH 2/2] msvcrt: Change forward for consistency.
by Piotr Caban Oct. 10, 2017

Oct. 10, 2017

On 10/09/17 12:23, Gijs Vermeulen wrote: > @@ -5320,7 +5320,7 @@ int CDECL MSVCRT_printf_s(const char *format, ...) > __ms_va_list valist; > int res; > __ms_va_start(valist, format); > - res = MSVCRT_vprintf_s(format, valist); > + res = MSVCRT_vfprintf_s(MSVCRT_stdout, format, valist); I don't think this code needs to be changed. It's just a matter of taste so I would leave it as is. Thanks, Piotr

1 0

wine-2.0.3-rc1 Available
by Michael Stefaniuc Oct. 10, 2017

Oct. 10, 2017

Hello guys, I have pushed wine-2.0.3-rc1 (with tag) to https://github.com/mstefani/wine-stable http://static-winehq.193b.starter-ca-central-1.openshiftapps.com/stable/ This version has only 63 commits and only 38 bugs fixed. The summer was kinda low on bug fixes. So I have picked some small fixes too that had no bugzilla entry. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes - FreeType 2.8.1 compatibility fixes ---------------------------------------------------------------- Bugs fixed in 2.0.3 (total 38): 11433 unimplemented function ole32.dll.OleGetIconOfFile 16948 tmpfile() fails when run from Unix path 24723 Lost Horizon crash/page fault during Chapter 2 26388 Sound Recorder crashes on encoding PCM Sample 32563 Purebasic does not display icons in toolbar which is drawn distorted. 33740 Sound Recorder displays error when seeking MP3 stream to the end 35529 Uninstaller: application list doesn't fit 38328 WPS 2013 (Kingsoft) crash at install 38980 World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports) 40919 Worms Armageddon Gameplay only shows top-left corner of screen 41489 notepad++ escape key 42080 Listview does not draw correctly in some conditions. 42140 "Unrecognized stencil op 0" messages flooding system log in Söldner Secret Wars 42656 ACDSee Pro 10 needs msvcp140.dll.?_Schedule_chore(a)details@Concurrency@@YAHPEAU_Threadpool_chore(a)12@@Z 42708 Soul Reaver GOG Cinematics stopped working 42754 Seed of Andromeda Pre-Alpha 0.2 crashes 42910 Scrabble (Infogrames) multiplayer requires IDirectPlay4::EnumConnections 42940 WAtomic: White labels that show name of elements hidden by GL components 43005 secur32/tests/ntlm.ok crashes in DeleteSecurityContext 43020 Guitar Pro 7 needs msvcp140.dll._To_wide 43026 SP+ maker won't run. 43039 Rise of the Tomb Raider needs unimplemented function USER32.dll.PhysicalToLogicalPoint 43097 WarBR: game (WarS v5.5 p4) crashes on start, needs WMP IOleObject::GetExtent method implementation 43157 Adobe Premiere needs ntoskrnl.exe.KeAcquireSpinLockRaiseToDpc 43216 winhttp fails to redirect from http to https on 301 error. 43220 Adobe Premiere needs ntoskrnl.exe.KeReleaseSpinLock 43268 Wargaming.net Game Center needs msvcp140.dll._To_byte 43283 Crazyracing KartRider: Crashes on startup on unimplemented function ntoskrnl.exe.IoCreateNotificationEvent 43295 BitLord crashes on unimplemented function IPHLPAPI.DLL.if_nametoindex 43303 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.acosh 43304 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.atanh 43305 numpy crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.log1p 43334 winealsa.drv: Warning while building (GCC 7.1.1) 43369 Nora, Princess and Stray cat (demo): fails to run (division by zero) 43392 valgrind shows a couple invalid reads in programs/regedit/tests/regedit.c 43403 make error on Debian 4.9.30-2kali1 (2017-06-22) x86_64 GNU/Linux 43715 Many applications (winecfg, ...) crash on startup with freetype 2.8.1 43716 freetype 2.8.1 breaks Wine build during font conversion with sfnt2fon ---------------------------------------------------------------- Changes since 2.0.2: Akihiro Sagawa (2): oleaut32: Fix parse error when converting non-ascii string to VT_DATE. gdi32: Return non-zero VREFRESH value for display devices. Alex Henrie (5): comctl32/listview: When adding a scrollbar, update the other one. msvcr120: Add acosh. msvcr120: Add atanh. msvcr120: Add expm1. msvcr120: Add log1p. Alexandre Julliard (1): user32: Always update the visible region for cross-process DCEs. Alistair Leslie-Hughes (2): dplayx: Implement IDirectPlay4 EnumConnections. dmime: Support more interfaces in IDirectMusicAudioPath.GetObjectInPath. Andrey Gusev (1): winealsa.drv: Fix uninitialized variable warning. André Hentschel (2): wpcap: Fix build with newer pcap versions. oleview: Fix bytecount for memmoves (Coverity). Austin English (4): user32: Add LogicalToPhysicalPoint/PhysicalToLogicalPoint stubs. ntoskrnl.exe: Add KeReleaseSpinLock stub. ntoskrnl: Add KeAcquireSpinLockRaiseToDpc stub. ntoskrnl.exe: Add IoCreateNotificationEvent stub. Daniel Lehman (1): mshtml: Decrement refcount in nsWeakReference::Release (Valgrind). Dmitry Timoshkov (3): oleaut32: Add an arguments check to LoadTypeLibEx. user.exe16: Fix memory leak in case when HeapReAlloc fails. dsound: Fix a memory leak. Fabian Maurer (1): user32: Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests. Hans Leidekker (4): winhttp: Reset content length when a redirect creates a new connection. wbemprox: Also free data for tables that don't have a fill function (Valgrind). advpack: Don't trace the contents of an output buffer (Valgrind). msi: Avoid zero size allocations (Valgrind). Henri Verbeet (4): ddraw/tests: Introduce a helper function to create windows. ddraw/tests: Add a test for the alpha and z-buffer blit flags. ddraw: Ignore unsupported blit flags. wined3d: Only warn about 0 stencil ops in gl_stencil_op(). Hugh McMaster (2): regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind). uninstaller: Pass RegQueryValueExW() the size of the buffer (Coverity). Huw D. M. Davies (2): shell32: Remove an extraneous '@'. user32: Explicitly set last error to ERROR_SUCCESS. Jacek Caban (1): wmp: Added IOleObject::GetExtent and SetExtent implementation. Józef Kucia (1): user32: Fix memory leak in WinHelpA(). Ken Thomases (2): winemac: Track whether a view has ever had an OpenGL context attached. gdiplus: Avoid infinite recursion in flatten_bezier(). Marcus Meissner (2): msvcrt: Free the temporary filename (Coverity). gameux: Avoid freeing uninitialized interfaces (Coverity). Michael Müller (1): include: Fix an invalid UUID in dxva2api.idl. Michael Stefaniuc (2): tools/sfnt2fon: Just skip all glyphs below 0x20. fonts: Increase the Em size to fix a build failure with freetype 2.8.1. Mikhail Paulyshka (1): msvcp140: Implement _To_byte. Nikolay Sivov (6): comctl32/toolbar: Fix TB_SETDRAWTEXTFLAGS handler. comctl32/toolbar: Don't add NULL imagelist entries. comctl32/toolbar: Support undocumented IDs for standard bitmap lists. gdi32: Pick first charmap if none was selected using preferred encoding. include: Fix IShellFolderView method macros. shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser. Piotr Caban (4): msvcrt: Use temp directory when creating file in tmpfile. msvcp140: Add _ContextCallback tests. msvcp140/tests: Add _TaskEventLogger tests. msvcp140: Add {_Schedule,_Reschedule,_Release}_chore implementation. Sebastian Lackner (1): ntoskrnl.exe: Add KeReleaseInStackQueuedSpinLock stub. Stefan Dösinger (3): ws2_32: Don't post completion packet if receiving fails with error immediately. iphlpapi: Implement if_nametoindex. msvcp140: Implement _To_wide. Zebediah Figura (4): secur32/tests: Zero-initialize contexts. msacm32: Don't write cbSize if the format is WAVE_FORMAT_PCM. winemp3.acm: Fix error in acmStreamSize(). msacm32: Rewrite PCM conversion functions. Zhenbo Li (1): ole32: Add stub for OleGetIconOfFile. -- Michael Stefaniuc mstefani(a)winehq.org

1 0