October 2017 - Wine-Devel - list.winehq.org

fvwm d3d test failures
by Stefan Dösinger Oct. 12, 2017

Oct. 12, 2017

Hi Alexandre, Since I currently have my head wrapped around the d3d message tests I'd like to give your fvwm2 test failures another try. Can you send me the test failures you currently see? Here I see one failure mostly reliably (~90% of all runs) with fvwm2 in focus follows mouse mode. I think the particular test is not too important, so we can disable it, but I'd like to verify first that it is the same issue you have. Cheers, Stefan

3 3

Re: [PATCH 1/4] wined3d: Show the device window when changing fullscreen resolutions.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33502 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:3029: Test failed: Received WM_WINDOWPOSCHANGED but did not expect it, i=0.

2 1

Re: [PATCH 2/4] d3d8/tests: Test mode change messages.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33503 Your paranoid android. === w1064 (32 bit device) === device.c:1532: Test failed: Reset failed, hr 0x80070057. device.c:1534: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1546: Test failed: D3DVIEWPORT->Width = 400. device.c:1547: Test failed: D3DVIEWPORT->Height = 300. 0c08:device: unhandled exception c0000005 at 706FA86E

2 1

Re: [PATCH 3/4] gdiplus/metafile: Implement EmfPlusImage deserialization for ImageDataTypeBitmap image type
by Vincent Povirk Oct. 12, 2017

Oct. 12, 2017

We'll need a way to reuse this when deserializing texture brushes.

1 0

Re: [PATCH 2/4] gdiplus/metafile: Support solid brushes in EmfPlusRecordTypeObject record playback
by Vincent Povirk Oct. 12, 2017

Oct. 12, 2017

We'll need a way to reuse this when deserializing pen objects.

1 0

Re: [PATCH 3/3] mshtml/tests: Added script event argument test.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33498 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 2/3] mshtml/tests: Use winetest.js in events.html.
by Marvin Oct. 12, 2017

Oct. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33497 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath === wvistau64 (64 bit events) === events.c:1006: Test failed: unexpected call img_onerror

1 0

Re: [1/2] twain_32: Add debug traces to TWAIN_UserSelect.
by Alistair Leslie-Hughes Oct. 11, 2017

Oct. 11, 2017

Hi Vincent, On 10/10/17 07:57, Vincent Povirk wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> > --- > dlls/twain_32/dsm_ctrl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/twain_32/dsm_ctrl.c b/dlls/twain_32/dsm_ctrl.c > index b71c112..54bd9fa 100644 > --- a/dlls/twain_32/dsm_ctrl.c > +++ b/dlls/twain_32/dsm_ctrl.c > @@ -263,12 +263,17 @@ TW_UINT16 TWAIN_UserSelect (pTW_IDENTITY pOrigin, TW_MEMREF pData) > { > pTW_IDENTITY selected = (pTW_IDENTITY)pData; > > + TRACE("DG_CONTROL/DAT_IDENTITY/MSG_USERSELECT SupportedGroups=0x%x ProductName=%s\n", > + selected->SupportedGroups, wine_dbgstr_a(selected->ProductName)); > + This patch makes the indentation of this function hard to read. Would it be better to just reformat this function to be like the reset of the file. Best Regards Alistair.

3 4

Please change WINE logo
by Farhad Mohammadi Majd Oct. 11, 2017

Oct. 11, 2017

Hello, the current WINE logo is really ugly in highest level! and has no concept, please change it with better one, I have a good sample: https://commons.wikimedia.org/wiki/File:Wine_bw.png It is really beautiful and Window$ logo shows its relationship with M$ Windows, I hope this logo is legal. .

7 17

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov Oct. 11, 2017

Oct. 11, 2017

On 11.10.2017 14:46, Vadim Druzhin wrote: > > >> Среда, 11 октября 2017, 12:53 +03:00 от Nikolay Sivov <nsivov(a)codeweavers.com>: >> >> On 10/11/2017 10:11 AM, Vadim Druzhin wrote: >> >>> Calculate approximated window size >>> when control does not have real items. >>> >>> Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) >>> >>> Signed-off-by: Vadim Druzhin < cdslow(a)mail.ru > >>> --- >>> dlls/comctl32/listview.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c >>> index 8114222 ..7e33f7c 100644 >>> --- a/dlls/comctl32/listview.c >>> +++ b/dlls/comctl32/listview.c >>> @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte >>> wWidth = rcBox.right - rcBox.left; >>> wHeight = (rcBox.bottom - rcBox.top) * nItemCount; >>> } >>> + else if (nItemCount > 0) >>> + { >>> + /* No real items, use approximation */ >>> + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); >>> + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; >>> + wWidth = infoPtr->nItemWidth; >>> + } >> Hi, Vadim. >> >> This doesn't look right. nItemCount less than -1 or 0 is acceptable too, >> only -1 has special meaning. Please add some tests to >> ./tests/listview.c:test_approximate_viewrect() first. Currently we only >> have some tests, and not that many, for LVS_ICON style. >>> else >>> { >>> /* use current height and width */ >>> -- >>> 2.5.5 >>> >> > For case with nItemCount less than -1 or 0 will be executed old code from else branch (return current window size). > Behavior changed only when nItemCount > 0 but infoPtr->nItemCount <= 0. Yes, my point is that limiting your new code to nItemCount > 0 does not look right. Anyway, like I said it need some tests first.

1 0