February 2017 - Wine-Devel - list.winehq.org

Re: [2/2] iphlpapi/tests: Add tests for GetUnicastIpAddressEntry
by Marvin Feb. 2, 2017

Feb. 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28247 Your paranoid android. === build (build) === Make failed

1 0

Re: [v3 4/6] user32: Add WM_NCPAINT tests for windows crossing screen or maximized
by Marvin Feb. 2, 2017

Feb. 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28244 Your paranoid android. === wxppro (32 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === wvistau64 (32 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7u (32 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7pro64 (32 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === wvistau64 (64 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7pro64 (64 bit msg) === msg.c:5216: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085

1 0

Re: [v3 3/6] user32: Add tests for windows when first shown if they have children
by Marvin Feb. 2, 2017

Feb. 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28243 Your paranoid android. === wxppro (32 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === wvistau64 (32 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7u (32 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7pro64 (32 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === wvistau64 (64 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085 === w7pro64 (64 bit msg) === msg.c:5141: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg sequence is not complete: expected 0000 - actual 0085

1 0

Re: winex11: Remove dead assignment (clang)
by Aric Stewart Feb. 2, 2017

Feb. 2, 2017

Are you sure that is dead? clang must be saying so but the assignment of ximStyleCallback to ximStyle seems meaningful. Just above this code we have code that ensures that ximStyle is not 0, so if ximStyleCallback == 0 then assigning ximStyleCallback = ximStyle does not seem dead to me. -aric > From: André Hentschel <nerv(a)dawncrow.de> > Subject: winex11: Remove dead assignment (clang) > Message-Id: <8472d171-8b3b-04a7-62cf-a99ee7a37026(a)dawncrow.de> > Date: Mon, 30 Jan 2017 23:11:02 +0100 > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/winex11.drv/xim.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c > index e51169d..3978bca 100644 > --- a/dlls/winex11.drv/xim.c > +++ b/dlls/winex11.drv/xim.c > @@ -416,10 +416,7 @@ static BOOL open_xim( Display *display ) > ximStyle = ximStyleNone; > > if (ximStyleCallback == 0) > - { > TRACE("No callback style available\n"); > - ximStyleCallback = ximStyle; > - } > > } > > > -- > 2.7.4

4 5

Re: [PATCH 1/2] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Alexandre Julliard Feb. 2, 2017

Feb. 2, 2017

Fabian Maurer <dark.shadow4(a)web.de> writes: > Fixes Bug 2624 and 6682 and a few others > > v2: Make patch independent from the WM_NCPAINT issue > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/user32/tests/msg.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/user32/winpos.c | 7 ++++ > 2 files changed, 111 insertions(+) This would also need tests for child windows, and for various flag combinations. In particular I expect you'd have to handle SWP_DEFERERASE. It would also be more convincing with tests calling SetWindowPos directly instead of through ShowWindow. And whatever changes are necessary should most likely be merged into the existing erase_now() call. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 8/8] wined3d: Implement applying state for compute pipeline.
by Henri Verbeet Feb. 2, 2017

Feb. 2, 2017

On 2 February 2017 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -3520,19 +3546,19 @@ BOOL context_apply_draw_state(struct wined3d_context *context, > wined3d_buffer_load_sysmem(state->index_buffer, context); > } > > - for (i = 0; i < context->numDirtyEntries; ++i) > + for (i = 0, dirty_idx = 0; i < context->numDirtyEntries; ++i) > { > DWORD rep = context->dirtyArray[i]; > - DWORD idx = rep / (sizeof(*context->isStateDirty) * CHAR_BIT); > - BYTE shift = rep & ((sizeof(*context->isStateDirty) * CHAR_BIT) - 1); > - context->isStateDirty[idx] &= ~(1u << shift); > - state_table[rep].apply(context, state, rep); > + if (!is_compute_state(rep)) > + apply_state(context, state_table, state, rep); > + else > + context->dirtyArray[dirty_idx++] = rep; I'd rather not do this. How important is it to avoid applying compute dispatch states for draws and vice-versa? As an aside, "dirtyArray" is mostly redundant, and possibly a little harmful.

3 3

Re: [PATCH 3/3] ole2.dll16: Implement several IIDs.
by Huw Davies Feb. 2, 2017

Feb. 2, 2017

On Wed, Feb 01, 2017 at 10:23:55PM -0600, Zebediah Figura wrote: > Needed for https://appdb.winehq.org/objectManager.php?sClass=version&iId=32136 > > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/ole2.dll16/ole2.dll16.spec | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/ole2.dll16/ole2.dll16.spec b/dlls/ole2.dll16/ole2.dll16.spec > index ed5e917..2789cdc 100644 > --- a/dlls/ole2.dll16/ole2.dll16.spec > +++ b/dlls/ole2.dll16/ole2.dll16.spec > @@ -111,10 +111,10 @@ > 126 stub _IID_IENUMGENERIC > 127 stub _IID_IENUMHOLDER > 128 stub _IID_IENUMCALLBACK > -129 stub _IID_IPERSISTSTREAM > -130 stub _IID_IPERSISTSTORAGE > +129 variable _IID_IPersistStream(0x00000109 0x00000000 0x000000c0 0x46000000) > +130 variable _IID_IPersistStorage(0x0000010a 0x00000000 0x000000c0 0x46000000) > 131 stub _IID_IPERSISTFILE > -132 stub _IID_IPERSIST > +132 variable _IPersist(0x0000010c 0x00000000 0x000000c0 0x46000000) Did you mean to drop the '_IID' prefix here? Huw.

2 1

Stubs in spec files
by Zebediah Figura Feb. 2, 2017

Feb. 2, 2017

Hi, I am a novice developer with a question about the spec files. Currently the .spec files contain stub lines for functions which have no implementation, and the compiler creates assembly thunks to __wine_spec_unimplemented_stub, which raises an exception when the function is called. However, some entries in the spec files are actually not functions but data, and when applications attempt to read this data they instead read the instruction code of the thunks. I recently was debugging a 16-bit application [1] which was referring to a GUID that I could not find defined anywhere, and only after some time was able to figure out that the application was reading the thunk code for _IID_IClassFactory in this way. The NE segment loading code in krnl386.dll16 will print a warning if an application attempts to request the location of a symbol not defined in the library. However, since the stubs are defined, no such message is printed, but the program will effectively be given a pointer to junk memory. As far as I can tell there is no way to add such a message either. What would in fact work is not to implement stub code in the libraries at all. In 16-bit code this results in a warning when the value is accessed, followed by a crash if it is a function which the code attempts to call. In 32-bit code this seems to behave identically to a stub function. Thus the only difference is that in 16-bit code (and possibly 32-bit code, but I could not find any variable that I could test with) a warning is printed (and 0xdeadbeef is returned instead of junk memory), which I see as a definite improvement. By commenting out all of the stub lines in compobj.dll16.spec I was able to locate several more that the program requested, but I may still be missing some in other DLLs. My question, then, is—is there any purpose of the stub lines besides to directly call __wine_spec_unimplemented_stub, or any other reason why this proposal would be detrimental? Thanks, Zebediah Figura

3 4

Re: [PATCH 3/3] mshtml/tests: Added COM aggregation tests.
by Marvin Feb. 2, 2017

Feb. 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28226 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2643: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5053: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH 2/2] comdlg32: Delay OleInitialize() for Windows versions older than Vista.
by Alexandre Julliard Feb. 2, 2017

Feb. 2, 2017

Józef Kucia <jkucia(a)codeweavers.com> writes: > This fixes a regression introduced by commit > f65e04770dc5748521a0de73814cea0b085bf3f8. > > OleInitialize() creates a window for the main apartment. SimCity 2000 > expects that the first created window after GetOpenFileA() is a file > dialog window. According to tests, this is expected to work on Windows > versions before Windows Vista. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Is a version check really necessary? Couldn't we find some better way? In what way does the app depend on the window creation order? -- Alexandre Julliard julliard(a)winehq.org

2 2