March 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 5/5] user32: Store the item rects as relative to the items_rect.
by Alexandre Julliard March 29, 2017

March 29, 2017

Huw Davies <huw(a)codeweavers.com> writes: > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/user32/menu.c | 68 ++++++++++++++++++++++++++---------------------------- > 1 file changed, 33 insertions(+), 35 deletions(-) This fails here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:1104: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203) win.c:1111: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) ... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [v2 2/2] d3dx9/tests: Add more tests for preshader relative addressing.
by Matteo Bruni March 28, 2017

March 28, 2017

2017-03-24 23:12 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Again, I'd separate the update of the test effect blob and the existing test from the addition of a new test. Aside from that, I just had a quick glance. expected_light_specular_2[] doesn't seem like a good name, you can call that "test_light_specular_2" or similar and rename its "result" field "expected" (i.e. always calling the table driving the test "test_something" is nice and consistent, as is calling the array with expected results "expected").

1 0

Re: [PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_ns.
by Nikolay Sivov March 28, 2017

March 28, 2017

On 28.03.2017 17:44, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > > > +static struct ns default_ns = { > + { emptyW }, > + { emptyW } > }; > I think this could use a better name. Default namespace is something defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match empty strings naming. Also everything static in this patch should be also const, no?

2 1

Re: [v2 PATCH] ole32: Add CoRegisterSurrogate/Ex stubs
by Huw Davies March 28, 2017

March 28, 2017

On Mon, Mar 27, 2017 at 10:12:11PM +0000, Alistair Leslie-Hughes wrote: > v2 - Removed CoRegisterSurrogateEx from header > - Minor formatting changes > - Return E_NOTIMPL > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ole32/compobj.c | 20 ++++++++++++++++++++ > dlls/ole32/ole32.spec | 4 ++-- > 2 files changed, 22 insertions(+), 2 deletions(-) Looks good. I've sent in a new version having run make_specfiles. Huw.

1 0

Re: [3/3] windowscodecs: Fixed loading png from streams
by Marvin March 28, 2017

March 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29747 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] windowscodecs: Test for png codec seeking too far
by Marvin March 28, 2017

March 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29746 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v4 6/7] user32/tests: Workaround an intermittent failure.
by Marvin March 27, 2017

March 27, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29730 Your paranoid android. === w7pro64 (64 bit msg) === msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 7: the msg sequence is not complete: expected 0000 - actual 0005

1 0

[1/3] shlwapi: SHCreateMemStream added to shlwapi.h
by Viktor Semykin March 27, 2017

March 27, 2017

Where it belongs according to its documentation. Signed-off-by: Viktor Semykin <thesame.ml(a)gmail.com> --- include/shlwapi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/shlwapi.h b/include/shlwapi.h index 2c68b7f..c19ca31 100644 --- a/include/shlwapi.h +++ b/include/shlwapi.h @@ -978,6 +978,7 @@ HRESULT WINAPI SHCreateStreamOnFileA(LPCSTR,DWORD,struct IStream**); HRESULT WINAPI SHCreateStreamOnFileW(LPCWSTR,DWORD,struct IStream**); #define SHCreateStreamOnFile WINELIB_NAME_AW(SHCreateStreamOnFile) +struct IStream * WINAPI SHCreateMemStream(const BYTE *lpbData, UINT dwDataLen); HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR,DWORD,DWORD,BOOL,struct IStream*,struct IStream**); HRESULT WINAPI SHCreateStreamWrapper(LPBYTE,DWORD,DWORD,struct IStream**); -- 2.12.1

1 2

Re: [PATCH v4 4/7] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin March 27, 2017

March 27, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29728 Your paranoid android. === w7u (32 bit msg) === msg.c:5084: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088

1 0

Re: [2/3] windowscodecs: Test for png codec seeking too far
by Vincent Povirk March 27, 2017

March 27, 2017

Does this test fail on Wine without patch 3? If it fails, you should add a todo_wine to the failing test, and remove it when the test is fixed.

2 1

Re: [PATCH 2/2 v2] devenum: Implement IMoniker::IsEqual().
by Andrew Eikum March 27, 2017

March 27, 2017

Thanks, just a couple more tweaks. On Mon, Mar 27, 2017 at 10:57:36PM +0800, Jactry Zeng wrote: > diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c > index e3c0f47256..b6275be8d2 100644 > --- a/dlls/devenum/tests/devenum.c > +++ b/dlls/devenum/tests/devenum.c > @@ -135,6 +135,94 @@ static void test_devenum(IBindCtx *bind_ctx) > if(sizeof(void*) == 4) > ok(have_mrle, "mrle codec not found\n"); > } > +static void test_moniker_isequal(void) > +{ > + HRESULT res; > + ICreateDevEnum *create_devenum = NULL; > + IEnumMoniker *enum_moniker0 = NULL, *enum_moniker1 = NULL; > + IMoniker *moniker0 = NULL, *moniker1 = NULL; > + > + res = CoCreateInstance(&CLSID_SystemDeviceEnum, NULL, CLSCTX_INPROC, > + &IID_ICreateDevEnum, (LPVOID*)&create_devenum); > + if (res) Please use FAILED() here. > + if (SUCCEEDED(IEnumMoniker_Next(enum_moniker0, 1, &moniker0, NULL)) && > + SUCCEEDED(IEnumMoniker_Next(enum_moniker1, 1, &moniker1, NULL))) > + { > + res = IMoniker_IsEqual(moniker0, moniker1); > + ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res); > + > + res = IMoniker_IsEqual(moniker1, moniker0); > + ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res); These should be compared against S_OK, otherwise S_FALSE will also pass the test. Andrew

2 1

Re: [PATCH 2/2] devenum: Implement IMoniker::IsEqual().
by Andrew Eikum March 27, 2017

March 27, 2017

On Sun, Mar 26, 2017 at 04:31:55PM +0800, Jactry Zeng wrote: > + res = ICreateDevEnum_CreateClassEnumerator(create_devenum, &CLSID_LegacyAmFilterCategory, &enum_moniker0, 0); > + ok(SUCCEEDED(res), "Cannot create enum moniker (res = %x)\n", res); > + res = ICreateDevEnum_CreateClassEnumerator(create_devenum, &CLSID_LegacyAmFilterCategory, &enum_moniker1, 0); > + ok(SUCCEEDED(res), "Cannot create enum moniker (res = %x)\n", res); > + if (!res) > + { > + if (!IEnumMoniker_Next(enum_moniker0, 1, &moniker0, NULL) && !IEnumMoniker_Next(enum_moniker1, 1, &moniker1, NULL)) > + { > + res = IMoniker_IsEqual(moniker0, moniker1); > + ok(!res, "IMoniker_IsEqual should failed (res = %x)\n", res); > + > + res = IMoniker_IsEqual(moniker1, moniker0); > + ok(!res, "IMoniker_IsEqual should failed (res = %x)\n", res); > + > + IMoniker_Release(moniker0); > + IMoniker_Release(moniker1); > + } These patches look fine to me except the ok() message is wrong on these two. Also, I think it's easier to read code that explicitly compares against S_OK or uses SUCCEEDED() instead of using !. Andrew

2 1

Re: iphlpapi: Implement GetUnicastIpAddressTable (try 2)
by Hans Leidekker March 27, 2017

March 27, 2017

> +DWORD WINAPI GetUnicastIpAddressTable(ADDRESS_FAMILY family, MIB_UNICASTIPADDRESS_TABLE **table) > +{ > + IP_ADAPTER_ADDRESSES *aa, *ptr; > + MIB_UNICASTIPADDRESS_TABLE *data; > + DWORD ret, count = 0; > + ULONG size; > + > + TRACE("%u, %p\n", family, table); > + > + if (!table || (family != WS_AF_INET && family != WS_AF_INET6 && family != WS_AF_UNSPEC)) > + return ERROR_INVALID_PARAMETER; > + > + ret = GetAdaptersAddresses(family, 0, NULL, NULL, &size); You should pass GAA_FLAG_SKIP_* flags here to exclude any data that will not be used.

2 1

Wine | Bug Query
by Akarsha Sehwag March 27, 2017

March 27, 2017

Hi I started with the bug( https://bugs.winehq.org/show_bug.cgi?id=39640 ). As of what I understood, I am writing it below. Kindly correct me wherever I go wrong. To implement ProcessPage_OnEndProcessTree() correctly we need to kill all its children and grandchildren also. So for that purpose, we need to iterate through all the active processes and check if their parent process is same as the process we wish to terminate. If yes, we kill them, if no, we continue our iteration. Now, for implementing this, can we use 'ps' or 'top' command. An example code: char string[30] = "ps -o pid --ppid "; char ppid[7]; sprintf(ppid , "%d" , getpid() ) ; strcat ( string , ppid ) ; system ( string ) ; ps -o pid --ppid <parent_Id> will give us the pid of all the child_processes whose parent has a PID. And now, get the parentProcess's PID by getpid(). Next, convert the integer into string and concatenate the result with string to get the final command which is then executed by system(string). Kindly tell me if I am anywhere near the right solution and also guide me how to proceed. Thanks :) Regards -- Akarsha Sehwag

3 2

Re: [PATCH v3 1/6] user32: Move internal message from EnableWindow() to WIN_SetStyle().
by Alexandre Julliard March 27, 2017

March 27, 2017

Zebediah Figura <z.figura12(a)gmail.com> writes: > The capture is already killed by handling WM_CANCELMODE, as in Windows. This should be a separate change, with its own tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: Add CoRegisterSurrogate/Ex stubs
by Huw Davies March 27, 2017

March 27, 2017

On Mon, Mar 27, 2017 at 04:29:24AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > diff --git a/include/objbase.h b/include/objbase.h > index 875f0e1..8f89389 100644 > --- a/include/objbase.h > +++ b/include/objbase.h > @@ -331,6 +331,7 @@ HRESULT WINAPI CoRevokeClassObject(DWORD dwRegister); > HRESULT WINAPI CoGetPSClsid(REFIID riid,CLSID *pclsid); > HRESULT WINAPI CoRegisterPSClsid(REFIID riid, REFCLSID rclsid); > HRESULT WINAPI CoRegisterSurrogate(LPSURROGATE pSurrogate); > +HRESULT WINAPI CoRegisterSurrogateEx(REFGUID guid, void *reserved); I don't see this in my Windows 10 SDK. Where does it come from? Huw.

2 2

Re: [v2 PATCH] oledb32/tests: Add convert to DBTYPE_NUMERIC tests
by Huw Davies March 27, 2017

March 27, 2017

On Sun, Mar 26, 2017 at 10:14:00PM +0000, Alistair Leslie-Hughes wrote: > v2 > - Added VT_NULL test > - Use result variables for each test. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> convert.c:3349: Test succeeded inside todo block: got 00000000 convert.c:3350: Test succeeded inside todo block: got 00000003 I've fixed these, removed the unnecessary src array, and resent. Huw.

1 0

Re: [PATCH v3 3/6] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin March 26, 2017

March 26, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29708 Your paranoid android. === w7u (32 bit msg) === msg.c:12062: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:12064: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:12064: Test failed: wrong tme.hwndTrack 0012017C, expected 00000000 msg.c:12064: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [PATCH 4/7] wined3d: Save pixel and vertex shader resource views in stateblocks.
by Henri Verbeet March 26, 2017

March 26, 2017

On 24 March 2017 at 17:14, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -3132,6 +3132,8 @@ struct wined3d_saved_states > WORD vertexShaderConstantsB; /* WINED3D_MAX_CONSTS_B, 16 */ > WORD vertexShaderConstantsI; /* WINED3D_MAX_CONSTS_I, 16 */ > BOOL vs_consts_f[WINED3D_MAX_VS_CONSTS_F]; > + DWORD pixel_shader_resource_views : 16; /* MAX_FRAGMENT_SAMPLERS, 16 */ > + DWORD vertex_shader_resource_views : 16; /* MAX_VERTEX_SAMPLERS, 4 */ So why is it 16 bits wide?

2 1

Re: [PATCH 2/7] wined3d: Allow creating shader resource views with NULL description.
by Henri Verbeet March 26, 2017

March 26, 2017

On 24 March 2017 at 17:14, Józef Kucia <jkucia(a)codeweavers.com> wrote: > For ddraw, d3d8 and d3d9. > I think we'd rather just create a wined3d_view_desc in those DLLs.

1 0

Re: cmd: Adjust CMD_LIST to a tree-like structure and implement command chains
by Flávio J. Saraiva March 25, 2017

March 25, 2017

Hi, Some time ago I was told that every patch in a patch set all patches should produce a state that passes all the tests. Given how much the current code is interconnected, i don't think i can split this while keeping the tests functional. How should I proceed in this case, can I split the code into logical bits knowing that the intermediate states will not pass the tests? Flávio J. Saraiva 2017-03-21 21:06 GMT+00:00 Marvin <testbot(a)winehq.org>: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Needs splitting". > > This means that the patch needs to be split, either because it > contains unrelated changes that should be their own separate patch, or > because it's too large for review. You need to find a way to resend > the changes in smaller chunks. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

5 8

Re: [PATCH v2 1/5] user32: Fix handling of internal messages.
by Alexandre Julliard March 25, 2017

March 25, 2017

Zebediah Figura <z.figura12(a)gmail.com> writes: > This patch adds a new flag and a server reply, allowing GetQueueStatus > to ignore internal messages, and MsgWaitForMultipleObjects to process > internal messages until a real sent message is found. There's a lot of code duplication in there, and adding private flags to public headers is discouraged. There has to be a better way of doing this, or else it would need a stronger justification than a couple of EnableWindow tests. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] oleaut32: Implement GetAltMonthNames()
by Jacek Caban March 25, 2017

March 25, 2017

Hi Nikolay, On 3/24/17 7:32 PM, Nikolay Sivov wrote: > diff --git a/dlls/oleaut32/oleaut.c b/dlls/oleaut32/oleaut.c > index f9734e6d78..816b18ce35 100644 > --- a/dlls/oleaut32/oleaut.c > +++ b/dlls/oleaut32/oleaut.c > @@ -935,3 +935,109 @@ HCURSOR WINAPI OleIconToCursor( HINSTANCE hinstExe, HICON hIcon) > /* FIXME: make an extended conversation from HICON to HCURSOR */ > return CopyCursor(hIcon); > } > + > +BOOL WINAPI GetAltMonthNames(LCID lcid, LPOLESTR **str) Shouldn't it return HRESULT? Thanks, Jacek

2 1

Re: [PATCH 2/3] d3dx9: Support relative addressing in preshader.
by Matteo Bruni March 24, 2017

March 24, 2017

2017-03-23 16:06 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 103 ++++++++++++++++++++++++++++++++++++------- > dlls/d3dx9_36/tests/effect.c | 38 ++++++++-------- > 2 files changed, 106 insertions(+), 35 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 9aedc99..2974ffd 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -191,6 +191,8 @@ struct d3dx_pres_operand > /* offset is component index, not register index, e. g. > offset for component c3.y is 13 (3 * 4 + 1) */ > unsigned int offset; > + enum pres_reg_tables base_reg_table; > + unsigned int base_reg_offset; > }; It would be nicer to create a struct for storing together table and offset and to pass it around to the various functions taking both arguments, like parse_pres_reg(). It should probably be a separate patch before this one. > + ptr = parse_pres_reg(ptr + 1, &opr->base_reg_table, &opr->base_reg_offset); > + } > + else > + { > + opr->base_reg_table = PRES_REGTAB_COUNT; > + ++ptr; > } > - opr->table = reg_table[*ptr++]; > - opr->offset = *ptr++; > + > + ptr = parse_pres_reg(ptr, &opr->table, &opr->offset); This would crash if the previous parse_pres_reg() call returned NULL. > + size = rs->table_sizes[table] * table_info[table].reg_component_count; > + if (offset >= size) > + { > + if ((offset & 255) < size) > + offset &= 255; > + else > + offset = offset % size; > + } Is this just to try and avoid the modulo operation in some cases or is there a deeper reason? If the former, you could extend that to all the power-of-two sizes by first checking if that's the case (!(size & size - 1)) and, if so, and-ing offset with the mask (size - 1). That's assuming the compiler doesn't do the same optimization already. Let me know if there is some other reason instead. > static double exec_get_arg(struct d3dx_regstore *rs, const struct d3dx_pres_operand *opr, unsigned int comp) > { > - if (!regstore_is_val_set_reg(rs, opr->table, (opr->offset + comp) / table_info[opr->table].reg_component_count)) > - WARN("Using uninitialized input, table %u, offset %u.\n", opr->table, opr->offset + comp); > + unsigned int base_offset, index; > + > + if (opr->base_reg_table == PRES_REGTAB_COUNT) > + index = 0; > + else > + index = (int)exec_get_reg_value(rs, opr->base_reg_table, opr->base_reg_offset); I think it's better with lrint() in place of the cast. > + if (index >= rs->table_sizes[opr->table] && opr->table == PRES_REGTAB_CONST) > + { > + unsigned int size_pow2; > + > + for (size_pow2 = 1; size_pow2 < rs->table_sizes[opr->table]; size_pow2 <<= 1) > + ; > + index &= (size_pow2 - 1); > + if (index >= rs->table_sizes[opr->table]) > + return 0.0; > + } I don't think we necessarily have to follow native's madness on buffer overflows to the letter. Since you did, that's certainly fine though.

2 6

Re: [PATCH v2] winex11: Use GLX_OML_sync_control to synchronise buffer swaps with X11DRV_FLUSH_GL_DRAWABLE requests.
by Jacek Caban March 24, 2017

March 24, 2017

Hi Henri, On 23.03.2017 23:58, Henri Verbeet wrote: > diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c > index af2fd92..7efd603 100644 > --- a/dlls/winex11.drv/init.c > +++ b/dlls/winex11.drv/init.c > @@ -375,9 +375,6 @@ static INT X11DRV_ExtEscape( PHYSDEV dev, INT escape, INT in_count, LPCVOID in_d > RECT rect = physDev->dc_rect; > > OffsetRect( &rect, -physDev->dc_rect.left, -physDev->dc_rect.top ); > - /* The GL drawable may be lagged behind if we don't flush first, so > - * flush the display make sure we copy up-to-date data */ > - XFlush( gdi_display ); Shouldn't this be called if GLX_OML_sync_control is not available? It seems to me that it should either depend on extension availability or be a separated patch. Thanks, Jacek

2 1