May 2017 - Wine-Devel - list.winehq.org

Re: [APPDB] query.php: implement query_affected_rows()
by Sebastian Lackner May 15, 2017

May 15, 2017

On 15.05.2017 03:13, Rosanne DiMesio wrote: > +function query_affected_rows(); Does this change work as expected? The ";" at the end of the function definition looks suspicious.

2 1

Re: [PATCH] dwrite/tests: Fix rendering mode variable type (Coverity)
by Sebastian Lackner May 14, 2017

May 14, 2017

On 14.05.2017 22:49, Nikolay Sivov wrote: > - mode1 = IDWriteRenderingParams3_GetRenderingMode(params3); > - ok(mode1 == DWRITE_RENDERING_MODE1_NATURAL_SYMMETRIC, "got %d\n", mode1); > + mode = IDWriteRenderingParams3_GetRenderingMode(params3); > + ok(mode == DWRITE_RENDERING_MODE_NATURAL_SYMMETRIC, "got %d\n", mode1); ^^^^^ What about the remaining occurrence of mode1?

1 0

Re: [v7 PATCH] oleaut32: Improve support for IDispatch in VarCat
by Marvin May 12, 2017

May 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30935 Your paranoid android. === wxppro (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w2003std (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === wvistau64 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w2008s64 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w7u (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w7pro64 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w8 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w864 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w1064 (32 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === wvistau64 (64 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w2008s64 (64 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w7pro64 (64 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w864 (64 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e === w1064 (64 bit vartest) === vartest.c:6153: Test failed: got 0x8007000e

1 0

Re: [v6 PATCH] oleaut32: Improve support for IDispatch in VarCat
by Sebastian Lackner May 12, 2017

May 12, 2017

On 12.05.2017 02:11, Alistair Leslie-Hughes wrote: > +static HRESULT WINAPI DummyDispatch_Invoke(IDispatch *iface, > + DISPID dispid, REFIID riid, > + LCID lcid, WORD wFlags, > + DISPPARAMS *params, > + VARIANT *res, > + EXCEPINFO *ei, > + UINT *arg_err) > +{ [...] > + if (FAILED(This->result)) > + return FAILED(This->result); I didn't review the whole patch, but this return value looks suspicious for a HRESULT function.

1 0

Re: [PATCH 8/9] d3dx9: Add test for 'cmp' preshader opcode.
by Matteo Bruni May 11, 2017

May 11, 2017

2017-05-08 17:39 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/tests/effect.c | 33 +++++++++++++++++++++++++++++---- > 1 file changed, 29 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c > index 015b505..dfc3f5b 100644 > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -4490,7 +4490,8 @@ static void test_preshader_op(IDirect3DDevice9 *device, const DWORD *sample_effe > { > {0, 0, 0}, > {5549, 0, 4}, > - {5400, 2, 1} > + {5400, 2, 1}, > + {4121, 0, 1} > }; You could add a ',' after the new array element so that, if we ever need to add another test, that line doesn't need to be changed. Just mentioning it since you have to resend anyway. > DWORD *test_effect_blob; > HRESULT hr; > @@ -4506,8 +4507,30 @@ static void test_preshader_op(IDirect3DDevice9 *device, const DWORD *sample_effe > > test_effect_blob = HeapAlloc(GetProcessHeap(), 0, sample_effect_blob_size); > memcpy(test_effect_blob, sample_effect_blob, sample_effect_blob_size); > - for (i = 0; i < blob_position[test->args_count].ins_count; ++i) > - test_effect_blob[op_pos + i * op_step] = test->opcode; > + > + if (test->args_count == 3) > + { > + DWORD *pos; > + > + pos = &test_effect_blob[op_pos - 1]; > + *pos++ = 1; > + *pos++ = test->opcode; > + *pos++ = test->args_count; > + for (i = 0; i < 3; ++i) > + { > + *pos++ = 0; > + *pos++ = 2; > + *pos++ = i == 2 ? 4 : 0; > + } > + *pos++ = 0; > + *pos++ = 4; > + *pos++ = 0; > + } > + else > + { > + for (i = 0; i < blob_position[test->args_count].ins_count; ++i) > + test_effect_blob[op_pos + i * op_step] = test->opcode; > + } I think this is getting more and more ugly. What about writing an effect with those 3 preshaders by hand instead? You could start with those edited effect fragments, fixing them up and putting them together in a new effect blob. Sprinkle over some comments as necessary. I'm not going to block the patch for this reason but I think it's something worth exploring.

2 15

Re: [APPDB] admin.php: fix incorrect call to query_affected_rows
by Bruno Jesus May 11, 2017

May 11, 2017

On Thu, May 11, 2017 at 3:27 PM, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > Should be query_num_rows. > > Signed-off-by: Rosanne DiMesio <dimesio(a)earthlink.net> > --- > admin.php | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/admin.php b/admin.php > index 09c0aca..fe1ccc6 100644 > --- a/admin.php > +++ b/admin.php > @@ -199,7 +199,7 @@ function fixNoteLinks() > > echo " Deleting note links "; > $hResult = query_parameters("DELETE FROM appNotes WHERE linkedWith != '0'"); > - echo "Deleted ".query_affected_rows()." links "; > + echo "Deleted ".query_num_rows()." links "; Is this some particularity of the wrapper database function? I say that because for example both mysql and postgresql have the 2 distinct functions where affected_rows is used for delete/update and num_rows is used for select queries.

1 0

Re: [APPDB] admin.php: fix incorrect call to query_affected_rows
by Michael Müller May 11, 2017

May 11, 2017

Am 11.05.2017 um 20:27 schrieb Rosanne DiMesio: > $hResult = query_parameters("DELETE FROM appNotes WHERE linkedWith != '0'"); > - echo "Deleted ".query_affected_rows()." links "; > + echo "Deleted ".query_num_rows()." links "; I suspect the new code is as broken as the old one. The function query_num_rows returns the number of query results, which is always zero for a DELETE query. The correct solution would be to implement query_affected_rows() based on the corresponding php function [1]. [1]: http://php.net/manual/de/mysqli.affected-rows.php

1 0

Re: [PATCH] winemac.drv: Implement systray version 1-3 notifications.
by Ken Thomases May 11, 2017

May 11, 2017

On May 11, 2017, at 6:15 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > > --- > > I am not sure how to handle NOTIFY_VERSION_4. The click events do not contain > a coordinate and I don't know how to read the position of the icon. The first > issue is probably trivial to handle by assuming a fixed coordinate because the > icon isn't all that big anyway. The latter is a larger problem because a wrong > coordinate could cause an app to show a popup in the wrong place. Also on dual > screen setups there are two copies of the status bar and two icon copies. Pick > the wrong one and things go bad as well. Thanks. I've sent a modified version that properly handles version 4. The internal events that you were looking at didn't contain the position, but can be made to. :) -Ken

1 0

Re: [PATCH] oleaut32: Improve support for IDispatch in VarCat
by Jacek Caban May 11, 2017

May 11, 2017

Hi Alistair, On 17.04.2017 05:43, Alistair Leslie-Hughes wrote: > diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c > index 17f753af70..6f695c3f37 100644 > --- a/dlls/oleaut32/variant.c > +++ b/dlls/oleaut32/variant.c > @@ -2611,6 +2611,13 @@ HRESULT WINAPI VarCat(LPVARIANT left, LPVARIANT right, LPVARIANT out) > V_VT(&bstrvar_left) = VT_BSTR; > V_BSTR(&bstrvar_left) = SysAllocString(sz_empty); > } > + else if (rightvt == VT_DISPATCH) > + { > + /* The returned Dispatch Value, may not be able to be coerced, ie. VT_NULL */ > + hres = VariantChangeTypeEx(&bstrvar_left,left,0,0,VT_BSTR); > + if (hres != S_OK && hres != DISP_E_TYPEMISMATCH) > + return hres; > + } > else > { > hres = VariantChangeTypeEx(&bstrvar_left,left,0,0,VT_BSTR); > @@ -2651,6 +2658,13 @@ HRESULT WINAPI VarCat(LPVARIANT left, LPVARIANT right, LPVARIANT out) > V_VT(&bstrvar_right) = VT_BSTR; > V_BSTR(&bstrvar_right) = SysAllocString(sz_empty); > } > + else if (rightvt == VT_DISPATCH) > + { > + /* The returned Dispatch Value, may not be able to be coerced, ie. VT_NULL */ > + hres = VariantChangeTypeEx(&bstrvar_right,right,0,0,VT_BSTR); > + if (hres != S_OK && hres != DISP_E_TYPEMISMATCH) > + return hres; > + } > else > { > hres = VariantChangeTypeEx(&bstrvar_right,right,0,0,VT_BSTR); While this change may do the right thing in the case you're fixing, the whole surrounding code looks just wrong and I don't like the idea of making it even more complicated to work around problem in this single case. For example take a look at if() statement in line 2620. It's never executed, because it requires leftvt to be VT_NULL, which is handled elsewhere (line 2609). If you remove that if(), this call is almost identical to what you add here as a special case. The only difference is DISP_E_TYPEMISMATCH handling. Did you investigate what happens in such case? Maybe we should handle VariantChangeTypeEx failures like you do in the patch? Thanks, Jacek

1 0

Re: [PATCH 3/9] d3dx9: Add 'asin' preshader opcode.
by Matteo Bruni May 11, 2017

May 11, 2017

2017-05-08 17:39 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +/* is_nan() does not work (by design) if compiled with gcc -ffinite-math-only option which is implied by > + * -ffast_math. */ > +static BOOL pres_is_nan(double v) > +{ > + return (*(ULONG64 *)&v & 0x7ff8000000000000) == 0x7ff8000000000000; > +} I don't think we care about people compiling Wine with broken CFLAGS. We should just trust the isnan() library function. FWIW we already do so in other places in Wine.

2 3

Re: [PATCH 7/7] wined3d: Add support for patch constant signatures.
by Henri Verbeet May 11, 2017

May 11, 2017

On 10 May 2017 at 15:54, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->input_signature, &len))) > + return hr; > + total = len; > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->output_signature, &len))) > + return hr; > + total += len; > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->patch_constant_signature, &len))) > + return hr; > + total += len; It's perhaps a fairly theoretical concern, but I think you can still make "total" overflow here.

1 0

Re: [PATCH 3/6 v2] dmusic: Implement IDirectMusic8::SetDirectSound()
by Sebastian Lackner May 10, 2017

May 10, 2017

On 10.05.2017 15:13, Michael Stefaniuc wrote: > + > + if (This->dsound) > + IDirectSound_Release(This->dsound); > + > + if (!dsound) { > + hr = DirectSoundCreate8(NULL, (IDirectSound8 **)&This->dsound, NULL); > + if (FAILED(hr)) > + return hr; > + hr = IDirectSound_SetCooperativeLevel(This->dsound, hwnd ? hwnd : GetForegroundWindow(), > + DSSCL_PRIORITY); > + if (FAILED(hr)) > + IDirectSound_Release(This->dsound); > + return hr; > + } > Shouldn't you unset This->dsound in the error paths (especially the last one)?

2 1

Re: [PATCH 3/6] d3d11/tests: Port test_clear_state() from d3d10core.
by Henri Verbeet May 10, 2017

May 10, 2017

On 9 May 2017 at 12:51, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + refcount = ID3D11Device_Release(device); > + ok(!refcount, "Device has %u references left.\n", refcount); > +} This test hangs for me on Windows. Specifically, the issue seems to be the final release of the device.

2 1

Wine native fps overlay
by CARLOS RODRIGUEZ May 10, 2017

May 10, 2017

>The big picture answer to your feature requests is that Wine is a tool to run Windows apps and all these things are side features that can be added with other tools and partially exist in drivers.If we add code for that it needs to be maintained, taking away attention from our main goal. I once tried to make FRAPS run in Wine, which would give you an option to add an FPS overlay to pretty much all d3d or GL apps. Unfortunately its DLL injection code doesn't work, and fixing it would require changes to the linker and/or dynamic loader, which is rather tricky. Likewise you can write a more generic FPS limiting or vsync forcing tool with LD_PRELOAD. That way it would also work with non-wine apps.>Unfortunate but for now nikolay suggestion (WINEDEBUG=-all,+fps) works without issues (only shows fps information and seems improve performance in some apps too)

1 0

Re: [PATCH] ws2_32: Use unsigned interface index on interface_bind_check
by Alexandre Julliard May 10, 2017

May 10, 2017

Bruno Jesus <bjesus(a)codeweavers.com> writes: > The exotic interface indexes used by linux for tun/ppp connections may > cause problems resulting in interface_bind_check not finding the > expected interface during loop. > > Signed-off-by: Bruno Jesus <bjesus(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The error checking would need to be adapted then, checking ifindex > 0 no longer makes much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v4 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

Getting closer. + HRESULT GetPriorityRecords( + [out] WM_STREAM_PRIORITY_RECORD *arrray, + [in, out] WORD *records); + + HRESULT SetPriorityRecords( + [in] WM_STREAM_PRIORITY_RECORD *arrray, + [in] WORD records); "array" is spelled with two R's. + HRESULT ResetLoggingUrlList( ); None of the other zero-argument functions in this file have a space between the parentheses. + HRESULT SetMaxPacketSize([in] DWORD size); + HRESULT SetMinPacketSize([in] DWORD size); None of the other functions in this file have two spaces between [in] and the variable type. + HRESULT GetPlayOutputLevels( + [out, size_is( *length )] DRM_PLAY_OPL *play, + [in, out] DWORD *length, + [out] DWORD *level); + + HRESULT GetCopyOutputLevels( + [out, size_is( *length )] DRM_COPY_OPL *copy, + [in, out] DWORD *length, + [out] DWORD *compliance); Why did you name the variable "level" in the first function and "compliance" in the second? It seems like they should be the same. -Alex

1 0

Re: [v3 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

These functions have formatting inconsistencies: + HRESULT GetPriorityRecords( + [out] WM_STREAM_PRIORITY_RECORD *arrray, + [in, out] WORD *records); + HRESULT SetPriorityRecords( + [in] WM_STREAM_PRIORITY_RECORD *arrray, + [in] WORD records); + HRESULT ResetLoggingUrlList( ); + HRESULT SetMaxPacketSize([in] DWORD size); + HRESULT SetMinPacketSize([in] DWORD size); + HRESULT GetDRMProperty( + [in] const WCHAR *name, + [out] WMT_ATTR_DATATYPE* type, + [out, size_is( *length )] BYTE *value, + [in, out] WORD *length); These functions have naming inconsistencies: + HRESULT GetPlayOutputLevels( + [out, size_is( *length )] DRM_PLAY_OPL *play, + [in, out] DWORD *length, + [out] DWORD *pdwMinAppComplianceLevel); + HRESULT GetTimecodeRangeBounds( + [in] WORD stream, + [in] WORD Range, + [out] DWORD *start_timecode, + [out] DWORD *end_timecode); Please spend some time double and triple checking before submitting again. -Alex

1 0

Re: [v2 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

The formatting is a little better now, but it's still all over the place. Please make every function declaration match the existing code in this file. For example, for a function with one argument: HRESULT GetType([out] GUID *guid); And for a function with multiple arguments: HRESULT GetProxyPort( [in] LPCWSTR protocol, [out] DWORD *port); -Alex

1 0

Re: [PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

- WMT_CODECINFO_UNKNOWN = 0xFFFFFFFF, + WMT_CODECINFO_UNKNOWN = 0xffffffff, I think this qualifies as a gratuitous formatting change. + HRESULT GetBandwidth( [out] DWORD *bitrate, + [out] DWORD *buffer ); + + HRESULT SetBandwidth( [in] DWORD bitrate, + [in] DWORD buffer ); The extra spaces after the left parentheses look like a mistake; they don't match the format in the rest of the file. + HRESULT GetBandwidthSharing( [in] DWORD index, + [out] IWMBandwidthSharing **bandwidth ); + HRESULT GetExpectedPacketCount( [in] QWORD duration, + [out] QWORD *packets ); + HRESULT SetDRMProperty( [in] const WCHAR *name, [in] WMT_ATTR_DATATYPE type, + [in, size_is( length )] const BYTE *value, + [in] WORD length ); + HRESULT GetDRMProperty( [in] const WCHAR *name, [out] WMT_ATTR_DATATYPE* type, + [out, size_is( *length )] BYTE *value, + [in, out] WORD *length ); Again, pick a whitespace style and stick to it. In particular, decide whether you want to break the line after each variable or after reaching 80, 100, or 120 characters. -Alex

3 3

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 9, 2017

May 9, 2017

>>If winecfg runs, that should be good enough. Optional packages can be >>backported if necessary. >> > >OK, then I will concentrate on min kernel version :) > Currently blocked by Bug 42986.

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 9, 2017

May 9, 2017

>You suppress the rest of traces, like -all,+fps. >Many thanks i dont know this option can be used at same time, i thinking -all can disable +fpsAlmost forget will be posible wine can add some fps limiter, this will be usefull in many older titles when vsync dont workThanks again

3 2

Re: [PATCH 3/3] mshtml: Use IE version dependent on compatibility mode for conditional comments.
by Marvin May 9, 2017

May 9, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30879 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2671: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 1/3] mshtml: Don't expose doScroll in IE11 document mode.
by Marvin May 9, 2017

May 9, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30878 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2671: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH] ws2_32: Don't post completion packet if receiving fails with error immediately.
by Bruno Jesus May 9, 2017

May 9, 2017

On Mon, May 8, 2017 at 4:41 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This fixes bug 38980. > > This patch is the equivalent to 1bbe92e7 for receiving operations. > Application in bug 38980 uses libtorrent, which in turn uses boost's > async IO classes. Boost starts IO operations and waits for their results > via IOCP. If the operation fails right away it enqueues a completion > status itself. By failing and enquing a status we broke Boost's > receiving logic - after the first status was read the internal data was > reused elsewhere (though the pointer was not freed). The second IOCP > result caused boost to call libtorrent's callback function with bad > parameters, ultimately causing a segfault or assertion violation in > libtorrent. Awesome work, thanks ;-) Some unused SetLastError calls and since I'm sending an email why not complain more? > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 - > dlls/ws2_32/tests/sock.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 127 insertions(+), 2 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 9d27fab..0950754 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -7744,9 +7744,7 @@ static int WS2_recv_base( SOCKET s, LPWSABUF lpBuffers, DWORD dwBufferCount, > > if (errno != EAGAIN) > { > - int loc_errno = errno; > err = wsaErrno(); > - if (cvalue) WS_AddCompletion( s, cvalue, sock_get_ntstatus(loc_errno), 0 ); > goto error; > } > } > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 023eb42..7fefff5 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -9299,6 +9299,133 @@ static void test_completion_port(void) > if (dest != INVALID_SOCKET) > closesocket(dest); > > + /* Test IOCP response on successful immediate read. */ > + tcp_socketpair(&src, &dest); > + if (src == INVALID_SOCKET || dest == INVALID_SOCKET) > + { > + skip("failed to create sockets\n"); > + goto end; > + } > + > + bufs.len = sizeof(buf); > + bufs.buf = buf; > + flags = 0; > + > + iret = WSASend(src, &bufs, 1, &num_bytes, 0, &ov, NULL); > + ok(!iret, "WSASend failed - %d\n", iret); Some winsock functions are basically boolean where 0 is true and SOCKET_ERROR is false, so (I believe) in most other places we use "WSASend failed with error %d", GetLastError()). This would require a previous SetLastError. > + ok(num_bytes == sizeof(buf), "Managed to send %d\n", num_bytes); I believe most code in ws2_32 prefer "Expected X, got Y\n". > + > + io_port = CreateIoCompletionPort((HANDLE)dest, previous_port, 125, 0); > + ok(io_port != NULL, "failed to create completion port %u\n", GetLastError()); > + > + set_blocking(dest, FALSE); > + > + Sleep(100); Better to remove the extra new empty line as in the other use of Sleep there is no empty line. Besides it makes it harder for AJ to see you are adding sleep to tests :-) > + > + num_bytes = 0xdeadbeef; > + SetLastError(0xdeadbeef); SetLastError forever alone, no GetLastError. Maybe reuse the format from above? > + flags = 0; > + > + iret = WSARecv(dest, &bufs, 1, &num_bytes, &flags, &ov, NULL); > + ok(!iret, "WSARecv failed - %d\n", iret); > + ok(num_bytes == sizeof(buf), "Managed to read %d\n", num_bytes); Reuse expected/got message format? > + SetLastError(0xdeadbeef); > + key = 0xdeadbeef; > + num_bytes = 0xdeadbeef; > + olp = (WSAOVERLAPPED *)0xdeadbeef; > + > + bret = GetQueuedCompletionStatus( io_port, &num_bytes, &key, &olp, 200 ); > + ok(bret == TRUE, "failed to get completion status %u\n", bret); > + ok(GetLastError() == 0xdeadbeef, "Last error was %d\n", GetLastError()); > + ok(key == 125, "Key is %lu\n", key); > + ok(num_bytes == sizeof(buf), "Number of bytes transferred is %u\n", num_bytes); > + ok(olp == &ov, "Overlapped structure is at %p\n", olp); > + > + /* Test IOCP response on graceful shutdown. */ > + closesocket(src); > + Sleep(100); > + > + num_bytes = 0xdeadbeef; > + SetLastError(0xdeadbeef); No GetLastError. > + flags = 0; > + memset(&ov, 0, sizeof(ov)); > + > + iret = WSARecv(dest, &bufs, 1, &num_bytes, &flags, &ov, NULL); > + ok(!iret, "WSARecv failed - %d\n", iret); > + ok(!num_bytes, "Managed to read %d\n", num_bytes); > + > + SetLastError(0xdeadbeef); > + key = 0xdeadbeef; > + num_bytes = 0xdeadbeef; > + olp = (WSAOVERLAPPED *)0xdeadbeef; > + > + bret = GetQueuedCompletionStatus( io_port, &num_bytes, &key, &olp, 200 ); > + ok(bret == TRUE, "failed to get completion status %u\n", bret); > + ok(GetLastError() == 0xdeadbeef, "Last error was %d\n", GetLastError()); > + ok(key == 125, "Key is %lu\n", key); > + ok(!num_bytes, "Number of bytes transferred is %u\n", num_bytes); > + ok(olp == &ov, "Overlapped structure is at %p\n", olp); > + > + closesocket(src); > + src = INVALID_SOCKET; > + closesocket(dest); > + dest = INVALID_SOCKET; > + > + /* Test IOCP response on hard shutdown. */ > + tcp_socketpair(&src, &dest); > + if (src == INVALID_SOCKET || dest == INVALID_SOCKET) > + { > + skip("failed to create sockets\n"); > + goto end; > + } > + > + bufs.len = sizeof(buf); > + bufs.buf = buf; > + flags = 0; > + memset(&ov, 0, sizeof(ov)); > + > + ling.l_onoff = 1; > + ling.l_linger = 0; > + iret = setsockopt (src, SOL_SOCKET, SO_LINGER, (char *) &ling, sizeof(ling)); > + ok(!iret, "Failed to set linger %d\n", GetLastError()); > + > + io_port = CreateIoCompletionPort((HANDLE)dest, previous_port, 125, 0); > + ok(io_port != NULL, "failed to create completion port %u\n", GetLastError()); > + > + set_blocking(dest, FALSE); > + > + closesocket(src); > + src = INVALID_SOCKET; > + > + Sleep(100); > + > + num_bytes = 0xdeadbeef; > + SetLastError(0xdeadbeef); > + > + /* Somehow a hard shutdown doesn't work on my Linux box. It seems SO_LINGER is ignored. */ AFAIR this is not your fault, it is a bug. WSARecv has a particular behavior of not returning a "0 bytes read", instead it returns error with WSAECONNRESET. Wine simply returns success with 0 bytes, which stands for connection reset in the old recv() way. This explains the 3 todo_wine below. > + iret = WSARecv(dest, &bufs, 1, &num_bytes, &flags, &ov, NULL); > + todo_wine ok(iret == SOCKET_ERROR, "WSARecv failed - %d\n", iret); > + todo_wine ok(GetLastError() == WSAECONNRESET, "Last error was %d\n", GetLastError()); > + todo_wine ok(num_bytes == 0xdeadbeef, "Managed to send %d\n", num_bytes); Expected/got format? If not the sentence is wrong: send/recv. > + > + SetLastError(0xdeadbeef); > + key = 0xdeadbeef; > + num_bytes = 0xdeadbeef; > + olp = (WSAOVERLAPPED *)0xdeadbeef; > + > + bret = GetQueuedCompletionStatus( io_port, &num_bytes, &key, &olp, 200 ); > + todo_wine ok(bret == FALSE, "GetQueuedCompletionStatus returned %u\n", bret ); > + todo_wine ok(GetLastError() == WAIT_TIMEOUT, "Last error was %d\n", GetLastError()); > + todo_wine ok(key == 0xdeadbeef, "Key is %lu\n", key); > + todo_wine ok(num_bytes == 0xdeadbeef, "Number of bytes transferred is %u\n", num_bytes); > + todo_wine ok(!olp, "Overlapped structure is at %p\n", olp); > + > + num_bytes = 0xdeadbeef; > + SetLastError(0xdeadbeef); > + > + closesocket(dest); > + > dest = socket(AF_INET, SOCK_STREAM, 0); > if (dest == INVALID_SOCKET) > { > -- > 2.10.2 > > >

3 2

Re: [APPDB] Remove Steam and GOG from licenses
by Bruno Jesus May 9, 2017

May 9, 2017

On Mon, May 8, 2017 at 6:09 PM, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > Steam and GOG are distribution platforms, not licenses. See bug 42970. Entries already using the mistakenly-added items will have to be manually fixed in the live database. What about changing them into a single LICENSE_DIGITAL which would encompass all online platforms.

2 1

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 8, 2017

May 8, 2017

>> 1) So question is - if winecfg shows up. Is that supported? Is it enough, >> when that _big_ "WARNING:" will be resolved (disappears), is such wine >> package supported? Most of them would be easy to overcome, except >> XInput2 + libOSMesa which needs IMHO deeper dependencies. > >If winecfg runs, that should be good enough. Optional packages can be >backported if necessary. > OK, then I will concentrate on min kernel version :)

1 0

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 8, 2017

May 8, 2017

> >None of those are needed by winecfg. They would be needed by some >applications, though. > I'm aware of it. But the idea is elsewhere... There are two approaches: 1. i will strictly find the lowest kernel on which i'm able to run winecfg but probably not much more... 2. i will find minimum requirements like pcap-v1.8.1 etc. so, that we can get rid of those generic: "configure: libpulse development files not found or __too__ __old__" but user will be given exact version (for Linux and those who care about other OS can do the same). Let's face it - most of programs says for example something like min supported OS: Win7 and higher) Isn't that "Bug 42478 - Undeclared O_CLOEXEC use in qcap DLL" about this? Quick googling sugest "O_CLOEXEC (Since Linux 2.6.23)". With commit dfd22fb294c6ce9c3daba311f96ca3b4933d265c shouldn't be min requirements bumped to linux-2.6.23 ?? Sure there is https://github.com/wine-compholio/wine-staging/blob/master/patches/qcap-O_C… Then two users having wine-2.7, but with totally different behavior, which is definitely harder to support... Maybe that's OK and then wine probably doesn't need nothing like minimum requirements. If we don't play on min requirements = it's normal, that some parts of wine do not work. Why there are two kinds of warning? a) configure: libmpg123 development files not found (or too old), mp3 codec won't be supported. b) configure: WARNING: libgnutls development files not found, no schannel support.

1 0

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 8, 2017

May 8, 2017

>> >> Isn't commit https://source.winehq.org/git/wine.git/commitdiff/9f06a197c8c156acf21d8d809… >> about this? > >For that specific issue, yes. But it would be interesting to find out if >there are other issues that we aren't aware of, and whether they would >be worth trying to fix. Plan was: Debian 3.0 Woody i386 ===================== * Released 2002-07-19 * kernel v2.2.20, v2.4.6 kernel is also included Debian 3.1 Sarge i386 ===================== * Released 2005-06-06 * Linux kernel v2.4.27, v2.6.8 Debian 4.0 Etch i386 ==================== * Released 2007-04-08 * Linux kernel v2.6.18 After getting these, i started with Etch and wine-2.7. I installed all needed & available *-dev packages. Nevertheless i got: configure: XInput2 headers not found, the XInput 2 extension won't be supported. configure: libOSMesa development files not found (or too old), OpenGL rendering in bitmaps won't be supported. configure: OpenCL development files not found, OpenCL won't be supported. configure: pcap development files not found, wpcap won't be supported. configure: liblcms2 development files not found, Color Management won't be supported. configure: libpulse development files not found or too old, Pulse won't be supported. configure: gstreamer-1.0 base plugins development files not found, gstreamer support disabled configure: OSS sound system found but too old (OSSv4 needed), OSS won't be supported. configure: libudev development files not found, plug and play won't be supported. configure: libmpg123 development files not found (or too old), mp3 codec won't be supported. configure: libopenal development files not found (or too old), OpenAL won't be supported configure: openal-soft development files not found (or too old), XAudio2 won't be supported configure: WARNING: libgnutls development files not found, no schannel support. configure: Finished. Do 'make' to compile Wine. 1) So question is - if winecfg shows up. Is that supported? Is it enough, when that _big_ "WARNING:" will be resolved (disappears), is such wine package supported? Most of them would be easy to overcome, except XInput2 + libOSMesa which needs IMHO deeper dependencies. Anyway, configure suggest "do make". In that case compilation fails with: gcc -c -o v4l.o ../../../wine_git_src/dlls/qcap/v4l.c -I. -I../../../wine_git_src/dlls/qcap \ -I../../include -I../../../wine_git_src/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings \ -Wpointer-arith -gdwarf-2 -fno-omit-frame-pointer ../../../wine_git_src/dlls/qcap/v4l.c: In function ‘qcap_driver_init’: ../../../wine_git_src/dlls/qcap/v4l.c:802: error: ‘O_CLOEXEC’ undeclared (first use in this function) ../../../wine_git_src/dlls/qcap/v4l.c:802: error: (Each undeclared identifier is reported only once ../../../wine_git_src/dlls/qcap/v4l.c:802: error: for each function it appears in.) make[1]: *** [v4l.o] Error 1 make[1]: Leaving directory `/build/wine_git_bin_32/dlls/qcap' 2) And this also happens with "./configure --without-v4l" so probably real bug? 3) That "libpcap0.8-dev" isn't that old. So i looked closer and it appears, that it fails because of missing "port.h". IMHO that comes from kernel headers as i have it in v4.9, but not in v2.6.18. So minimum is not 2.3.31, but 2.6.18+ / 3.x ? or where that port.h appeared for the first time ?? ... configure:6945: checking pcap/pcap.h usability configure:6945: gcc -c -g -O0 conftest.c >&5 configure:6945: $? = 0 configure:6945: result: yes configure:6945: checking pcap/pcap.h presence configure:6945: gcc -E conftest.c configure:6945: $? = 0 configure:6945: result: yes configure:6945: checking for pcap/pcap.h configure:6945: result: yes configure:6945: checking poll.h usability configure:6945: gcc -c -g -O0 conftest.c >&5 configure:6945: $? = 0 configure:6945: result: yes configure:6945: checking poll.h presence configure:6945: gcc -E conftest.c configure:6945: $? = 0 configure:6945: result: yes configure:6945: checking for poll.h configure:6945: result: yes configure:6945: checking port.h usability configure:6945: gcc -c -g -O0 conftest.c >&5 conftest.c:93:18: error: port.h: No such file or directory Before taking any other steps, i'll try to wait for feedback on 1), 2) and 3) Regards, W.

3 2

Re: [v5 PATCH 1/4] mfplat: Implement MFTRegister
by Alexandre Julliard May 8, 2017

May 8, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + if (cinput && input_types) > + { > + size = cinput * sizeof(MFT_REGISTER_TYPE_INFO); > + types = HeapAlloc(GetProcessHeap(), 0, size); > + if (!types) goto err; > + > + memcpy(types, input_types, size); > + > + ret = RegSetValueExW(hclsid, inputtypesW, 0, REG_BINARY, (BYTE *)types, size); > + HeapFree(GetProcessHeap(), 0, types); > + if (ret) goto err; Again, why do you need a copy? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/9] winemac.drv: EnumDisplayDevices placeholder implementation
by Ken Thomases May 8, 2017

May 8, 2017

Hi, Thanks for taking this up again… On Apr 24, 2017, at 3:48 PM, Donat Enikeev <donat(a)enikeev.net> wrote: > > Based on Ken Thomases <ken(a)codeweavers.com> staging patches > > Signed-off-by: Donat Enikeev <donat(a)enikeev.net> > --- > dlls/winemac.drv/display.c | 51 +++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/winemac.drv.spec | 1 + > 2 files changed, 52 insertions(+) This doesn't build: display.c:1007:13: error: use of undeclared identifier 'monitors' if (monitors[iDevNum].dwFlags & MONITORINFOF_PRIMARY) ^ display.c:1010:80: error: use of undeclared identifier 'monitors' memcpy(lpDisplayDevice->DeviceName, monitors[iDevNum].szDevice, sizeof(monitors[iDevNum].szDevice)); ^ display.c:1010:45: error: use of undeclared identifier 'monitors' memcpy(lpDisplayDevice->DeviceName, monitors[iDevNum].szDevice, sizeof(monitors[iDevNum].szDevice)); ^ Is this patch written on the assumption that some other staging patches have already been applied? Beyond that, can you explain the rationale of moving the implementation of EnumDisplayDevices to the drivers? My patches implemented it in user32 based on EnumDisplayMonitors() and GetMonitorInfoW(). It may be somewhat clunky, but has the advantage that it ensures all three functions return mutually consistent results. Since you appear to have dropped my patches which caused GetMonitorInfoW() to return unique names for the displays, they are no longer consistent. GetMonitorInfoW() always uses "\\.\DISPLAY1" for all monitors while this implementation of EnumDisplayDevices() attempts to use "\\.\DISPLAY2", etc., for secondary and subsequent monitors. For what it's worth, my original patches were rejected because Alexandre wanted the tracking and management of displays and display modes centralized in the explorer process[1]. I have my reservations about that approach, mind you. ;) [1] https://www.winehq.org/pipermail/wine-devel/2014-March/103680.html Issues with other patches in the series: Patch 1: \ No newline at end of file Patches 1 and 2 ought to come after 3. In the current order, they introduce dead code. -Ken

2 3

Outreachy: Rosanne DiMesio accepted for AppDB Improvements
by Austin English May 8, 2017

May 8, 2017

Howdy all, Please welcome me in congratulating Roseanne on being accepted for Outreachy. She will be working on improving the AppDB (which greatly needs it), and is being mentored by Jeremy Newman. Congrats Rosanne! -- -Austin GPG: 14FB D7EA A041 937B

4 3

Re: [PATCH 2/6] wined3d: Disable EXT_TEXTURE_LOD_BIAS on core profile.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > glTexEnvf(..., GL_TEXTURE_LOD_BIAS, ...) is not available in core profile. > Just disable the extension for now. > Is the extension advertised on core profiles then?

2 3

Re: [PATCH 4/6] wined3d: Disable YUV formats when fixups are not supported.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -5192,8 +5193,19 @@ static BOOL wined3d_check_surface_capability(const struct wined3d_format *format > > if (format->glInternal) > { > - TRACE("[OK]\n"); > - return TRUE; > + switch (format->id) > + { > + case WINED3DFMT_YUY2: > + case WINED3DFMT_UYVY: > + case WINED3DFMT_YV12: > + case WINED3DFMT_NV12: > + TRACE("%s\n", gl_info->supported[ARB_FRAGMENT_PROGRAM] > + ? "[OK]" : "[FAILED] - No YUV fixups support."); > + return gl_info->supported[ARB_FRAGMENT_PROGRAM]; > + default: > + TRACE("[OK]\n"); > + return TRUE; > + } Generally speaking, we've been moving away from this kind of "list some formats somewhere" approach. If we really have to disable these formats, I'd argue apply_format_fixups() would be the correct place, since creating the surfaces should probably also fail then. There's also an argument that the CPU blitter should be able to handle these though.

1 0

Re: [PATCH 3/6] wined3d: Disable ARB program extensions on core profile.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > None of the ARBfp shader backend, fragment pipe replacement or blitter > are currently in working condition in core profiles (nor they are > expected to be in the foreseeable future). > Sure, but you can just check for WINED3D_GL_LEGACY_CONTEXT in e.g. wined3d_arbfp_blitter_create(). (And arguably, the shader backend and fragment pipe cases can't even happen unless you took extra steps to break your setup.)

1 0

Re: [PATCH 4/6] wined3d: Disable YUV formats when fixups are not supported.
by Stefan Dösinger May 8, 2017

May 8, 2017

> Am 07.05.2017 um 20:32 schrieb Matteo Bruni <mbruni(a)codeweavers.com>: > > + switch (format->id) > + { > + case WINED3DFMT_YUY2: > + case WINED3DFMT_UYVY: > + case WINED3DFMT_YV12: > + case WINED3DFMT_NV12: > + TRACE("%s\n", gl_info->supported[ARB_FRAGMENT_PROGRAM] > + ? "[OK]" : "[FAILED] - No YUV fixups support."); > + return gl_info->supported[ARB_FRAGMENT_PROGRAM]; Once upon a time blitting YUY2 and UYVY via regular 3D draws worked with GL_APPLE_ycbcr_422, and afaics the necessary format definitions are still in place.

1 0

Re: [PATCH] msi: Add MsiGetPatchFileListA/W stubs.
by Hans Leidekker May 8, 2017

May 8, 2017

On Mon, 2017-05-08 at 00:47 +0300, Andrey Gusev wrote: > +UINT WINAPI MsiGetPatchFileListA(LPCSTR szProductCode, LPCSTR szPatchList, > + LPDWORD pcFiles, MSIHANDLE **pphFileRecords) > +{ > + FIXME("(%s, %s, %p, %p) stub!\n", debugstr_a(szProductCode), > + debugstr_a(szPatchList), pcFiles, pphFileRecords); > + return ERROR_SUCCESS; You should set the output parameters to sensible values, or return an error.

1 0

Re: [PATCH v2 5/6] wined3d: Fix specular lighting calculation.
by Marvin May 7, 2017

May 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30826 Your paranoid android. === w1064 (32 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00008080 for quad 2 (different colors). === w1064 (64 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH] user32: Removed 16-bit windows position trunc in WINPOS_SetPlacement.
by Alexandre Julliard May 6, 2017

May 6, 2017

Kees Beets <kbeets68(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38231 > > Replaced SetWindowPos in WINPOS_SetPlacement with an implementation that > does not truncate windows positions to 16-bit. Fixes a bug in Adobe > Lightroom under wine that is not present under windows (7, 8, 10), > while still running all win tests successfully. It's good that it doesn't break the other tests, but since we currently don't have tests for SetWindowPlacement, that's not very convincing. You'd want to add some tests at least for the truncation thing, and also probably some for the message sequences. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcp90: Call invalid_parameter_handler on index out of range in basic_string::operator[]
by Piotr Caban May 5, 2017

May 5, 2017

On 05/05/17 19:01, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/msvcp90/string.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) Please ignore this patch for now. Thanks, Piotr

1 0

Re: [PATCH] wined3d: Add NVIDIA GTX 1080 Ti to the GPU list
by Henri Verbeet May 5, 2017

May 5, 2017

On 4 May 2017 at 22:53, Björn Bidar <theodorstormgrade(a)googlemail.com> wrote: DRIVER_NVIDIA_GEFORCE8, 8192}, > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX1080TI, "NVIDIA GeForce GTX 1080 Ti", DRIVER_NVIDIA_GEFORCE8, 11169}, That's an unusual amount of memory, should that be 11264?

1 0

Re: [PATCH 04/10] d3dx9/tests: Use compare_float() in test_D3DXSHEvalSphericalLight().
by Alexandre Julliard May 4, 2017

May 4, 2017

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/d3dx9_36/tests/math.c | 171 ++++++++++++++++++++++++--------------------- > 1 file changed, 92 insertions(+), 79 deletions(-) This one is failing here: ../../../tools/runtest -q -P wine -T ../../.. -M d3dx9_36.dll -p d3dx9_36_test.exe.so math && touch math.ok math.c:3194: Test failed: Red: case 1, order 5: expected[20] = 5.29080920e-04, received 5.29033889e-04. math.c:3205: Test failed: Green: case 1, order 5: expected[20] = 8.09182529e-04, received 8.09110585e-04. math.c:3217: Test failed: Blue: case 1, order 5: expected[20] = 1.08928420e-03, received 1.08918734e-03. math.c:3194: Test failed: Red: case 1, order 6: expected[20] = 5.29080920e-04, received 5.29033889e-04. math.c:3205: Test failed: Green: case 1, order 6: expected[20] = 8.09182529e-04, received 8.09110585e-04. math.c:3217: Test failed: Blue: case 1, order 6: expected[20] = 1.08928420e-03, received 1.08918734e-03. math.c:3194: Test failed: Red: case 2, order 5: expected[20] = -7.14543217e-04, received -7.14479480e-04. math.c:3217: Test failed: Blue: case 2, order 5: expected[20] = -1.47111830e-03, received -1.47098722e-03. math.c:3194: Test failed: Red: case 2, order 6: expected[20] = -7.14543217e-04, received -7.14479480e-04. math.c:3217: Test failed: Blue: case 2, order 6: expected[20] = -1.47111830e-03, received -1.47098722e-03. Makefile:340: recipe for target 'math.ok' failed make[1]: *** [math.ok] Error 10 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 4/5] d3dx9: Do not set active pass if BeginPass() failed.
by Matteo Bruni May 4, 2017

May 4, 2017

2017-05-04 0:33 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > if (technique && pass < technique->pass_count && !effect->active_pass) > { > + HRESULT hr; > + > effect->active_pass = &technique->passes[pass]; > memset(effect->current_light, 0, sizeof(effect->current_light)); > memset(&effect->current_material, 0, sizeof(effect->current_material)); > - return d3dx9_apply_pass_states(effect, effect->active_pass, TRUE); > + hr = d3dx9_apply_pass_states(effect, effect->active_pass, TRUE); > + if (FAILED(hr)) > + effect->active_pass = NULL; > + return hr; > } Can't you just set active_pass only if d3dx9_apply_pass_states() succeeds, instead?

2 1

Re: dmusic/tests: Add some IDirectMusic_SetDirectSound() tests.
by Marvin May 4, 2017

May 4, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30792 Your paranoid android. === wvistau64 (32 bit dmusic) === dmusic.c:143: Test failed: DirectSoundCreate failed: 88780078 00c4:dmusic: unhandled exception c0000005 at 73C598FB

1 0

Re: [PATCH 04/10] d3dx9/tests: Use compare_float() in test_D3DXSHEvalSphericalLight().
by Matteo Bruni May 4, 2017

May 4, 2017

2017-05-04 12:05 GMT+02:00 Henri Verbeet <hverbeet(a)codeweavers.com>: > - ok(relative_error(expected, test[l].red_received[j]) < 0.0005f, > - "Red: case %u, order %u: expected[%u] = %f, received %f\n", l, order, j, expected, test[l].red_received[j]); > + equal = compare_float(expected, test[l].red_received[j], 512); > + ok(equal || (fabs(expected) < 1.0e-6f && fabs(test[l].red_received[j]) < 1.0e-6f), > + "Red: case %u, order %u: expected[%u] = %.8e, received %.8e.\n", > + l, order, j, expected, test[l].red_received[j]); I guess those are mostly to make our implementation pass the test. Did you have a look at it by any chance?

2 1

Re: [PATCH] d3dx9: Return shader functions in d3dx9_base_effect_get_pass_desc().
by Marvin May 4, 2017

May 4, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30788 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [v4 PATCH 1/4] mfplat: Implement MFTRegister
by Alexandre Julliard May 4, 2017

May 4, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + if (cinput && input_types) > + { > + size = cinput * sizeof(MFT_REGISTER_TYPE_INFO); > + types = HeapAlloc(GetProcessHeap(), 0, size); > + if (!types) goto err; > + > + memcpy(types, input_types, size); > + > + ret = RegSetValueExW(hclsid, inputtypesW, 0, REG_BINARY, (BYTE *)types, size); > + HeapFree(GetProcessHeap(), 0, types); Why do you need to make a copy? > + if (coutput && output_types) > + { > + size = cinput * sizeof(MFT_REGISTER_TYPE_INFO); I'm guessing you want coutput here. -- Alexandre Julliard julliard(a)winehq.org

1 0

pulse/alsa option in wine cfg audio tab
by CARLOS RODRIGUEZ May 4, 2017

May 4, 2017

>Are there bugs reported for those?>Yeah has been reported sometime agohttps://bugs.winehq.org/show_bug.cgi?id=41147

1 0

Re: [v2 5/5] d3dx9: Match native out of bounds array selector index handling.
by Paul Gofman May 4, 2017

May 4, 2017

Sorry, please ignore this last patch in the series. I found it is not correct for some cases and I will come up with more tests and corrected version separately. On 05/04/2017 01:33 AM, Paul Gofman wrote: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/effect.c | 25 ++++++++++++++++--------- > dlls/d3dx9_36/tests/effect.c | 17 ++++++----------- > 2 files changed, 22 insertions(+), 20 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 1ecd32e..a3511c8 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -1056,7 +1056,7 @@ static HRESULT d3dx9_base_effect_get_pass_desc(struct d3dx9_base_effect *base, > BOOL param_dirty; > > if (FAILED(hr = d3dx9_get_param_value_ptr(pass, &pass->states[i], &param_value, &param, > - TRUE, &param_dirty))) > + FALSE, &param_dirty))) > return hr; > > if (!param->object_id) > @@ -2647,7 +2647,9 @@ static HRESULT d3dx9_get_param_value_ptr(struct d3dx_pass *pass, struct d3dx_sta > FIXME("Preshader structure is null.\n"); > return D3DERR_INVALIDCALL; > } > - if (update_all || is_param_eval_input_dirty(param->param_eval)) > + /* According to the tests, native d3dx handles the case of array index evaluated to -1 > + * in a specific way. */ > + if (is_param_eval_input_dirty(param->param_eval) || state->index == 0xffffffffu) > { > if (FAILED(hr = d3dx_evaluate_parameter(param->param_eval, &array_idx_param, > &array_idx, update_all))) > @@ -2660,6 +2662,11 @@ static HRESULT d3dx9_get_param_value_ptr(struct d3dx_pass *pass, struct d3dx_sta > ref_param = param->referenced_param; > TRACE("Array index %u, stored array index %u, element_count %u.\n", array_idx, state->index, > ref_param->element_count); > + if (array_idx == 0xffffffffu) > + { > + WARN("Array index is -1, setting to 0.\n"); > + array_idx = 0; > + } > > if (array_idx >= ref_param->element_count) > { > @@ -2920,13 +2927,11 @@ static HRESULT d3dx9_apply_state(struct ID3DXEffectImpl *effect, struct d3dx_pas > if (FAILED(hr = d3dx9_get_param_value_ptr(pass, state, &param_value, &param, > update_all, &param_dirty))) > { > - if (hr == E_FAIL) > + if (!update_all && hr == E_FAIL) > { > - /* Native d3dx9 returns D3D_OK from BeginPass or Commit involving > + /* Native d3dx9 returns D3D_OK from Commit involving > * out of bounds array access and does not touch the affected > - * state, except for BeginPass when the out of bounds array index > - * depends on dirty parameters. The latter case is supposed to > - * return E_FAIL but is currently TODO. */ > + * state. */ > WARN("Returning D3D_OK on out of bounds array access.\n"); > return D3D_OK; > } > @@ -6101,6 +6106,7 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > if (FAILED(hr = d3dx9_copy_data(base, param->object_id, ptr))) > return hr; > hr = d3dx9_parse_array_selector(base, param); > + state->index = 0xffffffffu; > break; > > default: > @@ -6226,10 +6232,11 @@ static HRESULT d3dx9_parse_effect(struct d3dx9_base_effect *base, const char *da > > for (i = 0; i < base->parameter_count; ++i) > { > - if (FAILED(hr = d3dx_pool_sync_shared_parameter(base->pool, &base->parameters[i]))) > - goto err_out; > walk_parameter_tree(&base->parameters[i], param_set_top_level_param, > &base->parameters[i]); > + set_dirty(&base->parameters[i]); > + if (FAILED(hr = d3dx_pool_sync_shared_parameter(base->pool, &base->parameters[i]))) > + goto err_out; > } > return D3D_OK; > > diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c > index 7f7487e..c6713af 100644 > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -4658,14 +4658,12 @@ static void test_effect_out_of_bounds_selector(IDirect3DDevice9 *device) > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > hr = effect->lpVtbl->BeginPass(effect, 1); > - todo_wine ok(hr == E_FAIL, "Got result %#x.\n", hr); > - if (SUCCEEDED(hr)) > - effect->lpVtbl->EndPass(effect); > + ok(hr == E_FAIL, "Got result %#x.\n", hr); > > hr = effect->lpVtbl->BeginPass(effect, 1); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > - test_effect_preshader_compare_shader(device, 2, TRUE); > + test_effect_preshader_compare_shader(device, 2, FALSE); > > hr = effect->lpVtbl->EndPass(effect); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > @@ -4678,9 +4676,7 @@ static void test_effect_out_of_bounds_selector(IDirect3DDevice9 *device) > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > hr = effect->lpVtbl->BeginPass(effect, 1); > - todo_wine ok(hr == E_FAIL, "Got result %#x.\n", hr); > - if (SUCCEEDED(hr)) > - hr = effect->lpVtbl->EndPass(effect); > + ok(hr == E_FAIL, "Got result %#x.\n", hr); > > hr = IDirect3DDevice9_GetVertexShader(device, &vshader); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > @@ -4689,7 +4685,7 @@ static void test_effect_out_of_bounds_selector(IDirect3DDevice9 *device) > hr = effect->lpVtbl->BeginPass(effect, 1); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > - test_effect_preshader_compare_shader(device, 2, TRUE); > + test_effect_preshader_compare_shader(device, 2, FALSE); > > hr = effect->lpVtbl->EndPass(effect); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > @@ -4701,7 +4697,7 @@ static void test_effect_out_of_bounds_selector(IDirect3DDevice9 *device) > hr = effect->lpVtbl->BeginPass(effect, 1); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > - test_effect_preshader_compare_shader(device, 0, TRUE); > + test_effect_preshader_compare_shader(device, 0, FALSE); > > hr = IDirect3DDevice9_SetVertexShader(device, NULL); > ok(hr == D3D_OK, "Got result %#x.\n", hr); > @@ -6266,10 +6262,9 @@ static void test_effect_get_pass_desc(IDirect3DDevice9 *device) > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > hr = effect->lpVtbl->GetPassDesc(effect, pass, &desc); > - todo_wine > ok(hr == D3D_OK, "Got result %#x.\n", hr); > > - test_effect_preshader_compare_shader_bytecode(desc.pVertexShaderFunction, 0, 0, TRUE); > + test_effect_preshader_compare_shader_bytecode(desc.pVertexShaderFunction, 0, 0, FALSE); > > fvect.z = 2.0f; > hr = effect->lpVtbl->SetVector(effect, "g_iVect", &fvect);

1 0

Re: [PATCH] comctl32/tests: Add tests for mouse right-click in a treeview control
by Alexandre Julliard May 4, 2017

May 4, 2017

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From: Hugh McMaster <hugh.mcmaster(a)outlook.com> > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/comctl32/tests/treeview.c | 77 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) This fails here: ../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so treeview && touch treeview.ok treeview.c:2653: Test failed: right click sequence: the msg sequence is not complete: expected 0000 - actual 000f treeview.c:2654: Test failed: parent right click sequence: the msg sequence is not complete: expected 0000 - actual 004e Makefile:968: recipe for target 'treeview.ok' failed make[1]: *** [treeview.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] d3dx9: Match native out of bounds array selector index handling.
by Marvin May 3, 2017

May 3, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30756 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH 3/4] d3dx9: Do not set active pass if BeginPass() failed.
by Marvin May 3, 2017

May 3, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30755 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/4] d3dx9: Return shader functions in d3dx9_base_effect_get_pass_desc().
by Marvin May 3, 2017

May 3, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30754 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/4] d3dx9/tests: Add test for GetPassDesc() function.
by Marvin May 3, 2017

May 3, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30753 Your paranoid android. === build (build) === Make failed

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 3, 2017

May 3, 2017

Hi Could be possible add native fps overlay, maybe can usefull for many apps and without forget steam overlay give performance issues in certain apps (steam overlay dont work since wine 2.6) Thanks

3 2

pulse/alsa option in wine cfg audio tab
by CARLOS RODRIGUEZ May 3, 2017

May 3, 2017

Hi Seeking donat enikeev patch for add csmt option to graphics tab Could be possible add option for select which audio driver can be used aka alsa o pulse in winecfg audio tab ? Because various apps still needed alsa case tales of zestiria, alan wake and many others Thanks

2 1

Re: [PATCH 01/10] d3dx9/tests: Use compare_float() in D3DXFresnelTest().
by Alexandre Julliard May 3, 2017

May 3, 2017

Matteo Bruni <mbruni(a)codeweavers.com> writes: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Could you please try to send the signoff mail as a reply to the original patch, instead of a reply to your previous signoff? This way the tracker can find the appropriate patch automatically. Thanks. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/5] wsdapi: Implement WSD LinkedMemory functions [try 4]
by Alexandre Julliard May 3, 2017

May 3, 2017

Owen Rudge <orudge(a)codeweavers.com> writes: > + ptr = HeapAlloc(procHeap, HEAP_ZERO_MEMORY, MEMORY_ALLOCATION_SIZE + cbSize); Are all allocations supposed to be zeroed? This is a little surprising, it would need a test too. > + > + srand((unsigned)time(NULL)); Please don't do that, test results need to be reproducible. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 3, 2017

May 3, 2017

> >> I've not tested the version, but recent commit 45a632ee81c9c5c58309426de5aadbd8dbbba0f5 >> introduces SYS_mmap2 system call which doesn't exist before 2.3.31. >> So, should we update the requirement? Is 2.3.31 valid enough? > >I'm not sure that we know what the minimum version is these days. If >mmap2 is really the only new dependency, adding a workaround is easy >enough. Is anybody able to test this? > >-- >Alexandre Julliard >julliard(a)winehq.org > Hmmm, no answers... It seems to me like crazy project, which nobody on Earth would ever undergo. To promote it from crazy to totally insane I could give a drive to one of my oldies. Like - 486DX - 386DX + 387 / 32MB RAM - 386DX / 4MB RAM with ISA Trident 512KB (no 386SX / 486SX;) just to see, how deep we can sink with those old ships :-)) I would let Pentium and Pentium MMX docked for being too modern. So when testing old kernels (Debian distributions) – If that ever compile what else could be interesting? GCC version? Libc version? X version? How to interpret successful test - compilation? (pre-compiled in VM) - Running winecfg?? - Running MS Paint???

3 3

Re: [PATCH resend] comctl32: When adding a scrollbar to a listview, update the other one.
by Nikolay Sivov May 3, 2017

May 3, 2017

On 03.05.2017 7:53, Alex Henrie wrote: > Cc: Nikolay Sivov <nsivov(a)codeweavers.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=35529 > > Adding a vertical scrollbar can necessitate adding a horizontal > scrollbar just as easily as adding a horizontal scrollbar can > necessitate adding a vertical scrollbar. (And in the same way, removing > either of the scrollbars can necessitate removing the other scrollbar.) > > This patch was previously assigned to Nikolay, but I never received any > feedback about it. Sorry about that. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/comctl32/listview.c | 78 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 50 insertions(+), 28 deletions(-) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index c01d816c46..c3c89d08dc 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -2016,23 +2016,10 @@ static void LISTVIEW_UpdateHeaderSize(const LISTVIEW_INFO *infoPtr, INT nNewScro > SWP_NOZORDER | SWP_NOACTIVATE); > } > > -/*** > - * DESCRIPTION: > - * Update the scrollbars. This functions should be called whenever > - * the content, size or view changes. > - * > - * PARAMETER(S): > - * [I] infoPtr : valid pointer to the listview structure > - * > - * RETURN: > - * None > - */ > -static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > +static INT LISTVIEW_UpdateHScroll(LISTVIEW_INFO *infoPtr) > { > - SCROLLINFO horzInfo, vertInfo; > - INT dx, dy; > - > - if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + SCROLLINFO horzInfo; > + INT dx; > > ZeroMemory(&horzInfo, sizeof(SCROLLINFO)); > horzInfo.cbSize = sizeof(SCROLLINFO); > @@ -2084,10 +2071,22 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > dx -= SetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo, TRUE); > TRACE("horzInfo=%s\n", debugscrollinfo(&horzInfo)); > > - /* Setting the horizontal scroll can change the listview size > - * (and potentially everything else) so we need to recompute > - * everything again for the vertical scroll > - */ > + /* Update the Header Control */ > + if (infoPtr->hwndHeader) > + { > + horzInfo.fMask = SIF_POS; > + GetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo); > + LISTVIEW_UpdateHeaderSize(infoPtr, horzInfo.nPos); > + } > + > + LISTVIEW_UpdateSize(infoPtr); > + return dx; > +} > + > +static INT LISTVIEW_UpdateVScroll(LISTVIEW_INFO *infoPtr) > +{ > + SCROLLINFO vertInfo; > + INT dy; > > ZeroMemory(&vertInfo, sizeof(SCROLLINFO)); > vertInfo.cbSize = sizeof(SCROLLINFO); > @@ -2117,6 +2116,37 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > dy -= SetScrollInfo(infoPtr->hwndSelf, SB_VERT, &vertInfo, TRUE); > TRACE("vertInfo=%s\n", debugscrollinfo(&vertInfo)); > > + LISTVIEW_UpdateSize(infoPtr); > + return dy; > +} > + > +/*** > + * DESCRIPTION: > + * Update the scrollbars. This function should be called whenever > + * the content, size or view changes. > + * > + * PARAMETER(S): > + * [I] infoPtr : valid pointer to the listview structure > + * > + * RETURN: > + * None > + */ > +static void LISTVIEW_UpdateScroll(LISTVIEW_INFO *infoPtr) > +{ > + INT dx, dy; > + > + if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + > + /* Setting the horizontal scroll can change the listview size > + * (and potentially everything else) so we need to recompute > + * everything again for the vertical scroll and vice-versa > + */ > + > + dx = LISTVIEW_UpdateHScroll(infoPtr); > + dy = LISTVIEW_UpdateVScroll(infoPtr); > + dx += LISTVIEW_UpdateHScroll(infoPtr); > + dy += LISTVIEW_UpdateVScroll(infoPtr); > + This certainly doesn't look pretty, but I see what you mean. I'll take a look, thanks for reminding me. > /* Change of the range may have changed the scroll pos. If so move the content */ > if (dx != 0 || dy != 0) > { > @@ -2125,14 +2155,6 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > ScrollWindowEx(infoPtr->hwndSelf, dx, dy, &listRect, &listRect, 0, 0, > SW_ERASE | SW_INVALIDATE); > } > - > - /* Update the Header Control */ > - if (infoPtr->hwndHeader) > - { > - horzInfo.fMask = SIF_POS; > - GetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo); > - LISTVIEW_UpdateHeaderSize(infoPtr, horzInfo.nPos); > - } > } > > >

1 0

Re: [2/4] ole32: Implement DataCache_InitCache
by Huw Davies May 3, 2017

May 3, 2017

On Tue, May 02, 2017 at 06:11:22PM +0800, Wei Xie wrote: > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index 441a874..51a67e2 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -2052,8 +2052,45 @@ static HRESULT WINAPI DataCache_InitCache( > IOleCache2* iface, > IDataObject* pDataObject) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + HRESULT hr; > + FORMATETC fmt; > + STGMEDIUM med; > + > + FIXME("semi-stub\n"); > + > + hr = IDataObject_GetData(pDataObject, &fmt, &med); > + if (FAILED(hr)) > + { > + return CACHE_E_NOCACHE_UPDATED; > + } > + > + if (!fmt.cfFormat || !fmt.tymed || > + (check_valid_clipformat_and_tymed(fmt.cfFormat, fmt.tymed, FALSE) > + && TYMED_NULL != med.tymed)) > + { > + switch(med.tymed) > + { > + case TYMED_GDI: > + { > + fmt.cfFormat = CF_BITMAP; > + fmt.ptd = NULL; > + fmt.dwAspect = DVASPECT_CONTENT; > + fmt.lindex = -1; > + fmt.tymed = TYMED_GDI; > + } > + break; > + default: > + FIXME("Fill formatetc\n"); > + } > + } > + > + hr = IOleCache2_SetData(iface, &fmt, &med, FALSE); > + if (FAILED(hr)) > + { > + return CACHE_E_NOCACHE_UPDATED; > + } > + > + return hr; > } This isn't correct. What I think the tests will show you is that it looks something like the pseudo-code: for_each_cached_format( &fmt ) /* some function that returns the fmt of each cache entry */ { IDataObject_GetData(pDataObject, &fmt, &med); IOleCache2_SetData(iface, &fmt, &med); } Of course there needs to be error handling, tests if the cache has already been initialized, etc. However for now I suggest you just concerntrate on getting the tests in, and come back to this and the subsequent patches later on. Huw.

1 0

Re: [1/4] ole32/test: Add InitCache test
by Huw Davies May 3, 2017

May 3, 2017

On Tue, May 02, 2017 at 06:10:44PM +0800, Wei Xie wrote: > From 4f8b94b5a8c7739901eae8f19317ca6255911d20 Mon Sep 17 00:00:00 2001 > From: Wei xie <xiewei(a)linuxdeepin.com> > Date: Tue, 2 May 2017 18:07:22 +0800 > Subject: [PATCH 1/4] ole32/test: Add InitCache test ole32/test: -> ole32/tests: > +static HRESULT WINAPI DataObject2_QueryInterface( > + IDataObject* iface, > + REFIID riid, > + void** ppvObject) > +{ > + CHECK_EXPECTED_METHOD("DataObject2_QueryInterface"); > + > + if (IsEqualIID(riid, &IID_IDataObject) || IsEqualIID(riid, &IID_IUnknown)) > + { > + *ppvObject = iface; > + return S_OK; > + } > + *ppvObject = NULL; > + return S_OK; > +} There's no need to create a new IDataObject implementation. Use the existing one and add a file-scope variable to control what _GetData does (which is all you really care about for this test). > +static HRESULT WINAPI DataObject2_GetData( > + IDataObject* iface, > + LPFORMATETC pformatetcIn, > + STGMEDIUM* pmedium) > +{ > + *pformatetcIn = FormatEtc; > + *pmedium = StgMedium; > + return S_OK; > +} You're not checking this method is called, which should be one of the goals of this test! pfomratetcIn is an [in] variable, so assigning things to it is useless. > @@ -1838,10 +1994,23 @@ todo_wine { > > DeleteDC(hdcMem); > > - todo_wine { You remove a todo_wine here and yet this patch doesn't change Wine's implementation, so this will produce a failure. The test must run cleanly on Wine (and Windows) after just this patch is applied. If you fix the implementation later on in the series, then remove the todo_wine in that patch, not this one. > + /* IDataObject_GetData Invalid */ I don't understand how this comment relates to the code. > hr = IOleCache2_InitCache(pOleCache, &DataObject); > ok(hr == CACHE_E_NOCACHE_UPDATED, "IOleCache_InitCache should have returned CACHE_E_NOCACHE_UPDATED instead of 0x%08x\n", hr); > - } > + > + fmtetc.ptd = NULL; > + fmtetc.dwAspect = DVASPECT_CONTENT; > + fmtetc.lindex = -1; > + fmtetc.cfFormat = CF_BITMAP; > + fmtetc.tymed = TYMED_GDI; > + stgmedium.tymed = TYMED_GDI; > + stgmedium.hBitmap = CreateCompatibleBitmap(hdcMem, 100, 100); > + stgmedium.pUnkForRelease = NULL; > + IDataObject_SetData(&DataObject2, &fmtetc, &stgmedium, FALSE); > + > + /* IOleCache2_InitCache not need IOleCache2_Cache first */ > + hr = IOleCache2_InitCache(pOleCache, &DataObject2); > + ok(hr == CACHE_E_NOCACHE_UPDATED, "IOleCache2_InitCache should have returned CACHE_E_NOCACHE_UPDATED instead of 0x%08x\n", hr); Why is the hunk even necessary, you're just calling InitCache again below a test that shows it fails. > > IPersistStorage_Release(pPS); > IViewObject_Release(pViewObject); > @@ -1851,6 +2020,44 @@ todo_wine { > CHECK_NO_EXTRA_METHODS(); > } > > + hdcMem = CreateCompatibleDC(NULL); > + fmtetc.ptd = NULL; > + fmtetc.dwAspect = DVASPECT_CONTENT; > + fmtetc.lindex = -1; > + fmtetc.cfFormat = CF_BITMAP; > + fmtetc.tymed = TYMED_GDI; > + stgmedium.tymed = TYMED_GDI; > + stgmedium.hBitmap = CreateCompatibleBitmap(hdcMem, 100, 100); > + stgmedium.pUnkForRelease = NULL; > + IDataObject_SetData(&DataObject2, &fmtetc, &stgmedium, FALSE); > + > + expected_method_list = methods_cacheinit; > + > + hr = CreateDataCache(NULL, &CLSID_NULL, &IID_IOleCache2, (LPVOID *)&pOleCache); > + ok_ole_success(hr, "CreateDataCache"); > + > + hr = IOleCache2_QueryInterface(pOleCache, &IID_IViewObject2, (LPVOID *)&pViewObject2); > + ok_ole_success(hr, "IOleCache_QueryInterface(IID_IViewObject2)"); > + > + hr = IOleCache2_Cache(pOleCache, &fmtetc, 0, &dwConnection); > + ok_ole_success(hr, "IOleCache2_Cache"); > + hr = IOleCache2_InitCache(pOleCache, &DataObject2); > + ok_ole_success(hr, "IOleCache2_InitCache"); > + > + hr = IViewObject2_SetAdvise(pViewObject2, DVASPECT_CONTENT, ADVF_PRIMEFIRST, &AdviseSink); > + ok_ole_success(hr, "IViewObject2_SetAdvise"); > + > + hr = IViewObject2_GetExtent(pViewObject2, DVASPECT_CONTENT, -1, NULL, &sz ); > + ok_ole_success(hr, "IViewObject2_GetExtent"); > + > + hr = IViewObject2_Draw(pViewObject2, DVASPECT_CONTENT, -1, NULL, NULL, NULL, hdcMem, &rcBounds, NULL, draw_continue, 0xdeadbeef); > + ok_ole_success(hr, "IViewObject2_GetExtent"); > + > + IViewObject2_Release(pViewObject2); > + IOleCache2_Release(pOleCache); > + > + DeleteDC(hdcMem); For this bit of the test, drop the IViewObject calls. What we care about is testing InitCache(). Then I suggest calling _Cache twice with two different formats and checking that _InitCache calls DataObject_GetData for those two formats. You'll need to make DataObject_GetData respond to these two different formats. It's a bit more complicated than that however because in the CF_BITMAP case _InitCache apparently calls _GetData with CF_DIB (this is part of the cache's ability to use dibs instead of bitmaps and vice-versa). You may want to avoid using CF_BITMAP to test this at this stage (we can add CF_BITMAP <-> CF_DIB tests later). Huw.

1 0

Re: [PATCH resend] comctl32: When adding a scrollbar to a listview, update the other one.
by Alistair Leslie-Hughes May 3, 2017

May 3, 2017

Hi Alex, On 03/05/17 14:53, Alex Henrie wrote: > Cc: Nikolay Sivov <nsivov(a)codeweavers.com> > +static void LISTVIEW_UpdateScroll(LISTVIEW_INFO *infoPtr) > +{ > + INT dx, dy; > + > + if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + > + /* Setting the horizontal scroll can change the listview size > + * (and potentially everything else) so we need to recompute > + * everything again for the vertical scroll and vice-versa > + */ > + > + dx = LISTVIEW_UpdateHScroll(infoPtr); > + dy = LISTVIEW_UpdateVScroll(infoPtr); > + dx += LISTVIEW_UpdateHScroll(infoPtr); > + dy += LISTVIEW_UpdateVScroll(infoPtr); > + Is there any reason your calling update twice for each control? Best Regards Alistair Leslie-Hughes

2 1

Re: [PATCH resend] comctl32: When adding a scrollbar to a listview, update the other one.
by Alistair Leslie-Hughes May 3, 2017

May 3, 2017

Hi Alex, On 03/05/17 14:53, Alex Henrie wrote: > Cc: Nikolay Sivov <nsivov(a)codeweavers.com> > +static void LISTVIEW_UpdateScroll(LISTVIEW_INFO *infoPtr) > +{ > + INT dx, dy; > + > + if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + > + /* Setting the horizontal scroll can change the listview size > + * (and potentially everything else) so we need to recompute > + * everything again for the vertical scroll and vice-versa > + */ > + > + dx = LISTVIEW_UpdateHScroll(infoPtr); > + dy = LISTVIEW_UpdateVScroll(infoPtr); > + dx += LISTVIEW_UpdateHScroll(infoPtr); > + dy += LISTVIEW_UpdateVScroll(infoPtr); > + Is there any reason your calling update twice for each control? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH v3 4/6] user32: Fix the calculation of system metrics icon sizes.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30726 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w1064 (32 bit sysparams) === sysparams.c:206: Test failed: Unexpected WM_DISPLAYCHANGE message sysparams.c:206: Test failed: Unexpected WM_DISPLAYCHANGE message

2 1

Re: [PATCH v3 6/6] user32: Change IsProcessDPIAware() to always return TRUE.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30727 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH v2 6/6] user32: Change IsProcessDPIAware() to always return TRUE.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30723 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w1064 (32 bit sysparams) === sysparams.c:206: Test failed: Unexpected WM_DISPLAYCHANGE message

1 0

Re: [PATCH v2 2/2] ddraw: Validate that non-fill blits have a source surface in ddraw_surface7_Blt().
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30715 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:1686: Test failed: Got unexpected color 0x000000ff.

1 0

Re: [PATCH v2 4/6] user32: Fix the calculation of system metrics icon sizes.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30722 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 4/6] user32: Fix the calculation of system metrics icon sizes.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30703 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20 === wvistau64 (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w7u (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 6 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 6 === w8 (32 bit sysparams) === sysparams.c:2517: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 === w1064 (32 bit sysparams) === sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message sysparams.c:2523: Test failed: WM_DISPLAYCHANGE was sent with wParam 32 despite mode change failure sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 === wvistau64 (64 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w1064 (64 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16

2 1

Re: [PATCH 6/6] user32: Change IsProcessDPIAware() to always return TRUE.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30704 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20 === wvistau64 (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w7u (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 6 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 6 === w8 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0 === w1064 (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0 === wvistau64 (64 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w1064 (64 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0

1 0

Re: [PATCH 2/5] ddraw: Validate that non-fill blits have a source surface in ddraw_surface7_Blt().
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30698 Your paranoid android. === wxppro (32 bit ddraw4) === 0a24:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CE7A === wvistau64 (32 bit ddraw4) === 0970:ddraw4: unhandled exception c0000005 at 0049CE7A === w2008s64 (32 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 0049CE7F === w7u (32 bit ddraw4) === 0ca4:ddraw4: unhandled exception c0000005 at 0049CE7A === w7pro64 (32 bit ddraw4) === 00c0:ddraw4: unhandled exception c0000005 at 0049CE7F === wvistau64 (64 bit ddraw4) === 01b0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w2008s64 (64 bit ddraw4) === 08c4:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w7pro64 (64 bit ddraw4) === 07e0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (64 bit ddraw4) === 0fc8:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w1064 (64 bit ddraw4) === 0f3c:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (32 bit ddraw1) === ddraw1.c:10272: Test failed: Got unexpected color 0x00ffffff.

1 0

Re: [PATCH 1/5] ddraw/tests: Port test_texturemapblend() to ddraw4.c as well.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30697 Your paranoid android. === wxppro (32 bit ddraw4) === 09f8:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CB5A === wvistau64 (32 bit ddraw4) === 0744:ddraw4: unhandled exception c0000005 at 0049CB5A === w2008s64 (32 bit ddraw4) === 0bf4:ddraw4: unhandled exception c0000005 at 0049CB5F === w7u (32 bit ddraw4) === 0fbc:ddraw4: unhandled exception c0000005 at 0049CB5A === w7pro64 (32 bit ddraw4) === 0338:ddraw4: unhandled exception c0000005 at 0049CB5F === wvistau64 (64 bit ddraw4) === 072c:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w2008s64 (64 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w7pro64 (64 bit ddraw4) === 0854:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w864 (64 bit ddraw4) === 0fac:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w1064 (64 bit ddraw4) === 0c84:ddraw4: unhandled exception c0000005 at 00000000004863E2

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 2, 2017

May 2, 2017

Hi Almost forget maybe can improve WINEDEBUG=+fps for only display fps (actually gives priority to errors than fps information) Thanks

2 1

Re: [PATCH v3 1/2] mountmgr: Create devices and registry entries for serial ports.
by Bruno Jesus May 2, 2017

May 2, 2017

On Wed, Apr 26, 2017 at 12:18 AM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=11811 > > This patch also autodetects USB serial ports, making them "just work". > > The user may override the port autodetection by creating entries in > HKLM\Software\Wine\Ports. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Although I don't feel qualified to sign this patch I can say that I tested it with real hardware and it works fine for both real and USB serial ports in Linux. Hyper Terminal recognizes all ports without any manual registry workaround.

1 0

Re: [v3 PATCH 1/4] mfplat: Implement MFTRegister
by Alexandre Julliard May 1, 2017

May 1, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static HRESULT register_category(CLSID *clsid, GUID *category) > +{ > + HKEY hcategory, htmp1, htmp2; > + WCHAR buffer[64]; > + DWORD ret; > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, categories_keyW, &hcategory)) > + return E_FAIL; > + > + GUIDToString(buffer, category); > + ret = RegCreateKeyW(hcategory, buffer, &htmp1); > + RegCloseKey(hcategory); > + if (ret) return E_FAIL; You should create the entire path if needed instead of failing. > @@ -650,6 +650,10 @@ HKLM,Software\Borland\Database Engine\Settings\SYSTEM\INIT,SHAREDMEMLOCATION,,90 > HKLM,Software\Clients\Mail,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,"DLLPath",2,"%11%\winemapi.dll" > +HKLM,Software\Classes\MediaFoundation,,16 > +HKLM,Software\Classes\MediaFoundation\MediaSources,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms\Categories,,16 ...and then you no longer need this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regedit: Read registry lines through a single function
by Alexandre Julliard May 1, 2017

May 1, 2017

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > +static WCHAR *get_line(struct reg_info *reg_info) > +{ > + WCHAR *line; > + > + if (!reg_info->is_unicode) > + { > + char *lineA = get_lineA(reg_info->file); > + line = GetWideString(lineA); > + } > + else > + { > + line = get_lineW(reg_info->file); > + } > + > + return line; > +} That's fairly ugly. If you want to use common code, you should probably pass a function pointer for getting lines. Also you'd have to do it in a way that doesn't require freeing the buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: Do not call SendMessage() to show a window that is already visible.
by Dmitry Timoshkov May 1, 2017

May 1, 2017

Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index c2b35ec..64fdfe0 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -1239,6 +1239,9 @@ BOOL WINAPI ShowWindow( HWND hwnd, INT cmd ) > if ((cmd == SW_HIDE) && !(GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) > return FALSE; > > + if ((cmd == SW_SHOW) && (GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) > + return TRUE; > + > return SendMessageW( hwnd, WM_WINE_SHOWWINDOW, cmd, 0 ); > } Please have a look at the show_window() implementation and try to cover all cases that trigger SWP_SHOWWINDOW flag passed to SetWindowPos() in order to actually show a window. In fact it's only SW_HIDE that leads to that, so perhaps just adding an 'else' to the SW_HIDE case is enough? -- Dmitry.

2 1

Re: [1/5] wsdapi: Implement WSD LinkedMemory functions [try 3]
by Alexandre Julliard May 1, 2017

May 1, 2017

Owen Rudge <orudge(a)codeweavers.com> writes: > +struct memory_allocation > +{ > + int magic; > + struct list entry; > + > + struct list children; > +}; You'd probably want to preserve the heap block alignment. Some test cases would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 1, 2017

May 1, 2017

Gallium HUD provides various features but have same problem Only works in certain hardware and only on linux meanwhile if wine could provide native fps overlay must be works in all hardware and all type drivers (closed and opensource) and all operating system supported Thanks

1 0

Re: dmusic: Implement IDirectMusicBuffer::PackUnstructured().
by Henri Verbeet May 1, 2017

May 1, 2017

On 1 May 2017 at 02:05, Michael Stefaniuc <mstefani(a)winehq.org> wrote: > -static HRESULT WINAPI IDirectMusicBufferImpl_PackUnstructured(LPDIRECTMUSICBUFFER iface, REFERENCE_TIME rt, DWORD dwChannelGroup, DWORD cb, LPBYTE lpb) > +static HRESULT WINAPI IDirectMusicBufferImpl_PackUnstructured(IDirectMusicBuffer *iface, > + REFERENCE_TIME ref_time, DWORD channel_group, DWORD len, BYTE *data) > { > IDirectMusicBufferImpl *This = impl_from_IDirectMusicBuffer(iface); > + DWORD new_write_pos = This->write_pos + DMUS_EVENT_SIZE(len); > + DMUS_EVENTHEADER header; > + > + TRACE("(%p, 0x%s, %d, %d, %p)\n", This, wine_dbgstr_longlong(ref_time), channel_group, len, data); > > - FIXME("(%p, 0x%s, %d, %d, %p): stub\n", This, wine_dbgstr_longlong(rt), dwChannelGroup, cb, lpb); > + if (new_write_pos > This->size) > + return DMUS_E_BUFFER_FULL; > + > + if (!This->write_pos) > + This->start_time = ref_time; > + > + header.cbEvent = len; > + header.dwChannelGroup = channel_group; > + header.rtDelta = ref_time - This->start_time; > + header.dwFlags = 0; > + > + memcpy(This->data + This->write_pos, &header, sizeof(header)); > + memcpy(This->data + This->write_pos + sizeof(header), data, len); The difference is of course largely stylistic, but note that you could also do something like the following: DMUS_EVENTHEADER *header; ... header = (DMUS_EVENTHEADER *)&This->data[This->write_pos]; ... memcpy(&header[1], data, len);

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 1, 2017

May 1, 2017

Hi Yes +fps option works but not all time, many times wine gives priority to some errors messages than fps counter However native fps overlay will be better because overlay appears independent wine message errors Without forget will be better for new users but need to some option for enable in winecfg Thanks

2 1

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by Alexandre Julliard May 1, 2017

May 1, 2017

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > I've not tested the version, but recent commit 45a632ee81c9c5c58309426de5aadbd8dbbba0f5 > introduces SYS_mmap2 system call which doesn't exist before 2.3.31. > So, should we update the requirement? Is 2.3.31 valid enough? I'm not sure that we know what the minimum version is these days. If mmap2 is really the only new dependency, adding a workaround is easy enough. Is anybody able to test this? -- Alexandre Julliard julliard(a)winehq.org

1 0