May 2017 - Wine-Devel - list.winehq.org

Re: [3/7] wsdapi/tests: Add WSDCreateUdpAddress tests.
by Marvin May 30, 2017

May 30, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31265 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] msvcrt: Clean up registered C++ object in handler.
by Piotr Caban May 30, 2017

May 30, 2017

On 05/24/17 02:55, Daniel Lehman wrote: > +static DWORD cxx_catch_cleanup(EXCEPTION_RECORD *rec, EXCEPTION_REGISTRATION_RECORD *frame, > + CONTEXT *context, EXCEPTION_REGISTRATION_RECORD **pdispatcher) > +{ > + if (rec->ExceptionFlags & (EH_UNWINDING | EH_EXIT_UNWIND)) > + { > + thread_data_t *data = msvcrt_get_thread_data(); > + frame_info *cur; > + > + if (cxx_is_consolidate(rec)) Is this condition really needed? Shouldn't we clean the object no matter what's the reason of unwind? > + { > + rec = (void*)rec->ExceptionInformation[4]; > + > + for (cur = data->frame_info_head; cur; cur = cur->next) > + { > + if ((ULONG64)cur <= (ULONG64)frame) This condition is not working. It's making assumption about order of catch_frame and frame_info variables on stack while they are declared this way: > + EXCEPTION_REGISTRATION_RECORD catch_frame; > cxx_frame_info frame_info; Shouldn't the cxx_catch_cleanup just unregister the object that was registered in call_catch_block? Thanks, Piotr

1 1

Re: [PATCH] macdrv: Don't update clipboard if its content didn't change
by Ken Thomases May 30, 2017

May 30, 2017

On May 25, 2017, at 1:22 PM, Piotr Caban <piotr(a)codeweavers.com> wrote: > > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/winemac.drv/clipboard.c | 34 ++++++++++------------------------ > dlls/winemac.drv/cocoa_clipboard.m | 18 ++++++++++++++++++ > dlls/winemac.drv/macdrv_cocoa.h | 1 + > 3 files changed, 29 insertions(+), 24 deletions(-) > > +int macdrv_has_pasteboard_changed(void) > +{ > + __block int new_change_count; > + int ret; > + > + OnMainThread(^{ > + NSPasteboard* pb = [NSPasteboard generalPasteboard]; > + new_change_count = [pb changeCount]; > + }); > + > + ret = (change_count != new_change_count); > + change_count = new_change_count; > + return ret; > +} Unfortunately, -[NSPasteboard changeCount] isn't incremented for all changes to the pasteboard. For example, if the owner replaces the data for an existing type, it doesn't change. I'd have to check again, but I think it doesn't even change if the owner adds a new data type. I think it only changes when the pasteboard is cleared and rebuilt by -clearContents or -declareTypes:owner:. -Ken

2 5

Re: [PATCH 4/6] d3dx9: Evaluate condition if parameter can be directly copied during initialization.
by Matteo Bruni May 29, 2017

May 29, 2017

2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: The patch subject is a bit cumbersome IMO, what about "d3dx9: Add a direct copy path to set_constants()."?

2 2

Re: [PATCH 3/6] d3dx9: Factor out param_type_to_table_type() function.
by Matteo Bruni May 29, 2017

May 29, 2017

2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 262b7c1..bddd74f 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -193,7 +193,8 @@ enum pres_value_type > PRES_VT_FLOAT, > PRES_VT_DOUBLE, > PRES_VT_INT, > - PRES_VT_BOOL > + PRES_VT_BOOL, > + PRES_VT_MAX > }; I guess you mean PRES_VT_COUNT. > > static const struct > @@ -260,6 +261,22 @@ struct d3dx_pres_ins > struct d3dx_pres_operand output; > }; > > +static enum pres_value_type param_type_to_table_type(D3DXPARAMETER_TYPE type) In d3d we usually name those the other way around e.g. table_type_from_param_type().

1 0

Re: [PATCH 2/6] d3dx9: Factor out get_constant_dimensions() function.
by Matteo Bruni May 29, 2017

May 29, 2017

2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 43 +++++++++++++++++++++++++++---------------- > 1 file changed, 27 insertions(+), 16 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 29a2346..262b7c1 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -979,6 +979,31 @@ void d3dx_free_param_eval(struct d3dx_param_eval *peval) > HeapFree(GetProcessHeap(), 0, peval); > } > > +static void get_constant_dimensions(struct d3dx_const_param_eval_output *const_set, BOOL *transpose, > + unsigned int *major, unsigned int *minor, unsigned int *major_stride, unsigned int *n, > + unsigned int *count) It seems better to pass around a struct pointer in place of all those separate out arguments, e.g. struct const_upload_info. Then you can name the helper get_"structname"() too. > + *n = min(*major * *major_stride, > + get_offset_reg(table, const_set->register_count) + *major_stride - 1) / *major_stride; > + *count = *n * *minor; Preexisting, but "n" is a bit confusing, especially considering that there is a "count" too. Something like "available_major" / "reg_count"? count might be "component_count" or similar. Maybe you can find some better names...

1 0

Re: [PATCH] api-ms-win-security-activedirectoryclient-l1-1-0: Add dll.
by Nikolay Sivov May 29, 2017

May 29, 2017

On 29.05.2017 14:04, Andrey Gusev wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > configure | 2 ++ > configure.ac | 1 + > dlls/api-ms-win-security-activedirectoryclient-l1-1-0/Makefile.in | 1 + > .../api-ms-win-security-activedirectoryclient-l1-1-0.spec | 8 ++++++++ > tools/make_specfiles | 4 ++++ > 5 files changed, 16 insertions(+) > create mode 100644 dlls/api-ms-win-security-activedirectoryclient-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-security-activedirectoryclient-l1-1-0/api-ms-win-security-activedirectoryclient-l1-1-0.spec > > diff --git a/configure b/configure > index d2d391c..fb22627 100755 > --- a/configure > +++ b/configure > @@ -1026,6 +1026,7 @@ enable_api_ms_win_ntuser_dc_access_l1_1_0 > enable_api_ms_win_power_base_l1_1_0 > enable_api_ms_win_power_setting_l1_1_0 > enable_api_ms_win_rtcore_ntuser_private_l1_1_0 > +enable_api_ms_win_security_activedirectoryclient_l1_1_0 > enable_api_ms_win_security_audit_l1_1_1 > enable_api_ms_win_security_base_l1_1_0 > enable_api_ms_win_security_base_l1_2_0 > @@ -17897,6 +17898,7 @@ wine_fn_config_dll api-ms-win-ntuser-dc-access-l1-1-0 enable_api_ms_win_ntuser_d > wine_fn_config_dll api-ms-win-power-base-l1-1-0 enable_api_ms_win_power_base_l1_1_0 > wine_fn_config_dll api-ms-win-power-setting-l1-1-0 enable_api_ms_win_power_setting_l1_1_0 > wine_fn_config_dll api-ms-win-rtcore-ntuser-private-l1-1-0 enable_api_ms_win_rtcore_ntuser_private_l1_1_0 > +wine_fn_config_dll api-ms-win-security-activedirectoryclient-l1-1-0 enable_api_ms_win_security_activedirectoryclient_l1_1_0 > wine_fn_config_dll api-ms-win-security-audit-l1-1-1 enable_api_ms_win_security_audit_l1_1_1 > wine_fn_config_dll api-ms-win-security-base-l1-1-0 enable_api_ms_win_security_base_l1_1_0 > wine_fn_config_dll api-ms-win-security-base-l1-2-0 enable_api_ms_win_security_base_l1_2_0 > diff --git a/configure.ac b/configure.ac > index db4d168..dde867b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2843,6 +2843,7 @@ WINE_CONFIG_DLL(api-ms-win-ntuser-dc-access-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-power-base-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-power-setting-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-rtcore-ntuser-private-l1-1-0) > +WINE_CONFIG_DLL(api-ms-win-security-activedirectoryclient-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-security-audit-l1-1-1) > WINE_CONFIG_DLL(api-ms-win-security-base-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-security-base-l1-2-0) > diff --git a/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/Makefile.in b/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..e1e99bd > --- /dev/null > +++ b/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-security-activedirectoryclient-l1-1-0.dll > diff --git a/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/api-ms-win-security-activedirectoryclient-l1-1-0.spec b/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/api-ms-win-security-activedirectoryclient-l1-1-0.spec > new file mode 100644 > index 0000000..eef1c40 > --- /dev/null > +++ b/dlls/api-ms-win-security-activedirectoryclient-l1-1-0/api-ms-win-security-activedirectoryclient-l1-1-0.spec > @@ -0,0 +1,8 @@ > +@ stub DsBindWithSpnExW > +@ stub DsCrackNamesW > +@ stub DsFreeDomainControllerInfoW > +@ stub DsFreeNameResultW > +@ stub DsFreePasswordCredentials > +@ stub DsGetDomainControllerInfoW > +@ stub DsMakePasswordCredentialsW > +@ stub DsUnBindW > diff --git a/tools/make_specfiles b/tools/make_specfiles > index e544293..910bd0f 100755 > --- a/tools/make_specfiles > +++ b/tools/make_specfiles > @@ -157,6 +157,10 @@ my @dll_groups = > "api-ms-win-power-setting-l1-1-0", > ], > [ > + "ntdsapi", > + "api-ms-win-security-activedirectoryclient-l1-1-0", > + ], > + [ > "kernel32", > "api-ms-win-appmodel-identity-l1-1-0", > "api-ms-win-appmodel-runtime-l1-1-1", > Those exports are present in kernelbase spec file, maybe it's better to forward to it?

1 0

Re: [PATCH 4/6] wined3d: Prefer GLSL 1.50 shaders in draw_test_quad().
by Henri Verbeet May 29, 2017

May 29, 2017

On 29 May 2017 at 10:53, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + BOOL use_glsl_150 = gl_info->glsl_version >= 150; That doesn't work in Wine :D I wouldn't necessarily mind if it did though.

1 0

Re: [PATCH] comctl32/listview: Do not select the first list item when drawing a marquee rectangle
by Nikolay Sivov May 29, 2017

May 29, 2017

On 22.05.2017 16:02, Hugh McMaster wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/comctl32/listview.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index c681451..a117f83 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -3892,6 +3892,9 @@ static void LISTVIEW_MarqueeHighlight(LISTVIEW_INFO *infoPtr, const POINT *coord > if ((scroll & SCROLL_DOWN) && (coords_orig->y >= infoPtr->rcList.bottom)) > LISTVIEW_Scroll(infoPtr, 0, (coords_orig->y - infoPtr->rcList.bottom)); > > + if (IsRectEmpty(&infoPtr->marqueeRect)) > + infoPtr->marqueeRect = rect; > + > iterator_frameditems_absolute(&old_elems, infoPtr, &infoPtr->marqueeRect); > > infoPtr->marqueeRect = rect; > I see what you mean, when you start selecting with marquee first item in report mode is always selected. This patch fixes that, but breaks ICON mode it seems - sometimes items are not selected when they are clearly intersect with marquee rectangle. Admittedly this selection mode is already funny in ICON mode, it does not use dead zones properly, so slight movement selects things, while it should check with icon rectangle when resized horizontally, and allow about half icon rectangle intersect marquee vertically before setting item state.

2 3

Re: [v5 PATCH 1/3] wined3d: Send texture updates through the command stream.
by Stefan Dösinger May 29, 2017

May 29, 2017

Am 2017-05-24 um 15:49 schrieb Masanori Kakura: > + for (j = 0; j < layer_count; ++j) > + { > + wined3d_cs_emit_blt_sub_resource(cs, > + &dst_texture->resource, j * dst_level_count + i, &box, > + &src_texture->resource, j * src_level_count + i + src_skip_levels, &box, > + 0, NULL, WINED3D_TEXF_POINT); > + } I don't like emitting new operations in the CS handler instead of doing the actual operation. Maybe this can be avoided with some refactoring of wined3d_cs_exec_blt_sub_resource?

3 3

Re: [v6 PATCH 2/3] wined3d: Add dirty region tracking.
by Marvin May 28, 2017

May 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31231 Your paranoid android. === w1064 (64 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

about donat enikeev csmt on graphics tab in winecfg
by CARLOS RODRIGUEZ May 27, 2017

May 27, 2017

Hi henri I read your discussion about normal user dont need touch that However various titles needs csmt, mainly for solve graphics issues case duke nuke forever (dont show anything without csmt), resident evil 6 (only see light without csmt) Or flickering graphics case im alive, senran kagura shinovi versus, bayonetta, vanquish Resolve audio sincronization in prerenderer sequences case front mission evolved And possible many other titles Put option in winecfg could be usefull for new users I agree about you said related csmt dont be stay active for default for now, but solve before problems described Maybe can add some note in csmt like that: mainly for resolve graphics issues for now or something similar Thanks

1 0

Re: [PATCH] msvcp140: Implement _To_wide (v2).
by Stefan Dösinger May 26, 2017

May 26, 2017

Am 2017-05-26 um 13:17 schrieb Stefan Dösinger: > + return MultiByteToWideChar(CP_ACP, 0, src, -1, dst, strlen(src) + 1); Do not commit this yet, there is another version coming. The maximum length is limited to MAX_PATH, and Nikolai says the test randomly crashes on his Windows. It seems Microsoft lets interns write APIs nowadays.

1 0

Re: [PATCH] msvcp140: Implement _To_wide.
by Marvin May 26, 2017

May 26, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31204 Your paranoid android. === wvistau64 (32 bit msvcp140) === msvcp140.c:492: Test failed: Got unexpected output L"\05e6\05d4\f895\f893\20ac\009f" === wvistau64 (64 bit msvcp140) === msvcp140.c:492: Test failed: Got unexpected output L"\05e6\05d4\f895\f893\20ac\009f"

1 0

Re: [PATCH] oleaut32: Add VarBstrFromDisp tests
by Marvin May 25, 2017

May 25, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31191 Your paranoid android. === wxppro (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w2003std (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === wvistau64 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w2008s64 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w7u (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w7pro64 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w8 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w864 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === w1064 (32 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\c3c9\768d\c700\2444\7804\0014\c700\2404\9400S\8ce8\0091\c700\2404\fe44S\40e8\0094\c900\8dc3\26b4" === wvistau64 (64 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\8b4c\53dc\5655\4157\4154\4155\4156\4857\ec81\00a8" oleaut32:vartype crashed (c0000374) === w2008s64 (64 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\8b4c\53dc\5655\4157\4154\4155\4156\4857\ec81\00a8" oleaut32:vartype crashed (c0000374) === w7pro64 (64 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\8b4c\53dc\5655\4157\4154\4155\4156\4857\ec81\00a8" oleaut32:vartype crashed (c0000374) === w1064 (64 bit vartype) === vartype.c:5306: Test failed: got 0x80020008 vartype.c:5307: Test failed: got L"\5540\5653\4157\4154\4155\4156\4857\6c8d\e124\8148\d8ec" oleaut32:vartype crashed (c0000374)

1 0

Re: [7/8] d3d11/tests: Add R9G9B9E5_SHAREDEXP to test_create_texture3d.
by Józef Kucia May 25, 2017

May 25, 2017

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, > {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, > {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_RENDER_TARGET, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_DEPTH_STENCIL, FALSE, FALSE}, Please use D3D11 enum values.

1 0

Re: [6/8] d3d11/tests: Add R9G9B9E5_SHAREDEXP to test_create_texture2d.
by Józef Kucia May 25, 2017

May 25, 2017

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > {DXGI_FORMAT_D32_FLOAT, 1, D3D11_BIND_RENDER_TARGET, 0, FALSE, FALSE}, > {DXGI_FORMAT_D32_FLOAT, 1, D3D11_BIND_DEPTH_STENCIL, 0, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_SHADER_RESOURCE, 0, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_RENDER_TARGET, 0, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_DEPTH_STENCIL, 0, FALSE, FALSE}, > }; Please use D3D11 enum values.

1 0

Re: [5/8] d3d10core/tests: Add R9G9B9E5_SHAREDEXP to test_texture.
by Józef Kucia May 25, 2017

May 25, 2017

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > + static const DWORD r9g9b9e5_colors[16] = { Please try to put opening brackets on a new line (applies also to the d3d11 version).

1 0

Re: [PATCH 1/5] d3dx9/tests: Use ARRAY_SIZE in test_D3DXSHEvalDirectionalLight().
by Matteo Bruni May 24, 2017

May 24, 2017

2017-05-23 11:04 GMT+02:00 Henri Verbeet <hverbeet(a)codeweavers.com>: > @@ -2908,7 +2908,7 @@ static void test_D3DXSHEvalDirectionalLight(void) > green_out = test[l].green_in; > blue_out = test[l].blue_in; > > - for (j = 0; j < 49; j++) > + for (j = 0; j < ARRAY_SIZE(red_out); ++j) red_out here is defined as a pointer, not an array.

1 0

Re: [v5 PATCH 3/3] wined3d: Update only dirty regions in wined3d_cs_exec_update_texture().
by Marvin May 24, 2017

May 24, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31147 Your paranoid android. === w1064 (32 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH] iphlpapi: Implement if_nametoindex.
by Bruno Jesus May 24, 2017

May 24, 2017

On Wed, May 24, 2017 at 7:39 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > ... > diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c > index 796950e0f9..4cceb65621 100644 > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -36,6 +36,9 @@ > #ifdef HAVE_RESOLV_H > # include <resolv.h> > #endif > +#ifdef HAVE_NET_IF_H > +# include <net/if.h> > +#endif > > #define NONAMELESSUNION > #define NONAMELESSSTRUCT > @@ -3208,3 +3211,12 @@ DWORD WINAPI ConvertInterfaceNameToLuidW(const WCHAR *name, NET_LUID *luid) > luid->Info.IfType = row.dwType; > return NO_ERROR; > } > + > +/****************************************************************** > + * if_nametoindex (IPHLPAPI.@) > + */ > +IF_INDEX WINAPI IPHLP_if_nametoindex(const char *name) > +{ > + TRACE("(%s)\n", name); > + return if_nametoindex(name); > +} Hi, this seems to be the ASCII version of GetAdapterIndex, can't you call getInterfaceIndexByName and avoid the new #include? Best wishes, Bruno

3 8

Re: [PATCH 2/2] winex11.drv: Implement clipboard changes tracking using xfixes extension
by Alexandre Julliard May 24, 2017

May 24, 2017

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -499,6 +499,7 @@ extern Atom systray_atom DECLSPEC_HIDDEN; > typedef BOOL (*x11drv_event_handler)( HWND hwnd, XEvent *event ); > > extern void X11DRV_register_event_handler( int type, x11drv_event_handler handler, const char *name ) DECLSPEC_HIDDEN; > +extern void X11DRV_register_XFixesSelectionNotify( int type ) DECLSPEC_HIDDEN; Is there a reason you can't use X11DRV_register_event_handler? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu
by Nikolay Sivov May 24, 2017

May 24, 2017

On 24.05.2017 11:21, Hugh McMaster wrote: > + item.mask = TVIF_CHILDREN | TVIF_HANDLE | TVIF_STATE; > + item.stateMask = TVIS_EXPANDED | TVIS_EXPANDEDONCE | TVIS_EXPANDPARTIAL; > + SendMessageW(hwndTV, TVM_GETITEMW, 0, (LPARAM)&item) Later you only test for TVIS_EXPANDED, is it necessary to request other bits?

2 1

Re: [PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu
by Nikolay Sivov May 24, 2017

May 24, 2017

On 24.05.2017 11:21, Hugh McMaster wrote: > + case ID_TREE_EXPAND: > + { > + HTREEITEM selected = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_CARET, 0); > + SendMessageW(g_pChildWnd->hTreeWnd, TVM_EXPAND, TVE_TOGGLE, (LPARAM)selected); > + break; > + } Maybe it's better to name it ID_TREE_EXPAND_COLLAPSE, since it does not only expand.

2 1

Re: [PATCH] authz: document missorted function in specfile
by Alexandre Julliard May 24, 2017

May 24, 2017

Austin English <austinenglish(a)gmail.com> writes: > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/authz/authz.spec | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/authz/authz.spec b/dlls/authz/authz.spec > index eb9e044d2a..1e9edefc59 100644 > --- a/dlls/authz/authz.spec > +++ b/dlls/authz/authz.spec > @@ -35,6 +35,8 @@ > @ stub AuthziInitializeAuditQueue > @ stub AuthziInitializeContextFromSid > @ stub AuthziLogAuditEvent > +# AuthziModifyAuditEvent2 comes before AuthziModifyAuditEvent on native, > +# even though AuthzInitializeObjectAccessAuditEvent is before AuthzInitializeObjectAccessAuditEvent2 > @ stub AuthziModifyAuditEvent2 > @ stub AuthziModifyAuditEvent > @ stub AuthziModifyAuditEventType There are many functions that aren't sorted, I don't think this warrants a comment. If you have a script for this, you may want to maintain a list of exceptions inside the script instead. -- Alexandre Julliard julliard(a)winehq.org

3 4