May 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] ddraw: Validate that non-fill blits have a source surface in ddraw_surface7_Blt().
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30698 Your paranoid android. === wxppro (32 bit ddraw4) === 0a24:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CE7A === wvistau64 (32 bit ddraw4) === 0970:ddraw4: unhandled exception c0000005 at 0049CE7A === w2008s64 (32 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 0049CE7F === w7u (32 bit ddraw4) === 0ca4:ddraw4: unhandled exception c0000005 at 0049CE7A === w7pro64 (32 bit ddraw4) === 00c0:ddraw4: unhandled exception c0000005 at 0049CE7F === wvistau64 (64 bit ddraw4) === 01b0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w2008s64 (64 bit ddraw4) === 08c4:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w7pro64 (64 bit ddraw4) === 07e0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (64 bit ddraw4) === 0fc8:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w1064 (64 bit ddraw4) === 0f3c:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (32 bit ddraw1) === ddraw1.c:10272: Test failed: Got unexpected color 0x00ffffff.

1 0

Re: [PATCH 1/5] ddraw/tests: Port test_texturemapblend() to ddraw4.c as well.
by Marvin May 2, 2017

May 2, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30697 Your paranoid android. === wxppro (32 bit ddraw4) === 09f8:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CB5A === wvistau64 (32 bit ddraw4) === 0744:ddraw4: unhandled exception c0000005 at 0049CB5A === w2008s64 (32 bit ddraw4) === 0bf4:ddraw4: unhandled exception c0000005 at 0049CB5F === w7u (32 bit ddraw4) === 0fbc:ddraw4: unhandled exception c0000005 at 0049CB5A === w7pro64 (32 bit ddraw4) === 0338:ddraw4: unhandled exception c0000005 at 0049CB5F === wvistau64 (64 bit ddraw4) === 072c:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w2008s64 (64 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w7pro64 (64 bit ddraw4) === 0854:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w864 (64 bit ddraw4) === 0fac:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w1064 (64 bit ddraw4) === 0c84:ddraw4: unhandled exception c0000005 at 00000000004863E2

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 2, 2017

May 2, 2017

Hi Almost forget maybe can improve WINEDEBUG=+fps for only display fps (actually gives priority to errors than fps information) Thanks

2 1

Re: [PATCH v3 1/2] mountmgr: Create devices and registry entries for serial ports.
by Bruno Jesus May 2, 2017

May 2, 2017

On Wed, Apr 26, 2017 at 12:18 AM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=11811 > > This patch also autodetects USB serial ports, making them "just work". > > The user may override the port autodetection by creating entries in > HKLM\Software\Wine\Ports. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Although I don't feel qualified to sign this patch I can say that I tested it with real hardware and it works fine for both real and USB serial ports in Linux. Hyper Terminal recognizes all ports without any manual registry workaround.

1 0

Re: [v3 PATCH 1/4] mfplat: Implement MFTRegister
by Alexandre Julliard May 1, 2017

May 1, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static HRESULT register_category(CLSID *clsid, GUID *category) > +{ > + HKEY hcategory, htmp1, htmp2; > + WCHAR buffer[64]; > + DWORD ret; > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, categories_keyW, &hcategory)) > + return E_FAIL; > + > + GUIDToString(buffer, category); > + ret = RegCreateKeyW(hcategory, buffer, &htmp1); > + RegCloseKey(hcategory); > + if (ret) return E_FAIL; You should create the entire path if needed instead of failing. > @@ -650,6 +650,10 @@ HKLM,Software\Borland\Database Engine\Settings\SYSTEM\INIT,SHAREDMEMLOCATION,,90 > HKLM,Software\Clients\Mail,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,"DLLPath",2,"%11%\winemapi.dll" > +HKLM,Software\Classes\MediaFoundation,,16 > +HKLM,Software\Classes\MediaFoundation\MediaSources,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms\Categories,,16 ...and then you no longer need this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regedit: Read registry lines through a single function
by Alexandre Julliard May 1, 2017

May 1, 2017

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > +static WCHAR *get_line(struct reg_info *reg_info) > +{ > + WCHAR *line; > + > + if (!reg_info->is_unicode) > + { > + char *lineA = get_lineA(reg_info->file); > + line = GetWideString(lineA); > + } > + else > + { > + line = get_lineW(reg_info->file); > + } > + > + return line; > +} That's fairly ugly. If you want to use common code, you should probably pass a function pointer for getting lines. Also you'd have to do it in a way that doesn't require freeing the buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: Do not call SendMessage() to show a window that is already visible.
by Dmitry Timoshkov May 1, 2017

May 1, 2017

Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index c2b35ec..64fdfe0 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -1239,6 +1239,9 @@ BOOL WINAPI ShowWindow( HWND hwnd, INT cmd ) > if ((cmd == SW_HIDE) && !(GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) > return FALSE; > > + if ((cmd == SW_SHOW) && (GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) > + return TRUE; > + > return SendMessageW( hwnd, WM_WINE_SHOWWINDOW, cmd, 0 ); > } Please have a look at the show_window() implementation and try to cover all cases that trigger SWP_SHOWWINDOW flag passed to SetWindowPos() in order to actually show a window. In fact it's only SW_HIDE that leads to that, so perhaps just adding an 'else' to the SW_HIDE case is enough? -- Dmitry.

2 1

Re: [1/5] wsdapi: Implement WSD LinkedMemory functions [try 3]
by Alexandre Julliard May 1, 2017

May 1, 2017

Owen Rudge <orudge(a)codeweavers.com> writes: > +struct memory_allocation > +{ > + int magic; > + struct list entry; > + > + struct list children; > +}; You'd probably want to preserve the heap block alignment. Some test cases would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ May 1, 2017

May 1, 2017

Gallium HUD provides various features but have same problem Only works in certain hardware and only on linux meanwhile if wine could provide native fps overlay must be works in all hardware and all type drivers (closed and opensource) and all operating system supported Thanks

1 0

Re: dmusic: Implement IDirectMusicBuffer::PackUnstructured().
by Henri Verbeet May 1, 2017

May 1, 2017

On 1 May 2017 at 02:05, Michael Stefaniuc <mstefani(a)winehq.org> wrote: > -static HRESULT WINAPI IDirectMusicBufferImpl_PackUnstructured(LPDIRECTMUSICBUFFER iface, REFERENCE_TIME rt, DWORD dwChannelGroup, DWORD cb, LPBYTE lpb) > +static HRESULT WINAPI IDirectMusicBufferImpl_PackUnstructured(IDirectMusicBuffer *iface, > + REFERENCE_TIME ref_time, DWORD channel_group, DWORD len, BYTE *data) > { > IDirectMusicBufferImpl *This = impl_from_IDirectMusicBuffer(iface); > + DWORD new_write_pos = This->write_pos + DMUS_EVENT_SIZE(len); > + DMUS_EVENTHEADER header; > + > + TRACE("(%p, 0x%s, %d, %d, %p)\n", This, wine_dbgstr_longlong(ref_time), channel_group, len, data); > > - FIXME("(%p, 0x%s, %d, %d, %p): stub\n", This, wine_dbgstr_longlong(rt), dwChannelGroup, cb, lpb); > + if (new_write_pos > This->size) > + return DMUS_E_BUFFER_FULL; > + > + if (!This->write_pos) > + This->start_time = ref_time; > + > + header.cbEvent = len; > + header.dwChannelGroup = channel_group; > + header.rtDelta = ref_time - This->start_time; > + header.dwFlags = 0; > + > + memcpy(This->data + This->write_pos, &header, sizeof(header)); > + memcpy(This->data + This->write_pos + sizeof(header), data, len); The difference is of course largely stylistic, but note that you could also do something like the following: DMUS_EVENTHEADER *header; ... header = (DMUS_EVENTHEADER *)&This->data[This->write_pos]; ... memcpy(&header[1], data, len);

1 0