July 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] user32/tests: Add tests for activating windows.
by Marvin July 11, 2017

July 11, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32241 Your paranoid android. === wxppro (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00020152 win.c:9940: Test failed: GetFocus() = 00020152 === w2003std (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 000400F6 win.c:9940: Test failed: GetFocus() = 000400F6 === wvistau64 (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00050120 win.c:9940: Test failed: GetFocus() = 00050120 === w2008s64 (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00080124 win.c:9940: Test failed: GetFocus() = 00080124 === w7u (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A70144 fg 000B0188 in hook HCBT_MINMAX win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000700F8 fg 000B0188 in hook HCBT_MINMAX win.c:9962: Test failed: expected 000B00F0, got 000801AA win.c:9981: Test failed: expected 000B00F0, got 000801AA === wvistau64 (64 bit win) === win.c:9940: Test failed: GetActiveWindow() = 0000000000050120 win.c:9940: Test failed: GetFocus() = 0000000000050120 === w2008s64 (64 bit win) === win.c:9940: Test failed: GetActiveWindow() = 0000000000080124 win.c:9940: Test failed: GetFocus() = 0000000000080124 === w7pro64 (64 bit win) === win.c:9947: Test failed: expected 00000000000B015E, got 0000000000050024

1 0

Re: [PATCH 3/6] gdiplus: Support GdipSetSmoothingMode in metafiles
by Vincent Povirk July 11, 2017

July 11, 2017

According to the spec, SmoothingModeHighSpeed also does no antialiasing.

2 1

Re: [PATCH 7/9] msvcr120: Add erfc.
by Piotr Caban July 11, 2017

July 11, 2017

On 07/10/17 06:55, Alex Henrie wrote: > /********************************************************************* > + * erfc (MSVCR120.@) > + */ > +double CDECL MSVCR120_erfc(double x) > +{ > +#ifdef HAVE_ERFC > + return erfc(x); > +#else > + FIXME( "not implemented\n" ); > + return 0.0; > +#endif You can return 1.0 - MSVCR120_erf(x) if erfc is not available. Thanks, Piotr

2 2

Re: winhttp/tests: Make notification tests more strict.
by Marvin July 11, 2017

July 11, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32231 Your paranoid android. === w7pro64 (32 bit notification) === notification.c:219: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 219: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:226: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:236: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:248: Test failed: unexpected function 2, expected 8. probably some notifications were missing notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:282: Test failed: unexpected function 2, expected 1. probably some notifications were missing notification.c:90: Test failed: 282: expected function 2 got 1 notification.c:315: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 315: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 315: expected function 8 got 2 notification.c:322: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:332: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 341: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 341: expected function 1 got 8 === w1064 (64 bit notification) === notification.c:219: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 219: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:226: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:236: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:248: Test failed: unexpected function 2, expected 8. probably some notifications were missing notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:282: Test failed: unexpected function 2, expected 1. probably some notifications were missing notification.c:90: Test failed: 282: expected function 2 got 1 notification.c:315: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 315: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 315: expected function 8 got 2 notification.c:322: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:332: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 332: expected function 8 got 4

1 0

Re: [PATCH 4/4] msvcp140: Implement _Stat and _Lstat.
by Marvin July 11, 2017

July 11, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32230 Your paranoid android. === wvistau64 (32 bit msvcp140) === 0504:msvcp140: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit msvcp140) === 0504:msvcp140: unhandled exception c0000005 at 0000000000000000

1 0

Re: [PATCH 1/2] advapi32/tests: Statically link to ConvertSidToStringSidA()
by Dmitry Timoshkov July 11, 2017

July 11, 2017

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static BOOL (WINAPI *pConvertSidToStringSidA)( PSID pSid, LPSTR *str ); > static BOOL (WINAPI *pConvertStringSidToSidA)( LPCSTR str, PSID pSid ); ... > - pConvertSidToStringSidA = (void *)GetProcAddress(hmod, "ConvertSidToStringSidA"); > pConvertStringSidToSidA = (void *)GetProcAddress(hmod, "ConvertStringSidToSidA"); ... > - if( !pConvertSidToStringSidA || !pConvertStringSidToSidA ) > + if( !pConvertStringSidToSidA ) What's so special about ConvertSidToStringSidA and why same logic won't apply to ConvertStringSidToSidA and possibly others? -- Dmitry.

2 2

Re: [PATCH 7/7] gdiplus: Add EMF+ properties records tests
by Piotr Caban July 11, 2017

July 11, 2017

On 07/11/17 11:42, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/gdiplus/tests/metafile.c | 78 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 78 insertions(+) > I've sent it incorrectly so it wasn't picked by testbot. Here are the results: https://testbot.winehq.org/JobDetails.pl?Key=32226 Thanks, Piotr

1 0

Re: [PATCH 2/6] gdiplus: Support GdipSetPixelOffsetMode in metafiles
by Dmitry Timoshkov July 11, 2017

July 11, 2017

Piotr Caban <piotr(a)codeweavers.com> wrote: > + if(graphics->pixeloffset == mode) > + return Ok; This particular change would need an approproate test case to confirm that repetitive GdipSetPixelOffsetMode() calls with the same value won't generate new records. Same applies to other patches in the series. -- Dmitry.

1 1

Re: [PATCH 1/7] d3dx9/tests: Add test for skip_constants effect parameter.
by Matteo Bruni July 11, 2017

July 11, 2017

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static void test_effect_skip_constants(IDirect3DDevice9 *device) > +{ > + HRESULT hr; > + ID3DXEffect *effect; > + unsigned int passes_count; > + D3DXVECTOR4 fvect; > + unsigned int i; > + > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, "v3", 0, NULL, &effect, NULL); > + todo_wine > + ok(hr == D3DERR_INVALIDCALL, "Got result %#x.\n", hr); > + if (SUCCEEDED(hr)) > + effect->lpVtbl->Release(effect); > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, "v4", 0, NULL, &effect, NULL); > + todo_wine > + ok(hr == D3DERR_INVALIDCALL, "Got result %#x.\n", hr); > + if (SUCCEEDED(hr)) > + effect->lpVtbl->Release(effect); > + > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, " v1#,.+-= &\t\nv2*/!\"'v5 v6[1]", 0, NULL, &effect, NULL); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); Maybe also add a test with the "expected" syntax for the skip_constants parameters? MSDN mentions a semicolon-separated list. Of course it's not strictly needed, given this test... > + > + todo_wine > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v1", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + todo_wine > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v2", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(effect->lpVtbl->IsParameterUsed(effect, "v3", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(effect->lpVtbl->IsParameterUsed(effect, "v4", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v5", "tech0"), > + "Unexpected IsParameterUsed result.\n"); What about "v6"?

2 1

Re: [PATCH 5/7] d3dx9: Fail effect creation when shader parameter evaluator creation fails.
by Matteo Bruni July 11, 2017

July 11, 2017

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -6099,8 +6100,9 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > { > if (FAILED(hr = d3dx9_create_object(base, object))) > return hr; > - d3dx_create_param_eval(base, object->data, object->size, param->type, > - &param->param_eval, get_version_counter_ptr(base)); > + if (FAILED(hr = d3dx_create_param_eval(base, object->data, object->size, param->type, > + &param->param_eval, get_version_counter_ptr(base)))) > + return hr; > } > break; > > @@ -6138,8 +6140,11 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * It looks like you missed another call to d3dx_create_param_eval() in between these two.

2 1

Re: [PATCH 2/5] regedit: Use 'return' statements in delete_registry_key() to allow for memory clean-up
by Alexandre Julliard July 11, 2017

July 11, 2017

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -1593,11 +1593,11 @@ void delete_registry_key(WCHAR *reg_key_name) > > if (!(key_class = parse_key_name(reg_key_name, &key_name))) { > output_message(STRING_INCORRECT_REG_CLASS, reg_key_name); > - exit(1); > + return; > } > if (!*key_name) { > output_message(STRING_DELETE_REG_CLASS_FAILED, reg_key_name); > - exit(1); > + return; If the process is going to exit anyway, freeing memory is a waste of time. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 3/9] msvcr120: Remove precompiler check for asinh.
by Piotr Caban July 11, 2017

July 11, 2017

On 07/10/17 06:55, Alex Henrie wrote: > asinh is part of C89, so it is guaranteed to be present. Are you sure about it? As far as I know it's part of C99. The manual for asinh looks strange (it says that it conforms to C89 and gives test macro that checks for never standards). Thanks, Piotr

4 7

Re: [PATCH 6/7] d3dx9: Implement d3dx_shader_get_raw_constant_info() function.
by Matteo Bruni July 10, 2017

July 10, 2017

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/d3dx9_private.h | 3 +++ > dlls/d3dx9_36/shader.c | 18 ++++++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/dlls/d3dx9_36/d3dx9_private.h b/dlls/d3dx9_36/d3dx9_private.h > index db80490..bfb3909 100644 > --- a/dlls/d3dx9_36/d3dx9_private.h > +++ b/dlls/d3dx9_36/d3dx9_private.h > @@ -355,4 +355,7 @@ HRESULT d3dx_param_eval_set_shader_constants(ID3DXEffectStateManager *manager, s > struct d3dx_param_eval *peval, BOOL update_all) DECLSPEC_HIDDEN; > BOOL is_param_eval_input_dirty(struct d3dx_param_eval *peval, ULONG64 update_version) DECLSPEC_HIDDEN; > > +const D3DXSHADER_CONSTANTINFO *d3dx_shader_get_raw_constant_info(ID3DXConstantTable *iface, > + D3DXHANDLE constant) DECLSPEC_HIDDEN; > + > #endif /* __WINE_D3DX9_PRIVATE_H */ > diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c > index 4dbecb1..11527c8 100644 > --- a/dlls/d3dx9_36/shader.c > +++ b/dlls/d3dx9_36/shader.c > @@ -682,6 +682,7 @@ HRESULT WINAPI D3DXPreprocessShaderFromResourceW(HMODULE module, const WCHAR *re > } > > struct ctab_constant { > + const D3DXSHADER_CONSTANTINFO *raw_constant_info; > D3DXCONSTANT_DESC desc; > struct ctab_constant *constants; > }; > @@ -946,6 +947,22 @@ static HRESULT WINAPI ID3DXConstantTableImpl_GetDesc(ID3DXConstantTable *iface, > return D3D_OK; > } > > +const D3DXSHADER_CONSTANTINFO *d3dx_shader_get_raw_constant_info(ID3DXConstantTable *iface, D3DXHANDLE constant) > +{ > + struct ID3DXConstantTableImpl *const_table = impl_from_ID3DXConstantTable(iface); > + struct ctab_constant *c = get_valid_constant(const_table, constant); > + > + TRACE("const_table %p, constant %p.\n", const_table, constant); > + > + if (!c) > + { > + WARN("Invalid argument specified.\n"); > + return NULL; > + } > + > + return c->raw_constant_info; > +} > + > static HRESULT WINAPI ID3DXConstantTableImpl_GetConstantDesc(ID3DXConstantTable *iface, D3DXHANDLE constant, > D3DXCONSTANT_DESC *desc, UINT *count) > { > @@ -2052,6 +2069,7 @@ HRESULT WINAPI D3DXGetShaderConstantTableEx(const DWORD *byte_code, DWORD flags, > { > object->constants[i].desc.RegisterCount = constant_info[i].RegisterCount; > } > + object->constants[i].raw_constant_info = &constant_info[i]; > } > > *constant_table = &object->ID3DXConstantTable_iface; I don't like this all that much. If you need access to the original D3DXSHADER_CONSTANTINFO only for the Reserved field, as in the next patch, I'd say just store that one in struct ctab_constant. Then, for the retrieval part, I don't think it makes much sense to hide our internals from ourselves. You could move the definition of struct ctab_constant to d3dx9_private.h and introduce an internal function to return it from the constant table. You could then entirely replace the use of ID3DXConstantTable_GetConstantDesc(), if you want. Otherwise you can keep that part as-is for the time being and make use of the new function only to get to the Reserved data. Actually, if you go with the latter, it probably makes sense to merge this patch into the next.

1 0

Re: [PATCH 4/7] d3dx9: Get rid of init_set_constants() function.
by Matteo Bruni July 10, 2017

July 10, 2017

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 58 ++++++++++++++--------------------------------- > 1 file changed, 17 insertions(+), 41 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index cabddcd..1aaf59d 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -305,7 +305,8 @@ static unsigned int get_reg_components(unsigned int table) > > #define PRES_BITMASK_BLOCK_SIZE (sizeof(unsigned int) * 8) > > -static HRESULT init_set_constants(struct d3dx_const_tab *const_tab, ID3DXConstantTable *ctab); > +static HRESULT init_set_constants_param(struct d3dx_const_tab *const_tab, ID3DXConstantTable *ctab, > + D3DXHANDLE hc, struct d3dx_parameter *param); With some function reordering this forward declaration shouldn't be necessary at all.

1 0

Re: [PATCH 3/7] d3dx9: Simplify init and cleanup in get_constants_desc().
by Matteo Bruni July 10, 2017

July 10, 2017

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 2fb14ab..cabddcd 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -618,10 +618,6 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > D3DXHANDLE hc; > unsigned int i; > > - out->inputs = cdesc = NULL; > - out->inputs_param = NULL; > - out->input_count = 0; > - inputs_param = NULL; > hr = D3DXGetShaderConstantTable(byte_code, &ctab); > if (FAILED(hr) || !ctab) > { > @@ -635,8 +631,8 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > goto err_out; > } > > - cdesc = HeapAlloc(GetProcessHeap(), 0, sizeof(*cdesc) * desc.Constants); > - inputs_param = HeapAlloc(GetProcessHeap(), 0, sizeof(*inputs_param) * desc.Constants); > + out->inputs = cdesc = HeapAlloc(GetProcessHeap(), 0, sizeof(*cdesc) * desc.Constants); > + out->inputs_param = inputs_param = HeapAlloc(GetProcessHeap(), 0, sizeof(*inputs_param) * desc.Constants); > if (!cdesc || !inputs_param) > { > hr = E_OUTOFMEMORY; > @@ -678,16 +674,9 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > } > } > out->input_count = desc.Constants; > - out->inputs = cdesc; > - out->inputs_param = inputs_param; > hr = init_set_constants(out, ctab); > - ID3DXConstantTable_Release(ctab); > - return hr; > err_out: > - HeapFree(GetProcessHeap(), 0, cdesc); > - HeapFree(GetProcessHeap(), 0, inputs_param); > - if (ctab) > - ID3DXConstantTable_Release(ctab); > + ID3DXConstantTable_Release(ctab); > return hr; > } It would be a nice cleanup to rename the err_out: label to cleanup:, done: or similar.

1 0

Re: [PATCH 1/2] widl: Only generate Proxy Stubs when functions have the call_as attribute
by Nikolay Sivov July 10, 2017

July 10, 2017

On 10.07.2017 7:43, Alistair Leslie-Hughes wrote: > Fixes: https://bugs.winehq.org/show_bug.cgi?id=43302 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > tools/widl/header.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 7b97158..e48b488 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1172,7 +1172,7 @@ static void write_method_proto(FILE *header, const type_t *iface) > { > const var_t *func = stmt->u.var; > > - if (!is_local(func->attrs)) { > + if (is_callas(func->attrs)) { > const char *callconv = get_attrp(func->type->attrs, ATTR_CALLCONV); > if (!callconv) callconv = "STDMETHODCALLTYPE"; > /* proxy prototype */ > This is wrong, 'call_as' is used to map different method to be used for remote calls. Midl certainly does not limit prototype generation like that. You mentioned 'odl' attribute on bug report, it's irrelevant too.

2 2

Re: [v2 PATCH] widl: Only generate Proxy Stubs when functions have the call_as attribute
by Huw Davies July 10, 2017

July 10, 2017

On Mon, Jul 10, 2017 at 10:11:42AM +0000, Alistair Leslie-Hughes wrote: > Fixes: https://bugs.winehq.org/show_bug.cgi?id=43302 > > v2: Merge two matches together. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > include/unknwn.idl | 10 ++++++++++ > tools/widl/header.c | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/unknwn.idl b/include/unknwn.idl > index 78a2d9db18..7856a7f504 100644 > --- a/include/unknwn.idl > +++ b/include/unknwn.idl > @@ -46,6 +46,16 @@ interface IUnknown > ULONG Release(); > } > > +cpp_quote("HRESULT STDMETHODCALLTYPE IUnknown_QueryInterface_Proxy(IUnknown* This, REFIID riid, void **ppvObject);") > +cpp_quote("void __RPC_STUB IUnknown_QueryInterface_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_AddRef_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_AddRef_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_Release_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_Release_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > + > cpp_quote("#ifdef SAVE_WIDL_C_INLINE_WRAPPERS") > cpp_quote("#define WIDL_C_INLINE_WRAPPERS") > cpp_quote("#endif") > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 7b971582db..e48b488ae3 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1172,7 +1172,7 @@ static void write_method_proto(FILE *header, const type_t *iface) > { > const var_t *func = stmt->u.var; > > - if (!is_local(func->attrs)) { > + if (is_callas(func->attrs)) { > const char *callconv = get_attrp(func->type->attrs, ATTR_CALLCONV); > if (!callconv) callconv = "STDMETHODCALLTYPE"; > /* proxy prototype */ On further testing with midl v7, /Os does emit Proxy/Stub prototypes for all functions. Since widl essentially runs in this mode, I'd prefer to keep this behaviour if possible. In the bug you mention redefinition errors in qmgrprxy. How are you getting these? Huw.

1 1

Wine appimage request
by Dpto Catastro Topografia MuniSantaCruz July 10, 2017

July 10, 2017

Hello, I have used this software and it has been very useful to me, I am a surveyor engineer and free software user. A year ago in the world linux have agreed to generate universal packages self-contained with everything they need to install on any linux distribution. Of which there are today 3; Simon Peter's appimage, Gnome flatpak and Canonical snaps. The advantage of these packages is that they use everything in the same package to work, libraries and so on. Hence they can be installed in any linux distribution. It would be great to see the WINE in appimage or in flatpak or snap, and avoid using the terminal for new users. I somehow defend myself with the terminal but sometimes it is still somewhat annoying and tedious. I leave you the links of these new packaging technologies, so that you can analyze them and may in the not too distant future offer some of these simple packages. In fact I prefer appimage, I downloaded several of these applications with this type of package and is simple to use and distribute. Flatpak and snap are still using the terminal to install them, the snaps are fairly simple (it will be installed in the gnome and kde software center in 2018), flatpak the gnome desktop and kde install it from the software center to install packages Flatpak. Appimage has its own charm and does not use the terminal, just make executable and run. Thank you Links Http://appimage.org/ Http://flatpak.org/ Https://snapcraft.io/ atte Luis V --

1 0

Re: [PATCH 5/5] d3drm: Assign animation key ids
by Henri Verbeet July 10, 2017

July 10, 2017

On 10 July 2017 at 12:40, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static BOOL d3drm_animation_get_next_key_id(struct d3drm_animation_keys *keys, DWORD *id) > +{ > + DWORD i; > + > + if (keys->next_unused <= keys->last_id) > + { > + *id = keys->next_unused++; > + return TRUE; > + } > + > + if (keys->next_free <= keys->last_id) > + { > + *id = keys->next_free; > + keys->next_free = ~0u; > + return TRUE; > + } > + > + if (keys->count == keys->last_id - keys->first_id + 1) > + return FALSE; > + > + /* Worst case, look for the spot from the beginning. */ > + for (i = 0, *id = keys->first_id; i < keys->count; i++, ++*id) > + { > + if (*id != keys->keys[i].id) > + break; > + } Does that work? The keys aren't necessarily ordered by ID, right? Regardless, it may be easier to make use of the fact that we never shrink the keys array.

1 0

Re: server: Don't allow APCs on objects associated with completion port.
by Marvin July 10, 2017

July 10, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32203 Your paranoid android. === w7u (32 bit sock) === sock.c:6121: Test failed: Expected event sequence [FD_WRITE(0)], got [] sock.c:6142: Test failed: Expected event sequence [FD_READ(0) FD_CLOSE(0)], got [FD_WRITE(0) FD_CLOSE(10053)] sock.c:6145: Test failed: Failed to empty buffer: -1 - 10054 sock.c:6146: Test failed: Expected event sequence [FD_READ(0)], got [] sock.c:6149: Test failed: Failed to empty buffer: -1 - 10054

1 0

Re: [PATCH 2/2] msvcp140: Implement _File_size.
by Piotr Caban July 10, 2017

July 10, 2017

On 07/09/17 22:14, Stefan Dösinger wrote: > static int (__cdecl *p_To_wide)(const char *src, WCHAR *dst); > +static ULONGLONG(__cdecl *p_File_size)(WCHAR const*); Please add a space after ULONGLONG. > +static void test_File_size(void) > +{ > + ULONGLONG val; > + HANDLE file; > + LARGE_INTEGER file_size; > + WCHAR test_f1_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','f','1',0}; > + WCHAR test_f2_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','f','2',0}; > + WCHAR test_dir_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r',0}; > + WCHAR test_ne_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','n','e',0}; > + CreateDirectoryW(test_dir_W, NULL); Could you please create the test files in temp directory? Also please rename the directory (these are no longer tr2 namespace tests). > +/* _File_size, msvcp140 version. Different error handling. */ > +ULONGLONG __cdecl _File_size(WCHAR const* path) > +{ > + WIN32_FILE_ATTRIBUTE_DATA fad; > + > + TRACE("(%s)\n", debugstr_w(path)); > + if(!GetFileAttributesExW(path, GetFileExInfoStandard, &fad)) > + return ~0ULL; > + if(fad.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + return 0; We don't need to handle the directory separately here. It will have file size set to 0 anyway. Thanks, Piotr

1 0

Re: advapi32/tests: Add tests for RegSetValueExW and RegQueryValueExW.
by Alexandre Julliard July 10, 2017

July 10, 2017

Jactry Zeng <jzeng(a)codeweavers.com> writes: > Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> > --- > dlls/advapi32/tests/registry.c | 46 > +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) I don't see how this is different from the existing tests. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: user.exe16: Fix an incorrect use of ADD_TO_T in FormatMessage16.
by Henri Verbeet July 10, 2017

July 10, 2017

On 9 July 2017 at 18:53, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > ADD_TO_T actually consists of two statements > > #define ADD_TO_T(c) \ > *t++=c;\ > if (t-target == talloced) {\ > target = HeapReAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,target,talloced*2);\ > t = target+talloced;\ > talloced*=2;\ > } > > so > > for (x=b; *x; x++) ADD_TO_T(*x); > > does _not_ actually do what one might expect/hope. > > Fixed thusly, in line with other usage. > Alternatively, it shouldn't be hard to either fix the macro or replace it with a function.

1 0

Re: [PATCH 2/2] include: Add Proxy stubs for IUnknown
by Huw Davies July 10, 2017

July 10, 2017

On Mon, Jul 10, 2017 at 04:43:49AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > include/unknwn.idl | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/unknwn.idl b/include/unknwn.idl > index 78a2d9d..7856a7f 100644 > --- a/include/unknwn.idl > +++ b/include/unknwn.idl > @@ -46,6 +46,16 @@ interface IUnknown > ULONG Release(); > } > > +cpp_quote("HRESULT STDMETHODCALLTYPE IUnknown_QueryInterface_Proxy(IUnknown* This, REFIID riid, void **ppvObject);") > +cpp_quote("void __RPC_STUB IUnknown_QueryInterface_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_AddRef_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_AddRef_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_Release_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_Release_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") What do you need these for? Huw.

1 0

Re: msvcp140: implement _To_byte
by Nikolay Sivov July 9, 2017

July 9, 2017

On 08.07.2017 22:33, Mikhail Paulyshka wrote: > Signed-off-by: Mikhail Paulyshka <me(a)mixaill.tk> > --- > dlls/msvcp140/msvcp140.spec | 2 +- > dlls/msvcp140/tests/msvcp140.c | 49 ++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcp90/locale.c | 10 +++++++++ > 3 files changed, 60 insertions(+), 1 deletion(-) > Hi, and thanks for the patch. Some comments in addition to Stefan's reply: > + static const WCHAR test_2[] = {0xfe95, 0xfea0, 0xfea6, 0}; //some arabic glyphs These are characters, not glyphs. Also please use C-style comments - /**/.

3 2