July 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 3/3] mfplat/tests: Add MFCreateAttributes test
by Marvin July 8, 2017

July 8, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32169 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH] include: Support all version of BackgroundCopyManager from bits.h
by Alexandre Julliard July 7, 2017

July 7, 2017

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -22,12 +22,6 @@ > > #include "bits.idl" > > -#define DO_NO_IMPORTS > -#include "bits1_5.idl" > -#include "bits2_0.idl" > -#include "bits2_5.idl" > -#include "bits3_0.idl" This breaks the registration: ../../../tools/runtest -q -P wine -T ../../.. -M qmgr.dll -p qmgr_test.exe.so job && touch job.ok job.c:700: Test failed: Tests need BITS 2.0 or higher job.c:719: Test failed: Tests need BITS 2.5 or higher Makefile:285: recipe for target 'job.ok' failed make: *** [job.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntdll: Handle IMAGE_REL_BASED_DIR64 for arm64 in the same way as for x86_64
by Jacek Caban July 7, 2017

July 7, 2017

Hi Martin, On 07.07.2017 12:39, Martin Storsjo wrote: > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index 518a99f..3b784bf 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2476,7 +2476,7 @@ IMAGE_BASE_RELOCATION * WINAPI LdrProcessRelocationBlock( void *page, UINT count > case IMAGE_REL_BASED_HIGHLOW: > *(int *)((char *)page + offset) += delta; > break; > -#ifdef __x86_64__ > +#if defined(__x86_64__) || defined(__aarch64__) Could it use simply #ifdef _WIN64? Thanks, Jacek

1 0

Re: [1/2] vcomp: Add ARM64 support
by Alexandre Julliard July 7, 2017

July 7, 2017

Sebastian Lackner <sebastian(a)fds-team.de> writes: > On 05.07.2017 21:23, André Hentschel wrote: >> Signed-off-by: André Hentschel <nerv(a)dawncrow.de> >> --- >> dlls/vcomp/main.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> > > I have no ARM64 setup available, so please double-check that it actually > compiles before applying the patch. ;) It doesn't: aarch64-linux-android-clang -c -o main.o ../../../wine/dlls/vcomp/main.c -I. -I../../../wine/dlls/vcomp -I../../include \ -I../../../wine/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing \ -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits \ -Wvla -Wwrite-strings -Wpointer-arith -gdwarf-2 -gstrict-dwarf -g -O2 -fno-caret-diagnostics -Wno-tautological-constant-out-of-range-compare -Wno-enum-conversion -Wno-sometimes-uninitialized -Wno-ignored-attributes -Wno-array-bounds -Wno-absolute-value -Wno-unused-function -Wno-incompatible-pointer-types -Wno-invalid-source-encoding <inline asm>:36:2: error: too few operands for instruction Makefile:166: recipe for target 'main.o' failed make: *** [main.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] vcomp: Add ARM64 support
by Sebastian Lackner July 7, 2017

July 7, 2017

On 05.07.2017 21:23, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/vcomp/main.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > Just recently it was mentioned on the mailing lists that compilers do not support ms_va_list on ARM64 yet. Does your code rely on any compiler patches, or do you assume that va_list == ms_va_list?

2 2

Re: [PATCH 3/6] msi: Correctly format the template field for MsiProcessMessage().
by Hans Leidekker July 7, 2017

July 7, 2017

This one no longer applies after [PATCH v2 2/6] msi: Implement UI messages for dialogs: $ curl --silent -o - https://source.winehq.org/patches/data/135555 | git apply --verbose Checking patch dlls/msi/dialog.c... Checking patch dlls/msi/msi.rc... Checking patch dlls/msi/msipriv.h... Checking patch dlls/msi/package.c... Checking patch dlls/msi/resource.h... Checking patch dlls/msi/tests/package.c... error: while searching for: MsiCloseHandle(hpkg); ok_sequence(closehandle_sequence, "MsiCloseHandle()", TRUE); CoUninitialize(); DeleteFileA(msifile); DeleteFileA("forcecodepage.idt"); error: patch failed: dlls/msi/tests/package.c:9552 error: dlls/msi/tests/package.c: patch does not apply

1 0

Re: [PATCH 3/5] msi: Implement UI messages for dialogs.
by Alexandre Julliard July 6, 2017

July 6, 2017

Zebediah Figura <z.figura12(a)gmail.com> writes: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/msi/action.c | 74 +++++++++++++-------------- > dlls/msi/custom.c | 2 +- > dlls/msi/dialog.c | 55 +++++++++++++++++++- > dlls/msi/msi.rc | 3 +- > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 7 +++ > dlls/msi/resource.h | 1 + > dlls/msi/tests/package.c | 130 +++++++++++++++++++++++++++++++++++++++++++++-- > 8 files changed, 225 insertions(+), 48 deletions(-) This is causing the test to leave behind a winetest-package.msi file. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32/tests: A spelling fix in a comment.
by Marvin July 6, 2017

July 6, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32127 Your paranoid android. === wvistau64 (64 bit sock) === sock.c:8273: Test failed: bytesReturned isn't supposed to be 1 sock.c:8297: Test failed: GetOverlappedResult failed, error 997

1 0

Re: [PATCH 2/2] regedit: Null-terminate REG_EXPAND_SZ and REG_MULTI_SZ data if the parsed hex data does not end in a null-te
by Marvin July 6, 2017

July 6, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32126 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] regedit: Hex data lines may be terminated by a semicolon
by Marvin July 6, 2017

July 6, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32125 Your paranoid android. === build (build) === Patch failed to apply

1 0