July 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] msvcp140: Implement _Stat and _Lstat (v3).
by Piotr Caban July 14, 2017

July 14, 2017

Hi Stefan, On 07/13/17 17:40, Stefan Dösinger wrote: > +enum msvcp140_file_type { > + msvcp140_file_type_not_found = -1, msvcp140_file_type_none, msvcp140_file_type_regular, > + msvcp140_file_type_directory, msvcp140_file_type_symlink, msvcp140_file_type_block, > + msvcp140_file_type_character, msvcp140_file_type_fifo, msvcp140_file_type_socket, msvcp140_file_type_unknown > +}; Did you consider changing current structure instead of defining new one? I'm talking about something like: enum file_type { #if _MSVCP_VER < 140 status_unknown, file_not_found, #else file_not_found = -1, status_unknown, #endif regular_file, directory_file, ... } Thanks to it you will be able to use the same implementation of _Open_dir/_Read_dir in msvcp120 and msvcp140. > + *permissions = (attr & FILE_ATTRIBUTE_READONLY)?0555:0777; You should also handle permission==NULL case. Thanks, Piotr

2 2

Re: [PATCH 2/2] winhttp/tests: Make sure that all notifications were called before the end of a test.
by Marvin July 14, 2017

July 14, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32295 Your paranoid android. === w8 (32 bit notification) === notification.c:602: Test failed: some notifications were missing: 800

1 0

Re: [PATCH 1/2] winhttp/tests: Use notification flags to explicitly mark notifications that should signal an event.
by Marvin July 14, 2017

July 14, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32294 Your paranoid android. === w8 (32 bit notification) === notification.c:272: Test failed: got 00000102 notification.c:290: Test failed: unexpected function 8, expected 1. probably some notifications were missing notification.c:90: Test failed: 290: expected status 0x00000800 got 0x00000400 notification.c:91: Test failed: 290: expected function 8 got 1 notification.c:294: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:90: Test failed: 294: expected status 0x00000800 got 0x00000400 notification.c:91: Test failed: 294: expected function 8 got 2 notification.c:301: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:90: Test failed: 301: expected status 0x00000800 got 0x00000010 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:90: Test failed: 301: expected status 0x00000800 got 0x00000020 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:311: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:90: Test failed: 311: expected status 0x00000800 got 0x00000040 notification.c:91: Test failed: 311: expected function 8 got 4 notification.c:90: Test failed: 311: expected status 0x00000800 got 0x00000080 notification.c:91: Test failed: 311: expected function 8 got 4

1 0

wine-2.0.2-rc3 Available
by Michael Stefaniuc July 13, 2017

July 13, 2017

Hello guys, I have pushed wine-2.0.2-rc3 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Changes since rc2: - Added Steam fix bye michael

1 0

Re: [PATCH 2/6] gdiplus: Add helper for saving path objects in metafile
by Dmitry Timoshkov July 13, 2017

July 13, 2017

Piotr Caban <piotr(a)codeweavers.com> wrote: > +typedef struct EmfPlusPath > +{ > + DWORD Version; > + DWORD PathPointCount; > + DWORD PathPointFlags; > + /* PathPoints[] */ > + /* PathPointTypes[] */ > + /* AlignmentPadding */ > + BYTE data[1]; > +} EmfPlusPath; ... > +static GpStatus METAFILE_AddPathObject(GpMetafile *metafile, GpPath *path, DWORD *id) > +{ ... > + object_record->ObjectData.path.Version = 0xDBC01002; > + object_record->ObjectData.path.PathPointCount = path->pathdata.Count; > + object_record->ObjectData.path.PathPointFlags = 0; This looks very similar to the buffer format returned by GdipGetRegionData(), is it possible to use that API instead of a custom generator? -- Dmitry.

3 2

Meson buildsystem - does make it sense for Wine?
by David Heidelberg July 13, 2017

July 13, 2017

As I recently discovered Meson build system [1] (compatible with Linux, FreeBSD, Windows, Android etc.) which tends to be preferred replacement for autotools (at least recently by many projects). [2] I didn't found any discussion regarding to porting Wine build system. I wounder what is your opinion, could Meson can improve wine build times? Also maybe simplified crossbuilds? Thank you David [1] http://mesonbuild.com/ [2] https://www.youtube.com/watch?v=ae9_rNuFaQM

2 1

Re: [4/5] [v2] ntdll: Provide more accurate virtual memory counters. (rebased)
by Alex Henrie July 13, 2017

July 13, 2017

I don't think this patch is going to be accepted without showing that it makes some application usable that previously was not. -Alex

2 3

Re: [PATCH v2 1/2] explorer: Improve tray sizing and style.
by Alexandre Julliard July 13, 2017

July 13, 2017

Zebediah Figura <zfigura(a)codeweavers.com> writes: > v2: use appropriate system metrics. > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > programs/explorer/systray.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) It's mainly a matter of taste, but this doesn't look better to me. In particular having buttons remain pushed when active feels wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcp140: Implement _Stat and _Lstat (v2).
by Stefan Dösinger July 13, 2017

July 13, 2017

Am 2017-07-13 um 15:05 schrieb Stefan Dösinger: +enum msvcp140_file_type { + file_type_not_found = -1, file_type_none, file_type_regular, + file_type_directory, file_type_symlink, file_type_block, + file_type_character, file_type_fifo, file_type_socket, file_type_unknown +}; Please skip this patch for now, with the changes needed to handle _Open_dir I feel it'd be better to consistently use msvcp140_file_type for the name of the enum type and the enum values. I don't plan any functional changes beyond this cosmetic one, so it should be good to review though.

1 0

Re: [2/6] wsdapi: Add code to create SOAP envelope from header and body elements.
by Alexandre Julliard July 13, 2017

July 13, 2017

Owen Rudge <orudge(a)codeweavers.com> writes: > +#define WCHAR_URN_COLON 'u','r','n',':' > +#define WCHAR_HTTP_COLON_SLASH_SLASH 'h','t','t','p',':','/','/' > +#define WCHAR_SCHEMAS 's','c','h','e','m','a','s' > +#define WCHAR_SOAP 's','o','a','p' > +#define WCHAR_XMLSOAP 'x','m','l',WCHAR_SOAP > +#define WCHAR_ORG 'o','r','g' > +#define WCHAR_WS_SLASH 'w','s','/' > +#define WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG WCHAR_SCHEMAS,'.',WCHAR_XMLSOAP,'.',WCHAR_ORG > +#define WCHAR_DISCOVERY 'd','i','s','c','o','v','e','r','y' > +#define WCHAR_MESSAGE 'M','e','s','s','a','g','e' > +#define WCHAR_SEQUENCE 'S','e','q','u','e','n','c','e' > + > +static const WCHAR addressingNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG,'/', > + WCHAR_WS_SLASH,'2','0','0','4','/','0','8','/','a','d','d','r','e','s','s','i','n','g', 0 }; > + > +static const WCHAR discoveryNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG,'/', > + WCHAR_WS_SLASH,'2','0','0','5','/','0','4','/',WCHAR_DISCOVERY, 0 }; > + > +static const WCHAR envelopeNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + 'w','w','w','.','w','3','.',WCHAR_ORG,'/', > + '2','0','0','3','/','0','5','/',WCHAR_SOAP,'-','e','n','v','e','l','o','p','e', 0 }; > + > +static const WCHAR addressingPrefix[] = { 'w','s','a', 0 }; > +static const WCHAR discoveryPrefix[] = { 'w','s','d', 0 }; > +static const WCHAR envelopePrefix[] = { WCHAR_SOAP, 0 }; > +static const WCHAR headerString[] = { 'H','e','a','d','e','r', 0 }; > +static const WCHAR actionString[] = { 'A','c','t','i','o','n', 0 }; > +static const WCHAR messageIdString[] = { WCHAR_MESSAGE,'I','D', 0 }; > +static const WCHAR toString[] = { 'T','o', 0 }; > +static const WCHAR relatesToString[] = { 'R','e','l','a','t','e','s','T','o', 0 }; > +static const WCHAR appSequenceString[] = { 'A','p','p',WCHAR_SEQUENCE, 0 }; > +static const WCHAR instanceIdString[] = { 'I','n','s','t','a','n','c','e','I','d', 0 }; > +static const WCHAR messageNumberString[] = { WCHAR_MESSAGE,'N','u','m','b','e','r', 0 }; > +static const WCHAR sequenceIdString[] = { WCHAR_SEQUENCE,'I','d', 0 }; > +static const WCHAR emptyString[] = { 0 }; I think this would be more readable (and more greppable) without the #defines. -- Alexandre Julliard julliard(a)winehq.org

1 0