September 2017 - Wine-Devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

COM tracing ...
by Michael Meeks Aug. 21, 2018

Aug. 21, 2018

Hi guys, Rather a peripheral question; apologies for that - but I'd imagine there are experts here that may be able to help. I have a black-box problem - a Windows app dealing with confidential data that I can't easily touch (and thus can't get to run under Wine) - which does some small but critical automation of MS Office - using VBS / COM scripting. I'd -really- love some input on how best to trace that series of COM method calls on Windows itself ie. the (remote) service activation, and the RPC beyond that - particularly the method names, parameters etc. of the COM/OLE Office API. I've tried (so far): http://www.rohitab.com/apimonitor which, while closed, looks interesting; but traces a lot in a hard-to-search way and doesn't appear to do the trick. https://support.microsoft.com/en-us/help/926098/how-to-enable-com-and-com-d… Sounds useful: using Event Tracing for Windows (ETW) but has this rather unhelpful property: "The binary file must be formatted by Microsoft so that it can be analyzed. Please forward the .etl files to your support contact. ..." ;-) Component models used to be all the rage in my youth ;-) surely someone solved the "strace for COM calls" problem elegantly some-when ! Crazily - might it be possible to instrument, interpose and use Wine's COM impl. on Windows [ which sounds a bit 'exciting' ;-], or ? Anyhow - help much appreciated & sorry for the noise ! Regards, Michael. -- michael.meeks(a)collabora.com <><, Pseudo Engineer, itinerant idiot

2 4

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

Re: [PATCH] arm64: Use __builtin_ms_va_list and __attribute__((ms_abi)) on arm64
by André Hentschel Feb. 13, 2018

Feb. 13, 2018

Am 14.08.2017 um 12:35 schrieb Martin Storsjo: > Windows uses a different ABI for va_list on arm64 just like on x86_64. > > On x86_64, the calling convention for windows functions is completely > different from the one on other platforms. On arm64, they're mostly the > same, with the only exception being variadic functions (where all float > arguments are passed in integer registers, since the va_list is a single > pointer). > > Any functions using __builtin_ms_va_start need to be decorated with > __attribute__((ms_abi)). > > Add a check in configure for the support of __builtin_ms_va_list > (both features appared in clang at the same time, in the 5.0 release). > > This fixes running binaries that use e.g. printf style functions > (e.g. midl.exe from the windows 10 sdk), fixing > https://bugs.winehq.org/show_bug.cgi?id=38886. > > Signed-off-by: Martin Storsjo <martin(a)martin.st> > --- > clang 5.0, which this requires, isn't yet released, but is in RC2 and > will probably be released pretty soon. > --- > configure.ac | 7 +++++++ > include/msvcrt/crtdefs.h | 6 +++++- > include/windef.h | 6 +++++- > include/wine/test.h | 4 ++-- > 4 files changed, 19 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 7d52b24..c33221f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -179,6 +179,13 @@ case $host in > CFLAGS="$CFLAGS -marm" > AC_SUBST(TARGETFLAGS,"-marm") > ;; > + aarch64*) > + AC_MSG_CHECKING([whether $CC supports __builtin_ms_va_list]) > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdarg.h>]], [[void func(__builtin_ms_va_list *args);]])], > + [AC_MSG_RESULT([yes])], > + [AC_MSG_RESULT([no]) > + AC_MSG_ERROR([You need clang >= 5.0 to build Wine for arm64.])]) Hi, The upstreamed variadic function handling is terrific, thanks for that! I also like this patch as logical next step, I'm just a bit worried because it locks out current builds without upgrading to an RC... At the moment I'm doing winelib builds with gcc for Linux/ARM64 and clang builds for Android/ARM64. It's quite easy on Linux to pick up a new clang version, not sure how long it takes until clang5 is picked up in the Android NDK... On the other hand, there are not much people building Wine for ARM64, and those can pretty easily revert your patch until they are at clang5 OK... We need this improvement, I'll sign it off :) Now, we only need to convince distributions to avoid x18

3 4

Re: [3/3] ole32: Use a shortcut in DataCache_Save only if fSameAsLoad set to TRUE.
by Huw Davies Oct. 19, 2017

Oct. 19, 2017

On Wed, Sep 20, 2017 at 02:54:21PM +0300, Dmitry Timoshkov wrote: > This looks like a typo, and this patch makes saving data in a pretty complex > application work. > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/datacache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index 4e684b4189..c3383176f8 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -1663,7 +1663,7 @@ static HRESULT WINAPI DataCache_Save( > } > > /* this is a shortcut if nothing changed */ > - if (!dirty && !fSameAsLoad && This->presentationStorage) > + if (!dirty && fSameAsLoad && This->presentationStorage) > { > return IStorage_CopyTo(This->presentationStorage, 0, NULL, NULL, pStg); > } No, this isn't a typo. The idea is to copy the loaded storage to a fresh storage that is passed when fSameAsLoad is FALSE. I'm aware that there are issues related to the storage handling in both the cache and the default handler. That's on my list of things to look into, but feel free to investigate further. Huw.

2 7

Re: [PATCH] server_ioctl_file() - Prefix printed hex values with '0x'
by Alexandre Julliard Oct. 12, 2017

Oct. 12, 2017

Chris Morgan <chmorgan(a)gmail.com> writes: > Avoids the ambiguity with non-alphanumeric hex values. > > Signed-off-by: Chris Morgan <chmorgan(a)gmail.com> > --- > dlls/ntdll/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index fd7f3dd..4d081b7 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -1567,7 +1567,7 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > SERVER_END_REQ; > > if (status == STATUS_NOT_SUPPORTED) > - FIXME("Unsupported ioctl %x (device=%x access=%x func=%x method=%x)\n", > + FIXME("Unsupported ioctl 0x%x (device=0x%x access=0x%x func=0x%x method=0x%x)\n", That's mostly a matter of taste, so I don't think it's necessary to change it. -- Alexandre Julliard julliard(a)winehq.org

3 2

Please change WINE logo
by Farhad Mohammadi Majd Oct. 11, 2017

Oct. 11, 2017

Hello, the current WINE logo is really ugly in highest level! and has no concept, please change it with better one, I have a good sample: https://commons.wikimedia.org/wiki/File:Wine_bw.png It is really beautiful and Window$ logo shows its relationship with M$ Windows, I hope this logo is legal. .

7 17

Wine Swag Sticker Poll
by Aric Stewart Oct. 10, 2017

Oct. 10, 2017

Hello! So all the way back at wineconf I volunteered to be swag master for winehq. The idea is to have something that can be given away at trade shows, presentations, LUG visits and the like. Just something to help promote the visibility of the project. Jana here, CodeWeavers marketing director, has put together a sampling of designs to do as our first sticker and so now we are looking for some feedback on what people prefer. https://docs.google.com/forms/d/e/1FAIpQLSd5X_fXe9KSFAppRHz8kUo3XKeODyH5KeX… Rosanne? Could you direct me as to where this should be put up for the users as well? I am unfamiliar with how to communicate to our user base. The poll will run for as long as it feels like it needs to get some sort of winner. Comments and suggestions are always welcome! -aric

7 10

Re: [PATCH] midimap: Add warning for user in case midi won't work
by Matteo Bruni Sept. 29, 2017

Sept. 29, 2017

2017-09-23 22:52 GMT+02:00 Fabian Maurer <dark.shadow4(a)web.de>: > When no midi port or only the midi-through port > is found, we can inform the user that midi > won't work as expected. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/midimap/midimap.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/dlls/midimap/midimap.c b/dlls/midimap/midimap.c > index 64b4dc8546..c80834515b 100644 > --- a/dlls/midimap/midimap.c > +++ b/dlls/midimap/midimap.c > @@ -553,6 +553,7 @@ static LRESULT MIDIMAP_drvOpen(void) > { > MIDIOUTCAPSW moc; > unsigned dev, i; > + WCHAR throughportW[] = {'M','i','d','i',' ','T','h','r','o','u','g','h',0}; > > if (midiOutPorts) > return 0; > @@ -578,6 +579,13 @@ static LRESULT MIDIMAP_drvOpen(void) > } > } > > + if(numMidiOutPorts == 0) > + MESSAGE("Midi sound output won't work - No midi port found.\n"); > + else if(numMidiOutPorts == 1 && midiOutPorts[0].loaded == -1) > + MESSAGE("Midi sound output won't work - No working midi port found.\n"); > + else if(numMidiOutPorts == 1 && strncmpW(midiOutPorts[0].name, throughportW, strlenW(throughportW)) == 0) > + MESSAGE("Midi sound output probably won't work - Only 'midi through' port found. Make sure your setup is correct.\n"); > + > return 1; > } Since you have to resend anyway... The string comparison doesn't look correct to me, I think that breaks if the midi port name has a prefix matching the throughportW string. I guess it's not going to be a problem in practice but it seems better to do it right anyway. There should be a space between 'if' and the '(', like elsewhere in the function and source file.

2 3

Re: [PATCH 3/3] mshtml/tests: Run events tests in IE9 mode.
by Alexandre Julliard Sept. 29, 2017

Sept. 29, 2017

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/mshtml/tests/events.c | 132 > +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 103 insertions(+), 29 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so events && touch events.ok events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1191: Test failed: pdp->cArgs = 1 Makefile:267: recipe for target 'events.ok' failed make[1]: *** [events.ok] Error 37 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] mshtml: Inherit document mode from parent document.
by Marvin Sept. 29, 2017

Sept. 29, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33334 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: mshtml: Inherit document mode from parent document.
by Gijs Vermeulen Sept. 29, 2017

Sept. 29, 2017

Hi, 2017-09-28 19:50 GMT+02:00 Jacek Caban <jacek(a)codeweavers.com>: > > + TRACE("parnet mode %u\n", parent_mode); > > There seems to be a typo here. Sincerely, Gijs

2 1

Re: [v7 1/5] server: Named pipe query SD from pipe object
by Jacek Caban Sept. 29, 2017

Sept. 29, 2017

Hi Jonathan, Your tests still don't really show intended behaviour. Your calls that set security descriptor use new SD that has the same tested values as before the call, then what's the point in setting it? Anyway, I cleaned it up and changed a bit to see how it's really supposed to work. See the attachment. It looks like client and served should indeed share security descriptor, but pipe object should not, so that part is wrong. Thanks, Jacek

2 2

Re: mshtml: Inherit document mode from parent document.
by Marvin Sept. 28, 2017

Sept. 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33325 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH] midimap: Add warning for user in case midi won't work
by Alexandre Julliard Sept. 28, 2017

Sept. 28, 2017

Fabian Maurer <dark.shadow4(a)web.de> writes: > When no midi port or only the midi-through port > is found, we can inform the user that midi > won't work as expected. This should probably use the winediag debug channel. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/3] hlink/tests: Add tests for navigating from a string reference.
by Jacek Caban Sept. 28, 2017

Sept. 28, 2017

Hi Zebediah, This test leaves iexplore instance running on Wine. Jacek

2 1

Re: [PATCH 2/9] sapi: Implement SpDataKey::SetKey().
by Marvin Sept. 28, 2017

Sept. 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33314 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

2 1

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1
by Dmitry Timoshkov Sept. 28, 2017

Sept. 28, 2017

Michael Stefaniuc <mstefani(a)winehq.org> wrote: > -UnderlinePosition: -100 > -UnderlineWidth: 50 > -Ascent: 11 > -Descent: 2 > +UnderlinePosition: -15753.8 > +UnderlineWidth: 7876.92 > +Ascent: 1733 > +Descent: 315 > +InvalidEm: 0 > LayerCount: 2 > Layer: 0 0 "Back" 1 > Layer: 1 0 "Fore" 0 > @@ -21,7 +22,7 @@ OS2_UseTypoMetrics: 0 > PfmFamily: 49 > TTFWeight: 400 > TTFWidth: 5 > -LineGap: 1 > +LineGap: 158 > VLineGap: 0 > Panose: 2 0 6 9 0 0 0 0 0 0 > OS2TypoAscent: 0 > @@ -56,770 +57,770 @@ BeginChars: 65536 498 > > StartChar: space > Encoding: 32 32 0 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar > > StartChar: exclam > Encoding: 33 33 1 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar Did you test that after this patch font and glyph metrics still stay the same? -- Dmitry.

2 3

Re: [PATCH 9/9] sapi: Add a partial implementation of SpObjectTokenCategory::EnumTokens().
by Marvin Sept. 28, 2017

Sept. 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33316 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [PATCH 6/9] sapi: Add a partial implementation of SpObjectTokenEnum::Next().
by Marvin Sept. 28, 2017

Sept. 28, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33315 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

WineTest does not run the vcomp tests
by Francois Gouget Sept. 28, 2017

Sept. 28, 2017

So WineTest is not running the vcomp tests. What happens is this: * It parses the vcomp_test.exe filename and concludes that this tests the vcomp dll. * It does a LoadLibraryExA("vcomp.dll", NULL, LOAD_LIBRARY_AS_DATAFILE) which fails (as expected) and concludes that the dll is missing: vcomp=dll is missing * Since the dll is missing WineTest skips the vcomp tests. According to Dan Kegel this is a manifest / activation context issue and he sent a patch for it [1]. However the patch was for the TestBot [2], not WineTest, and as far as I can tell it's not working. Furthermore WineTest already has activation context code that seems equivalent to Dan Kegel's patch. Does anyone know how to fix WineTest? [1] https://bugs.winehq.org/show_bug.cgi?id=31609 https://www.winehq.org/pipermail/wine-patches/2012-September/117631.html [2] Paradoxically the TestBot has no problem running the vcomp tests now that they dynamically load the vcomp dll. That's because the TestBot makes no assumption based on the executable filename since one can upload test binaries that don't follow any naming scheme. So now the test dynamically loads vcomp.dll the TestBot cannot check for it. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 2

Re: user.exe16: Support Windows 1.x and 2.x Menus
by Alexandre Julliard Sept. 28, 2017

Sept. 28, 2017

Martin Payne <development(a)martinpayne.me.uk> writes: > Added support for Windows 1.x / 2.x menu resources to > LoadMenuIndirect16. The format of these are slightly different from > Windows 3.x menus which causes them to fail to load. Where did you find an app that needs this? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 6/6] shell32: Implement FolderItem::Name() property getter
by Marvin Sept. 27, 2017

Sept. 27, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33296 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:635: Test failed: file_defs[1]: unexpected name L"01-empty".

2 1

Re: [PATCH] ole32: CreateDataCache should return a COleCache object by default.
by Huw Davies Sept. 26, 2017

Sept. 26, 2017

On Tue, Sep 26, 2017 at 01:00:08AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ole32/datacache.c | 5 ++++- > dlls/ole32/tests/ole2.c | 10 ++++++++-- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index a95d0fb..c563118 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -2760,7 +2760,10 @@ HRESULT WINAPI CreateDataCache( > if (newCache == 0) > return E_OUTOFMEMORY; > > - hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, riid, ppvObj); > + if ( !pUnkOuter && IsEqualIID(&IID_IUnknown, riid) ) > + hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, &IID_IOleCache2, ppvObj); > + else > + hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, riid, ppvObj); > IUnknown_Release(&newCache->IUnknown_inner); But now if you call QI(IID_IUnknown) on this interface you'll get back something different, which is wrong. You'll need to do some more restructing to make this correct. Btw, is there a bug that depends on this? > diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c > index b30f63b..39b161c 100644 > --- a/dlls/ole32/tests/ole2.c > +++ b/dlls/ole32/tests/ole2.c > @@ -1575,6 +1575,7 @@ static void test_data_cache(void) > char szSystemDir[MAX_PATH]; > WCHAR wszPath[MAX_PATH]; > static const WCHAR wszShell32[] = {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + DWORD connection; > > static const struct expected_method methods_cacheinitnew[] = > { > @@ -1651,14 +1652,19 @@ static void test_data_cache(void) > ok(hr == S_OK, "got 0x%08x\n", hr); > hr = IUnknown_QueryInterface(unk, &IID_IOleCache2, (void**)&pOleCache); > ok(hr == S_OK, "got 0x%08x\n", hr); > -todo_wine { > ok(unk == (IUnknown*)olecache, "got %p, expected %p\n", olecache, unk); > ok(unk == (IUnknown*)pOleCache, "got %p, expected %p\n", pOleCache, unk); > -} > + > IOleCache2_Release(pOleCache); > IOleCache_Release(olecache); > IUnknown_Release(unk); > > + hr = CreateDataCache(NULL, &CLSID_NULL, &IID_IUnknown, (void**)&olecache); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + hr = IOleCache_Cache(olecache, &fmtetc, ADVF_PRIMEFIRST | ADVFCACHE_NOHANDLER, &connection); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + IOleCache_Release(olecache); > + A better test would be to call QI(IID_IOleCache) on the returned IUnknown* and show that it's the same. You could also QI(IID_IUnknown) to test for my comment above. Huw.

2 1