September 2017 - Wine-Devel

Re: [PATCH 4/4] mshtml: Expose IHTMLElement6 to scripts.
by Marvin Sept. 13, 2017

Sept. 13, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33084 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH 5/5] wined3d: Don't take the upload code path if the destination surface is onscreen.
by Henri Verbeet Sept. 13, 2017

Sept. 13, 2017

On 12 September 2017 at 21:22, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/wined3d/surface.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Why would we want to avoid that?

2 2

Re: [v4 1/4] strmiids: Add evr interface GUIDS
by Alexandre Julliard Sept. 12, 2017

Sept. 12, 2017

Fabian Maurer <dark.shadow4(a)web.de> writes: > evr GUIDs should be defined in strmiids.lib This seems to be adding many GUIDs that are not supposed to be there. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] comctl32/tests: Dump sequence correctly
by Nikolay Sivov Sept. 12, 2017

Sept. 12, 2017

On 09/12/2017 07:17 PM, Fabian Maurer wrote: > The "expected" pointer already got moved in the function, > make sure to use the full list of expected messages. Yes, that makes sense, thanks. Please make it look closer to how it's done in user32, see attached diff.

2 1

Re: [PATCH 1/2] comctl32/taskdialog: Initial support for callback procedure
by Fabian Maurer Sept. 12, 2017

Sept. 12, 2017

Hi, Sorry, but there's a bunch of issues I need to point out. Of course we could address them later, but it'll mean rewriting a bunch of code, and I'd like to have it correct from the beginning. In general, I think this implementation limits us too much. For example, I don't think it's a good idea to have the TASKDIALOGCONFIG structure being filled in run_test_, we need to be able to control it easily. Second, we also need to be able to return different values in the callback, the current approach doesn't account for that. And the most important part, the separation from messages to send and received messages to test against. It's better to send the next message only when the last message arrived, to make sure we process them in the correct order. I attached a patch to show the problem (apply on top of my in-review patch). When sending all messages together, the first message is skipped, and we don't want that to happen. Please reconsider my approach, I can try to simplify it if you want, but I think the complexity is justified to solve a complicated problem. Regards, Fabian Maurer

2 3

Re: [v4 2/4] evr: Add tests
by Marvin Sept. 12, 2017

Sept. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33066 Your paranoid android. === build (build) === Make failed

2 1

Re: [1/6] wsdapi: Add wsdapi_internal.h for shared internal function and macro definitions. [try 3]
by Owen Rudge Sept. 12, 2017

Sept. 12, 2017

Hi Alexandre, Is there anything else that needs improving for these patches to be accepted? Thanks, -- Owen Rudge http://www.owenrudge.net/

2 1

Re: [PATCH 7/7] mshtml: Added IHTMLDocument7::getElementsByClassName implementation.
by Marvin Sept. 12, 2017

Sept. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33062 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 6/7] mshtml: Added IHTMLDocument7::head property implementation.
by Marvin Sept. 12, 2017

Sept. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33061 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH 5/7] mshtml: Expose IHTMLDocument7 interface to scripts.
by Marvin Sept. 12, 2017

Sept. 12, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33060 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0