July 2018 - Wine-Devel - list.winehq.org

[PATCH] comctl32: the item gets characters not bytes passed in
by Marcus Meissner July 2, 2018

July 2, 2018

Signed-off-by: Marcus Meissner <meissner(a)suse.de> --- dlls/comctl32/treeview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c index b0b8325e25..bbef651597 100644 --- a/dlls/comctl32/treeview.c +++ b/dlls/comctl32/treeview.c @@ -4694,7 +4694,7 @@ static INT TREEVIEW_ProcessLetterKeys(TREEVIEW_INFO *infoPtr, WPARAM charCode, L item.mask = TVIF_TEXT; item.hItem = idx; item.pszText = buffer; - item.cchTextMax = sizeof(buffer); + item.cchTextMax = ARRAY_SIZE(buffer); TREEVIEW_GetItemT( infoPtr, &item, TRUE ); /* check for a match */ -- 2.17.1

1 0

[PATCH] user32: Add semi-stub for GetAutoRotationState.
by Alistair Leslie-Hughes July 2, 2018

July 2, 2018

From: Michael Müller <michael(a)fds-team.de> We cannot check the status value reliable since there is a good change that all the possible values will be returned from different setups. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/user32/sysparams.c | 11 +++++++++-- dlls/user32/tests/sysparams.c | 24 ++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/dlls/user32/sysparams.c b/dlls/user32/sysparams.c index 3245f20..fc55b06 100644 --- a/dlls/user32/sysparams.c +++ b/dlls/user32/sysparams.c @@ -3387,8 +3387,15 @@ BOOL WINAPI PhysicalToLogicalPointForPerMonitorDPI( HWND hwnd, POINT *pt ) */ BOOL WINAPI GetAutoRotationState( AR_STATE *state ) { - FIXME("(%p): stub\n", state); - *state = AR_NOT_SUPPORTED; + TRACE("(%p)\n", state); + + if (!state) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + *state = AR_NOSENSOR; return TRUE; } diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c index 3db058f..fec37b6 100644 --- a/dlls/user32/tests/sysparams.c +++ b/dlls/user32/tests/sysparams.c @@ -55,6 +55,7 @@ static INT (WINAPI *pGetSystemMetricsForDpi)(INT,UINT); static BOOL (WINAPI *pSystemParametersInfoForDpi)(UINT,UINT,void*,UINT,UINT); static BOOL (WINAPI *pLogicalToPhysicalPointForPerMonitorDPI)(HWND,POINT*); static BOOL (WINAPI *pPhysicalToLogicalPointForPerMonitorDPI)(HWND,POINT*); +static LONG (WINAPI *pGetAutoRotationState)(PAR_STATE); static BOOL strict; static int dpi, real_dpi; @@ -3621,6 +3622,27 @@ static void test_dpi_window(void) pSetThreadDpiAwarenessContext( orig ); } +static void test_GetAutoRotationState(void) +{ + AR_STATE state; + BOOL ret; + + if (!pGetAutoRotationState) + { + win_skip("GetAutoRotationState not supported\n"); + return; + } + + SetLastError(0xdeadbeef); + ret = pGetAutoRotationState(NULL); + ok(!ret, "Expected GetAutoRotationState to fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); + + state = 0; + ret = pGetAutoRotationState(&state); + ok(ret, "Expected GetAutoRotationState to succeed, error %d\n", GetLastError()); +} + START_TEST(sysparams) { int argc; @@ -3650,6 +3672,7 @@ START_TEST(sysparams) pSystemParametersInfoForDpi = (void*)GetProcAddress(hdll, "SystemParametersInfoForDpi"); pLogicalToPhysicalPointForPerMonitorDPI = (void*)GetProcAddress(hdll, "LogicalToPhysicalPointForPerMonitorDPI"); pPhysicalToLogicalPointForPerMonitorDPI = (void*)GetProcAddress(hdll, "PhysicalToLogicalPointForPerMonitorDPI"); + pGetAutoRotationState = (void*)GetProcAddress(hdll, "GetAutoRotationState"); hInstance = GetModuleHandleA( NULL ); hdc = GetDC(0); @@ -3671,6 +3694,7 @@ START_TEST(sysparams) test_metrics_for_dpi( 192 ); test_EnumDisplaySettings( ); test_GetSysColorBrush( ); + test_GetAutoRotationState( ); change_counter = 0; change_last_param = 0; -- 1.9.1

2 1

[PATCH] comctl32: listinfow struct gets characters not bytes
by Marcus Meissner July 2, 2018

July 2, 2018

Signed-off-by: Marcus Meissner <meissner(a)suse.de> --- dlls/comctl32/tests/listview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index e9b715ee41..c118f02026 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -5490,7 +5490,7 @@ static void test_header_notification2(void) memset(&itemW, 0, sizeof(itemW)); itemW.mask = HDI_WIDTH | HDI_ORDER | HDI_TEXT; itemW.pszText = buffer; - itemW.cchTextMax = sizeof(buffer); + itemW.cchTextMax = ARRAY_SIZE(buffer); ret = SendMessageW(header, HDM_GETITEMW, 0, (LPARAM)&itemW); expect(1, ret); -- 2.17.1

1 0

[PATCH] winecfg: recommend against overriding secur32
by Austin English July 1, 2018

July 1, 2018

-- -Austin GPG: 267B CC1F 053F 0749 (expires 2021/02/18)

1 0

[PATCH] winecfg: recommend against overriding sspicli
by Austin English July 1, 2018

July 1, 2018

-- -Austin GPG: 267B CC1F 053F 0749 (expires 2021/02/18)

1 1

Bugzilla permissions for Wine developers
by Austin English July 1, 2018

July 1, 2018

Howdy all, Because several people asked me at Wineconf, I wanted to clarify something regarding bugzilla. All Wine developers are entitled to bugzilla triage permissions, all you need to do is ask. I've made a note on https://wiki.winehq.org/Bugs, so it's there for the future, but if you: * Have commits in Wine or * Are active in Bugzilla (and aren't known for making comments of little or not value ;) ) and you want to triage bugs (i.e., add keywords, change component, mark stuff fixed, etc.), please send me and email and I'll get you set up. Thanks, and happy hacking! -- -Austin GPG: 267B CC1F 053F 0749 (expires 2021/02/18)

1 0

[PATCH] dissect: Raise the Windows 10 failed tests limit for 1709.
by Francois Gouget July 1, 2018

July 1, 2018

Windows 10 1709 has so many new test failures that its WineTest reports get rejected. But developers cannot fix test failures they are not aware of, resulting in slow progress. So temporarily increase the Windows 10 limit. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- winetest/dissect | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winetest/dissect b/winetest/dissect index 4db4f85b7..24d562154 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -368,6 +368,8 @@ foreach my $entry (@idmatch) last; } } +# Give a little slack to the Windows 10 1709. +$maxfailedtests += 20 if ($version eq "win10"); if ($prediluvian and not $acceptprediluvianwin) { -- 2.18.0

1 0

[PATCH] testbot/WineRunTask: Fix the WineTest suite command.
by Francois Gouget July 1, 2018

July 1, 2018

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/WineRunTask.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl index fb2966303..0f2a093e1 100755 --- a/testbot/bin/WineRunTask.pl +++ b/testbot/bin/WineRunTask.pl @@ -461,7 +461,7 @@ elsif ($Step->Type eq "suite") if (defined($WebHostName)) { my $StepTask = 100 * $StepNo + $TaskNo; - $Script .= "-u \"http://$WebHostName/JobDetails.pl?Key=$JobId&s$StepTask=1#k$StepTask\""; + $Script .= "-u \"http://$WebHostName/JobDetails.pl?Key=$JobId&s$StepTask=1#k$StepTask\" "; } my $Info = $VM->Description ? $VM->Description : ""; if ($VM->Details) -- 2.18.0

1 0

[website] zh-cn: Update Simplified Chinese translation.
by Jactry Zeng July 1, 2018

July 1, 2018

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> --- templates/zh-cn/global/layout/content.template | 87 +++++++++++++++++++ templates/zh-cn/home.template | 113 ++++++++++++++++++++----- templates/zh-cn/search.template | 32 +++---- 3 files changed, 192 insertions(+), 40 deletions(-) create mode 100644 templates/zh-cn/global/layout/content.template

1 0

ole32/tests: Don't crash if EnumFormatEtc failed
by André Hentschel July 1, 2018

July 1, 2018

Signed-off-by: André Hentschel <nerv(a)dawncrow.de> --- dlls/ole32/tests/clipboard.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c index 4890782..e518996 100644 --- a/dlls/ole32/tests/clipboard.c +++ b/dlls/ole32/tests/clipboard.c @@ -589,6 +589,11 @@ static void test_enum_fmtetc(IDataObject *src) hr = IDataObject_EnumFormatEtc(data, DATADIR_GET, &enum_fmt); ok(hr == S_OK, "got %08x\n", hr); ok(DataObjectImpl_EnumFormatEtc_calls == 0, "EnumFormatEtc was called\n"); + if (FAILED(hr)) + { + skip("EnumFormatEtc failed, skipping tests.\n"); + return; + } if(src) IDataObject_EnumFormatEtc(src, DATADIR_GET, &src_enum); @@ -1422,6 +1427,11 @@ static void test_nonole_clipboard(void) ok(hr == S_OK, "got %08x\n", hr); hr = IDataObject_EnumFormatEtc(get, DATADIR_GET, &enum_fmt); ok(hr == S_OK, "got %08x\n", hr); + if (FAILED(hr)) + { + skip("EnumFormatEtc failed, skipping tests.\n"); + return; + } hr = IEnumFORMATETC_Next(enum_fmt, 1, &fmt, NULL); ok(hr == S_OK, "got %08x\n", hr); -- 2.7.4

1 0