September 2020 - Wine-Devel

[PATCH] comdlg32: Fix error precedence in IFileDialog2_SetFileTypes
by Alex Henrie Sept. 10, 2020

Sept. 10, 2020

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- Discovered while debugging ShareX. --- dlls/comdlg32/itemdlg.c | 6 +++--- dlls/comdlg32/tests/itemdlg.c | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c index 1ae20ca782..f17c2f926d 100644 --- a/dlls/comdlg32/itemdlg.c +++ b/dlls/comdlg32/itemdlg.c @@ -2402,12 +2402,12 @@ static HRESULT WINAPI IFileDialog2_fnSetFileTypes(IFileDialog2 *iface, UINT cFil UINT i; TRACE("%p (%d, %p)\n", This, cFileTypes, rgFilterSpec); - if(This->filterspecs) - return E_UNEXPECTED; - if(!rgFilterSpec) return E_INVALIDARG; + if(This->filterspecs) + return E_UNEXPECTED; + if(!cFileTypes) return S_OK; diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c index 6ee0d5fc3d..c38457a0a1 100644 --- a/dlls/comdlg32/tests/itemdlg.c +++ b/dlls/comdlg32/tests/itemdlg.c @@ -675,6 +675,8 @@ static void test_basics(void) ok(hr == S_OK, "got 0x%08x.\n", hr); hr = IFileOpenDialog_SetFileTypes(pfod, 0, filterspec); ok(hr == E_UNEXPECTED, "got 0x%08x.\n", hr); + hr = IFileOpenDialog_SetFileTypes(pfod, 0, NULL); + ok(hr == E_INVALIDARG, "got 0x%08x.\n", hr); hr = IFileOpenDialog_SetFileTypeIndex(pfod, 0); ok(hr == S_OK, "got 0x%08x.\n", hr); hr = IFileOpenDialog_GetFileTypeIndex(pfod, &filetype); -- 2.28.0

2 1

[PATCH] user32/menu: Store application defined value as pointer
by Fabian Maurer Sept. 10, 2020

Sept. 10, 2020

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49805 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/user32/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/menu.c b/dlls/user32/menu.c index 3b1e3f25f42..59c2083c17c 100644 --- a/dlls/user32/menu.c +++ b/dlls/user32/menu.c @@ -104,7 +104,7 @@ typedef struct { UINT cyMax; /* max height of the whole menu, 0 is screen height */ HBRUSH hbrBack; /* brush for menu background */ DWORD dwContextHelpID; - DWORD dwMenuData; /* application defined value */ + ULONG_PTR dwMenuData; /* application defined value */ HMENU hSysMenuOwner; /* Handle to the dummy sys menu holder */ WORD textOffset; /* Offset of text when items have both bitmaps and text */ } POPUPMENU, *LPPOPUPMENU; -- 2.28.0

2 1

[PATCH] server: Fix some alt + hotkeys dont' work if the msg param is WM_SYSKEYDOWN in queue_hotkey_message function.
by Yongjie Yao Sept. 10, 2020

Sept. 10, 2020

1 0

[PATCH v3] comdlg32/tests: Add test for overwrite when IFileDialog set FOS_PICKFOLDERS option.
by Jiangyi Chen Sept. 10, 2020

Sept. 10, 2020

2 1

[PATCH] server: Fix some alt + hotkeys dont' work if the msg param is WM_SYSKEYDOWN in queue_hotkey_message function.
by Yongjie Yao Sept. 10, 2020

Sept. 10, 2020

1 0

Re: [PATCH] shell32: Skip OpenAs_RunDLL in uri
by Nikolay Sivov Sept. 10, 2020

Sept. 10, 2020

On 9/8/20 12:28 PM, Haoyang Chen wrote: > > Through windows 7, I found that OpenAs_RunDLL functions will open a > dialog that can choose to specify the application. my idea is to skip > this OpenAs_RunDLL and use wine's default application execution. > > eg: ShellExecuteW(NULL, L"open", L"rundll32.exe", L"shell32.dll, > OpenAs_RunDLL https://www.winehq.org/", NULL, SW_SHOW); If it's only meant to open a dialog, why would you shellexec instead? P.S. please cc wine-devel on replies. > > 在 2020/9/8 下午3:57, Nikolay Sivov 写道: >> It's probably easier to implement OpenAs_RunDLL(). What is the full >> command line and what is supposed to happen on OpenAs_RunDLL() call? >> >> >> >> > >

2 3

[PATCH v2] comdlg32/tests: Add test for overwrite when IFileDialog set FOS_PICKFOLDERS option.
by Jiangyi Chen Sept. 10, 2020

Sept. 10, 2020

2 1

[PATCH] msxml3: Fix a memory leak (Valgrind).
by 阿杰 Sept. 10, 2020

Sept. 10, 2020

==1461== 8 bytes in 1 blocks are possibly lost in loss record 178 of 3,995 ==1461== at 0x7BC6F0DA: notify_alloc (heap.c:260) ==1461== by 0x7BC731BB: RtlAllocateHeap (heap.c:1725) ==1461== by 0x7B04CEC2: LocalAlloc (memory.c:606) ==1461== by 0x7B04CD6A: GlobalAlloc (memory.c:570) ==1461== by 0x5D9FC30: CreateStreamOnHGlobal (hglobalstream.c:600) ==1461== by 0x20580F06: domdoc_load_from_stream (domdoc.c:780)

1 0

[PATCH v3] comdlg32: Fix the wrong popup when saving the same file again in the same directory.
by Jiangyi Chen Sept. 10, 2020

Sept. 10, 2020

1 0

[PATCH v2] comdlg32: Fix the wrong popup when saving the same file again in the same directory.
by Jiangyi Chen Sept. 10, 2020

Sept. 10, 2020

1 0