September 2021 - Wine-Devel

[PATCH vkd3d 5/5] vkd3d-shader: Introduce shader_sm4_reset().
by Henri Verbeet Sept. 2, 2021

Sept. 2, 2021

This allows us to drop the "ptr" argument to various functions. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- libs/vkd3d-shader/dxbc.c | 21 ++++++++++++++------- libs/vkd3d-shader/glsl.c | 4 ++-- libs/vkd3d-shader/trace.c | 7 +++---- libs/vkd3d-shader/vkd3d_shader_main.c | 13 ++++++++----- libs/vkd3d-shader/vkd3d_shader_private.h | 9 ++++----- 5 files changed, 31 insertions(+), 23 deletions(-) diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 99a085f1..86cd0ec0 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -1110,12 +1110,11 @@ static struct vkd3d_shader_src_param *get_src_param(struct vkd3d_sm4_data *priv) return &e->param; } -void shader_sm4_read_header(struct vkd3d_shader_parser *parser, - const uint32_t **ptr, struct vkd3d_shader_version *shader_version) +void shader_sm4_read_header(struct vkd3d_shader_parser *parser, struct vkd3d_shader_version *shader_version) { struct vkd3d_sm4_data *sm4 = parser->data; - *ptr = sm4->start; + parser->ptr = sm4->start; *shader_version = sm4->shader_version; } @@ -1527,12 +1526,12 @@ static void shader_sm4_read_instruction_modifier(DWORD modifier, struct vkd3d_sh } } -void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, - const uint32_t **ptr, struct vkd3d_shader_instruction *ins) +void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, struct vkd3d_shader_instruction *ins) { const struct vkd3d_sm4_opcode_info *opcode_info; uint32_t opcode_token, opcode, previous_token; struct vkd3d_sm4_data *sm4 = parser->data; + const uint32_t **ptr = &parser->ptr; unsigned int i, len; size_t remaining; const DWORD *p; @@ -1647,10 +1646,18 @@ fail: return; } -bool shader_sm4_is_end(struct vkd3d_shader_parser *parser, const uint32_t **ptr) +bool shader_sm4_is_end(struct vkd3d_shader_parser *parser) { struct vkd3d_sm4_data *sm4 = parser->data; - return *ptr == sm4->end; + + return parser->ptr == sm4->end; +} + +void shader_sm4_reset(struct vkd3d_shader_parser *parser) +{ + struct vkd3d_sm4_data *sm4 = parser->data; + + parser->ptr = sm4->start; } static bool require_space(size_t offset, size_t count, size_t size, size_t data_size) diff --git a/libs/vkd3d-shader/glsl.c b/libs/vkd3d-shader/glsl.c index 9824840f..b304addc 100644 --- a/libs/vkd3d-shader/glsl.c +++ b/libs/vkd3d-shader/glsl.c @@ -104,9 +104,9 @@ int vkd3d_glsl_generator_generate(struct vkd3d_glsl_generator *generator, vkd3d_string_buffer_printf(&generator->buffer, "#version 440\n\n"); vkd3d_string_buffer_printf(&generator->buffer, "void main()\n{\n"); - while (!shader_sm4_is_end(parser, &parser->ptr)) + while (!shader_sm4_is_end(parser)) { - shader_sm4_read_instruction(parser, &parser->ptr, &ins); + shader_sm4_read_instruction(parser, &ins); if (ins.handler_idx == VKD3DSIH_INVALID) { diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 409ed550..1dca1ae2 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -1781,7 +1781,6 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, struct vkd3d_string_buffer *buffer; unsigned int indent, i; const char *indent_str; - const DWORD *ptr; void *code; static const struct vkd3d_d3d_asm_colours no_colours = @@ -1831,17 +1830,17 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, vkd3d_string_buffer_init(buffer); shader_version = &compiler.shader_version; - shader_sm4_read_header(parser, &ptr, shader_version); + shader_sm4_read_header(parser, shader_version); vkd3d_string_buffer_printf(buffer, "%s%s_%u_%u%s\n", compiler.colours.version, shader_get_type_prefix(shader_version->type), shader_version->major, shader_version->minor, compiler.colours.reset); indent = 0; - while (!shader_sm4_is_end(parser, &ptr)) + while (!shader_sm4_is_end(parser)) { struct vkd3d_shader_instruction ins; - shader_sm4_read_instruction(parser, &ptr, &ins); + shader_sm4_read_instruction(parser, &ins); if (ins.handler_idx == VKD3DSIH_INVALID) { WARN("Skipping unrecognized instruction.\n"); diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index b108fa65..5d7cdf01 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -388,7 +388,7 @@ static int vkd3d_shader_parser_init(struct vkd3d_shader_parser *parser, return VKD3D_ERROR_INVALID_ARGUMENT; } - shader_sm4_read_header(parser, &parser->ptr, &parser->shader_version); + shader_sm4_read_header(parser, &parser->shader_version); return VKD3D_OK; } @@ -952,11 +952,14 @@ static int scan_dxbc(const struct vkd3d_shader_compile_info *compile_info, } if (TRACE_ON()) + { vkd3d_shader_trace(&parser); + shader_sm4_reset(&parser); + } - while (!shader_sm4_is_end(&parser, &parser.ptr)) + while (!shader_sm4_is_end(&parser)) { - shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); + shader_sm4_read_instruction(&parser, &instruction); if (instruction.handler_idx == VKD3DSIH_INVALID) { @@ -1085,9 +1088,9 @@ static int compile_dxbc_tpf(const struct vkd3d_shader_compile_info *compile_info return VKD3D_ERROR; } - while (!shader_sm4_is_end(&parser, &parser.ptr)) + while (!shader_sm4_is_end(&parser)) { - shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); + shader_sm4_read_instruction(&parser, &instruction); if (instruction.handler_idx == VKD3DSIH_INVALID) { diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index 6d044c51..b9c2ccea 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -891,11 +891,10 @@ struct vkd3d_shader_message_context; void *shader_sm4_init(const DWORD *byte_code, size_t byte_code_size, const struct vkd3d_shader_signature *output_signature, struct vkd3d_shader_message_context *message_context); void shader_sm4_free(struct vkd3d_shader_parser *parser); -void shader_sm4_read_header(struct vkd3d_shader_parser *parser, - const uint32_t **ptr, struct vkd3d_shader_version *shader_version); -void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, - const uint32_t **ptr, struct vkd3d_shader_instruction *ins); -bool shader_sm4_is_end(struct vkd3d_shader_parser *parser, const uint32_t **ptr); +void shader_sm4_read_header(struct vkd3d_shader_parser *parser, struct vkd3d_shader_version *shader_version); +void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, struct vkd3d_shader_instruction *ins); +bool shader_sm4_is_end(struct vkd3d_shader_parser *parser); +void shader_sm4_reset(struct vkd3d_shader_parser *parser); struct vkd3d_string_buffer { -- 2.20.1

1 0

[PATCH vkd3d 4/5] vkd3d-shader: Pass a vkd3d_shader_parser structure to shader_sm4_is_end().
by Henri Verbeet Sept. 2, 2021

Sept. 2, 2021

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- libs/vkd3d-shader/dxbc.c | 6 +++--- libs/vkd3d-shader/glsl.c | 2 +- libs/vkd3d-shader/trace.c | 2 +- libs/vkd3d-shader/vkd3d_shader_main.c | 4 ++-- libs/vkd3d-shader/vkd3d_shader_private.h | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 99c32ae2..99a085f1 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -1647,10 +1647,10 @@ fail: return; } -bool shader_sm4_is_end(void *data, const DWORD **ptr) +bool shader_sm4_is_end(struct vkd3d_shader_parser *parser, const uint32_t **ptr) { - struct vkd3d_sm4_data *priv = data; - return *ptr == priv->end; + struct vkd3d_sm4_data *sm4 = parser->data; + return *ptr == sm4->end; } static bool require_space(size_t offset, size_t count, size_t size, size_t data_size) diff --git a/libs/vkd3d-shader/glsl.c b/libs/vkd3d-shader/glsl.c index 04d948c2..9824840f 100644 --- a/libs/vkd3d-shader/glsl.c +++ b/libs/vkd3d-shader/glsl.c @@ -104,7 +104,7 @@ int vkd3d_glsl_generator_generate(struct vkd3d_glsl_generator *generator, vkd3d_string_buffer_printf(&generator->buffer, "#version 440\n\n"); vkd3d_string_buffer_printf(&generator->buffer, "void main()\n{\n"); - while (!shader_sm4_is_end(parser->data, &parser->ptr)) + while (!shader_sm4_is_end(parser, &parser->ptr)) { shader_sm4_read_instruction(parser, &parser->ptr, &ins); diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 3e2b1523..409ed550 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -1837,7 +1837,7 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, shader_version->minor, compiler.colours.reset); indent = 0; - while (!shader_sm4_is_end(parser->data, &ptr)) + while (!shader_sm4_is_end(parser, &ptr)) { struct vkd3d_shader_instruction ins; diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 56611772..b108fa65 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -954,7 +954,7 @@ static int scan_dxbc(const struct vkd3d_shader_compile_info *compile_info, if (TRACE_ON()) vkd3d_shader_trace(&parser); - while (!shader_sm4_is_end(parser.data, &parser.ptr)) + while (!shader_sm4_is_end(&parser, &parser.ptr)) { shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); @@ -1085,7 +1085,7 @@ static int compile_dxbc_tpf(const struct vkd3d_shader_compile_info *compile_info return VKD3D_ERROR; } - while (!shader_sm4_is_end(parser.data, &parser.ptr)) + while (!shader_sm4_is_end(&parser, &parser.ptr)) { shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index 5e828b6f..6d044c51 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -895,7 +895,7 @@ void shader_sm4_read_header(struct vkd3d_shader_parser *parser, const uint32_t **ptr, struct vkd3d_shader_version *shader_version); void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, const uint32_t **ptr, struct vkd3d_shader_instruction *ins); -bool shader_sm4_is_end(void *data, const DWORD **ptr); +bool shader_sm4_is_end(struct vkd3d_shader_parser *parser, const uint32_t **ptr); struct vkd3d_string_buffer { -- 2.20.1

1 0

[PATCH vkd3d 3/5] vkd3d-shader: Pass a vkd3d_shader_parser structure to shader_sm4_read_instruction().
by Henri Verbeet Sept. 2, 2021

Sept. 2, 2021

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- Note that this does also change the way vkd3d_glsl_generator_generate() interacts with parser->ptr; it's inconsequential because the parser is destroyed immediately after the only call to vkd3d_glsl_generator_generate(). libs/vkd3d-shader/dxbc.c | 31 ++++++++++++------------ libs/vkd3d-shader/glsl.c | 9 +++---- libs/vkd3d-shader/trace.c | 2 +- libs/vkd3d-shader/vkd3d_shader_main.c | 6 ++--- libs/vkd3d-shader/vkd3d_shader_private.h | 9 +++---- 5 files changed, 28 insertions(+), 29 deletions(-) diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 18ccc952..99c32ae2 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -1527,24 +1527,25 @@ static void shader_sm4_read_instruction_modifier(DWORD modifier, struct vkd3d_sh } } -void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_shader_instruction *ins) +void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, + const uint32_t **ptr, struct vkd3d_shader_instruction *ins) { const struct vkd3d_sm4_opcode_info *opcode_info; - DWORD opcode_token, opcode, previous_token; - struct vkd3d_sm4_data *priv = data; + uint32_t opcode_token, opcode, previous_token; + struct vkd3d_sm4_data *sm4 = parser->data; unsigned int i, len; size_t remaining; const DWORD *p; DWORD precise; - list_move_head(&priv->src_free, &priv->src); + list_move_head(&sm4->src_free, &sm4->src); - if (*ptr >= priv->end) + if (*ptr >= sm4->end) { WARN("End of byte-code, failed to read opcode.\n"); goto fail; } - remaining = priv->end - *ptr; + remaining = sm4->end - *ptr; opcode_token = *(*ptr)++; opcode = opcode_token & VKD3D_SM4_OPCODE_MASK; @@ -1581,9 +1582,9 @@ void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_sha ins->structured = false; ins->predicate = NULL; ins->dst_count = strlen(opcode_info->dst_info); - ins->dst = priv->dst_param; + ins->dst = sm4->dst_param; ins->src_count = strlen(opcode_info->src_info); - ins->src = priv->src_param; + ins->src = sm4->src_param; ins->resource_type = VKD3D_SHADER_RESOURCE_NONE; ins->resource_stride = 0; ins->resource_data_type[0] = VKD3D_DATA_FLOAT; @@ -1597,7 +1598,7 @@ void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_sha if (opcode_info->read_opcode_func) { - opcode_info->read_opcode_func(ins, opcode, opcode_token, p, len, priv); + opcode_info->read_opcode_func(ins, opcode, opcode_token, p, len, sm4); } else { @@ -1618,19 +1619,19 @@ void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_sha for (i = 0; i < ins->dst_count; ++i) { - if (!(shader_sm4_read_dst_param(priv, &p, *ptr, map_data_type(opcode_info->dst_info[i]), - &priv->dst_param[i]))) + if (!(shader_sm4_read_dst_param(sm4, &p, *ptr, map_data_type(opcode_info->dst_info[i]), + &sm4->dst_param[i]))) { ins->handler_idx = VKD3DSIH_INVALID; return; } - priv->dst_param[i].modifiers |= instruction_dst_modifier; + sm4->dst_param[i].modifiers |= instruction_dst_modifier; } for (i = 0; i < ins->src_count; ++i) { - if (!(shader_sm4_read_src_param(priv, &p, *ptr, map_data_type(opcode_info->src_info[i]), - &priv->src_param[i]))) + if (!(shader_sm4_read_src_param(sm4, &p, *ptr, map_data_type(opcode_info->src_info[i]), + &sm4->src_param[i]))) { ins->handler_idx = VKD3DSIH_INVALID; return; @@ -1641,7 +1642,7 @@ void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_sha return; fail: - *ptr = priv->end; + *ptr = sm4->end; ins->handler_idx = VKD3DSIH_INVALID; return; } diff --git a/libs/vkd3d-shader/glsl.c b/libs/vkd3d-shader/glsl.c index 38d18cce..04d948c2 100644 --- a/libs/vkd3d-shader/glsl.c +++ b/libs/vkd3d-shader/glsl.c @@ -95,9 +95,8 @@ static void vkd3d_glsl_handle_instruction(struct vkd3d_glsl_generator *generator return; } -int vkd3d_glsl_generator_generate(void *parser_data, const uint32_t *parser_ptr, - struct vkd3d_glsl_generator *generator, - struct vkd3d_shader_code *out) +int vkd3d_glsl_generator_generate(struct vkd3d_glsl_generator *generator, + struct vkd3d_shader_parser *parser, struct vkd3d_shader_code *out) { void *code; struct vkd3d_shader_instruction ins; @@ -105,9 +104,9 @@ int vkd3d_glsl_generator_generate(void *parser_data, const uint32_t *parser_ptr, vkd3d_string_buffer_printf(&generator->buffer, "#version 440\n\n"); vkd3d_string_buffer_printf(&generator->buffer, "void main()\n{\n"); - while (!shader_sm4_is_end(parser_data, &parser_ptr)) + while (!shader_sm4_is_end(parser->data, &parser->ptr)) { - shader_sm4_read_instruction(parser_data, &parser_ptr, &ins); + shader_sm4_read_instruction(parser, &parser->ptr, &ins); if (ins.handler_idx == VKD3DSIH_INVALID) { diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 107554f6..3e2b1523 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -1841,7 +1841,7 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, { struct vkd3d_shader_instruction ins; - shader_sm4_read_instruction(parser->data, &ptr, &ins); + shader_sm4_read_instruction(parser, &ptr, &ins); if (ins.handler_idx == VKD3DSIH_INVALID) { WARN("Skipping unrecognized instruction.\n"); diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 08a1cee1..56611772 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -956,7 +956,7 @@ static int scan_dxbc(const struct vkd3d_shader_compile_info *compile_info, while (!shader_sm4_is_end(parser.data, &parser.ptr)) { - shader_sm4_read_instruction(parser.data, &parser.ptr, &instruction); + shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); if (instruction.handler_idx == VKD3DSIH_INVALID) { @@ -1068,7 +1068,7 @@ static int compile_dxbc_tpf(const struct vkd3d_shader_compile_info *compile_info return VKD3D_ERROR; } - ret = vkd3d_glsl_generator_generate(parser.data, parser.ptr, glsl_generator, out); + ret = vkd3d_glsl_generator_generate(glsl_generator, &parser, out); vkd3d_glsl_generator_destroy(glsl_generator); vkd3d_shader_parser_destroy(&parser); @@ -1087,7 +1087,7 @@ static int compile_dxbc_tpf(const struct vkd3d_shader_compile_info *compile_info while (!shader_sm4_is_end(parser.data, &parser.ptr)) { - shader_sm4_read_instruction(parser.data, &parser.ptr, &instruction); + shader_sm4_read_instruction(&parser, &parser.ptr, &instruction); if (instruction.handler_idx == VKD3DSIH_INVALID) { diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index 3b1169a1..5e828b6f 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -893,8 +893,8 @@ void *shader_sm4_init(const DWORD *byte_code, size_t byte_code_size, void shader_sm4_free(struct vkd3d_shader_parser *parser); void shader_sm4_read_header(struct vkd3d_shader_parser *parser, const uint32_t **ptr, struct vkd3d_shader_version *shader_version); -void shader_sm4_read_instruction(void *data, const DWORD **ptr, - struct vkd3d_shader_instruction *ins); +void shader_sm4_read_instruction(struct vkd3d_shader_parser *parser, + const uint32_t **ptr, struct vkd3d_shader_instruction *ins); bool shader_sm4_is_end(void *data, const DWORD **ptr); struct vkd3d_string_buffer @@ -998,9 +998,8 @@ struct vkd3d_glsl_generator; struct vkd3d_glsl_generator *vkd3d_glsl_generator_create(const struct vkd3d_shader_version *version, const struct vkd3d_shader_compile_info *compile_info, struct vkd3d_shader_message_context *message_context); -int vkd3d_glsl_generator_generate(void *parser_data, const uint32_t *parser_ptr, - struct vkd3d_glsl_generator *generator, - struct vkd3d_shader_code *out); +int vkd3d_glsl_generator_generate(struct vkd3d_glsl_generator *generator, + struct vkd3d_shader_parser *parser, struct vkd3d_shader_code *out); void vkd3d_glsl_generator_destroy(struct vkd3d_glsl_generator *generator); struct vkd3d_dxbc_compiler; -- 2.20.1

1 0

[PATCH vkd3d 2/5] vkd3d-shader: Pass a vkd3d_shader_parser structure to shader_sm4_read_header().
by Henri Verbeet Sept. 2, 2021

Sept. 2, 2021

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- libs/vkd3d-shader/dxbc.c | 9 +++++---- libs/vkd3d-shader/trace.c | 2 +- libs/vkd3d-shader/vkd3d_shader_main.c | 2 +- libs/vkd3d-shader/vkd3d_shader_private.h | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 479cc5b8..18ccc952 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -1110,12 +1110,13 @@ static struct vkd3d_shader_src_param *get_src_param(struct vkd3d_sm4_data *priv) return &e->param; } -void shader_sm4_read_header(void *data, const DWORD **ptr, struct vkd3d_shader_version *shader_version) +void shader_sm4_read_header(struct vkd3d_shader_parser *parser, + const uint32_t **ptr, struct vkd3d_shader_version *shader_version) { - struct vkd3d_sm4_data *priv = data; + struct vkd3d_sm4_data *sm4 = parser->data; - *ptr = priv->start; - *shader_version = priv->shader_version; + *ptr = sm4->start; + *shader_version = sm4->shader_version; } static bool shader_sm4_read_reg_idx(struct vkd3d_sm4_data *priv, const DWORD **ptr, const DWORD *end, diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 3b01b531..107554f6 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -1831,7 +1831,7 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, vkd3d_string_buffer_init(buffer); shader_version = &compiler.shader_version; - shader_sm4_read_header(parser->data, &ptr, shader_version); + shader_sm4_read_header(parser, &ptr, shader_version); vkd3d_string_buffer_printf(buffer, "%s%s_%u_%u%s\n", compiler.colours.version, shader_get_type_prefix(shader_version->type), shader_version->major, shader_version->minor, compiler.colours.reset); diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index c439308e..08a1cee1 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -388,7 +388,7 @@ static int vkd3d_shader_parser_init(struct vkd3d_shader_parser *parser, return VKD3D_ERROR_INVALID_ARGUMENT; } - shader_sm4_read_header(parser->data, &parser->ptr, &parser->shader_version); + shader_sm4_read_header(parser, &parser->ptr, &parser->shader_version); return VKD3D_OK; } diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index fb449aac..3b1169a1 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -891,8 +891,8 @@ struct vkd3d_shader_message_context; void *shader_sm4_init(const DWORD *byte_code, size_t byte_code_size, const struct vkd3d_shader_signature *output_signature, struct vkd3d_shader_message_context *message_context); void shader_sm4_free(struct vkd3d_shader_parser *parser); -void shader_sm4_read_header(void *data, const DWORD **ptr, - struct vkd3d_shader_version *shader_version); +void shader_sm4_read_header(struct vkd3d_shader_parser *parser, + const uint32_t **ptr, struct vkd3d_shader_version *shader_version); void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct vkd3d_shader_instruction *ins); bool shader_sm4_is_end(void *data, const DWORD **ptr); -- 2.20.1

1 0

[PATCH vkd3d 1/5] vkd3d-shader: Pass a vkd3d_shader_parser structure to shader_sm4_free().
by Henri Verbeet Sept. 2, 2021

Sept. 2, 2021

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- libs/vkd3d-shader/dxbc.c | 10 +++++----- libs/vkd3d-shader/vkd3d_shader_main.c | 2 +- libs/vkd3d-shader/vkd3d_shader_private.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 83f91960..479cc5b8 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -1075,17 +1075,17 @@ void *shader_sm4_init(const DWORD *byte_code, size_t byte_code_size, return priv; } -void shader_sm4_free(void *data) +void shader_sm4_free(struct vkd3d_shader_parser *parser) { struct vkd3d_shader_src_param_entry *e1, *e2; - struct vkd3d_sm4_data *priv = data; + struct vkd3d_sm4_data *sm4 = parser->data; - list_move_head(&priv->src_free, &priv->src); - LIST_FOR_EACH_ENTRY_SAFE(e1, e2, &priv->src_free, struct vkd3d_shader_src_param_entry, entry) + list_move_head(&sm4->src_free, &sm4->src); + LIST_FOR_EACH_ENTRY_SAFE(e1, e2, &sm4->src_free, struct vkd3d_shader_src_param_entry, entry) { vkd3d_free(e1); } - vkd3d_free(priv); + vkd3d_free(sm4); } static struct vkd3d_shader_src_param *get_src_param(struct vkd3d_sm4_data *priv) diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 36c211e6..c439308e 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -394,7 +394,7 @@ static int vkd3d_shader_parser_init(struct vkd3d_shader_parser *parser, static void vkd3d_shader_parser_destroy(struct vkd3d_shader_parser *parser) { - shader_sm4_free(parser->data); + shader_sm4_free(parser); free_shader_desc(&parser->shader_desc); } diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index 97c1999b..fb449aac 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -890,7 +890,7 @@ struct vkd3d_shader_message_context; void *shader_sm4_init(const DWORD *byte_code, size_t byte_code_size, const struct vkd3d_shader_signature *output_signature, struct vkd3d_shader_message_context *message_context); -void shader_sm4_free(void *data); +void shader_sm4_free(struct vkd3d_shader_parser *parser); void shader_sm4_read_header(void *data, const DWORD **ptr, struct vkd3d_shader_version *shader_version); void shader_sm4_read_instruction(void *data, const DWORD **ptr, -- 2.20.1

1 0

[PATCH v2] shlwapi/tests: Document where SHFormatDateTimeA() crashes for NULL pointers.
by Francois Gouget Sept. 2, 2021

Sept. 2, 2021

Knowing which Windows versions have been confirmed to crash will make it easier to know whether that information is potentially obsolete if the Windows behavior changes. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- v2: Indented. The if (0) is likely to stay there for a good while so it makes sense to indent the corresponding test. --- dlls/shlwapi/tests/ordinal.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c index bf43d35b1c2..8a294ec1751 100644 --- a/dlls/shlwapi/tests/ordinal.c +++ b/dlls/shlwapi/tests/ordinal.c @@ -1674,11 +1674,8 @@ static void test_SHFormatDateTimeA(void) DWORD flags; INT ret; -if (0) -{ - /* crashes on native */ - pSHFormatDateTimeA(NULL, NULL, NULL, 0); -} + if (0) /* crashes on Windows XP to Windows 10 20H2 */ + pSHFormatDateTimeA(NULL, NULL, NULL, 0); GetLocalTime(&st); SystemTimeToFileTime(&st, &filetime); -- 2.30.2

5 10

[PATCH] uxtheme/tests: Use the OpenThemeDataForDpi() function pointer.
by Francois Gouget Sept. 2, 2021

Sept. 2, 2021

OpenThemeDataForDpi() is not available in Windows 10 1607 and older. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- dlls/uxtheme/tests/system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c index f9bf371e6bf..b088a7a050e 100644 --- a/dlls/uxtheme/tests/system.c +++ b/dlls/uxtheme/tests/system.c @@ -657,7 +657,7 @@ static void test_OpenThemeDataForDpi(void) is_theme_active = IsThemeActive(); SetLastError(0xdeadbeef); - htheme = OpenThemeDataForDpi(NULL, WC_BUTTONW, 96); + htheme = pOpenThemeDataForDpi(NULL, WC_BUTTONW, 96); if (is_theme_active) { ok(!!htheme, "Got a NULL handle.\n"); -- 2.30.2

2 1

[PATCH v2 1/9] ntoskrnl.exe/tests: Reduce the verbosity of test_return_status.
by Rémi Bernon Sept. 2, 2021

Sept. 2, 2021

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- v2: Fix an incorrect use of sizeof in the WCHAR / char conversion, in GetFullPathNameW and SetupCopyOEMInfW calls. I also initially overlooked the small differences variations between driver_pnp and driver_hid start/stop sequences, it doesn't seem to make any difference but I used the driver_pnp version which does a few more things. Also edited the subjects. dlls/ntoskrnl.exe/tests/ntoskrnl.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c index dc10497caee..e3afd46181c 100644 --- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c @@ -946,7 +946,7 @@ static void do_return_status(ULONG ioctl, struct return_status_params *params) static void test_return_status(void) { struct return_status_params params; - unsigned int i, j, k; + unsigned int i, j, k, old_threshold; static const ULONG method_tests[] = { @@ -979,12 +979,15 @@ static void test_return_status(void) params.ret_status = status_tests[i]; params.iosb_status = status_tests[j]; - winetest_push_context("return 0x%08x, iosb 0x%08x, pending %d, method %u", - params.ret_status, params.iosb_status, params.pending, method_tests[k] & 3); + trace("testing return 0x%08x, iosb 0x%08x, pending %d, method %u\n", + params.ret_status, params.iosb_status, params.pending, method_tests[k] & 3); + old_threshold = winetest_mute_threshold; + winetest_mute_threshold = 1; do_return_status(method_tests[k], &params); - winetest_pop_context(); + winetest_mute_threshold = old_threshold; + trace("done\n"); } } } -- 2.33.0

2 10

[PATCH 00/13] Hardening of Dwarf debug info parsing
by Eric Pouech Sept. 2, 2021

Sept. 2, 2021

The following serie is the first step toward adding Dwarf3/4 support into dbghelp. It mainly includes: - constant / definition updates - hardening of code regarding error conditions, improper input stream... - a couple of bug fixes A+ --- Eric Pouech (13): dbghelp: fix in dwarf2 subprogram handling dbghelp: dwarf support of DW_FORM_ref_udata dbghelp: more traces while parsing dwarf dbghelp: update dwarf definitions dbghelp: fix dwarf constants dbghelp: dwarf's internals adjustement dbghelp: Mostly get rid of symt_cache in dwarf debug information dbghelp: Added an unknown type in symt_cache for handling bad references to types dbghelp: check correctness of type (esp. in case of unknown ones) dbghelp: No longer call assert() on missing subprogram dwarf's information dbghelp: Harden inspection of Dwarf line number information dbghelp: Fix some erroneous string manipulation when said string is empty "" dbghelp: Properly handle errors when reading first DIE in compilation unit dlls/dbghelp/dbghelp_private.h | 5 + dlls/dbghelp/dwarf.c | 191 ++++++++++++++------------------- dlls/dbghelp/dwarf.h | 44 +++++++- dlls/dbghelp/source.c | 2 +- 4 files changed, 129 insertions(+), 113 deletions(-)

1 13

[PATCH] gdi32: Remove useless calls to CreateICA.
by Jiajin Cui Sept. 2, 2021

Sept. 2, 2021

We can get funcs without calling CreateICA. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> --- dlls/gdi32/driver.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/dlls/gdi32/driver.c b/dlls/gdi32/driver.c index 340476bca10..2c8feee25e7 100644 --- a/dlls/gdi32/driver.c +++ b/dlls/gdi32/driver.c @@ -1057,16 +1057,13 @@ INT WINAPI GDI_CallExtDeviceMode16( HWND hwnd, if (!WideCharToMultiByte(CP_ACP, 0, bufW, -1, buf, 300, NULL, NULL)) return -1; - if (!(hdc = CreateICA( buf, lpszDevice, lpszPort, NULL ))) return -1; - - if ((dc = get_dc_ptr( hdc ))) - { - PHYSDEV physdev = GET_DC_PHYSDEV( dc, pExtDeviceMode ); - ret = physdev->funcs->pExtDeviceMode( buf, hwnd, lpdmOutput, lpszDevice, lpszPort, + const struct gdi_dc_funcs *funcs = NULL; + funcs = DRIVER_load_driver(bufW); + if (funcs) { + ret = funcs->pExtDeviceMode( buf, hwnd, lpdmOutput, lpszDevice, lpszPort, lpdmInput, lpszProfile, fwMode ); - release_dc_ptr( dc ); } - DeleteDC( hdc ); + return ret; } -- 2.20.1

1 0