June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v4 0/1] MR181: winebus: Optionally split joysticks with more than 6 axes. - approved
by Alexandre Julliard (＠julliard) June 10, 2022

June 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/181

1 0

Re: [PATCH v2 0/6] MR223: dinput/tests: Cleanup mouse and keyboard tests and merge them into device8.c. - approved
by Alexandre Julliard (＠julliard) June 10, 2022

June 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/223

1 0

Re: [PATCH v2 0/2] MR219: user32: Avoid use of setupapi in raw input device enumeration. - approved
by Alexandre Julliard (＠julliard) June 10, 2022

June 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/219

1 0

Re: [PATCH v2 0/1] MR221: comctl32: Fix integer overflow in DPA_Search. - approved
by Alexandre Julliard (＠julliard) June 10, 2022

June 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/221

1 0

[PATCH 0/2] MR227: riched20: Fix for #52752 (use IViewObject implementation)
by Jinoh Kang (＠iamahuman) June 10, 2022

June 10, 2022

Fixes https://bugs.winehq.org/show_bug.cgi?id=52752. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/227

3 4

[PATCH v4 0/9] MR205: Add support for HRESULT and ID3DX10ThreadPump parameters in D3DX10GetImageInfo functions
by Piotr Caban (＠piotr) June 10, 2022

June 10, 2022

-- v4: d3dx10/tests: Add a test for loading an invalid resource from a valid module. d3dx10/tests: Initialize a function argument. d3dx10/tests: Add D3DX10GetImageInfoFromMemory thread pump tests. d3dx10: Support ID3DX10ThreadPump parameter in D3DX10GetImageInfoFromMemory. d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10GetImageInfoFromResourceW. d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10GetImageInfoFromResourceA. d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10GetImageInfoFromFileW. d3dx10/tests: Add D3DX10GetImageInfoFromMemory HRESULT argument tests. d3dx10: Don't ignore HRESULT parameter in D3DX10GetImageInfoFrom* functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/205

4 11

[PATCH v3 0/7] MR205: Add support for HRESULT and ID3DX10ThreadPump parameters in D3DX10GetImageInfo functions
by Piotr Caban (＠piotr) June 10, 2022

June 10, 2022

-- v3: d3dx10/tests: Add D3DX10GetImageInfoFromMemory thread pump tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/205

3 11

[PATCH 0/3] MR225: server: Fix races related to socket errors
by Piotr Caban (＠piotr) June 10, 2022

June 10, 2022

Calling ioctl(..., SO_ERROR, ...) clears pending socket error. Because of that we may clear the error in poll_socket or IOCTL_AFD_GET_SO_ERROR. This leads to failures during Battle.net installation (it's a race that I can only reproduce on slow machines). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/225

3 6

[PATCH v2 0/4] MR218: advapi32: Implement RegRenameKey()
by Nikolay Sivov (＠nsivov) June 10, 2022

June 10, 2022

-- v2: advapi32: Implement RegRenameKey(). ntdll: Implement NtRenameKey(). advapi32/tests: Add some tests for RegRenameKey(). ntdll/tests: Add some tests for NtRenameKey(). https://gitlab.winehq.org/wine/wine/-/merge_requests/218

3 7

[PATCH v2 0/2] MR127: ws2_32: Make wait in select alertable
by Paul Gofman (＠gofman) June 10, 2022

June 10, 2022

Fixes V Rising hang on exit. During exit the main thread wants to terminate the other thread by queuing APC which APC is supposed to raise an exception and abort the thread. That is basically how Unity / Mono aborts threads. The thread being terminated is calling select() in a loop and the wait in select() is currently not alertable (while they should be, as the test suggests). But with the first patch the things may get more interesting. ws2_32.select() passes on stack io status block to NtDeviceIoControlFile(), then it is killed from APC while waiting for event to be signaled by ioctl async processing. Then, wineserver wants to complete the async. The async owner thread is already terminated and it delivers SIGUSR1 to process the system APC to the main thread. When the APC is processed from USR1 handler it segfaults trying to put the IO status to iosb pointing to already deallocated thread stack. This is segfault on signal stack and as such is unrecoverable. The process is left hanging. Thus the second patch. In the ideal case we'd probably want to avoid crashing or handle segfault in system APC processing somehow, but I don't yet see a feasible way to do it. In theory the same may happen without ws2_32 if the app does the same, but I don't know that anything hits that case while ws2_32 queues those on stack iosbs, so avoiding that may probably avoid the practical issues. -- v2: ws2_32: Make wait in WS2_recv_base() alertable. ws2_32: Make wait in select() alertable. https://gitlab.winehq.org/wine/wine/-/merge_requests/127

4 4