July 2022 - Wine-Devel - list.winehq.org

[tools] testbot/web: Highlight the submit page's File and Branch fields if invalid.
by Francois Gouget July 6, 2022

July 6, 2022

Unlike the other fields, these two fields are generated by the submit page itself. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/Submit.pl | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index ca225b615d..c5423c7951 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -77,7 +77,7 @@ sub _Upload($) { umask($OldUMask); delete $self->{FileName}; - $self->{ErrField} = "Upload"; + $self->{ErrField} = "File"; $self->{ErrMessage} = "Unable to save the uploaded file"; return undef; } @@ -85,7 +85,7 @@ sub _Upload($) else { delete $self->{FileName}; - $self->{ErrField} = "Upload"; + $self->{ErrField} = "File"; $self->{ErrMessage} = "Unable to upload the file"; return undef; } @@ -709,6 +709,15 @@ sub GetPropertyDescriptors($) return $self->SUPER::GetPropertyDescriptors(); } +sub GetHtmlLabel($$) +{ + my ($self, $Label) = @_; + + # This assumes that the label is also the field name + return "<label". ($self->IsErrField($Label) ? " class='errorfield'" : "") + .">$Label</label>"; +} + sub GenerateFields($) { my ($self) = @_; @@ -723,7 +732,7 @@ sub GenerateFields($) if ($self->{Page} == 1 or $self->{Page} == 4) { - print "<div class='ItemProperty'><label>File</label>", + print "<div class='ItemProperty'>", $self->GetHtmlLabel("File"), "<div class='ItemValue'>"; if (defined $self->{FileName}) { @@ -749,7 +758,7 @@ sub GenerateFields($) } else { - print "<div class='ItemProperty'><label>Branch</label>", + print "<div class='ItemProperty'>", $self->GetHtmlLabel("Branch"), "<div class='ItemValue'>", "<select name='Branch' size='1'>"; my $SortedBranches = $Branches->GetSortedItems(); -- 2.30.2

1 0

[tools] testbot/cgi: Fix an operator precedence issue in Page::IsErrField().
by Francois Gouget July 6, 2022

July 6, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/Page.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm index 6e18c29ab4..1df5392930 100644 --- a/testbot/lib/ObjectModel/CGI/Page.pm +++ b/testbot/lib/ObjectModel/CGI/Page.pm @@ -342,7 +342,7 @@ Returns true if the error concerns the specified field. sub IsErrField($$) { my ($self, $FieldName) = @_; - return defined $self->{ErrField} and $self->{ErrField} eq $FieldName; + return (defined $self->{ErrField} and $self->{ErrField} eq $FieldName); } =pod -- 2.30.2

1 0

[PATCH v7 0/3] MR355: win32u: Move more display mode logic out of graphics drivers.
by Rémi Bernon July 6, 2022

July 6, 2022

-- v7: win32u: Set generic DEVMODEW fields in NtUserEnumDisplaySettings. win32u: Move default UpdateDisplayDevices implementation out of nulldrv. win32u: Add invisible winstation virtual monitor outside of nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/355

1 5

[PATCH v2 0/3] MR392: regedit: Code clean-up and invalid read fix
by Hugh McMaster (＠hmc) July 6, 2022

July 6, 2022

-- v2: regedit: Directly use RegQueryValueExW() instead of a helper function regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer regedit: Remove unneeded valueDataLen override for DWORD values https://gitlab.winehq.org/wine/wine/-/merge_requests/392

2 3

What is the purpose of PE conversion of *.sys drivers?
by Jinoh Kang July 6, 2022

July 6, 2022

As the Wine PE conversion process marches toward the finish line, a question of mine has stuck around for a long time: Why is the *.sys modules, which emulate the Windows kernel drivers, being converted to PE? As lots of efforts have been put into the process so far, I asume there is a valid reason for it; however, I'm yet to find any explanations on the list. Here are the best explanations I found so far: - "PE Conversion", Giovanni Mascellani, https://www.winehq.org/pipermail/wine-devel/2021-August/193127.html - "wine modules", Eric Pouech, https://www.winehq.org/pipermail/wine-devel/2022-April/213677.html To begin with, the rationale of the conversion process *in general* is twofold: 1. Accurate emulation of Windows userspace. This includes the system call interface. Such effort is necessary to appease some DRM and anti-cheat technologies. 2. Wow64 support. Some platforms (e.g. macOS) are either planning to drop, or have already dropped support for 32-bit binaries. To work around this, Wine adopts a "32-on-64" model where 32-bit code is run on 64-bit processes thanks to CPU and operating system support. Now, here's the reasons I think that both of the above do not necessarily apply to drivers: 1. Accurate emulation of Windows userspace. As kernel drivers run in kernel mode, a syscall interface does not make sense at all. 2. Wow64 support. Note that 64-bit Windows does not support running 32-bit drivers. I don't necessary see a significant value in supporting 32-bit binaries on a Wow64 wineprefix, but others may have different opinion. Also, drivers tend to interface with the host platform *a lot*, so it's much more difficult than, say, purely native modules whose PE conversion is only a matter of getting rid of "-mcygwin". Looking forward for your input. Thanks a lot! -- Sincerely, Jinoh Kang

2 4

[PATCH 0/3] MR358: atl: Avoid NULL pointer reference in AtlComModuleGetClassObject().
by Zhiyi Zhang (＠zhiyi) July 6, 2022

July 6, 2022

Fix crash in CAXA CAD when clicking component library. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/358

3 6

[PATCH 0/3] MR392: regedit: Code clean-up and invalid read fix
by Hugh McMaster (＠hmc) July 6, 2022

July 6, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/392

2 3

[PATCH v2] sechost: Support decimal access rights in ConvertStringSecurityDescriptorToSecurityDescriptor.
by Dmitry Timoshkov July 6, 2022

July 6, 2022

v2: Add a test with leading zero. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/advapi32/tests/security.c | 2 ++ dlls/sechost/security.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index ed91ccc39d3..547daef2bd6 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -4240,6 +4240,8 @@ static void test_ConvertStringSecurityDescriptor(void) { "D:(D;;GA;;;WD )", SDDL_REVISION_1, TRUE }, /* test ACE string access rights */ { "D:(A;;GA;;;WD)", SDDL_REVISION_1, TRUE }, + { "D:(A;;1;;;WD)", SDDL_REVISION_1, TRUE }, + { "D:(A;;01;;;WD)", SDDL_REVISION_1, TRUE }, { "D:(A;;GRGWGX;;;WD)", SDDL_REVISION_1, TRUE }, { "D:(A;;RCSDWDWO;;;WD)", SDDL_REVISION_1, TRUE }, { "D:(A;;RPWPCCDCLCSWLODTCR;;;WD)", SDDL_REVISION_1, TRUE }, diff --git a/dlls/sechost/security.c b/dlls/sechost/security.c index 6916b3ad662..f6fcffd9cfc 100644 --- a/dlls/sechost/security.c +++ b/dlls/sechost/security.c @@ -903,6 +903,9 @@ static DWORD parse_ace_right( const WCHAR **string_ptr ) if (string[0] == '0' && string[1] == 'x') return wcstoul( string, (WCHAR **)string_ptr, 16 ); + if (iswdigit( string[0] )) + return wcstoul( string, (WCHAR **)string_ptr, 10 ); + for (i = 0; i < ARRAY_SIZE(ace_rights); ++i) { if (!wcsncmp( string, ace_rights[i].str, 2 )) -- 2.36.1

2 2

[PATCH v6 0/6] MR355: win32u: Move more display mode logic out of graphics drivers.
by Rémi Bernon July 6, 2022

July 6, 2022

-- v6: win32u: Move writing mode to registry out of graphics drivers. win32u: Move NtUserChangeDisplaySettings mode validation to a separate helper. win32u: Move reading mode from registry out of graphics drivers. win32u: Set generic DEVMODEW fields in NtUserEnumDisplaySettings. win32u: Move default UpdateDisplayDevices implementation out of nulldrv. win32u: Add invisible winstation virtual monitor outside of nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/355

2 9

Re: [PATCH v14 0/8] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod - approved
by Huw Davies (＠huw) July 6, 2022

July 6, 2022

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/337

1 0