- Wine-Devel - list.winehq.org

[PATCH 9/9] quartz: Use nameless unions.
by Jacek Caban March 24, 2021

March 24, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/quartz/Makefile.in | 1 - dlls/quartz/filtermapper.c | 58 +++++++++++++++++++------------------- dlls/quartz/regsvr.c | 4 +-- 3 files changed, 31 insertions(+), 32 deletions(-)

2 1

[PATCH] ws2_32: Copy send buffer data for async send in WS2_ConnectEx().
by Jacek Caban March 24, 2021

March 24, 2021

From: Paul Gofman <pgofman(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50738 Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ws2_32/socket.c | 11 +++++++++-- dlls/ws2_32/tests/sock.c | 1 + 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[PATCH 2/9] winepulse: Use nameless unions.
by Jacek Caban March 24, 2021

March 24, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winepulse.drv/Makefile.in | 1 - dlls/winepulse.drv/mmdevdrv.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)

2 1

[PATCH 1/9] winmm: Use nameless unions.
by Jacek Caban March 24, 2021

March 24, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winmm/Makefile.in | 2 +- dlls/winmm/lolvldrv.c | 4 ++-- dlls/winmm/waveform.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-)

2 1

[PATCH] wineqtdecoder: Build with WINE_NO_NAMELESS_EXTENSION.
by Gijs Vermeulen March 24, 2021

March 24, 2021

Fixes a regression caused by b39b9eea39b19a8f91543b8350ed822d0fd9eef0. Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> --- dlls/wineqtdecoder/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wineqtdecoder/Makefile.in b/dlls/wineqtdecoder/Makefile.in index 41a96709beb..d6b77b4cb44 100644 --- a/dlls/wineqtdecoder/Makefile.in +++ b/dlls/wineqtdecoder/Makefile.in @@ -1,6 +1,7 @@ MODULE = wineqtdecoder.dll IMPORTS = strmiids uuid ole32 advapi32 EXTRALIBS = $(QUICKTIME_LIBS) +EXTRADEFS = -DWINE_NO_NAMELESS_EXTENSION PARENTSRC = ../strmbase C_SRCS = \ -- 2.31.0

2 1

[PATCH 7/9] shell32/tests: Use nameless unions.
by Jacek Caban March 24, 2021

March 24, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/shell32/tests/Makefile.in | 1 - dlls/shell32/tests/shellole.c | 12 ++++++------ 2 files changed, 6 insertions(+), 7 deletions(-)

1 0

[PATCH 6/9] shell32: Use nameless unions.
by Jacek Caban March 24, 2021

March 24, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/shell32/Makefile.in | 2 +- dlls/shell32/shellole.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)

1 0

[PATCH] sapi/tests: Remove SpResourceManager refcount tests.
by Gijs Vermeulen March 24, 2021

March 24, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50841 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> --- dlls/sapi/tests/resource.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/dlls/sapi/tests/resource.c b/dlls/sapi/tests/resource.c index cbddaf6323a..0c4bd5bc783 100644 --- a/dlls/sapi/tests/resource.c +++ b/dlls/sapi/tests/resource.c @@ -25,15 +25,6 @@ #include "wine/test.h" -#define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__) -static void _expect_ref(IUnknown *obj, ULONG ref, int line) -{ - ULONG rc; - IUnknown_AddRef(obj); - rc = IUnknown_Release(obj); - ok_(__FILE__,line)(rc == ref, "Unexpected refcount %d, expected %d.\n", rc, ref); -} - static void test_interfaces(void) { ISpResourceManager *resource_manager, *resource_manager2; @@ -44,25 +35,21 @@ static void test_interfaces(void) hr = CoCreateInstance(&CLSID_SpResourceManager, NULL, CLSCTX_INPROC_SERVER, &IID_ISpResourceManager, (void **)&resource_manager); ok(hr == S_OK, "Failed to create ISpeechVoice interface: %#x.\n", hr); - EXPECT_REF(resource_manager, 1); + ok(!!resource_manager, "Expected non-NULL resource manager.\n"); hr = CoCreateInstance(&CLSID_SpResourceManager, NULL, CLSCTX_INPROC_SERVER, &IID_ISpResourceManager, (void **)&resource_manager2); ok(hr == S_OK, "Failed to create ISpeechVoice interface: %#x.\n", hr); + ok(!!resource_manager2, "Expected non-NULL resource manager.\n"); todo_wine ok(resource_manager2 == resource_manager, "Expected managers to match.\n"); - todo_wine EXPECT_REF(resource_manager2, 2); - todo_wine EXPECT_REF(resource_manager, 2); - if (resource_manager2 == resource_manager) ISpResourceManager_Release(resource_manager2); - EXPECT_REF(resource_manager, 1); + ISpResourceManager_Release(resource_manager2); hr = CoCreateInstance(&CLSID_SpResourceManager, NULL, CLSCTX_INPROC_SERVER, &IID_IUnknown, (void **)&unk); ok(hr == S_OK, "Failed to create IUnknown interface: %#x.\n", hr); + ok(!!unk, "Expected non-NULL unk.\n"); todo_wine ok(unk == (IUnknown *)resource_manager, "Expected unk to match existing manager.\n"); - todo_wine EXPECT_REF(unk, 2); - todo_wine EXPECT_REF(resource_manager, 2); - if (unk == (IUnknown *)resource_manager) IUnknown_Release(unk); - EXPECT_REF(resource_manager, 1); + IUnknown_Release(unk); hr = CoCreateInstance(&CLSID_SpResourceManager, NULL, CLSCTX_INPROC_SERVER, &IID_IDispatch, (void **)&dispatch); -- 2.31.0

1 0

[PATCH 4/5] mountmgr.sys: Add the ability to query filesystem attributes on a file handle.
by Erich E. Hoover March 24, 2021

March 24, 2021

This patch adds capability to the new IOCTL_MOUNTMGR_QUERY_VOLUME ioctl to be able to return volume information on a file handle. This code represents the "fallback" case when standard volume information is unavailable (for more details see the code removed from dlls/ntdll/unix/file.c in patch 5 in the case where get_mountmgr_fs_info() fails). Best, Erich

3 3

[PATCH 2/5] mountmgr.sys: Simplify query_unix_drive.
by Erich E. Hoover March 24, 2021

March 24, 2021

This patch replaces query_dos_device() with a find_volume_by_letter() routine and query_unix_device() with a find_volume_by_unixdev() routine, which sets up for patch 3 to be able to share this code to find the volumes (by letter and unix device). The patch also consolidates all the actual query code into query_unix_drive. Best, Erich

2 1