- Wine-Devel - list.winehq.org

[PATCH 4/4] server: Use set_active_screen_buffer for consoles attached to server.
by Jacek Caban Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/console.c | 4 ---- 1 file changed, 4 deletions(-)

1 0

[PATCH 3/4] server: Don't propagate STATUS_PENDING in get_next_console_request request.
by Jacek Caban Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- conhost never sets it like that, but if it would, avoid an assert in async code. server/console.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

1 0

[PATCH 2/4] conhost: Clear out_size in IOCTL_CONDRV_READ_CONSOLE implementation.
by Jacek Caban Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/conhost/conhost.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

1 0

[PATCH 1/4] conhost: Call ensure_tty_input_thread in IOCTL_CONDRV_PEEK implementation.
by Jacek Caban Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/conhost/conhost.c | 1 + 1 file changed, 1 insertion(+)

1 0

[PATCH 1/4] evr/mixer: Store input type attributes.
by Nikolay Sivov Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/evr/mixer.c | 11 ++++++++++- dlls/evr/tests/evr.c | 31 +++++++++++-------------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/dlls/evr/mixer.c b/dlls/evr/mixer.c index e19520fa7ed..9227e6a1777 100644 --- a/dlls/evr/mixer.c +++ b/dlls/evr/mixer.c @@ -686,7 +686,16 @@ static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DW &count, &guids))) { if (SUCCEEDED(hr = video_mixer_collect_output_types(mixer, &video_desc, service, count, guids))) - FIXME("Set input type.\n"); + { + GUID subtype = { 0 }; + + if (FAILED(hr = IMFMediaType_GetGUID(media_type, &MF_MT_SUBTYPE, &subtype))) + WARN("Failed to get subtype %#x.\n", hr); + + if (SUCCEEDED(hr = MFCreateVideoMediaTypeFromSubtype(&subtype, &mixer->inputs[0].media_type))) + hr = IMFMediaType_CopyAllItems(media_type, (IMFAttributes *)mixer->inputs[0].media_type); + + } CoTaskMemFree(guids); } } diff --git a/dlls/evr/tests/evr.c b/dlls/evr/tests/evr.c index bf33051d6e1..e6f6251be60 100644 --- a/dlls/evr/tests/evr.c +++ b/dlls/evr/tests/evr.c @@ -896,17 +896,15 @@ static void test_default_mixer_type_negotiation(void) ok(hr == S_OK, "Unexpected hr %#x.\n", hr); hr = IMFTransform_GetInputCurrentType(transform, 0, &media_type); -todo_wine ok(hr == S_OK, "Unexpected hr %#x.\n", hr); -if (hr == S_OK) -{ ok(media_type != (IMFMediaType *)video_type, "Unexpected media type instance.\n"); + hr = IMFTransform_GetInputCurrentType(transform, 0, &media_type2); ok(hr == S_OK, "Unexpected hr %#x.\n", hr); ok(media_type == media_type2, "Unexpected media type instance.\n"); IMFMediaType_Release(media_type); IMFMediaType_Release(media_type2); -} + hr = IMFTransform_QueryInterface(transform, &IID_IMFVideoProcessor, (void **)&processor); ok(hr == S_OK, "Unexpected hr %#x.\n", hr); @@ -919,31 +917,24 @@ todo_wine ok(hr == MF_E_TRANSFORM_TYPE_NOT_SET, "Unexpected hr %#x.\n", hr); hr = IMFTransform_GetInputCurrentType(transform, 0, &media_type); -todo_wine ok(hr == S_OK, "Unexpected hr %#x.\n", hr); - if (SUCCEEDED(hr)) - { - ok(media_type != (IMFMediaType *)video_type, "Unexpected pointer.\n"); - hr = IMFMediaType_QueryInterface(media_type, &IID_IMFVideoMediaType, (void **)&unk); - ok(hr == S_OK, "Unexpected hr %#x.\n", hr); - IUnknown_Release(unk); - IMFMediaType_Release(media_type); - } + ok(media_type != (IMFMediaType *)video_type, "Unexpected pointer.\n"); + hr = IMFMediaType_QueryInterface(media_type, &IID_IMFVideoMediaType, (void **)&unk); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + IUnknown_Release(unk); + IMFMediaType_Release(media_type); hr = IMFVideoProcessor_GetAvailableVideoProcessorModes(processor, &count, &guids); todo_wine ok(hr == MF_E_TRANSFORM_TYPE_NOT_SET, "Unexpected hr %#x.\n", hr); hr = IMFTransform_GetOutputAvailableType(transform, 0, 0, &media_type); -todo_wine ok(hr == S_OK, "Unexpected hr %#x.\n", hr); - if (SUCCEEDED(hr)) - { - hr = IMFTransform_SetOutputType(transform, 0, media_type, 0); - ok(hr == S_OK, "Unexpected hr %#x.\n", hr); - IMFMediaType_Release(media_type); - } + hr = IMFTransform_SetOutputType(transform, 0, media_type, 0); +todo_wine + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + IMFMediaType_Release(media_type); hr = IMFVideoProcessor_GetVideoProcessorMode(processor, &guid); todo_wine -- 2.28.0

1 3

Re: [PATCH] comctl32: Accept Tab key on IP Address controls.
by Nikolay Sivov Oct. 1, 2020

Oct. 1, 2020

Surely you can focus first Edit control and press Tab without using dialogs? And WM_GETDLGCODE returns are testable without any user interaction. On 10/1/20 3:24 PM, katahiromz wrote: > Prove it without dialog box? Impossible. Focus needs activation of > dialog box. > > 片山博文MZ > > 2020年10月1日(木) 21:10 Nikolay Sivov <nsivov(a)codeweavers.com > <mailto:nsivov(a)codeweavers.com>>: > > Please create a small test without dialogs that shows that your > changes > are correct. > > Using dialog item iterators already looks suspicious. > > > On 10/1/20 2:46 PM, katahiromz wrote: > > I used IP Address controls in ReactOS as follows: > > https://github.com/reactos/reactos/pull/3212 > > > > 2020年10月1日(木) 20:10 Nikolay Sivov <nsivov(a)codeweavers.com > <mailto:nsivov(a)codeweavers.com>>: > >> On 10/1/20 1:51 PM, katahiromz wrote: > >>> Tab key and Shift+Tab key could not work on IP Address controls > >>> (SysIPAddress32). > >> I don't see it working with Control Spy either. How was it tested? > >> >

1 0

[PATCH 2/2] wsdapi/tests: Use wide character string literals.
by Owen Rudge Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> --- dlls/wsdapi/tests/address.c | 25 +++----- dlls/wsdapi/tests/discovery.c | 98 ++++++++++--------------------- dlls/wsdapi/tests/msgparams.c | 6 +- dlls/wsdapi/tests/xml.c | 106 ++++++++++++++-------------------- 4 files changed, 84 insertions(+), 151 deletions(-)

1 0

[PATCH 1/2] wsdapi: Use wide character string literals.
by Owen Rudge Oct. 1, 2020

Oct. 1, 2020

Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> --- dlls/wsdapi/soap.c | 137 ++++++++++++++------------------------------- dlls/wsdapi/xml.c | 3 +- 2 files changed, 43 insertions(+), 97 deletions(-)

1 0

Re: [PATCH] comctl32: Accept Tab key on IP Address controls.
by Nikolay Sivov Oct. 1, 2020

Oct. 1, 2020

Please create a small test without dialogs that shows that your changes are correct. Using dialog item iterators already looks suspicious. On 10/1/20 2:46 PM, katahiromz wrote: > I used IP Address controls in ReactOS as follows: > https://github.com/reactos/reactos/pull/3212 > > 2020年10月1日(木) 20:10 Nikolay Sivov <nsivov(a)codeweavers.com>: >> On 10/1/20 1:51 PM, katahiromz wrote: >>> Tab key and Shift+Tab key could not work on IP Address controls >>> (SysIPAddress32). >> I don't see it working with Control Spy either. How was it tested? >>

1 0

[PATCH] comctl32: Accept Tab key on IP Address controls.
by katahiromz Oct. 1, 2020

Oct. 1, 2020

Tab key and Shift+Tab key could not work on IP Address controls (SysIPAddress32).

2 1