- Wine-Devel - list.winehq.org

[PATCH] winepulse: Don't rely on pulseaudio callbacks for timing
by Andrew Eikum Aug. 17, 2020

Aug. 17, 2020

Contains contributions from Mark Harmstone and Zhiyi Zhang. Some devices, especially USB devices, have very irregular timing or very long periods. Some Windows applications (The Witcher 3) are built to expect regular, short period times, and so would underrun when the device timing didn't match their expectations. This patch decouples the Windows-side timing from the OS-side timing so we can meet those applications' requirements. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- This patch has been in wine-staging and Proton for years. Finally squashing down the fixes and submitting it upstream. dlls/winepulse.drv/mmdevdrv.c | 617 ++++++++++++++++------------------ 1 file changed, 281 insertions(+), 336 deletions(-) diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c index 23c34a50f66..e34c5ea5916 100644 --- a/dlls/winepulse.drv/mmdevdrv.c +++ b/dlls/winepulse.drv/mmdevdrv.c @@ -172,13 +172,16 @@ struct ACImpl { EDataFlow dataflow; DWORD flags; AUDCLNT_SHAREMODE share; - HANDLE event; + HANDLE event, timer; INT32 locked; - UINT32 bufsize_frames, bufsize_bytes, capture_period, pad, started, peek_ofs, wri_offs_bytes, lcl_offs_bytes; - UINT32 tmp_buffer_bytes, held_bytes, peek_len, peek_buffer_len; + UINT32 bufsize_frames, real_bufsize_bytes, period_bytes; + UINT32 started, peek_ofs, read_offs_bytes, lcl_offs_bytes, pa_offs_bytes; + UINT32 tmp_buffer_bytes, held_bytes, peek_len, peek_buffer_len, pa_held_bytes; BYTE *local_buffer, *tmp_buffer, *peek_buffer; void *locked_ptr; + BOOL please_quit, just_started, just_underran; + pa_usec_t last_time, mmdev_period_usec; pa_stream *stream; pa_sample_spec ss; @@ -709,18 +712,7 @@ static void silence_buffer(pa_sample_format_t format, BYTE *buffer, UINT32 bytes memset(buffer, format == PA_SAMPLE_U8 ? 0x80 : 0, bytes); } -static void pulse_free_noop(void *buf) -{ -} - -enum write_buffer_flags -{ - WINEPULSE_WRITE_NOFREE = 0x01, - WINEPULSE_WRITE_SILENT = 0x02 -}; - -static int write_buffer(const ACImpl *This, BYTE *buffer, UINT32 bytes, - enum write_buffer_flags flags) +static int write_buffer(const ACImpl *This, BYTE *buffer, UINT32 bytes) { float vol[PA_CHANNELS_MAX]; BOOL adjust = FALSE; @@ -728,7 +720,7 @@ static int write_buffer(const ACImpl *This, BYTE *buffer, UINT32 bytes, BYTE *end; if (!bytes) return 0; - if (This->session->mute || (flags & WINEPULSE_WRITE_SILENT)) + if (This->session->mute) { silence_buffer(This->ss.format, buffer, bytes); goto write; @@ -855,9 +847,7 @@ static int write_buffer(const ACImpl *This, BYTE *buffer, UINT32 bytes, } write: - return pa_stream_write(This->stream, buffer, bytes, - (flags & WINEPULSE_WRITE_NOFREE) ? pulse_free_noop : NULL, - 0, PA_SEEK_RELATIVE); + return pa_stream_write(This->stream, buffer, bytes, NULL, 0, PA_SEEK_RELATIVE); } static void dump_attr(const pa_buffer_attr *attr) { @@ -880,147 +870,129 @@ static void pulse_attr_update(pa_stream *s, void *user) { dump_attr(attr); } -/* Here's the buffer setup: - * - * vvvvvvvv sent to HW already - * vvvvvvvv in Pulse buffer but rewindable - * [dddddddddddddddd] Pulse buffer - * [dddddddddddddddd--------] mmdevapi buffer - * ^^^^^^^^^^^^^^^^ pad - * ^ lcl_offs_bytes - * ^^^^^^^^^ held_bytes - * ^ wri_offs_bytes - * - * GetCurrentPadding is pad - * - * During pulse_wr_callback, we decrement pad, fill Pulse buffer, and move - * lcl_offs forward - * - * During Stop, we flush the Pulse buffer - */ -static void pulse_wr_callback(pa_stream *s, size_t bytes, void *userdata) +static void pulse_write(ACImpl *This) { - ACImpl *This = userdata; - UINT32 oldpad = This->pad; + /* write as much data to PA as we can */ + UINT32 to_write; + BYTE *buf = This->local_buffer + This->pa_offs_bytes; + UINT32 bytes = pa_stream_writable_size(This->stream); - if(This->local_buffer){ - UINT32 to_write; - BYTE *buf = This->local_buffer + This->lcl_offs_bytes; - - if(This->pad > bytes){ - This->clock_written += bytes; - This->pad -= bytes; - }else{ - This->clock_written += This->pad; - This->pad = 0; + if(This->just_underran){ + /* prebuffer with silence if needed */ + if(This->pa_held_bytes < bytes){ + to_write = bytes - This->pa_held_bytes; + TRACE("prebuffering %u frames of silence\n", + (int)(to_write / pa_frame_size(&This->ss))); + buf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, to_write); + pa_stream_write(This->stream, buf, to_write, NULL, 0, PA_SEEK_RELATIVE); + HeapFree(GetProcessHeap(), 0, buf); } - bytes = min(bytes, This->held_bytes); - - if(This->lcl_offs_bytes + bytes > This->bufsize_bytes){ - to_write = This->bufsize_bytes - This->lcl_offs_bytes; - TRACE("writing small chunk of %u bytes\n", to_write); - write_buffer(This, buf, to_write, 0); - This->held_bytes -= to_write; - to_write = bytes - to_write; - This->lcl_offs_bytes = 0; - buf = This->local_buffer; - }else - to_write = bytes; - - TRACE("writing main chunk of %u bytes\n", to_write); - write_buffer(This, buf, to_write, 0); - This->lcl_offs_bytes += to_write; - This->lcl_offs_bytes %= This->bufsize_bytes; - This->held_bytes -= to_write; - }else{ - if (bytes < This->bufsize_bytes) - This->pad = This->bufsize_bytes - bytes; - else - This->pad = 0; - - if (oldpad == This->pad) - return; - - assert(oldpad > This->pad); - - This->clock_written += oldpad - This->pad; - TRACE("New pad: %zu (-%zu)\n", This->pad / pa_frame_size(&This->ss), (oldpad - This->pad) / pa_frame_size(&This->ss)); + This->just_underran = FALSE; } - if (This->event) - SetEvent(This->event); + buf = This->local_buffer + This->pa_offs_bytes; + TRACE("held: %u, avail: %u\n", + This->pa_held_bytes, bytes); + bytes = min(This->pa_held_bytes, bytes); + + if(This->pa_offs_bytes + bytes > This->real_bufsize_bytes){ + to_write = This->real_bufsize_bytes - This->pa_offs_bytes; + TRACE("writing small chunk of %u bytes\n", to_write); + write_buffer(This, buf, to_write); + This->pa_held_bytes -= to_write; + to_write = bytes - to_write; + This->pa_offs_bytes = 0; + buf = This->local_buffer; + }else + to_write = bytes; + + TRACE("writing main chunk of %u bytes\n", to_write); + write_buffer(This, buf, to_write); + This->pa_offs_bytes += to_write; + This->pa_offs_bytes %= This->real_bufsize_bytes; + This->pa_held_bytes -= to_write; } static void pulse_underflow_callback(pa_stream *s, void *userdata) -{ - WARN("Underflow\n"); -} - -/* Latency is periodically updated even when nothing is played, - * because of PA_STREAM_AUTO_TIMING_UPDATE so use it as timer - * - * Perfect for passing all tests :) - */ -static void pulse_latency_callback(pa_stream *s, void *userdata) { ACImpl *This = userdata; - if (!This->pad && This->event) - SetEvent(This->event); + WARN("%p: Underflow\n", userdata); + This->just_underran = TRUE; + /* re-sync */ + This->pa_offs_bytes = This->lcl_offs_bytes; + This->pa_held_bytes = This->held_bytes; } static void pulse_started_callback(pa_stream *s, void *userdata) { - TRACE("(Re)started playing\n"); + TRACE("%p: (Re)started playing\n", userdata); } -static void pulse_rd_loop(ACImpl *This, size_t bytes) +static void pulse_read(ACImpl *This) { - while (bytes >= This->capture_period) { - ACPacket *p, *next; - LARGE_INTEGER stamp, freq; - BYTE *dst, *src; - size_t src_len, copy, rem = This->capture_period; - if (!(p = (ACPacket*)list_head(&This->packet_free_head))) { - p = (ACPacket*)list_head(&This->packet_filled_head); - if (!p->discont) { - next = (ACPacket*)p->entry.next; - next->discont = 1; - } else - p = (ACPacket*)list_tail(&This->packet_filled_head); - assert(This->pad == This->bufsize_bytes); - } else { - assert(This->pad < This->bufsize_bytes); - This->pad += This->capture_period; - assert(This->pad <= This->bufsize_bytes); + size_t bytes = pa_stream_readable_size(This->stream); + + TRACE("Readable total: %zu, fragsize: %u\n", bytes, pa_stream_get_buffer_attr(This->stream)->fragsize); + + bytes += This->peek_len - This->peek_ofs; + + while (bytes >= This->period_bytes) { + BYTE *dst = NULL, *src; + size_t src_len, copy, rem = This->period_bytes; + + if (This->started) { + LARGE_INTEGER stamp, freq; + ACPacket *p, *next; + + if (!(p = (ACPacket*)list_head(&This->packet_free_head))) { + p = (ACPacket*)list_head(&This->packet_filled_head); + if (!p) return; + if (!p->discont) { + next = (ACPacket*)p->entry.next; + next->discont = 1; + } else + p = (ACPacket*)list_tail(&This->packet_filled_head); + } else { + This->held_bytes += This->period_bytes; + } + QueryPerformanceCounter(&stamp); + QueryPerformanceFrequency(&freq); + p->qpcpos = (stamp.QuadPart * (INT64)10000000) / freq.QuadPart; + p->discont = 0; + list_remove(&p->entry); + list_add_tail(&This->packet_filled_head, &p->entry); + + dst = p->data; } - QueryPerformanceCounter(&stamp); - QueryPerformanceFrequency(&freq); - p->qpcpos = (stamp.QuadPart * (INT64)10000000) / freq.QuadPart; - p->discont = 0; - list_remove(&p->entry); - list_add_tail(&This->packet_filled_head, &p->entry); - dst = p->data; while (rem) { if (This->peek_len) { copy = min(rem, This->peek_len - This->peek_ofs); - memcpy(dst, This->peek_buffer + This->peek_ofs, copy); + if (dst) { + memcpy(dst, This->peek_buffer + This->peek_ofs, copy); + dst += copy; + } rem -= copy; - dst += copy; This->peek_ofs += copy; if(This->peek_len == This->peek_ofs) - This->peek_len = 0; - } else { - pa_stream_peek(This->stream, (const void**)&src, &src_len); + This->peek_len = This->peek_ofs = 0; + + } else if (pa_stream_peek(This->stream, (const void**)&src, &src_len) == 0 && src_len) { copy = min(rem, src_len); - memcpy(dst, src, rem); + if (dst) { + if(src) + memcpy(dst, src, copy); + else + silence_buffer(This->ss.format, dst, copy); + + dst += copy; + } - dst += copy; rem -= copy; if (copy < src_len) { @@ -1030,7 +1002,11 @@ static void pulse_rd_loop(ACImpl *This, size_t bytes) This->peek_buffer_len = src_len; } - memcpy(This->peek_buffer, src + copy, src_len - copy); + if(src) + memcpy(This->peek_buffer, src + copy, src_len - copy); + else + silence_buffer(This->ss.format, This->peek_buffer, src_len - copy); + This->peek_len = src_len - copy; This->peek_ofs = 0; } @@ -1039,56 +1015,100 @@ static void pulse_rd_loop(ACImpl *This, size_t bytes) } } - bytes -= This->capture_period; + bytes -= This->period_bytes; } } -static void pulse_rd_drop(ACImpl *This, size_t bytes) +static DWORD WINAPI pulse_timer_cb(void *user) { - while (bytes >= This->capture_period) { - size_t src_len, copy, rem = This->capture_period; - while (rem) { - const void *src; - pa_stream_peek(This->stream, &src, &src_len); - assert(src_len); - assert(This->peek_ofs < src_len); - src_len -= This->peek_ofs; - assert(src_len <= bytes); - - copy = rem; - if (copy > src_len) - copy = src_len; - - src_len -= copy; - rem -= copy; - - if (!src_len) { - This->peek_ofs = 0; - pa_stream_drop(This->stream); - } else - This->peek_ofs += copy; - bytes -= copy; + DWORD delay; + UINT32 adv_bytes; + ACImpl *This = user; + int success; + pa_operation *o; + + pthread_mutex_lock(&pulse_lock); + delay = This->mmdev_period_usec / 1000; + pa_stream_get_time(This->stream, &This->last_time); + pthread_mutex_unlock(&pulse_lock); + + while(!This->please_quit){ + pa_usec_t now, adv_usec = 0; + int err; + + Sleep(delay); + + pthread_mutex_lock(&pulse_lock); + + delay = This->mmdev_period_usec / 1000; + + o = pa_stream_update_timing_info(This->stream, pulse_op_cb, &success); + if (o) + { + while (pa_operation_get_state(o) == PA_OPERATION_RUNNING) + pthread_cond_wait(&pulse_cond, &pulse_lock); + pa_operation_unref(o); } - } -} + err = pa_stream_get_time(This->stream, &now); + if(err == 0){ + TRACE("got now: %s, last time: %s\n", wine_dbgstr_longlong(now), wine_dbgstr_longlong(This->last_time)); + if(This->started && (This->dataflow == eCapture || This->held_bytes)){ + if(This->just_underran){ + This->last_time = now; + This->just_started = TRUE; + } -static void pulse_rd_callback(pa_stream *s, size_t bytes, void *userdata) -{ - ACImpl *This = userdata; + if(This->just_started){ + /* let it play out a period to absorb some latency and get accurate timing */ + pa_usec_t diff = now - This->last_time; + + if(diff > This->mmdev_period_usec){ + This->just_started = FALSE; + This->last_time = now; + } + }else{ + INT32 adjust = This->last_time + This->mmdev_period_usec - now; - TRACE("Readable total: %zu, fragsize: %u\n", bytes, pa_stream_get_buffer_attr(s)->fragsize); - assert(bytes >= This->peek_ofs); - bytes -= This->peek_ofs; - if (bytes < This->capture_period) - return; + adv_usec = now - This->last_time; - if (This->started) - pulse_rd_loop(This, bytes); - else - pulse_rd_drop(This, bytes); + if(adjust > ((INT32)(This->mmdev_period_usec / 2))) + adjust = This->mmdev_period_usec / 2; + else if(adjust < -((INT32)(This->mmdev_period_usec / 2))) + adjust = -1 * This->mmdev_period_usec / 2; + + delay = (This->mmdev_period_usec + adjust) / 1000; + + This->last_time += This->mmdev_period_usec; + } + + if(This->dataflow == eRender){ + pulse_write(This); + + /* regardless of what PA does, advance one period */ + adv_bytes = min(This->period_bytes, This->held_bytes); + This->lcl_offs_bytes += adv_bytes; + This->lcl_offs_bytes %= This->real_bufsize_bytes; + This->held_bytes -= adv_bytes; + }else if(This->dataflow == eCapture){ + pulse_read(This); + } + }else{ + This->last_time = now; + delay = This->mmdev_period_usec / 1000; + } + } + + if (This->event) + SetEvent(This->event); + + TRACE("%p after update, adv usec: %d, held: %u, delay: %u\n", + This, (int)adv_usec, + (int)(This->held_bytes/ pa_frame_size(&This->ss)), delay); + + pthread_mutex_unlock(&pulse_lock); + } - if (This->event) - SetEvent(This->event); + return 0; } static HRESULT pulse_stream_connect(ACImpl *This, UINT32 period_bytes) { @@ -1117,15 +1137,16 @@ static HRESULT pulse_stream_connect(ACImpl *This, UINT32 period_bytes) { /* PulseAudio will fill in correct values */ attr.minreq = attr.fragsize = period_bytes; - attr.maxlength = attr.tlength = This->bufsize_bytes; + attr.tlength = period_bytes * 3; + attr.maxlength = This->bufsize_frames * pa_frame_size(&This->ss); attr.prebuf = pa_frame_size(&This->ss); dump_attr(&attr); if (This->dataflow == eRender) ret = pa_stream_connect_playback(This->stream, NULL, &attr, - PA_STREAM_START_CORKED|PA_STREAM_START_UNMUTED|PA_STREAM_AUTO_TIMING_UPDATE|PA_STREAM_INTERPOLATE_TIMING|PA_STREAM_EARLY_REQUESTS, NULL, NULL); + PA_STREAM_START_CORKED|PA_STREAM_START_UNMUTED|PA_STREAM_ADJUST_LATENCY, NULL, NULL); else ret = pa_stream_connect_record(This->stream, NULL, &attr, - PA_STREAM_START_CORKED|PA_STREAM_START_UNMUTED|PA_STREAM_AUTO_TIMING_UPDATE|PA_STREAM_INTERPOLATE_TIMING|PA_STREAM_EARLY_REQUESTS); + PA_STREAM_START_CORKED|PA_STREAM_START_UNMUTED|PA_STREAM_ADJUST_LATENCY); if (ret < 0) { WARN("Returns %i\n", ret); return AUDCLNT_E_ENDPOINT_CREATE_FAILED; @@ -1136,11 +1157,9 @@ static HRESULT pulse_stream_connect(ACImpl *This, UINT32 period_bytes) { return AUDCLNT_E_ENDPOINT_CREATE_FAILED; if (This->dataflow == eRender) { - pa_stream_set_write_callback(This->stream, pulse_wr_callback, This); pa_stream_set_underflow_callback(This->stream, pulse_underflow_callback, This); pa_stream_set_started_callback(This->stream, pulse_started_callback, This); - } else - pa_stream_set_read_callback(This->stream, pulse_rd_callback, This); + } return S_OK; } @@ -1275,6 +1294,11 @@ static ULONG WINAPI AudioClient_Release(IAudioClient *iface) TRACE("(%p) Refcount now %u\n", This, ref); if (!ref) { if (This->stream) { + if(This->timer){ + This->please_quit = TRUE; + WaitForSingleObject(This->timer, INFINITE); + CloseHandle(This->timer); + } pthread_mutex_lock(&pulse_lock); if (PA_STREAM_IS_GOOD(pa_stream_get_state(This->stream))) { pa_stream_disconnect(This->stream); @@ -1570,7 +1594,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, { ACImpl *This = impl_from_IAudioClient(iface); HRESULT hr = S_OK; - UINT period_bytes; + UINT32 bufsize_bytes; TRACE("(%p)->(%x, %x, %s, %s, %p, %s)\n", This, mode, flags, wine_dbgstr_longlong(duration), wine_dbgstr_longlong(period), fmt, debugstr_guid(sessionguid)); @@ -1617,38 +1641,19 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, if (FAILED(hr)) goto exit; - if (mode == AUDCLNT_SHAREMODE_SHARED) { - REFERENCE_TIME def = pulse_def_period[This->dataflow == eCapture]; - REFERENCE_TIME min = pulse_min_period[This->dataflow == eCapture]; + period = pulse_def_period[This->dataflow == eCapture]; + if (duration < 3 * period) + duration = 3 * period; - /* Switch to low latency mode if below 2 default periods, - * which is 20 ms by default, this will increase the amount - * of interrupts but allows very low latency. In dsound I - * managed to get a total latency of ~8ms, which is well below - * default - */ - if (duration < 2 * def) - period = min; - else - period = def; - if (duration < 2 * period) - duration = 2 * period; + This->period_bytes = pa_frame_size(&This->ss) * MulDiv(period, This->ss.rate, 10000000); - /* Uh oh, really low latency requested.. */ - if (duration <= 2 * period) - period /= 2; - } - period_bytes = pa_frame_size(&This->ss) * MulDiv(period, This->ss.rate, 10000000); - - if (duration < 20000000) - This->bufsize_frames = ceil((duration / 10000000.) * fmt->nSamplesPerSec); - else - This->bufsize_frames = 2 * fmt->nSamplesPerSec; - This->bufsize_bytes = This->bufsize_frames * pa_frame_size(&This->ss); + This->bufsize_frames = ceil((duration / 10000000.) * fmt->nSamplesPerSec); + bufsize_bytes = This->bufsize_frames * pa_frame_size(&This->ss); + This->mmdev_period_usec = period / 10; This->share = mode; This->flags = flags; - hr = pulse_stream_connect(This, period_bytes); + hr = pulse_stream_connect(This, This->period_bytes); if (SUCCEEDED(hr)) { UINT32 unalign; const pa_buffer_attr *attr = pa_stream_get_buffer_attr(This->stream); @@ -1656,39 +1661,34 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, /* Update frames according to new size */ dump_attr(attr); if (This->dataflow == eRender) { - if (attr->tlength < This->bufsize_bytes) { - TRACE("PulseAudio buffer too small (%u < %u), using tmp buffer\n", attr->tlength, This->bufsize_bytes); - - This->local_buffer = HeapAlloc(GetProcessHeap(), 0, This->bufsize_bytes); - if(!This->local_buffer) - hr = E_OUTOFMEMORY; - } + This->real_bufsize_bytes = This->bufsize_frames * 2 * pa_frame_size(&This->ss); + This->local_buffer = HeapAlloc(GetProcessHeap(), 0, This->real_bufsize_bytes); + if(!This->local_buffer) + hr = E_OUTOFMEMORY; } else { UINT32 i, capture_packets; - This->capture_period = period_bytes = attr->fragsize; - if ((unalign = This->bufsize_bytes % period_bytes)) - This->bufsize_bytes += period_bytes - unalign; - This->bufsize_frames = This->bufsize_bytes / pa_frame_size(&This->ss); + if ((unalign = bufsize_bytes % This->period_bytes)) + bufsize_bytes += This->period_bytes - unalign; + This->bufsize_frames = bufsize_bytes / pa_frame_size(&This->ss); + This->real_bufsize_bytes = bufsize_bytes; - capture_packets = This->bufsize_bytes / This->capture_period; + capture_packets = This->real_bufsize_bytes / This->period_bytes; - This->local_buffer = HeapAlloc(GetProcessHeap(), 0, This->bufsize_bytes + capture_packets * sizeof(ACPacket)); + This->local_buffer = HeapAlloc(GetProcessHeap(), 0, This->real_bufsize_bytes + capture_packets * sizeof(ACPacket)); if (!This->local_buffer) hr = E_OUTOFMEMORY; else { - ACPacket *cur_packet = (ACPacket*)((char*)This->local_buffer + This->bufsize_bytes); + ACPacket *cur_packet = (ACPacket*)((char*)This->local_buffer + This->real_bufsize_bytes); BYTE *data = This->local_buffer; - silence_buffer(This->ss.format, This->local_buffer, This->bufsize_bytes); + silence_buffer(This->ss.format, This->local_buffer, This->real_bufsize_bytes); list_init(&This->packet_free_head); list_init(&This->packet_filled_head); for (i = 0; i < capture_packets; ++i, ++cur_packet) { list_add_tail(&This->packet_free_head, &cur_packet->entry); cur_packet->data = data; - data += This->capture_period; + data += This->period_bytes; } - assert(!This->capture_period || This->bufsize_bytes == This->capture_period * capture_packets); - assert(!capture_packets || data - This->bufsize_bytes == This->local_buffer); } } } @@ -1753,12 +1753,12 @@ static HRESULT WINAPI AudioClient_GetStreamLatency(IAudioClient *iface, attr = pa_stream_get_buffer_attr(This->stream); if (This->dataflow == eRender){ lat = attr->minreq / pa_frame_size(&This->ss); - lat += pulse_def_period[0]; }else lat = attr->fragsize / pa_frame_size(&This->ss); *latency = 10000000; *latency *= lat; *latency /= This->ss.rate; + *latency += pulse_def_period[0]; pthread_mutex_unlock(&pulse_lock); TRACE("Latency: %u ms\n", (DWORD)(*latency / 10000)); return S_OK; @@ -1766,7 +1766,7 @@ static HRESULT WINAPI AudioClient_GetStreamLatency(IAudioClient *iface, static void ACImpl_GetRenderPad(ACImpl *This, UINT32 *out) { - *out = This->pad / pa_frame_size(&This->ss); + *out = This->held_bytes / pa_frame_size(&This->ss); } static void ACImpl_GetCapturePad(ACImpl *This, UINT32 *out) @@ -1778,7 +1778,7 @@ static void ACImpl_GetCapturePad(ACImpl *This, UINT32 *out) list_remove(&packet->entry); } if (out) - *out = This->pad / pa_frame_size(&This->ss); + *out = This->held_bytes / pa_frame_size(&This->ss); } static HRESULT WINAPI AudioClient_GetCurrentPadding(IAudioClient *iface, @@ -2024,6 +2024,8 @@ static HRESULT WINAPI AudioClient_Start(IAudioClient *iface) return AUDCLNT_E_NOT_STOPPED; } + pulse_write(This); + if (pa_stream_is_corked(This->stream)) { o = pa_stream_cork(This->stream, 0, pulse_op_cb, &success); if (o) { @@ -2038,8 +2040,10 @@ static HRESULT WINAPI AudioClient_Start(IAudioClient *iface) if (SUCCEEDED(hr)) { This->started = TRUE; - if (This->dataflow == eRender && This->event) - pa_stream_set_latency_update_callback(This->stream, pulse_latency_callback, This); + This->just_started = TRUE; + + if(!This->timer) + This->timer = CreateThread(NULL, 0, pulse_timer_cb, This, 0, NULL); } pthread_mutex_unlock(&pulse_lock); return hr; @@ -2111,7 +2115,7 @@ static HRESULT WINAPI AudioClient_Reset(IAudioClient *iface) if (This->dataflow == eRender) { /* If there is still data in the render buffer it needs to be removed from the server */ int success = 0; - if (This->pad) { + if (This->held_bytes) { pa_operation *o = pa_stream_flush(This->stream, pulse_op_cb, &success); if (o) { while(pa_operation_get_state(o) == PA_OPERATION_RUNNING) @@ -2119,14 +2123,14 @@ static HRESULT WINAPI AudioClient_Reset(IAudioClient *iface) pa_operation_unref(o); } } - if (success || !This->pad){ - This->clock_lastpos = This->clock_written = This->pad = 0; - This->wri_offs_bytes = This->lcl_offs_bytes = This->held_bytes = 0; + if (success || !This->held_bytes){ + This->clock_lastpos = This->clock_written = 0; + This->pa_offs_bytes = This->lcl_offs_bytes = This->held_bytes = This->pa_held_bytes = 0; } } else { ACPacket *p; - This->clock_written += This->pad; - This->pad = 0; + This->clock_written += This->held_bytes; + This->held_bytes = 0; if ((p = This->locked_ptr)) { This->locked_ptr = NULL; @@ -2292,10 +2296,9 @@ static HRESULT WINAPI AudioRenderClient_GetBuffer(IAudioRenderClient *iface, UINT32 frames, BYTE **data) { ACImpl *This = impl_from_IAudioRenderClient(iface); - size_t avail, req, bytes = frames * pa_frame_size(&This->ss); - UINT32 pad; + size_t bytes = frames * pa_frame_size(&This->ss); HRESULT hr = S_OK; - int ret = -1; + UINT32 wri_offs_bytes; TRACE("(%p)->(%u, %p)\n", This, frames, data); @@ -2314,37 +2317,19 @@ static HRESULT WINAPI AudioRenderClient_GetBuffer(IAudioRenderClient *iface, return S_OK; } - ACImpl_GetRenderPad(This, &pad); - avail = This->bufsize_frames - pad; - if (avail < frames || bytes > This->bufsize_bytes) { + if(This->held_bytes / pa_frame_size(&This->ss) + frames > This->bufsize_frames){ pthread_mutex_unlock(&pulse_lock); - WARN("Wanted to write %u, but only %zu available\n", frames, avail); return AUDCLNT_E_BUFFER_TOO_LARGE; } - if(This->local_buffer){ - if(This->wri_offs_bytes + bytes > This->bufsize_bytes){ - alloc_tmp_buffer(This, bytes); - *data = This->tmp_buffer; - This->locked = -frames; - }else{ - *data = This->local_buffer + This->wri_offs_bytes; - This->locked = frames; - } + wri_offs_bytes = (This->lcl_offs_bytes + This->held_bytes) % This->real_bufsize_bytes; + if(wri_offs_bytes + bytes > This->real_bufsize_bytes){ + alloc_tmp_buffer(This, bytes); + *data = This->tmp_buffer; + This->locked = -bytes; }else{ - req = bytes; - ret = pa_stream_begin_write(This->stream, &This->locked_ptr, &req); - if (ret < 0 || req < bytes) { - FIXME("%p Not using pulse locked data: %i %zu/%u %u/%u\n", This, ret, req/pa_frame_size(&This->ss), frames, pad, This->bufsize_frames); - if (ret >= 0) - pa_stream_cancel_write(This->stream); - alloc_tmp_buffer(This, bytes); - *data = This->tmp_buffer; - This->locked_ptr = NULL; - } else - *data = This->locked_ptr; - - This->locked = frames; + *data = This->local_buffer + wri_offs_bytes; + This->locked = bytes; } silence_buffer(This->ss.format, *data, bytes); @@ -2356,12 +2341,13 @@ static HRESULT WINAPI AudioRenderClient_GetBuffer(IAudioRenderClient *iface, static void pulse_wrap_buffer(ACImpl *This, BYTE *buffer, UINT32 written_bytes) { - UINT32 chunk_bytes = This->bufsize_bytes - This->wri_offs_bytes; + UINT32 wri_offs_bytes = (This->lcl_offs_bytes + This->held_bytes) % This->real_bufsize_bytes; + UINT32 chunk_bytes = This->real_bufsize_bytes - wri_offs_bytes; if(written_bytes <= chunk_bytes){ - memcpy(This->local_buffer + This->wri_offs_bytes, buffer, written_bytes); + memcpy(This->local_buffer + wri_offs_bytes, buffer, written_bytes); }else{ - memcpy(This->local_buffer + This->wri_offs_bytes, buffer, chunk_bytes); + memcpy(This->local_buffer + wri_offs_bytes, buffer, chunk_bytes); memcpy(This->local_buffer, buffer + chunk_bytes, written_bytes - chunk_bytes); } @@ -2372,88 +2358,47 @@ static HRESULT WINAPI AudioRenderClient_ReleaseBuffer( { ACImpl *This = impl_from_IAudioRenderClient(iface); UINT32 written_bytes = written_frames * pa_frame_size(&This->ss); + BYTE *buffer; TRACE("(%p)->(%u, %x)\n", This, written_frames, flags); pthread_mutex_lock(&pulse_lock); if (!This->locked || !written_frames) { - if (This->locked_ptr) - pa_stream_cancel_write(This->stream); This->locked = 0; - This->locked_ptr = NULL; pthread_mutex_unlock(&pulse_lock); return written_frames ? AUDCLNT_E_OUT_OF_ORDER : S_OK; } - if (This->locked < written_frames) { + if(written_frames * pa_frame_size(&This->ss) > (This->locked >= 0 ? This->locked : -This->locked)){ pthread_mutex_unlock(&pulse_lock); return AUDCLNT_E_INVALID_SIZE; } - if(This->local_buffer){ - BYTE *buffer; - - if(This->locked >= 0) - buffer = This->local_buffer + This->wri_offs_bytes; - else - buffer = This->tmp_buffer; - - if(flags & AUDCLNT_BUFFERFLAGS_SILENT) - silence_buffer(This->ss.format, buffer, written_bytes); - - if(This->locked < 0) - pulse_wrap_buffer(This, buffer, written_bytes); - - This->wri_offs_bytes += written_bytes; - This->wri_offs_bytes %= This->bufsize_bytes; - - This->pad += written_bytes; - This->held_bytes += written_bytes; - - if(This->held_bytes == This->pad){ - int e; - UINT32 to_write = min(This->attr.tlength, written_bytes); - - /* nothing in PA, so send data immediately */ - - TRACE("pre-writing %u bytes\n", to_write); - - e = write_buffer(This, buffer, to_write, 0); - if(e) - ERR("pa_stream_write failed: 0x%x\n", e); - - This->lcl_offs_bytes += to_write; - This->lcl_offs_bytes %= This->bufsize_bytes; - This->held_bytes -= to_write; - } - - }else{ - enum write_buffer_flags wr_flags = 0; - - if (flags & AUDCLNT_BUFFERFLAGS_SILENT) wr_flags |= WINEPULSE_WRITE_SILENT; - if (!This->locked_ptr) wr_flags |= WINEPULSE_WRITE_NOFREE; - - write_buffer(This, This->locked_ptr ? This->locked_ptr : This->tmp_buffer, written_bytes, wr_flags); - This->pad += written_bytes; - } - - if (!pa_stream_is_corked(This->stream)) { - int success; - pa_operation *o; - o = pa_stream_trigger(This->stream, pulse_op_cb, &success); - if (o) { - while(pa_operation_get_state(o) == PA_OPERATION_RUNNING) - pthread_cond_wait(&pulse_cond, &pulse_lock); - pa_operation_unref(o); - } + if(This->locked >= 0) + buffer = This->local_buffer + (This->lcl_offs_bytes + This->held_bytes) % This->real_bufsize_bytes; + else + buffer = This->tmp_buffer; + + if(flags & AUDCLNT_BUFFERFLAGS_SILENT) + silence_buffer(This->ss.format, buffer, written_bytes); + + if(This->locked < 0) + pulse_wrap_buffer(This, buffer, written_bytes); + + This->held_bytes += written_bytes; + This->pa_held_bytes += written_bytes; + if(This->pa_held_bytes > This->real_bufsize_bytes){ + This->pa_offs_bytes += This->pa_held_bytes - This->real_bufsize_bytes; + This->pa_offs_bytes %= This->real_bufsize_bytes; + This->pa_held_bytes = This->real_bufsize_bytes; } - + This->clock_written += written_bytes; This->locked = 0; - This->locked_ptr = NULL; - TRACE("Released %u, pad %zu\n", written_frames, This->pad / pa_frame_size(&This->ss)); - assert(This->pad <= This->bufsize_bytes); + + TRACE("Released %u, held %zu\n", written_frames, This->held_bytes / pa_frame_size(&This->ss)); pthread_mutex_unlock(&pulse_lock); + return S_OK; } @@ -2530,13 +2475,13 @@ static HRESULT WINAPI AudioCaptureClient_GetBuffer(IAudioCaptureClient *iface, ACImpl_GetCapturePad(This, NULL); if ((packet = This->locked_ptr)) { - *frames = This->capture_period / pa_frame_size(&This->ss); + *frames = This->period_bytes / pa_frame_size(&This->ss); *flags = 0; if (packet->discont) *flags |= AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY; if (devpos) { if (packet->discont) - *devpos = (This->clock_written + This->capture_period) / pa_frame_size(&This->ss); + *devpos = (This->clock_written + This->period_bytes) / pa_frame_size(&This->ss); else *devpos = This->clock_written / pa_frame_size(&This->ss); } @@ -2570,11 +2515,11 @@ static HRESULT WINAPI AudioCaptureClient_ReleaseBuffer( if (done) { ACPacket *packet = This->locked_ptr; This->locked_ptr = NULL; - This->pad -= This->capture_period; + This->held_bytes -= This->period_bytes; if (packet->discont) - This->clock_written += 2 * This->capture_period; + This->clock_written += 2 * This->period_bytes; else - This->clock_written += This->capture_period; + This->clock_written += This->period_bytes; list_add_tail(&This->packet_free_head, &packet->entry); } This->locked = 0; @@ -2594,7 +2539,7 @@ static HRESULT WINAPI AudioCaptureClient_GetNextPacketSize( pthread_mutex_lock(&pulse_lock); ACImpl_GetCapturePad(This, NULL); if (This->locked_ptr) - *frames = This->capture_period / pa_frame_size(&This->ss); + *frames = This->period_bytes / pa_frame_size(&This->ss); else *frames = 0; pthread_mutex_unlock(&pulse_lock); @@ -2686,7 +2631,7 @@ static HRESULT WINAPI AudioClock_GetPosition(IAudioClock *iface, UINT64 *pos, return hr; } - *pos = This->clock_written; + *pos = This->clock_written - This->held_bytes; if (This->share == AUDCLNT_SHAREMODE_EXCLUSIVE) *pos /= pa_frame_size(&This->ss); -- 2.28.0

1 0

[PATCH 0/22] Port Wine to PPC64
by André Hentschel Aug. 17, 2020

Aug. 17, 2020

Since some month I keep splitting/cleaning up/rebasing the PowerPC64le patchset from last year: [1] The goal is to have a winelib base for Hangover [2] on PowerPC64 and there's also interest in having winelib for crosscompiling [3]. [1] https://github.com/madscientist159/wine/commits/master [2] https://github.com/AndreRH/hangover [3] https://wiki.raptorcs.com/wiki/Porting/Wine

2 30

[PATCH 1/2] msvcrt/tests: Add tests for SpecialCasing.
by Daniel Lehman Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> --- dlls/msvcrt/tests/string.c | 86 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 86 insertions(+) diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c index a4b1fb9d11..a08a76fc68 100644 --- a/dlls/msvcrt/tests/string.c +++ b/dlls/msvcrt/tests/string.c @@ -4295,6 +4295,91 @@ static void test___STRINGTOLD(void) } } +static void test_SpecialCasing(void) +{ + int i; + wint_t ret, exp; + _locale_t locale; + struct test { + const char *lang; + wint_t ch; + wint_t exp; + }; + + struct test ucases[] = { + {"English", 'I', 'i'}, /* LATIN CAPITAL LETTER I */ + {"English", 0x0130}, /* LATIN CAPITAL LETTER I WITH DOT ABOVE */ + + {"Turkish", 'I', 'i'}, /* LATIN CAPITAL LETTER I */ + {"Turkish", 0x0130}, /* LATIN CAPITAL LETTER I WITH DOT ABOVE */ + }; + struct test lcases[] = { + {"English", 'i', 'I'}, /* LATIN SMALL LETTER I */ + {"English", 0x0131}, /* LATIN SMALL LETTER DOTLESS I */ + + {"Turkish", 'i', 'I'}, /* LATIN SMALL LETTER I */ + {"Turkish", 0x0131}, /* LATIN SMALL LETTER DOTLESS I */ + }; + + for (i = 0; i < ARRAY_SIZE(ucases); i++) { + if (!setlocale(LC_ALL, ucases[i].lang)) { + win_skip("skipping special case tests for %s\n", ucases[i].lang); + continue; + } + + ret = p_towlower(ucases[i].ch); + exp = ucases[i].exp ? ucases[i].exp : ucases[i].ch; + ok(ret == exp, "expected lowercase %x, got %x for locale %s\n", exp, ret, ucases[i].lang); + } + + for (i = 0; i < ARRAY_SIZE(lcases); i++) { + if (!setlocale(LC_ALL, lcases[i].lang)) { + win_skip("skipping special case tests for %s\n", lcases[i].lang); + continue; + } + + ret = p_towupper(lcases[i].ch); + exp = lcases[i].exp ? lcases[i].exp : lcases[i].ch; + ok(ret == exp, "expected uppercase %x, got %x for locale %s\n", exp, ret, lcases[i].lang); + } + + setlocale(LC_ALL, "C"); + + if (!p__towlower_l || !p__towupper_l || !p__create_locale) + { + win_skip("_towlower_l/_towupper_l/_create_locale not available\n"); + return; + } + + /* test _towlower_l creating locale */ + for (i = 0; i < ARRAY_SIZE(ucases); i++) { + if (!(locale = p__create_locale(LC_ALL, ucases[i].lang))) { + win_skip("locale %s not available. skipping\n", ucases[i].lang); + continue; + } + + ret = p__towlower_l(ucases[i].ch, locale); + exp = ucases[i].exp ? ucases[i].exp : ucases[i].ch; + ok(ret == exp, "expected lowercase %x, got %x for locale %s\n", exp, ret, ucases[i].lang); + + p__free_locale(locale); + } + + /* test _towupper_l creating locale */ + for (i = 0; i < ARRAY_SIZE(lcases); i++) { + if (!(locale = p__create_locale(LC_ALL, lcases[i].lang))) { + win_skip("locale %s not available. skipping\n", lcases[i].lang); + continue; + } + + ret = p__towupper_l(lcases[i].ch, locale); + exp = lcases[i].exp ? lcases[i].exp : lcases[i].ch; + ok(ret == exp, "expected uppercase %x, got %x for locale %s\n", exp, ret, lcases[i].lang); + + p__free_locale(locale); + } +} + START_TEST(string) { char mem[100]; @@ -4446,4 +4531,5 @@ START_TEST(string) test_iswdigit(); test_wcscmp(); test___STRINGTOLD(); + test_SpecialCasing(); } -- 2.25.1

2 3

[PATCH] ole32: Add a check for hglobal pointer to GetHGlobalFromStream.
by Dmitry Timoshkov Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ole32/hglobalstream.c | 4 ++-- dlls/ole32/tests/hglobalstream.c | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/ole32/hglobalstream.c b/dlls/ole32/hglobalstream.c index 4590bb9c43..4cfedd66a1 100644 --- a/dlls/ole32/hglobalstream.c +++ b/dlls/ole32/hglobalstream.c @@ -664,10 +664,10 @@ HRESULT WINAPI GetHGlobalFromStream(IStream* pstm, HGLOBAL* phglobal) { HGLOBALStreamImpl* pStream; - if (pstm == NULL) + if (!pstm || !phglobal) return E_INVALIDARG; - pStream = (HGLOBALStreamImpl*) pstm; + pStream = impl_from_IStream(pstm); /* * Verify that the stream object was created with CreateStreamOnHGlobal. diff --git a/dlls/ole32/tests/hglobalstream.c b/dlls/ole32/tests/hglobalstream.c index 2f386914af..5bcf9abfbd 100644 --- a/dlls/ole32/tests/hglobalstream.c +++ b/dlls/ole32/tests/hglobalstream.c @@ -561,6 +561,12 @@ static void test_IStream_Clone(void) hr = CreateStreamOnHGlobal(orig_hmem, TRUE, &stream); ok(hr == S_OK, "unexpected %#x\n", hr); + hr = GetHGlobalFromStream(stream, NULL); + ok(hr == E_INVALIDARG, "unexpected %#x\n", hr); + + hr = GetHGlobalFromStream(NULL, &hmem); + ok(hr == E_INVALIDARG, "unexpected %#x\n", hr); + stream_info(stream, &hmem, &size, &pos); ok(hmem == orig_hmem, "handles should match\n"); ok(size == 0, "unexpected %d\n", size); -- 2.26.2

2 1

[PATCH 3/6] kernelbase: Use IOCTL_CONDRV_SET_TITLE in SetConsoleTitleW.
by Jacek Caban Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/console.c | 4 ++++ dlls/kernelbase/console.c | 14 +++----------- 2 files changed, 7 insertions(+), 11 deletions(-)

2 1

[PATCH 2/6] kernelbase: Use IOCTL_CONDRV_SET_INPUT_INFO in SetConsoleOutputCP.
by Jacek Caban Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/console.c | 4 ++++ dlls/kernelbase/console.c | 15 +++++---------- 2 files changed, 9 insertions(+), 10 deletions(-)

2 1

[PATCH 1/6] kernelbase: Use IOCTL_CONDRV_SET_INPUT_INFO in SetConsoleCP.
by Jacek Caban Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/console.c | 4 ++++ dlls/kernelbase/console.c | 15 +++++---------- 2 files changed, 9 insertions(+), 10 deletions(-)

2 1

[PATCH v2] vbscript: Implement Split.
by Robert Wilhelm Aug. 17, 2020

Aug. 17, 2020

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47570 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> --- dlls/vbscript/global.c | 119 +++++++++++++++++++++++++++++++++++- dlls/vbscript/tests/api.vbs | 19 ++++++ 2 files changed, 135 insertions(+), 3 deletions(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 122f5c7b71..b799b962fe 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -2291,10 +2291,123 @@ static HRESULT Global_Join(BuiltinDisp *This, VARIANT *arg, unsigned args_cnt, V return E_NOTIMPL; } -static HRESULT Global_Split(BuiltinDisp *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) +static HRESULT Global_Split(BuiltinDisp *This, VARIANT *args, unsigned args_cnt, VARIANT *res) { - FIXME("\n"); - return E_NOTIMPL; + BSTR str,string,delimeter; + int count,max,mode,len,start,end,ret; + SAFEARRAYBOUND bounds; + SAFEARRAY *sa; + VARIANT *data,var; + HRESULT hres = S_OK; + + TRACE("%s %u...\n", debugstr_variant(args), args_cnt); + + assert(1 <= args_cnt && args_cnt <= 4); + + if(V_VT(args) != VT_BSTR) { + hres = to_string(args, &string); + if(FAILED(hres)) + return hres; + }else { + string = V_BSTR(args); + } + + if ( args_cnt > 1) + { + if(V_VT(args+1) != VT_BSTR) { + hres = to_string(args+1, &delimeter); + if(FAILED(hres)) + return hres; + }else { + delimeter = V_BSTR(args+1); + } + } + else + delimeter = SysAllocString(L" "); + + if(args_cnt > 2) { + hres = to_int(args + 2, &max); + if(FAILED(hres)) + return hres; + }else { + max = -1; + } + + if (args_cnt == 4) { + hres = to_int(args+3, &mode); + if(FAILED(hres)) + return hres; + + if (mode != 0 && mode != 1) { + FIXME("unknown compare mode = %d\n", mode); + return E_FAIL; + } + } + else + mode = 0; + + start = 0; + + bounds.lLbound = 0; + bounds.cElements = 0; + + sa = SafeArrayCreate( VT_VARIANT, 1, &bounds); + if (!sa) + return E_OUTOFMEMORY; + + len = SysStringLen(string); + count = 0; + + while(1) + { + ret = FindStringOrdinal(FIND_FROMSTART, string + start, len -start, + delimeter, SysStringLen(delimeter), mode); + + if (ret == -1) + end = len; + else + end = start + ret; + + str = SysAllocStringLen(string + start, end - start); + if (!str) + return E_OUTOFMEMORY; + + V_VT(&var) = VT_BSTR; + V_BSTR(&var) = str; + + bounds.cElements++; + SafeArrayRedim(sa, &bounds); + hres = SafeArrayAccessData(sa, (void**)&data); + if(FAILED(hres)) { + SafeArrayDestroy(sa); + return hres; + } + + hres = VariantCopyInd(data+count, &var); + + if(FAILED(hres)) { + SafeArrayUnaccessData(sa); + SafeArrayDestroy(sa); + return hres; + } + + SafeArrayUnaccessData(sa); + + if (ret == -1) break; + + start = start + ret + SysStringLen(delimeter); + count++; + if (count == max) break; + } + + if(res) { + V_VT(res) = VT_ARRAY|VT_VARIANT; + V_ARRAY(res) = sa; + }else { + SafeArrayDestroy(sa); + } + + return S_OK; } static HRESULT Global_Replace(BuiltinDisp *This, VARIANT *args, unsigned args_cnt, VARIANT *res) diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs index 6af49c849d..fe4799b52f 100644 --- a/dlls/vbscript/tests/api.vbs +++ b/dlls/vbscript/tests/api.vbs @@ -609,6 +609,25 @@ TestLCase 0.123, doubleAsString(0.123) TestLCase Empty, "" Call ok(getVT(LCase(Null)) = "VT_NULL", "getVT(LCase(Null)) = " & getVT(LCase(Null))) +x = Split("abc") +Call ok(x(0) = "abc", "Split returned " & x(0)) +x = Split("abc def") +Call ok(x(0) = "abc", "Split returned " & x(0)) +Call ok(x(1) = "def", "Split returned " & x(1)) +x = Split("abc-def","-") +Call ok(x(0) = "abc", "Split returned " & x(0)) +Call ok(x(1) = "def", "Split returned " & x(1)) +x = Split("abc-def-ghi","-") +Call ok(UBound(x) = 2, "Split returned " & UBound(x)) +x = Split("abc-def-ghi","-",2) +Call ok(UBound(x) = 1, "Split returned " & UBound(x)) +x = Split("abcZdefZghi","Z",3,0) +Call ok(UBound(x) = 2, "Split returned " & UBound(x)) +x = Split("abcZdefZghi","z",3,0) +Call ok(UBound(x) = 0, "Split returned " & UBound(x)) +x = Split("abcZdefZghi","z",3,1) +Call ok(UBound(x) = 2, "Split returned " & UBound(x)) + Sub TestStrComp(str_left, str_right, mode, ex) x = StrComp(str_left, str_right, mode) Call ok(x = ex, "StrComp(" & str_left & ", " & str_right & ", " & mode & ") = " & x & " expected " & ex) -- 2.26.2

3 2

[PATCH 6/6] server: Use passed console handle to inherit console for created process.
by Jacek Caban Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernelbase/process.c | 1 + server/console.c | 37 +++++++++++++------------------------ server/process.c | 2 +- server/process.h | 2 +- 4 files changed, 16 insertions(+), 26 deletions(-)

1 0

[PATCH 5/6] wineconsole: Make sure that console process is not attached to another console.
by Jacek Caban Aug. 17, 2020

Aug. 17, 2020

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/wineconsole/wineconsole.c | 3 +++ 1 file changed, 3 insertions(+)

1 0