- Wine-Devel - list.winehq.org

[PATCH v3 5/6] win32u: Move NtUserPeekMessage implementation from user32.
by Jacek Caban March 31, 2022

March 31, 2022

3 2

[tools 1/3] testbot/cgi: Add SimpleCollectionPage.
by Francois Gouget March 31, 2022

March 31, 2022

SimpleCollectionPage embeds a single collection block. But unlike CollectionPage it is only a Page subclass instead of implementing both the Page and CollectionBlock interfaces. Customizing the collection block is done by creating a CollectionBlock subclass and passing the appropriate creator function to the page constructor. This better separates the page customization aspects (implement a SimpleCollectionPage subclass) from the collection block ones (implement a CollectionBlock subclass). Most of the time only the collection block needs to be customized and SimpleCollectionPage can be used as is. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- .../lib/ObjectModel/CGI/CollectionBlock.pm | 5 + .../ObjectModel/CGI/SimpleCollectionPage.pm | 138 ++++++++++++++++++ 2 files changed, 143 insertions(+) create mode 100644 testbot/lib/ObjectModel/CGI/SimpleCollectionPage.pm diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm index 9a52f11bc..200734a6a 100644 --- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm +++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm @@ -91,6 +91,11 @@ sub _initialize($$$) #my ($self, $Collection, $EnclosingPage) = @_; } +sub Create($$@) +{ + return ObjectModel::CGI::CollectionBlock->new(@_); +} + sub CallGetDetailsPage($) { my ($self) = @_; diff --git a/testbot/lib/ObjectModel/CGI/SimpleCollectionPage.pm b/testbot/lib/ObjectModel/CGI/SimpleCollectionPage.pm new file mode 100644 index 000000000..76e4d5195 --- /dev/null +++ b/testbot/lib/ObjectModel/CGI/SimpleCollectionPage.pm @@ -0,0 +1,138 @@ +# -*- Mode: Perl; perl-indent-level: 2; indent-tabs-mode: nil -*- +# Base class for list pages +# +# Copyright 2009 Ge van Geldorp +# Copyright 2014, 2017-2018, 2022 Francois Gouget +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + +use strict; + +package ObjectModel::CGI::SimpleCollectionPage; + +=head1 NAME + +ObjectModel::CGI::SimpleCollectionPage - Base class for list pages + +A page containing a single collection block. + +The SimpleCollectionPage instances have the following properties: +=over +=item Collection +The collection containing the items to be shown in the CollectionBlock widget. + +=item CollectionBlock +The widget showing the items in the specified collection. + +=item ActionPerformed +Set to true if an action was specified and succeeded. +=back + +=cut + +use ObjectModel::CGI::Page; +our @ISA = qw(ObjectModel::CGI::Page); + +# Use require to avoid overriding Page::new() +require ObjectModel::CGI::CollectionBlock; + + +=pod +=over 12 + +=item C<_initialize()> + +Sets up the new page object. + +Parameters: +=over + +=item Request +=item RequiredRole +See Page::new(). + +=item Collection +This is the collection of items that should be shown in the CollectionBlock +widget. + +=item BlockCreator +If undefined the page will create an instance of the CollectionBlock class. +Otherwise it will use this function to create the CollectionBlock widget, thus +enabling use of a CollectionBlock subclass. + +=back + +=back +=cut + +sub _initialize($$$$;$) +{ + my ($self, $Request, $RequiredRole, $Collection, $BlockCreator) = @_; + + $self->{Collection} = $Collection; + $BlockCreator ||= \&ObjectModel::CGI::CollectionBlock::Create; + $self->{CollectionBlock} = &$BlockCreator($Collection, $self); + $self->SUPER::_initialize($Request, $RequiredRole); +} + + +# +# HTML page generation +# + +sub GetTitle($) +{ + my ($self) = @_; + + my $Title = ucfirst($self->{Collection}->GetCollectionName()); + $Title =~ s/([a-z])([A-Z])/$1 $2/g; + return $Title; +} + +sub GenerateTitle($) +{ + my ($self) = @_; + + my $Title = $self->GetTitle(); + if ($Title) + { + print "<h1 id='PageTitle'>", $self->escapeHTML($Title), "</h1>\n"; + } +} + +sub GenerateBody($) +{ + my ($self) = @_; + + print "<div class='CollectionPageBody'>\n"; + $self->GenerateTitle(); + print "<div class='Content'>\n"; + $self->{CollectionBlock}->GenerateList(); + print "</div>\n"; + print "</div>\n"; +} + +sub GeneratePage($) +{ + my ($self) = @_; + + if ($self->GetParam("Action")) + { + $self->{ActionPerformed} = $self->{CollectionBlock}->OnAction($self->GetParam("Action")); + } + $self->SUPER::GeneratePage(); +} + +1; -- 2.30.2

1 2

[tools] testbot: Fix the spelling of a couple of Perl POD entries.
by Francois Gouget March 31, 2022

March 31, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 2 +- testbot/lib/ObjectModel/CGI/Page.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm index 58ece69f3..9a52f11bc 100644 --- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm +++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm @@ -37,7 +37,7 @@ Also, because this is only one part of a web page, some methods, such as those dealing with errors, are delegated to the EnclosingPage object which must implement the ObjectModel::CGI::Page interface. -Other methods are designed so they can be overriden by the enclosing page as +Other methods are designed so they can be overridden by the enclosing page as a way to allow it to modify how the collection block looks or behaves. These methods can be identified by their CallXxx() trampoline. The override mechanism works as follows: diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm index a79155950..0879557ad 100644 --- a/testbot/lib/ObjectModel/CGI/Page.pm +++ b/testbot/lib/ObjectModel/CGI/Page.pm @@ -360,7 +360,7 @@ sub GetPageTitle($) =head1 C<GetTitle()> This returns the title for the current web page or email section. -Note that this may not be valid HTML and thus my need escaping. +Note that this may not be valid HTML and thus may need escaping. =back =cut -- 2.30.2

1 0

[PATCH v3 4/6] win32u: Move process_sent_messages implementation from user32.
by Jacek Caban March 31, 2022

March 31, 2022

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- v3: Removed unused functions. dlls/user32/message.c | 11 +- dlls/user32/user_main.c | 3 + dlls/user32/user_private.h | 6 +- dlls/user32/winproc.c | 6 + dlls/win32u/message.c | 392 ++++++++++++++++++++++++++++++++++- dlls/win32u/ntuser_private.h | 6 + dlls/win32u/sysparams.c | 10 + dlls/win32u/win32u_private.h | 2 + include/ntuser.h | 12 ++ 9 files changed, 440 insertions(+), 8 deletions(-)

3 2

[PATCH v3 3/6] user32: Move unpack_message call to User32CallWindowProc.
by Jacek Caban March 31, 2022

March 31, 2022

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/message.c | 412 +++-------------------------------- dlls/user32/winproc.c | 486 +++++++++++++++++++++++++++++++++++++++++- dlls/win32u/message.c | 2 + include/ntuser.h | 1 + 4 files changed, 511 insertions(+), 390 deletions(-)

3 2

[tools] testbot/web: Standardize the page creation.
by Francois Gouget March 31, 2022

March 31, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/Activity.pl | 5 ++--- testbot/web/Feedback.pl | 5 ++--- testbot/web/ForgotPassword.pl | 5 ++--- testbot/web/JobDetails.pl | 5 ++--- testbot/web/Login.pl | 5 ++--- testbot/web/Logout.pl | 5 ++--- testbot/web/Register.pl | 5 ++--- testbot/web/ResetPassword.pl | 5 ++--- testbot/web/Stats.pl | 5 ++--- testbot/web/Submit.pl | 5 ++--- testbot/web/admin/BranchDetails.pl | 5 ++--- testbot/web/admin/Log.pl | 5 ++--- testbot/web/admin/SpecialJobs.pl | 5 ++--- testbot/web/admin/UserDetails.pl | 5 ++--- testbot/web/admin/VMDetails.pl | 5 ++--- testbot/web/index.pl | 5 ++--- 16 files changed, 32 insertions(+), 48 deletions(-) diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl index 1771e7ca3..5a5a37505 100644 --- a/testbot/web/Activity.pl +++ b/testbot/web/Activity.pl @@ -318,6 +318,5 @@ sub GenerateFooter($) package main; my $Request = shift; - -my $ActivityPage = ActivityPage->new($Request, "wine-devel"); -$ActivityPage->GeneratePage(); +my $Page = ActivityPage->new($Request, "wine-devel"); +$Page->GeneratePage(); diff --git a/testbot/web/Feedback.pl b/testbot/web/Feedback.pl index ca1ee5ed7..6185d26d2 100644 --- a/testbot/web/Feedback.pl +++ b/testbot/web/Feedback.pl @@ -137,6 +137,5 @@ sub GenerateBody($) package main; my $Request = shift; - -my $FeedbackPage = FeedbackPage->new($Request, ""); -$FeedbackPage->GeneratePage(); +my $Page = FeedbackPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/ForgotPassword.pl b/testbot/web/ForgotPassword.pl index cc0cd455d..190985264 100644 --- a/testbot/web/ForgotPassword.pl +++ b/testbot/web/ForgotPassword.pl @@ -131,6 +131,5 @@ sub GenerateBody($) package main; my $Request = shift; - -my $ForgotPasswordPage = ForgotPasswordPage->new($Request, ""); -$ForgotPasswordPage->GeneratePage(); +my $Page = ForgotPasswordPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index c4d6b1a1b..7e1df1ffa 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -741,6 +741,5 @@ sub GenerateFooter($) package main; my $Request = shift; - -my $JobDetailsPage = JobDetailsPage->new($Request, ""); -$JobDetailsPage->GeneratePage(); +my $Page = JobDetailsPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/Login.pl b/testbot/web/Login.pl index ac64fc28e..b1f82a94b 100644 --- a/testbot/web/Login.pl +++ b/testbot/web/Login.pl @@ -154,6 +154,5 @@ sub OnAction($$) package main; my $Request = shift; - -my $LoginPage = LoginPage->new($Request, ""); -$LoginPage->GeneratePage(); +my $Page = LoginPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/Logout.pl b/testbot/web/Logout.pl index b0fd5cdc1..35f5c487c 100644 --- a/testbot/web/Logout.pl +++ b/testbot/web/Logout.pl @@ -76,6 +76,5 @@ sub GeneratePage($) package main; my $Request = shift; - -my $LogoutPage = LogoutPage->new($Request, ""); -$LogoutPage->GeneratePage(); +my $Page = LogoutPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/Register.pl b/testbot/web/Register.pl index 4cfef79fc..bbea0eb12 100644 --- a/testbot/web/Register.pl +++ b/testbot/web/Register.pl @@ -183,6 +183,5 @@ EOF package main; my $Request = shift; - -my $RegisterPage = RegisterPage->new($Request, ""); -$RegisterPage->GeneratePage(); +my $Page = RegisterPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/ResetPassword.pl b/testbot/web/ResetPassword.pl index 81655e0c4..4f672ea94 100644 --- a/testbot/web/ResetPassword.pl +++ b/testbot/web/ResetPassword.pl @@ -184,6 +184,5 @@ sub GenerateBody($) package main; my $Request = shift; - -my $ResetPasswordPage = ResetPasswordPage->new($Request, ""); -$ResetPasswordPage->GeneratePage(); +my $Page = ResetPasswordPage->new($Request, ""); +$Page->GeneratePage(); diff --git a/testbot/web/Stats.pl b/testbot/web/Stats.pl index 39c28789c..7ef65b3bf 100644 --- a/testbot/web/Stats.pl +++ b/testbot/web/Stats.pl @@ -397,6 +397,5 @@ sub GenerateFooter($) package main; my $Request = shift; - -my $StatsPage = StatsPage->new($Request, "wine-devel"); -$StatsPage->GeneratePage(); +my $Page = StatsPage->new($Request, "wine-devel"); +$Page->GeneratePage(); diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index aba2b6dc5..8323b9ab7 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -1376,6 +1376,5 @@ sub OnAction($$) package main; my $Request = shift; - -my $SubmitPage = SubmitPage->new($Request, "wine-devel"); -$SubmitPage->GeneratePage(); +my $Page = SubmitPage->new($Request, "wine-devel"); +$Page->GeneratePage(); diff --git a/testbot/web/admin/BranchDetails.pl b/testbot/web/admin/BranchDetails.pl index fe3ebd118..1373e20fe 100644 --- a/testbot/web/admin/BranchDetails.pl +++ b/testbot/web/admin/BranchDetails.pl @@ -38,6 +38,5 @@ sub _initialize($$$) package main; my $Request = shift; - -my $BranchDetailsPage = BranchDetailsPage->new($Request, "admin"); -$BranchDetailsPage->GeneratePage(); +my $Page = BranchDetailsPage->new($Request, "admin"); +$Page->GeneratePage(); diff --git a/testbot/web/admin/Log.pl b/testbot/web/admin/Log.pl index 8d3a8ce8b..9c18c375e 100644 --- a/testbot/web/admin/Log.pl +++ b/testbot/web/admin/Log.pl @@ -97,6 +97,5 @@ sub GenerateBody($) package main; my $Request = shift; - -my $LogPage = LogPage->new($Request, "admin"); -$LogPage->GeneratePage(); +my $Page = LogPage->new($Request, "admin"); +$Page->GeneratePage(); diff --git a/testbot/web/admin/SpecialJobs.pl b/testbot/web/admin/SpecialJobs.pl index 49f80a0f9..e267cc7d5 100644 --- a/testbot/web/admin/SpecialJobs.pl +++ b/testbot/web/admin/SpecialJobs.pl @@ -256,6 +256,5 @@ sub OnAction($$) package main; my $Request = shift; - -my $SubmitPage = SpecialJobsPage->new($Request, "admin"); -$SubmitPage->GeneratePage(); +my $Page = SpecialJobsPage->new($Request, "admin"); +$Page->GeneratePage(); diff --git a/testbot/web/admin/UserDetails.pl b/testbot/web/admin/UserDetails.pl index 7f7c710e1..f11d127ad 100644 --- a/testbot/web/admin/UserDetails.pl +++ b/testbot/web/admin/UserDetails.pl @@ -126,6 +126,5 @@ sub OnAction($$) package main; my $Request = shift; - -my $UserDetailsPage = UserDetailsPage->new($Request, "admin"); -$UserDetailsPage->GeneratePage(); +my $Page = UserDetailsPage->new($Request, "admin"); +$Page->GeneratePage(); diff --git a/testbot/web/admin/VMDetails.pl b/testbot/web/admin/VMDetails.pl index f39b0d674..35b26811a 100644 --- a/testbot/web/admin/VMDetails.pl +++ b/testbot/web/admin/VMDetails.pl @@ -89,6 +89,5 @@ sub GenerateFooter($) package main; my $Request = shift; - -my $VMDetailsPage = VMDetailsPage->new($Request, "admin"); -$VMDetailsPage->GeneratePage(); +my $Page = VMDetailsPage->new($Request, "admin"); +$Page->GeneratePage(); diff --git a/testbot/web/index.pl b/testbot/web/index.pl index 94421536d..d2dd2b49d 100644 --- a/testbot/web/index.pl +++ b/testbot/web/index.pl @@ -394,6 +394,5 @@ EOF package main; my $Request = shift; - -my $StatusPage = StatusPage->new($Request, ""); -$StatusPage->GeneratePage(); +my $Page = StatusPage->new($Request, ""); +$Page->GeneratePage(); -- 2.30.2

1 0

[PATCH v3 2/6] win32u: Move reply_message_result implementation from user32.
by Jacek Caban March 31, 2022

March 31, 2022

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/message.c | 181 +----------------------- dlls/win32u/message.c | 264 +++++++++++++++++++++++++++++++++++ dlls/win32u/ntuser_private.h | 9 ++ dlls/win32u/sysparams.c | 2 + dlls/win32u/win32u_private.h | 1 + include/ntuser.h | 153 ++++++++++++++++++++ 6 files changed, 431 insertions(+), 179 deletions(-)

3 2

[tools] testbot: Remove an unneeded Fcntl import in VM::Run().
by Francois Gouget March 31, 2022

March 31, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/WineTestBot/VMs.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index f850daaf3..65f633354 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -446,7 +446,6 @@ sub Run($$$$$$) # So set ChildPid in the parent and synchronize with the child so it only # execs once this is done. - use Fcntl; my ($fd_read, $fd_write); pipe($fd_read, $fd_write); # For synchronization -- 2.30.2

1 0

[tools] testbot/cgi: ItemPage does not need URI::Escape.
by Francois Gouget March 31, 2022

March 31, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/ItemPage.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm index 567a489fc..b88e27394 100644 --- a/testbot/lib/ObjectModel/CGI/ItemPage.pm +++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm @@ -31,7 +31,6 @@ ObjectModel::CGI::ItemPage - Base class for bound web forms use ObjectModel::CGI::FormPage; our @ISA = qw(ObjectModel::CGI::FormPage); -use URI::Escape; sub _initialize($$$$) { -- 2.30.2

1 0

[tools] testbot/CheckForWinetestUpdate: HTTP::Response is not needed.
by Francois Gouget March 31, 2022

March 31, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/CheckForWinetestUpdate.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/testbot/bin/CheckForWinetestUpdate.pl b/testbot/bin/CheckForWinetestUpdate.pl index 94d975071..c7aecce1e 100755 --- a/testbot/bin/CheckForWinetestUpdate.pl +++ b/testbot/bin/CheckForWinetestUpdate.pl @@ -46,7 +46,6 @@ use File::Compare; use File::Copy; use LWP::UserAgent; use HTTP::Request; -use HTTP::Response; use HTTP::Status; use WineTestBot::Config; -- 2.30.2

1 0