- Wine-Devel - list.winehq.org

[PATCH v3 1/4] mf/tests: Check the number of input samples to get a H264 stream change.
by Rémi Bernon March 11, 2022

March 11, 2022

We check that we can at least push two input samples at a time, which matches what Call of Duty Black Ops 3 is doing, as it is not checking ProcessInput result most of the time. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45988 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47084 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49715 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52183 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- v3: Rebase and fix uninitialized output_info.cbSize usage in PATCH 4. dlls/mf/tests/mf.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c index 2e126a1dbcf..ead2d56dc70 100644 --- a/dlls/mf/tests/mf.c +++ b/dlls/mf/tests/mf.c @@ -6619,6 +6619,7 @@ static void test_h264_decoder(void) MFT_OUTPUT_DATA_BUFFER output; const BYTE *h264_encoded_data; ULONG h264_encoded_data_len; + IMFAttributes *attributes; IMFMediaType *media_type; IMFTransform *transform; ULONG i, ret, flags; @@ -6636,6 +6637,14 @@ static void test_h264_decoder(void) &transform, &class_id)) goto failed; + hr = IMFTransform_GetAttributes(transform, &attributes); + todo_wine + ok(hr == S_OK, "GetAttributes returned %#lx\n", hr); + if (hr != S_OK) MFCreateAttributes(&attributes, 0); + hr = IMFAttributes_SetUINT32(attributes, &MF_LOW_LATENCY, 1); + ok(hr == S_OK, "SetUINT32 returned %#lx\n", hr); + IMFAttributes_Release(attributes); + /* no output type is available before an input type is set */ hr = IMFTransform_GetOutputAvailableType(transform, 0, 0, &media_type); @@ -6830,6 +6839,7 @@ static void test_h264_decoder(void) ok(!output.pEvents, "got pEvents %p\n", output.pEvents); ok(status == 0, "got status %#lx\n", status); + i = 0; sample = next_h264_sample(&h264_encoded_data, &h264_encoded_data_len); while (1) { @@ -6848,19 +6858,30 @@ static void test_h264_decoder(void) ret = IMFSample_Release(output.pSample); ok(ret == 0, "Release returned %lu\n", ret); - while (h264_encoded_data_len > 4) - { - hr = IMFTransform_ProcessInput(transform, 0, sample, 0); - if (FAILED(hr)) break; - ok(hr == S_OK, "ProcessInput returned %#lx\n", hr); - ret = IMFSample_Release(sample); - ok(ret <= 1, "Release returned %lu\n", ret); - sample = next_h264_sample(&h264_encoded_data, &h264_encoded_data_len); - } - ok(hr == MF_E_NOTACCEPTING, "ProcessInput returned %#lx\n", hr); - EXPECT_REF(sample, 1); + hr = IMFTransform_ProcessInput(transform, 0, sample, 0); + todo_wine + ok(hr == S_OK, "ProcessInput returned %#lx\n", hr); + ret = IMFSample_Release(sample); + ok(ret <= 1, "Release returned %lu\n", ret); + sample = next_h264_sample(&h264_encoded_data, &h264_encoded_data_len); + + hr = IMFTransform_ProcessInput(transform, 0, sample, 0); + todo_wine + ok(hr == S_OK, "ProcessInput returned %#lx\n", hr); + ret = IMFSample_Release(sample); + ok(ret <= 1, "Release returned %lu\n", ret); + sample = next_h264_sample(&h264_encoded_data, &h264_encoded_data_len); + i++; + + hr = IMFTransform_ProcessMessage(transform, MFT_MESSAGE_COMMAND_DRAIN, 0); + todo_wine + ok(hr == S_OK, "ProcessMessage returned %#lx\n", hr); } todo_wine + ok(i == 2, "got %lu iterations\n", i); + todo_wine + ok(h264_encoded_data_len == 44959, "got h264_encoded_data_len %lu\n", h264_encoded_data_len); + todo_wine ok(hr == MF_E_TRANSFORM_STREAM_CHANGE, "ProcessOutput returned %#lx\n", hr); ok(output.dwStreamID == 0, "got dwStreamID %lu\n", output.dwStreamID); ok(!!output.pSample, "got pSample %p\n", output.pSample); -- 2.35.1

2 7

[RFC PATCH] advapi32/tests: Check the timezone name size limits in all languages.
by Francois Gouget March 10, 2022

March 10, 2022

The localized standard and daylight timezone names returned by EnumDynamicTimeZoneInformation() must fit in a 32 character buffer. But there is no such limitation in Wine's PO files and the regular WineTest runs only cover some locales. So use SetThreadUILanguage() to verify the translations in all the known languages. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51619 Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- Unfortunately SetThreadUILanguage() is a stub in Wine so this currently has no effect where we need it. Also while going through all of Wine's ~150 known languages only takes about 35 seconds, this would benefit from some parallelization to speed things up (see d3d11:d3d11 for instance). I can send a patch for that if this approach is deemed worthwhile. Note that on Windows we typically only install a few language packs, resulting in only about 20 loops and a sub 4 second runtime. So the optimization is not as necessary there. --- dlls/advapi32/tests/registry.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 6152a313803..4eefd18cf5f 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -4308,7 +4308,7 @@ static void test_RegLoadMUIString(void) SetEnvironmentVariableA("WineMuiDat", NULL); } -static void test_EnumDynamicTimeZoneInformation(void) +static BOOL CALLBACK test_EnumDynamicTimeZoneInformation(LPSTR value, LONG_PTR lParam) { LSTATUS status; HKEY key, subkey; @@ -4329,7 +4329,14 @@ static void test_EnumDynamicTimeZoneInformation(void) if (!pEnumDynamicTimeZoneInformation) { win_skip("EnumDynamicTimeZoneInformation is not supported.\n"); - return; + return FALSE; + } + + if (value) + { + LANGID lang = strtol(value, NULL, 16); + winetest_push_context("lang=%04x", lang); + ok(SetThreadUILanguage(lang) == lang, "SetThreadUILanguage(%04x) failed: gle=%lu\n", lang, GetLastError()); } if (pRegLoadMUIStringW) @@ -4473,6 +4480,8 @@ static void test_EnumDynamicTimeZoneInformation(void) ok(!memcmp(&dtzi, &bogus_dtzi, sizeof(dtzi)), "mismatch\n"); RegCloseKey(key); + winetest_pop_context(); + return TRUE; } START_TEST(registry) @@ -4512,8 +4521,14 @@ START_TEST(registry) test_RegNotifyChangeKeyValue(); test_performance_keys(); test_RegLoadMUIString(); - test_EnumDynamicTimeZoneInformation(); test_perflib_key(); + if (SetThreadUILanguage(0xffff) == 0xffff) + { + skip("SetThreadUILanguage() is a stub; test the current UI language\n"); + test_EnumDynamicTimeZoneInformation(NULL, 0); + } + else + EnumUILanguagesA(test_EnumDynamicTimeZoneInformation, MUI_LANGUAGE_ID, 0); /* cleanup */ delete_key( hkey_main ); -- 2.30.2

2 1

[PATCH] conhost: Reimplement font dialog handling
by Hugh McMaster March 10, 2022

March 10, 2022

Much of the existing font dialog code is overly complicated and difficult to follow. There are also bugs in the code, which cannot be fixed with minimal changes due to the complexity of the existing source. For example, changing the font face via the listbox unexpectedly changes the font size. It is also unnecessary to recreate the list of available font sizes each font face selection if the font type remains unchanged. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> --- programs/conhost/window.c | 227 +++++++++----------------------------- 1 file changed, 55 insertions(+), 172 deletions(-) diff --git a/programs/conhost/window.c b/programs/conhost/window.c index abfc791c1ef..fb02ef9fd94 100644 --- a/programs/conhost/window.c +++ b/programs/conhost/window.c @@ -1206,13 +1206,6 @@ struct dialog_info struct console *console; struct console_config config; HWND dialog; /* handle to active propsheet */ - int font_count; /* number of fonts */ - struct dialog_font_info - { - unsigned int height; - unsigned int weight; - WCHAR faceName[LF_FACESIZE]; - } *font; /* array of fonts */ }; /* dialog proc for the option property sheet */ @@ -1352,12 +1345,10 @@ static LRESULT WINAPI font_preview_proc( HWND hwnd, UINT msg, WPARAM wparam, LPA struct dialog_info *di; HFONT font, old_font; PAINTSTRUCT ps; - int size_idx; di = (struct dialog_info *)GetWindowLongPtrW( GetParent( hwnd ), DWLP_USER ); BeginPaint( hwnd, &ps ); - size_idx = SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_GETCURSEL, 0, 0 ); font = (HFONT)GetWindowLongPtrW( hwnd, 0 ); if (font) { @@ -1373,7 +1364,7 @@ static LRESULT WINAPI font_preview_proc( HWND hwnd, UINT msg, WPARAM wparam, LPA SetTextColor( ps.hdc, get_color( di, IDC_FNT_COLOR_FG )); len = LoadStringW( GetModuleHandleW(NULL), IDS_FNT_PREVIEW, buf, ARRAY_SIZE(buf) ); if (len) TextOutW( ps.hdc, 0, 0, buf, len ); - TextOutW( ps.hdc, 0, di->font[size_idx].height, ascii, ARRAY_SIZE(ascii) - 1 ); + TextOutW( ps.hdc, 0, di->config.cell_height, ascii, ARRAY_SIZE(ascii) - 1 ); SelectObject( ps.hdc, old_font ); } EndPaint( hwnd, &ps ); @@ -1461,146 +1452,42 @@ static LRESULT WINAPI color_preview_proc( HWND hwnd, UINT msg, WPARAM wparam, LP return 0; } -/* enumerates all the font names with at least one valid font */ -static int WINAPI font_enum_size2( const LOGFONTW *lf, const TEXTMETRICW *tm, - DWORD font_type, LPARAM lparam ) -{ - struct dialog_info *di = (struct dialog_info *)lparam; - TRACE( "%s\n", debugstr_textmetric( tm, font_type )); - if (validate_font_metric( di->console, tm, font_type, 0 )) di->font_count++; - return 1; -} - -static int WINAPI font_enum( const LOGFONTW *lf, const TEXTMETRICW *tm, - DWORD font_type, LPARAM lparam ) -{ - struct dialog_info *di = (struct dialog_info *)lparam; - - TRACE( "%s\n", debugstr_logfont( lf, font_type )); - - if (validate_font( di->console, lf, 0 )) - { - if (font_type & RASTER_FONTTYPE) - { - di->font_count = 0; - EnumFontFamiliesW( di->console->window->mem_dc, lf->lfFaceName, - font_enum_size2, (LPARAM)di ); - } - else - di->font_count = 1; - - if (di->font_count) - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_ADDSTRING, - 0, (LPARAM)lf->lfFaceName ); - } - return 1; -} - -static int WINAPI font_enum_size( const LOGFONTW *lf, const TEXTMETRICW *tm, - DWORD font_type, LPARAM lparam ) -{ - struct dialog_info *di = (struct dialog_info *)lparam; - WCHAR buf[32]; - - TRACE( "%s\n", debugstr_textmetric( tm, font_type )); - - if (di->font_count == 0 && !(font_type & RASTER_FONTTYPE)) - { - static const int sizes[] = {8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72}; - int i; - - di->font_count = ARRAY_SIZE(sizes); - di->font = malloc( di->font_count * sizeof(di->font[0]) ); - for (i = 0; i < di->font_count; i++) - { - /* drop sizes where window size wouldn't fit on screen */ - if (sizes[i] * di->config.win_height > GetSystemMetrics( SM_CYSCREEN )) - { - di->font_count = i; - break; - } - di->font[i].height = sizes[i]; - di->font[i].weight = 400; - lstrcpyW( di->font[i].faceName, lf->lfFaceName ); - wsprintfW( buf, L"%d", sizes[i] ); - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_INSERTSTRING, i, (LPARAM)buf ); - } - /* don't need to enumerate other */ - return 0; - } - - if (validate_font_metric( di->console, tm, font_type, 0 )) - { - int idx = 0; - - /* we want the string to be sorted with a numeric order, not a lexicographic... - * do the job by hand... get where to insert the new string - */ - while (idx < di->font_count && tm->tmHeight > di->font[idx].height) - idx++; - while (idx < di->font_count && - tm->tmHeight == di->font[idx].height && - tm->tmWeight > di->font[idx].weight) - idx++; - if (idx == di->font_count || - tm->tmHeight != di->font[idx].height || - tm->tmWeight < di->font[idx].weight) - { - /* here we need to add the new entry */ - wsprintfW( buf, L"%d", tm->tmHeight ); - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_INSERTSTRING, idx, (LPARAM)buf ); - - /* now grow our arrays and insert the values at the same index than in the list box */ - if (di->font_count) - { - di->font = realloc( di->font, sizeof(*di->font) * (di->font_count + 1) ); - if (idx != di->font_count) - memmove( &di->font[idx + 1], &di->font[idx], - (di->font_count - idx) * sizeof(*di->font) ); - } - else - di->font = malloc( sizeof(*di->font) ); - di->font[idx].height = tm->tmHeight; - di->font[idx].weight = tm->tmWeight; - lstrcpyW( di->font[idx].faceName, lf->lfFaceName ); - di->font_count++; - } - } - return 1; -} - static BOOL select_font( struct dialog_info *di ) { - struct console_config config; int font_idx, size_idx; + WCHAR face_name[LF_FACESIZE], height_buf[4]; + size_t len; + unsigned int font_height; + LOGFONTW lf; HFONT font, old_font; DWORD_PTR args[2]; WCHAR buf[256]; WCHAR fmt[128]; - LOGFONTW lf; font_idx = SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_GETCURSEL, 0, 0 ); size_idx = SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_GETCURSEL, 0, 0 ); - if (font_idx < 0 || size_idx < 0 || size_idx >= di->font_count) + if (font_idx < 0 || size_idx < 0) return FALSE; - fill_logfont( &lf, di->font[size_idx].faceName, - wcslen(di->font[size_idx].faceName) * sizeof(WCHAR), - di->font[size_idx].height, di->font[size_idx].weight ); - font = select_font_config( &config, di->console->output_cp, di->console->win, &lf ); + len = SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_GETTEXT, font_idx, (LPARAM)&face_name ); + SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_GETTEXT, size_idx, (LPARAM)&height_buf ); + font_height = _wtoi( height_buf ); + + fill_logfont( &lf, face_name, len * sizeof(WCHAR), font_height, FW_NORMAL ); + font = select_font_config( &di->config, di->console->output_cp, di->console->win, &lf ); if (!font) return FALSE; - if (config.cell_height != di->font[size_idx].height) - TRACE( "mismatched heights (%u<>%u)\n", config.cell_height, di->font[size_idx].height ); + if (di->config.cell_height != font_height) + TRACE( "mismatched heights (%u<>%u)\n", di->config.cell_height, font_height ); old_font = (HFONT)SendDlgItemMessageW( di->dialog, IDC_FNT_PREVIEW, WM_GETFONT, 0, 0 ); SendDlgItemMessageW( di->dialog, IDC_FNT_PREVIEW, WM_SETFONT, (WPARAM)font, TRUE ); if (old_font) DeleteObject( old_font ); LoadStringW( GetModuleHandleW(NULL), IDS_FNT_DISPLAY, fmt, ARRAY_SIZE(fmt) ); - args[0] = config.cell_width; - args[1] = config.cell_height; + args[0] = di->config.cell_width; + args[1] = di->config.cell_height; FormatMessageW( FORMAT_MESSAGE_FROM_STRING|FORMAT_MESSAGE_ARGUMENT_ARRAY, fmt, 0, 0, buf, ARRAY_SIZE(buf), (__ms_va_list*)args ); @@ -1608,52 +1495,62 @@ static BOOL select_font( struct dialog_info *di ) return TRUE; } -/* fills the size list box according to selected family in font LB */ static BOOL fill_list_size( struct dialog_info *di, BOOL init ) { - WCHAR face_name[LF_FACESIZE]; - int idx = 0; - - idx = SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_GETCURSEL, 0, 0 ); - if (idx < 0) return FALSE; - - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_GETTEXT, idx, (LPARAM)face_name ); - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_RESETCONTENT, 0, 0 ); - free( di->font ); - di->font_count = 0; - di->font = NULL; - - EnumFontFamiliesW( di->console->window->mem_dc, face_name, font_enum_size, (LPARAM)di ); - if (init) { - int ref = -1; - for (idx = 0; idx < di->font_count; idx++) + static const int sizes[] = {8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72}; + unsigned int i, idx = 4; + WCHAR buf[4]; + + for (i = 0; i < ARRAY_SIZE(sizes); i++) { - if (!lstrcmpW( di->font[idx].faceName, di->config.face_name ) && - di->font[idx].height == di->config.cell_height && - di->font[idx].weight == di->config.font_weight) - { - if (ref == -1) ref = idx; - else TRACE("Several matches found: ref=%d idx=%d\n", ref, idx); - } + wsprintfW( buf, L"%u", sizes[i] ); + SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_INSERTSTRING, -1, (LPARAM)buf ); + + if (di->config.cell_height == sizes[i]) idx = i; } - idx = (ref == -1) ? 0 : ref; + + SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_SETCURSEL, idx, 0 ); } - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_SIZE, LB_SETCURSEL, idx, 0 ); select_font( di ); + return TRUE; } +static int CALLBACK enum_list_font_proc( const LOGFONTW *lf, const TEXTMETRICW *tm, + DWORD font_type, LPARAM lparam ) +{ + struct dialog_info *di = (struct dialog_info *)lparam; + + if (font_type != TRUETYPE_FONTTYPE) return 1; + + TRACE( "%s\n", debugstr_logfont( lf, font_type )); + + if (validate_font( di->console, lf, 0 )) + SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_ADDSTRING, 0, (LPARAM)lf->lfFaceName ); + + return 1; +} + static BOOL fill_list_font( struct dialog_info *di ) { - SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_RESETCONTENT, 0, 0 ); - EnumFontFamiliesW( di->console->window->mem_dc, NULL, font_enum, (LPARAM)di ); + LOGFONTW lf; + + memset( &lf, 0, sizeof(lf) ); + lf.lfCharSet = DEFAULT_CHARSET; + lf.lfFaceName[0] = 0; + lf.lfPitchAndFamily = FIXED_PITCH | FF_MODERN; + + EnumFontFamiliesExW( di->console->window->mem_dc, &lf, enum_list_font_proc, (LPARAM)di, 0 ); + if (SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_SELECTSTRING, -1, (LPARAM)di->config.face_name ) == LB_ERR) SendDlgItemMessageW( di->dialog, IDC_FNT_LIST_FONT, LB_SETCURSEL, 0, 0 ); + fill_list_size( di, TRUE ); + return TRUE; } @@ -1668,7 +1565,7 @@ static INT_PTR WINAPI font_dialog_proc( HWND dialog, UINT msg, WPARAM wparam, LP di = (struct dialog_info *)((PROPSHEETPAGEA*)lparam)->lParam; di->dialog = dialog; SetWindowLongPtrW( dialog, DWLP_USER, (DWORD_PTR)di ); - /* remove dialog from this control, font will be reset when listboxes are filled */ + /* use default system font until user-selected font is applied */ SendDlgItemMessageW( dialog, IDC_FNT_PREVIEW, WM_SETFONT, 0, 0 ); fill_list_font( di ); SetWindowLongW( GetDlgItem( dialog, IDC_FNT_COLOR_BK ), 0, (di->config.attr >> 4) & 0x0F ); @@ -1702,18 +1599,6 @@ static INT_PTR WINAPI font_dialog_proc( HWND dialog, UINT msg, WPARAM wparam, LP di->dialog = dialog; break; case PSN_APPLY: - val = SendDlgItemMessageW( dialog, IDC_FNT_LIST_SIZE, LB_GETCURSEL, 0, 0 ); - if (val < di->font_count) - { - LOGFONTW lf; - - fill_logfont( &lf, di->font[val].faceName, - wcslen(di->font[val].faceName) * sizeof(WCHAR), - di->font[val].height, di->font[val].weight ); - DeleteObject( select_font_config( &di->config, di->console->output_cp, - di->console->win, &lf )); - } - val = (GetWindowLongW( GetDlgItem( dialog, IDC_FNT_COLOR_BK ), 0 ) << 4) | GetWindowLongW( GetDlgItem( dialog, IDC_FNT_COLOR_FG ), 0 ); di->config.attr = val; @@ -1978,8 +1863,6 @@ static BOOL config_dialog( struct console *console, BOOL current ) } else current_config( console, &di.config ); prev_config = di.config; - di.font_count = 0; - di.font = NULL; wndclass.style = 0; wndclass.lpfnWndProc = font_preview_proc; -- 2.35.1

2 1

[PATCH 1/7] ws2_32: Manage shorter length for TCP_NODELAY.
by Paul Gofman March 10, 2022

March 10, 2022

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- dlls/ws2_32/socket.c | 18 ++++++++++++------ dlls/ws2_32/tests/sock.c | 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 9f140a6ee44..80665ff57a4 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1725,6 +1725,12 @@ int WINAPI getsockopt( SOCKET s, int level, int optname, char *optval, int *optl switch(optname) { case TCP_NODELAY: + if (*optlen < 1 || !optval) + { + SetLastError( WSAEFAULT ); + return SOCKET_ERROR; + } + *optlen = 1; return server_getsockopt( s, IOCTL_AFD_WINE_GET_TCP_NODELAY, optval, optlen ); default: @@ -2998,14 +3004,14 @@ int WINAPI setsockopt( SOCKET s, int level, int optname, const char *optval, int switch(optname) { case TCP_NODELAY: - { - INT nodelay = *optval; - if (optlen <= 0) { - SetLastError(WSAEFAULT); + if (optlen <= 0 || !optval) + { + SetLastError( optlen && optval ? WSAENOBUFS : WSAEFAULT ); return SOCKET_ERROR; } - return server_setsockopt( s, IOCTL_AFD_WINE_SET_TCP_NODELAY, (char*)&nodelay, sizeof(nodelay) ); - } + value = *optval; + return server_setsockopt( s, IOCTL_AFD_WINE_SET_TCP_NODELAY, (char*)&value, sizeof(value) ); + default: FIXME("Unknown IPPROTO_TCP optname 0x%08x\n", optname); SetLastError(WSAENOPROTOOPT); diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index a0bbde875d3..ec0bb2254a8 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -1181,6 +1181,7 @@ static void test_set_getsockopt(void) {AF_INET, SOCK_STREAM, SOL_SOCKET, SO_SNDBUF, FALSE, {1, 2, 4}, {0xdeadbe00, 0xdead0000}, TRUE}, {AF_INET, SOCK_STREAM, SOL_SOCKET, SO_SNDTIMEO, FALSE, {1, 2, 4}, {0}, TRUE}, {AF_INET, SOCK_STREAM, SOL_SOCKET, SO_OPENTYPE, FALSE, {1, 2, 4}, {0}, TRUE}, + {AF_INET, SOCK_STREAM, IPPROTO_TCP, TCP_NODELAY, TRUE, {1, 1, 1}, {0}, TRUE}, {AF_INET, SOCK_DGRAM, IPPROTO_IP, IP_MULTICAST_LOOP, TRUE, {1, 1, 4}, {0}, TRUE, TRUE}, {AF_INET, SOCK_DGRAM, IPPROTO_IP, IP_MULTICAST_TTL, TRUE, {1, 1, 4}, {0}, FALSE}, {AF_INET, SOCK_DGRAM, IPPROTO_IP, IP_TOS, TRUE, {1, 1, 4}, {0}, FALSE}, -- 2.35.1

3 15

[PATCH] mshtml: implement the IsNoCacheReponse method
by Pat Leamon March 10, 2022

March 10, 2022

From: Pat Leamon <pat.leamon(a)gmail.com> Implements IsNoCacheReponse based on IsNoStoreReponse implementation. Signed-off-by: Pat Leamon <pat.leamon(a)gmail.com> --- dlls/mshtml/nsio.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index fc6602eddf4..33d26670e4c 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -1501,10 +1501,15 @@ static nsresult NSAPI nsChannel_IsNoStoreResponse(nsIHttpChannel *iface, cpp_boo static nsresult NSAPI nsChannel_IsNoCacheResponse(nsIHttpChannel *iface, cpp_bool *_retval) { nsChannel *This = impl_from_nsIHttpChannel(iface); + http_header_t *header; - FIXME("(%p)->(%p)\n", This, _retval); + static const WCHAR cache_controlW[] = {'C','a','c','h','e','-','C','o','n','t','r','o','l'}; - return NS_ERROR_NOT_IMPLEMENTED; + TRACE("(%p)->(%p)\n", This, _retval); + + header = find_http_header(&This->response_headers, cache_controlW, ARRAY_SIZE(cache_controlW)); + *_retval = header && !wcsicmp(header->data, L"no-cache"); + return NS_OK; } static nsresult NSAPI nsChannel_IsPrivateResponse(nsIHttpChannel *iface, cpp_bool *_retval) -- 2.25.1

2 1

[PATCH] mshtml: Implement nsIHttpChannel::IsNoCacheReponse.
by Jacek Caban March 10, 2022

March 10, 2022

From: Pat Leamon <pat.leamon(a)gmail.com> Signed-off-by: Pat Leamon <pleamonhp(a)yahoo.com.au> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- Supersedes 229496, adds a comment about Gecko handling of max-age header. dlls/mshtml/nsio.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)

1 0

[PATCH v4 4/8] server: Defer postprocessing until after setting initial status in send_socket handler.
by Jinoh Kang March 10, 2022

March 10, 2022

This allows the client to postpone the initial I/O until the server has queued the I/O request. The server should perform the postprocessing only after the initial I/O has been done. In the case of send_socket, the manipulation of event flags shall ideally be done *after* (not *before*) the client has attempted the initial I/O, since the outbound queue status of the socket may change in the meanwhile. Also, the implicitly bound address is available only after the send* system call has been performed. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- Notes: v1 -> v2: - pass around total size of data to be transmitted - detect short write in send_socket_initial_callback v2 -> v3: no changes v3 -> v4: no changes dlls/ntdll/unix/socket.c | 15 ++++++++++++++ server/protocol.def | 1 + server/sock.c | 42 +++++++++++++++++++++++++++------------- 3 files changed, 45 insertions(+), 13 deletions(-) diff --git a/dlls/ntdll/unix/socket.c b/dlls/ntdll/unix/socket.c index 23059e3cff8..d04ebb7f874 100644 --- a/dlls/ntdll/unix/socket.c +++ b/dlls/ntdll/unix/socket.c @@ -873,6 +873,7 @@ static NTSTATUS sock_send( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, voi NTSTATUS status; unsigned int i; ULONG options; + data_size_t data_size; async_size = offsetof( struct async_send_ioctl, iov[count] ); @@ -906,6 +907,18 @@ static NTSTATUS sock_send( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, voi async->iov_cursor = 0; async->sent_len = 0; + data_size = 0; + for (i = 0; i < count; ++i) + { + SIZE_T len = async->iov[i].iov_len; + if (len > (SIZE_T)(data_size_t)-1 || (data_size_t)(data_size + len) < data_size) + { + release_fileio( &async->io ); + return STATUS_NO_MEMORY; + } + data_size += len; + } + status = try_send( fd, async ); if (status != STATUS_SUCCESS && status != STATUS_DEVICE_NOT_READY) @@ -919,6 +932,7 @@ static NTSTATUS sock_send( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, voi SERVER_START_REQ( send_socket ) { + req->data_size = data_size; req->status = status; req->total = async->sent_len; req->async = server_async( handle, &async->io, event, apc, apc_user, iosb_client_ptr(io) ); @@ -1099,6 +1113,7 @@ static NTSTATUS sock_transmit( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, SERVER_START_REQ( send_socket ) { + req->data_size = async->head_len + async->file_len + async->tail_len; req->status = STATUS_PENDING; req->total = 0; req->async = server_async( handle, &async->io, event, apc, apc_user, iosb_client_ptr(io) ); diff --git a/server/protocol.def b/server/protocol.def index 9d90544fa41..2e57c91ccad 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -1461,6 +1461,7 @@ enum server_fd_type /* Perform a send on a socket */ @REQ(send_socket) + data_size_t data_size; /* total number of bytes to send (>= total) */ async_data_t async; /* async I/O parameters */ unsigned int status; /* status of initial call */ unsigned int total; /* number of bytes already sent */ diff --git a/server/sock.c b/server/sock.c index 91f98556552..0e386e3537c 100644 --- a/server/sock.c +++ b/server/sock.c @@ -3454,16 +3454,17 @@ DECL_HANDLER(recv_socket) release_object( sock ); } -DECL_HANDLER(send_socket) +static void send_socket_initial_callback( void *private, struct async *async, struct fd *fd, unsigned int status ) { - struct sock *sock = (struct sock *)get_handle_obj( current->process, req->async.handle, 0, &sock_ops ); - unsigned int status = req->status; - timeout_t timeout = 0; - struct async *async; - struct fd *fd; + struct sock *sock = get_fd_user( fd ); + struct iosb *iosb; + int is_short_write = 0; - if (!sock) return; - fd = sock->fd; + if ((iosb = async_get_iosb( async ))) + { + is_short_write = iosb->result < (unsigned long)private; + release_object( iosb ); + } if (sock->type == WS_SOCK_DGRAM) { @@ -3476,13 +3477,29 @@ DECL_HANDLER(send_socket) sock->bound = 1; } - if (status != STATUS_SUCCESS) + if (status != STATUS_SUCCESS || is_short_write) { - /* send() calls only clear and reselect events if unsuccessful. */ + /* send() calls only clear and reselect events if unsuccessful. + * Also treat short writes as being unsuccessful. + */ sock->pending_events &= ~AFD_POLL_WRITE; sock->reported_events &= ~AFD_POLL_WRITE; } + sock_reselect( sock ); +} + +DECL_HANDLER(send_socket) +{ + struct sock *sock = (struct sock *)get_handle_obj( current->process, req->async.handle, 0, &sock_ops ); + unsigned int status = req->status; + timeout_t timeout = 0; + struct async *async; + struct fd *fd; + + if (!sock) return; + fd = sock->fd; + /* If we had a short write and the socket is nonblocking (and the client is * not trying to force the operation to be asynchronous), return success. * Windows actually refuses to send any data in this case, and returns @@ -3518,15 +3535,14 @@ DECL_HANDLER(send_socket) } set_error( status ); + async_set_initial_status_callback( async, send_socket_initial_callback, (void *)(unsigned long)req->data_size ); + if (timeout) async_set_timeout( async, timeout, STATUS_IO_TIMEOUT ); if (status == STATUS_PENDING) queue_async( &sock->write_q, async ); - /* always reselect; we changed reported_events above */ - sock_reselect( sock ); - reply->wait = async_handoff( async, NULL, 0 ); reply->options = get_fd_options( fd ); release_object( async ); -- 2.34.1

2 12

[PATCH 1/4] windows.media.speech: Import DEFINE_INSPECTABLE macros.
by Bernhard Kölbl March 10, 2022

March 10, 2022

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> --- dlls/windows.media.speech/private.h | 42 +++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/dlls/windows.media.speech/private.h b/dlls/windows.media.speech/private.h index b1df726413d..2694b23beab 100644 --- a/dlls/windows.media.speech/private.h +++ b/dlls/windows.media.speech/private.h @@ -46,4 +46,46 @@ extern IActivationFactory *synthesizer_factory; + + +#define DEFINE_IINSPECTABLE_( pfx, iface_type, impl_type, impl_from, iface_mem, expr ) \ + static inline impl_type *impl_from( iface_type *iface ) \ + { \ + return CONTAINING_RECORD( iface, impl_type, iface_mem ); \ + } \ + static HRESULT WINAPI pfx##_QueryInterface( iface_type *iface, REFIID iid, void **out ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_QueryInterface( (IInspectable *)(expr), iid, out ); \ + } \ + static ULONG WINAPI pfx##_AddRef( iface_type *iface ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_AddRef( (IInspectable *)(expr) ); \ + } \ + static ULONG WINAPI pfx##_Release( iface_type *iface ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_Release( (IInspectable *)(expr) ); \ + } \ + static HRESULT WINAPI pfx##_GetIids( iface_type *iface, ULONG *iid_count, IID **iids ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_GetIids( (IInspectable *)(expr), iid_count, iids ); \ + } \ + static HRESULT WINAPI pfx##_GetRuntimeClassName( iface_type *iface, HSTRING *class_name ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_GetRuntimeClassName( (IInspectable *)(expr), class_name ); \ + } \ + static HRESULT WINAPI pfx##_GetTrustLevel( iface_type *iface, TrustLevel *trust_level ) \ + { \ + impl_type *impl = impl_from( iface ); \ + return IInspectable_GetTrustLevel( (IInspectable *)(expr), trust_level ); \ + } +#define DEFINE_IINSPECTABLE( pfx, iface_type, impl_type, base_iface ) \ + DEFINE_IINSPECTABLE_( pfx, iface_type, impl_type, impl_from_##iface_type, iface_type##_iface, &impl->base_iface ) +#define DEFINE_IINSPECTABLE_OUTER( pfx, iface_type, impl_type, outer_iface ) \ + DEFINE_IINSPECTABLE_( pfx, iface_type, impl_type, impl_from_##iface_type, iface_type##_iface, impl->outer_iface ) + #endif -- 2.35.1

3 9

[PATCH 8/8] win32u: Move NtUserUpdateLayeredWindow implementation from user32.
by Jacek Caban March 10, 2022

March 10, 2022

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/driver.c | 15 +------- dlls/user32/win.c | 49 +++---------------------- dlls/win32u/driver.c | 7 ++++ dlls/win32u/gdiobj.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/win32u_private.h | 4 +++ dlls/win32u/window.c | 70 ++++++++++++++++++++++++++++++++++++ dlls/win32u/wrappers.c | 9 +++++ include/ntuser.h | 3 ++ 9 files changed, 100 insertions(+), 60 deletions(-)

2 1

[PATCH 7/8] win32u: Move NtUserSetLayeredWindowAttributes implementation from user32.
by Jacek Caban March 10, 2022

March 10, 2022

2 1