- Wine-Devel - list.winehq.org

Re: [PATCH v3 1/2] ddraw: Don't account video memory for sysmem surfaces' draw textures.
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120070 Your paranoid android. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw7: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

[PATCH v2 0/6] MR370: mciqtz32: Simplify video window management by creating default window.
by Akihiro Sagawa (＠sgwaki) July 28, 2022

July 28, 2022

-- v2: mciqtz32: Update parent window's title instead of the video window's one. mciqtz32: Update parent window's state instead of the video window's one. winmm/tests: Add more window command tests. mciqtz32: Implement MCI_DGV_STATUS_HWND. winmm/tests: Add basic video window tests. mciqtz32: Simplify video window management by creating default window. https://gitlab.winehq.org/wine/wine/-/merge_requests/370

5 12

[PATCH] server: Write terminating '\0' in the strings.
by Dmitry Timoshkov July 28, 2022

July 28, 2022

I have an application that creates its special registry key using NtCreateKey(parent, "Something\0"), and then expects to be able to open this key with NtOpenKey("Something\0") on start up. Currently this fails because terminating '\0' in the key name doesn't survive saving/loading the registry. parse_strW() helper already supports loading such key names. As the tests show after creating a kernel object with name "Something\0" it's possible to only open it as "Something\0", an attempt opening it as "Something" fails with STATUS_OBJECT_NAME_NOT_FOUND, and vice versa. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- server/unicode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/unicode.c b/server/unicode.c index 86a1217b01f..a146677cf21 100644 --- a/server/unicode.c +++ b/server/unicode.c @@ -219,7 +219,6 @@ int dump_strW( const WCHAR *str, data_size_t len, FILE *f, const char escape[2] } if (*str < 32) /* octal or C escape */ { - if (!*str && len == 1) continue; /* do not output terminating NULL */ if (escapes[*str] != '.') pos += sprintf( pos, "\\%c", escapes[*str] ); else if (len > 1 && str[1] >= '0' && str[1] <= '7') -- 2.37.1

1 0

[PATCH 2/2] ntdll/tests: Add a bunch of tests for creating kernel objects with the names containing '\0'.
by Dmitry Timoshkov July 28, 2022

July 28, 2022

As the tests show after creating a kernel object with name "wine_test\0" it's possible to only open it as "wine_test\0", an attempt opening it as "wine_test" fails with STATUS_OBJECT_NAME_NOT_FOUND, and vice versa. Also the tests show that "wine\0test" is a valid kernel object name. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ntdll/tests/om.c | 350 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 349 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index 7fe0fb59f89..f98a8843d62 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -1580,7 +1580,8 @@ static void _test_object_name( unsigned line, HANDLE handle, const WCHAR *expect ok_(__FILE__,line)( status == STATUS_SUCCESS, "NtQueryObject failed %lx\n", status ); ok_(__FILE__,line)( len >= sizeof(OBJECT_NAME_INFORMATION) + str->Length, "unexpected len %lu\n", len ); todo_wine_if (todo) - ok_(__FILE__,line)(compare_unicode_string( str, expected_name ), "wrong name %s\n", debugstr_w( str->Buffer )); + ok_(__FILE__,line)(compare_unicode_string( str, expected_name ), "got %s, expected %s\n", + debugstr_w(str->Buffer), debugstr_w(expected_name)); } static void test_query_object(void) @@ -2722,6 +2723,352 @@ static void test_query_directory(void) pNtClose( dir ); } +#define test_object_name_with_null(a,b) _test_object_name_with_null(__LINE__,a,b) +static void _test_object_name_with_null(unsigned line, HANDLE handle, UNICODE_STRING *expect) +{ + char buffer[1024]; + UNICODE_STRING *str = (UNICODE_STRING *)buffer; + ULONG len = 0; + NTSTATUS status; + + memset(buffer, 0, sizeof(buffer)); + status = pNtQueryObject(handle, ObjectNameInformation, buffer, sizeof(buffer), &len); + ok_(__FILE__,line)(status == STATUS_SUCCESS, "got %08lx\n", status); + ok_(__FILE__,line)(len >= sizeof(OBJECT_NAME_INFORMATION) + str->Length, "got %lu\n", len); + ok_(__FILE__,line)(str->Length == expect->Length, "got %lu, expected %lu\n", str->Length, expect->Length); + ok_(__FILE__,line)(!wcsnicmp(str->Buffer, expect->Buffer, str->Length/sizeof(WCHAR)), "got %s, expected %s\n", + debugstr_w(str->Buffer), debugstr_w(expect->Buffer)); +} + +static void test_null_in_object_name(void) +{ + WCHAR name[256], name3[256], *p, *name_exp, *name3_exp; + HANDLE handle, handle2; + NTSTATUS status; + OBJECT_ATTRIBUTES attr, attr2, attr3; + UNICODE_STRING nameU, name2U, name3U, name2U_exp, name3U_exp; + LARGE_INTEGER size; +#ifndef _WIN64 + BOOL is_wow64 = FALSE; +#endif + + trace("running as %d bit\n", (int)sizeof(void *) * 8); + + swprintf(name, ARRAY_SIZE(name), L"\\Sessions\\%u\\BaseNamedObjects\\wine_test", NtCurrentTeb()->Peb->SessionId); + swprintf(name3, ARRAY_SIZE(name3), L"\\Sessions\\%u\\BaseNamedObjects\\wine_test", NtCurrentTeb()->Peb->SessionId); + p = wcsrchr(name3, '\\'); + p[5] = 0; /* => \\wine\0test */ + + RtlInitUnicodeString(&nameU, name); + InitializeObjectAttributes(&attr, &nameU, 0, 0, NULL); + + name2U = nameU; + name2U.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + InitializeObjectAttributes(&attr2, &name2U, 0, 0, NULL); + + name3U = nameU; + name3U.Buffer = name3; + InitializeObjectAttributes(&attr3, &name3U, 0, 0, NULL); + + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr2, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr3, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + pNtClose(handle); + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + pNtClose(handle); + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + pNtClose(handle); + + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr2, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr3, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr2, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr3, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + size.QuadPart = 4096; + status = pNtCreateSection(&handle, GENERIC_ALL, &attr, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateSection(&handle, GENERIC_ALL, &attr2, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateSection(&handle, GENERIC_ALL, &attr3, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + wcscpy(name, L"\\Registry\\Machine\\Software\\wine_test"); + wcscpy(name3, L"\\Registry\\Machine\\Software\\wine_test"); + p = wcsrchr(name3, '\\'); + p[5] = 0; /* => \\wine\0test */ + + RtlInitUnicodeString(&nameU, name); + name2U = nameU; + name3U = nameU; + name3U.Buffer = name3; +#ifdef _WIN64 + name_exp = name; + name3_exp = name3; + name2U_exp = name2U; +#else + if (IsWow64Process(GetCurrentProcess(), &is_wow64) && is_wow64) + { + name_exp = (WCHAR *)L"\\Registry\\Machine\\Software\\WOW6432Node\\wine_test"; + name3_exp =(WCHAR *) L"\\Registry\\Machine\\Software\\WOW6432Node\\wine\0test"; + } + else + { + name_exp = name; + name3_exp = name3; + } + RtlInitUnicodeString(&name2U_exp, name_exp); +#endif + name3U_exp = name2U_exp; + name3U_exp.Buffer = name3_exp; + name2U.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + name2U_exp.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + + status = pNtCreateKey(&handle, GENERIC_ALL, &attr, 0, NULL, 0, NULL); + ok(!status || status == STATUS_ACCESS_DENIED || broken(status == STATUS_OBJECT_PATH_NOT_FOUND) /* win8 */, "got %08lx\n", status); + if (!status) + { + test_object_name(handle, name_exp, FALSE); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name_exp, FALSE); + pNtClose(handle2); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtDeleteKey(handle); + pNtClose(handle); + status = pNtCreateKey(&handle, GENERIC_ALL, &attr2, 0, NULL, 0, NULL); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U_exp); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U_exp); + pNtClose(handle2); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtDeleteKey(handle); + pNtClose(handle); + status = pNtCreateKey(&handle, GENERIC_ALL, &attr3, 0, NULL, 0, NULL); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U_exp); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U_exp); + pNtClose(handle2); + pNtDeleteKey(handle); + pNtClose(handle); + } + else + skip("Limited access to \\Registry\\Machine\\Software key, skipping the tests\n"); +} + START_TEST(om) { HMODULE hntdll = GetModuleHandleA("ntdll.dll"); @@ -2767,6 +3114,7 @@ START_TEST(om) pNtDuplicateObject = (void *)GetProcAddress(hntdll, "NtDuplicateObject"); pNtCompareObjects = (void *)GetProcAddress(hntdll, "NtCompareObjects"); + test_null_in_object_name(); test_case_sensitive(); test_namespace_pipe(); test_name_collisions(); -- 2.37.1

1 0

[PATCH 1/2] ntdll/tests: Fix compilation with PSDK.
by Dmitry Timoshkov July 28, 2022

July 28, 2022

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ntdll/tests/om.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index ddbdce0281c..7fe0fb59f89 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -2078,7 +2078,7 @@ static void test_token(void) status = pNtOpenThreadToken( GetCurrentThread(), TOKEN_ALL_ACCESS, TRUE, (HANDLE *)0xdeadbee0 ); ok( status == STATUS_ACCESS_VIOLATION, "NtOpenProcessToken failed: %lx\n", status); handle = (HANDLE)0xdeadbeef; - status = NtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); + status = pNtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); ok( status == STATUS_INVALID_HANDLE, "NtOpenProcessToken failed: %lx\n", status); ok( !handle || broken(handle == (HANDLE)0xdeadbeef) /* vista */, "handle set %p\n", handle ); handle = (HANDLE)0xdeadbeef; @@ -2526,7 +2526,7 @@ static void test_query_directory(void) RtlInitUnicodeString( &string, L"\\BaseNamedObjects\\winetest" ); InitializeObjectAttributes( &attr, &string, 0, 0, NULL ); - status = NtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); + status = pNtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); ok( !status, "got %#lx\n", status ); context = 0xdeadbeef; @@ -2717,9 +2717,9 @@ static void test_query_directory(void) ok( !memcmp( &info[1], &empty_info, sizeof(*info) ), "entry was not cleared\n" ); } - NtClose( child1 ); - NtClose( child2 ); - NtClose( dir ); + pNtClose( child1 ); + pNtClose( child2 ); + pNtClose( dir ); } START_TEST(om) -- 2.37.1

1 0

Re: [PATCH v2 2/2] ddraw/tests: Add some video memory accounting tests.
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119983 Your paranoid android. === w7u_2qxl (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w1064 (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x00000040. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x0000ff00. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw1: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

Re: [PATCH v3 5/9] mshtml: Implement lastElementChild for Elements.
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119953 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH v3 4/9] mshtml: Implement hasAttributeNS for Elements.
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119952 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w1064_2qxl (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w1064_adm (64 bit report) === mshtml: script.c:3119: Test failed: ReportResult failed: 80ef0001

1 0

Re: [PATCH v3 3/9] mshtml: Implement removeAttributeNS for Elements.
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119951 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

Re: [PATCH v4 1/1] d3drm/tests: Show Clear sets background color
by Marvin July 28, 2022

July 28, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120010 Your paranoid android. === debian11 (32 bit report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Arabic:Morocco report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit German report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit French report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hebrew:Israel report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hindi:India report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Japanese:Japan report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Chinese:China report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (64 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f.

1 0