- Wine-Devel - list.winehq.org

Re: patch opengl.c, wgl.c
by Vitaliy Margolen March 19, 2006

March 19, 2006

Saturday, March 18, 2006, 11:48:12 AM, Henry Kroll wrote: > Changelog: > Henry Kroll, admin(a)comptune.com corrects X "bad match" errors when > running opengl apps. > Ref: http://bugs.winehq.org/show_bug.cgi?id=4143 > ========================== > --- wine/dlls/x11drv/opengl.c.orig 2006-03-11 11:58:01.000000000 -0900 > +++ wine/dlls/x11drv/opengl.c 2006-03-11 11:58:09.000000000 -0900 > @@ -199,6 +199,12 @@ > dump_PIXELFORMATDESCRIPTOR((const PIXELFORMATDESCRIPTOR *) ppfd); > } + if (ppfd->>dwFlags & PFD_DRAW_TO_BITMAP) { > + ERR("Flag not supported !\n"); > + /* Should SetError here... */ > + return 0; > + } > + > /* Now, build the request to GLX */ [skip] This is not a patch but rather partial reversal of the patch that caused this regression. You should fix this and not revert it back to what it was before. Unless you have a prove that this is the way native works. Vitaliy Margolen

1 0

Re: PATCH: GetDevCaps() bitdepth flag
by pagefault March 19, 2006

March 19, 2006

Thanks for testing it out. I will try to get a copy of these apps and figure out whats going on. On 3/18/06, pagefault <pagefault(a)gmail.com> wrote: > Thanks for testing it out. I will try to get a copy of these apps and > figure out whats going on. > > On 3/17/06, Willie Sippel <willie(a)zeitgeistmedia.net> wrote: > > Am Freitag, 17. März 2006 20:12 schrieb pagefault: > > > Hi there, I work on ZSNES and I was trying to get it working under > > > wine and I ran into a small bug when running under a 32 bit desktop. > > > > > > This fixed a bug in the DeviceGetCaps() function used to return the > > > current bitdepth of the desktop. It is my understanding that X11 > > > returns "24" as the bitdepth while running a 32 bit framebuffer. I > > > have seen in the code where it does change the 24 to 32, but I have > > > discovered a spot where this has been missed. > > > > > > The following is the changes I made, it simply returns 32 if the user > > > has a 24 bit desktop. > > > > > With your patch applied, two applications I tested (Newtek Aura and Bauhaus/ > > TVPaint Mirage) show an odd bug. Only the window background gets drawn, but > > all the widgets are missing, or, more precisely, invisible. Both applications > > use their own toolkit - Mirage is infact Aura's successor, so their drawing > > code should be very similar. But Aura's used to work, while Mirage's always > > produced borked results - painting stuff blue and distorted instead of gray. > > > > -- > > Willie Sippel > > > > //////// | Tritium Studios > > // | ______________________________ > > //// /// | http://www.tritium-studios.com > > > > <willie(a)froq.net> > > > > > > >

2 6

Re: shlwapi: Fix compilaction with GCC 4.1.
by Robert Shearman March 18, 2006

March 18, 2006

Jacek Caban wrote: >Without this patch GCC 4.1 fails with message >string.c:531: undefined reference to `strncmpW' > > That would seem to be a bug in GCC 4.1. I'm no expert on the C spec, but if the compiler can't inline the function, as it can't here when a function pointer is used then I think it should include the static version of the function in the object file. -- Rob Shearman

2 1

PATCH: GetDevCaps() bitdepth flag
by pagefault March 18, 2006

March 18, 2006

Hi there, I work on ZSNES and I was trying to get it working under wine and I ran into a small bug when running under a 32 bit desktop. This fixed a bug in the DeviceGetCaps() function used to return the current bitdepth of the desktop. It is my understanding that X11 returns "24" as the bitdepth while running a 32 bit framebuffer. I have seen in the code where it does change the 24 to 32, but I have discovered a spot where this has been missed. The following is the changes I made, it simply returns 32 if the user has a 24 bit desktop. I could also post code which exposes this bug if needed. *** dlls/x11drv/init.c 2006-03-17 13:05:59.000000000 -0500 --- dlls/x11drv/init.diff 2006-03-17 12:18:05.000000000 -0500 *************** *** 190,196 **** case VERTRES: return screen_height; case BITSPIXEL: ! return screen_depth; case PLANES: return 1; case NUMBRUSHES: --- 190,196 ---- case VERTRES: return screen_height; case BITSPIXEL: ! return (screen_depth == 24) ? 32 : screen_depth; case PLANES: return 1; case NUMBRUSHES: Thanks.

3 3

Re: kernel32: fix last error result on CreateFile
by Mike McCormack March 18, 2006

March 18, 2006

Víctor Manuel Álvarez García wrote: > If CreateFile is called with CREATE_ALWAYS or > OPEN_ALWAYS flags, and the file already exists, the > function should success but the result of GetLastError > after the call must be ERROR_ALREADY_EXISTS. Wine was > not not setting the proper error code and GetLastError > just returned ERROR_SUCCESS. > > Wine is great, good work guys! > > Here goes my contribution, Thanks for the contribution! It would be great to write a test for this behaviour too, and add it to dlls/kernel/tests/file.c Mike

1 0

re: riched20: add EM_EXSETSEL conformance tests and fixes bug 4462 (revised)
by Dan Kegel March 17, 2006

March 17, 2006

Brian wrote: + /* FIXME: EM_GETSEL needs to return proper ending value */ + todo_wine + { + ok(start == 0 && end == 18, "EM_EXSETSEL: expected (0,18) actual:(%d,%d)\n", start,end); + } What does EM_GETSEL return right now? It might be worth looking at that to see if you can fix it in the same patch, if it's easy. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Wine and RDPRINT
by Frederico Bertucci March 17, 2006

March 17, 2006

Good morning guys I did my system works with wine no problem, but when I try print using then, doesnt work... if I print from any other aplication, works. I talked with my developer and he told me that are using a delphi componet called RDPRINT, this in windows, to create better graphics. So, Are there any way to print in wine, using this RDPRINT ?? any dll, any configuration I am using latest wine configured with winetools, the printer is a lx300. I am trying do this works since 2 weeks ago and not sucefull Tks guys -- Frederico Bertucci e-mail / msn: fred(a)netbil.com.br www.netbil.com.br NetBil - Redes e Internet 18-3659-2444 XxX Linux for work Linux for fun XxX ________________________________________________ :: NetBil :: :: A escolha certa em Internet ::

2 1

Re: WINEFILE: Eliminate use of windowsx.h
by Martin Fuchs March 17, 2006

March 17, 2006

Hi, "Eliminating" windowsx.h sounds like you consider this header file a bad thing. I don't think so - it provides a bunch of very usefull type safe macro definitions. (SelectFont, ListBox_SetSel, Button_SetCheck, ...) I understand you want to eliminate some useless warnings printed by newer GCC versions. Wouldn't it be better to correct the wrong warnings of GCC instead? Regards, Martin

1 0

Problem with virtual memory rlimits
by Marcus Meissner March 17, 2006

March 17, 2006

Hi, I am having a problem with virtual ulimits/rlimits. If you limit the virtual memory size using "ulimit -v 1400000" for instance, wine will only crash. The problem is, that VIRTUAL_alloc_teb() tries to allocate a memory area within the acceptable userspace ... but it does so much mmap()s that it runs out of available mmap space before. I was only able to reproduce this on AMD64 machines up to now, which pass out memory starting from 0xf7fffffff somewhere. Any clue how to solve this? Ciao, Marcus

3 4

Re: wglMakeCurrent
by Wino Rojo March 17, 2006

March 17, 2006

Interesting... according to your log file, it seems you are using Mesa instead of any ATI accelerated driver. >From: "Jesse Allen" <the3dfxdude(a)gmail.com> >To: "Wino Rojo" <winorojo(a)hotmail.com> >Subject: Re: wglMakeCurrent >Date: Wed, 15 Mar 2006 11:45:16 -0700 > > > > > > > Jesse, I can't access your log at that page (I got an error). Could you > > please send it to me? > > > > Thanks, > > > > W > >attachment ><< logfile >> _________________________________________________________________ Powerful Parental Controls Let your child discover the best the Internet has to offer. http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht… Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.

2 2