- Wine-Devel - list.winehq.org

Re: server: allow OpenClipboard to succeed when already open
by Eric Frias Feb. 7, 2006

Feb. 7, 2006

James Hawkins wrote: > On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote: > >> I think I submitted a version >> of this patch a year or two back, but it wasn't accepted. > > You should add a unit test for this case in Wine's test suite. It > would be pretty easy to write, and it would verify this information, > making your fix more likely to be accepted. Yeah, I didn't write a test on first go-around and I didn't follow up, so I'm not entirely surprised that the patch didn't get accepted. This is the first time I've tried to write a test, and I was pleased to find out that it was easy to do and the documentation on test-writing and compiling was accurate. Eric

1 0

wined3d: CheckDeviceMultiSampleType
by Vitaly Budovski Feb. 7, 2006

Feb. 7, 2006

Can I have some feedback on the attached patch? I'm not entirely sure it's correct. Thanks, Vitaly diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 7aa8d5d..8394362 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1245,6 +1245,13 @@ HRESULT WINAPI IWineD3DImpl_CheckDeviceM BOOL Windowed, D3DMULTISAMPLE_TYPE MultiSampleType, DWORD* pQualityLevels) { IWineD3DImpl *This = (IWineD3DImpl *)iface; + HDC deviceContext; + Display * pDisplay; + GLXFBConfig * pConfig; + int attributeList[5] = {GLX_SAMPLE_BUFFERS_ARB, 1, GLX_SAMPLES_ARB, MultiSampleType, 0}; + int configCount; + int attributeValue; + TRACE_(d3d_caps)("(%p)-> (STUB) (Adptr:%d, DevType:(%x,%s), SurfFmt:(%x,%s), Win?%d, MultiSamp:%x, pQual:%p)\n", This, Adapter, @@ -1267,7 +1274,32 @@ HRESULT WINAPI IWineD3DImpl_CheckDeviceM *pQualityLevels = 1; /* Guess at a value! */ } - if (D3DMULTISAMPLE_NONE == MultiSampleType) return D3D_OK; + if(D3DMULTISAMPLE_NONE == MultiSampleType) return D3D_OK; + + /* Get the display */ + deviceContext = GetDC(0); + pDisplay = get_display(deviceContext); + + ENTER_GL(); + + pConfig = glXChooseFBConfig(pDisplay, 0, attributeList, &configCount); + if(pConfig) { + if(!glXGetFBConfigAttrib(pDisplay, *pConfig, GLX_SAMPLES, &attributeValue)) { + XFree(pConfig); + + LEAVE_GL(); + ReleaseDC(0, deviceContext); + + return D3D_OK; + } + } else { + FIXME("Error retrieving FBConfig\n"); + } + XFree(pConfig); + + LEAVE_GL(); + ReleaseDC(0, deviceContext); + return D3DERR_NOTAVAILABLE; }

2 1

Re: server: allow OpenClipboard to succeed when already open
by James Hawkins Feb. 7, 2006

Feb. 7, 2006

On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote: > When OpenClipboard is called twice in a row with the same HWND as a > parameter, wine lets the first call succeed, but the second call fails > because the clipboard was already locked. Although it's not specified > in the docs, Windows allows the second call to succeed (and something > deep inside of our app depends on this). I think I submitted a version > of this patch a year or two back, but it wasn't accepted. > You should add a unit test for this case in Wine's test suite. It would be pretty easy to write, and it would verify this information, making your fix more likely to be accepted. -- James Hawkins

3 3

Re: shell32: SHELL32_GetItemAttributes()
by Martin Fuchs Feb. 7, 2006

Feb. 7, 2006

is there anything wrong with this patch to get Photoshop launching again? On 31.01.2006 22:58:34 Martin Fuchs wrote: > Changelog: > - retrieve file attributes using SHGetPathFromIDListW() when they are not already > present in the internal PIDL structures > - correct documentation which incorrectly claimed not to set any attribute bits

1 0

Re: msvcrt: Handle data types B,R,S in C++ symbol demangling
by Eric Pouech Feb. 7, 2006

Feb. 7, 2006

Michael Stefaniuc wrote: > Hello, > > found while trying to demangle some mfc42 symbols. Tested against native > msvcrt with my small demangle.exe tool. actually, it would be good to add them to the test part as well A+ -- Eric Pouech

2 1

Re: Remove %1 from [http|htmlfile]\shell\open\command
by Michael Ost Feb. 7, 2006

Feb. 7, 2006

While you're playing with wine's default registry, could you create a registry entry for https? It can be just the same as the http rule, e.g. HKEY_CLASSES_ROOT/https/shell/open/command = winebrowser %1 (or whatever the http rule ends up being. I have an app that assumes that entry exists and it exists in my windows XP registry, tho I am not sure who created it. Thanks... mo

1 0

Re: Add missing LANG_xxx and SUBLANG_xxx macros
by Huw D M Davies Feb. 7, 2006

Feb. 7, 2006

On Tue, Feb 07, 2006 at 07:08:58PM +0100, Francois Gouget wrote: > Index: include/winnt.h > =================================================================== > RCS file: /home/wine/wine/include/winnt.h,v > retrieving revision 1.227 > diff -u -p -r1.227 winnt.h > --- include/winnt.h 3 Feb 2006 18:04:06 -0000 1.227 > +++ include/winnt.h 7 Feb 2006 16:44:07 -0000 > #define LANG_TELUGU 0x4a > #define LANG_THAI 0x1e > +#define LANG_TIBETAN 0x51 > +#define LANG_WELSH 0x52 > +#define LANG_TIGRIGNA 0x73 > +#define LANG_TSWANA 0x32 > #define LANG_TURKISH 0x1f Why is WELSH in between TIBETAN and TIGRIGNA ? Huw.

1 0

*** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so',
by Rainer Dorsch Feb. 7, 2006

Feb. 7, 2006

Hello, I compiled the last few wine releases. 0.9.6 gives me a compile error: make[2]: Entering directory `/home/rd/SW.nobackup/wine-0.9.6/programs/winetest' make[2]: *** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so', needed by `d3d9_test.exe.so'. Stop. Any hints are welcome. Thanks, Rainer

5 9

RE: select behavior different with wine
by Phil Lodwick Feb. 7, 2006

Feb. 7, 2006

I have attached a patch that fixes this problem for me. Does anybody want to comment on it before I submit it. Is there a better way? Thanks, Phil -----Original Message----- From: wine-devel-bounces(a)winehq.org [mailto:wine-devel-bounces(a)winehq.org] On Behalf Of Phil Lodwick Sent: Wednesday, February 01, 2006 4:14 PM To: wine-devel(a)winehq.org Subject: select behavior different with wine Greetings, I ran across a problem that the following code demonstrates. I believe it is due to the different definition of select on Windows vs Linux. Before I start to think about how to fix this in Wine, I was wondering if anybody has already thought about the problem. #include "stdafx.h" #include <winsock2.h> int _tmain(int argc, _TCHAR* argv[]) { SOCKET fd; WORD wVersionRequested; WSADATA wsaData; wVersionRequested = MAKEWORD( 2, 2 ); WSAStartup(wVersionRequested, &wsaData); fd = socket(AF_INET, SOCK_STREAM, 0); if (fd != INVALID_SOCKET) { fd_set readfds; struct timeval select_timeout ; FD_ZERO(&readfds); FD_SET(fd, &readfds) ; select_timeout.tv_sec=2 ; select_timeout.tv_usec=0 ; if (select((int) fd+1, &readfds, NULL, NULL, &select_timeout) != SOCKET_ERROR) { if(FD_ISSET(fd, &readfds)) printf("THIS IS WINE\n"); else printf("THIS IS WINDOWS\n"); } else printf("got a socket error\n"); closesocket(fd); } return 0; }

1 0

Re: [Fwd: Re: [AppDB] modify installs and runs fields]
by Tony Lambregts Feb. 7, 2006

Feb. 7, 2006

Mike McCormack wrote: > > If you've already got a way of showing what works "out of the box" > that's great! It wasn't obvious to me. > > I had to dig around the appdb pages to figure out where you define what > "gold" is, and there's also no way to search for "gold" apps. > > So what I really want is a way to list all the apps that run out of the > box. How can I do that? > > If we can get people to concentrate on getting applications to "gold" > and then testing them like that, I think it would be a good thing. > The current situation is that we lack a query page in the AppDB. This needs to be rectified. One of the main reasons I have not addressed this because as soon as it is created it will be called inadequate, and no matter the amount of work put into it it will continue to be a source of complaints. (Yes thats cinical but it's from experience based on the complaints about the query page for bugzilla ). So I know it should be done but am personaly not motivated to do it. ;^{ -- Tony Lambregts

1 0