- Wine-Devel - list.winehq.org

Re: Yeah - our RichEDit needs some work
by Dan Kegel Feb. 1, 2006

Feb. 1, 2006

On Dec 25 2003, Subhobroto Sinha wrote: > IMHO, one of the best tests are Steve Gibson's > (http://www.grc.com) freeware tools - this guy writes in pure ASM. > and thus we can be sure that his code will be the least messy (lesser MS stuff..) > However, if you try his 'Wizmo' or 'DCOMObulator', > you will see that the RichEdit textareas as blank ! OK, I finally tried Wizmo :-) Wine's riched20 works a lot better now, but it still has a scrolling bug, so I filed http://bugs.winehq.org/show_bug.cgi?id=4458 - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: wined3d: Fixed render states
by H. Verbeet Feb. 1, 2006

Feb. 1, 2006

On 31/01/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Fixed up render states POINTSCALEENABLE, POINTSPRITENABLE, > EDGEANTIALIAS, MULTISAMPLEANTIALIAS You probably want to split the patch up in smaller pieces. > + if(This->stateBlock->renderState[D3DRS_POINTSCALEENABLE]) { > + att[0] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_A]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + att[1] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_B]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + att[2] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_C]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + } You're not supposed to use D3DRS_ stuff in wined3d, rather use the respective WINED3DRS_ defines, as the original code did. > + if(GL_SUPPORT(ARB_POINT_PARAMETERS)) { Same problem as with your patch for d3d8, wined3d doesn't currently check for ARB_POINT_PARAMETERS support (in IWineD3DImpl_FillGLCaps). > - /* Doesn't work with GL_POINT_SMOOTH on on my ATI 9600, but then ATI drivers are buggered! */ > - glDisable(GL_POINT_SMOOTH); Did you verify that this isn't required anymore? Otherwise that's a potential regression. > + checkGLcall("glEnable(Gl_LINE_SMOOTH)"); > + checkGLcall("glDisable(Gl_LINE_SMOOTH)"); That should probably say Gl_LINE_SMOOTH, but it's not really critical.

4 5

Re: <DEL> key is sending an extra char when NumLock is ON
by penna＠bb.com.br Feb. 1, 2006

Feb. 1, 2006

zhilla wrote: > > I am going to open a bug at bugzilla and send the WINEDEBUG=+key > > (just the piece where the stuff happens). > > dont, its already opened for a while. > http://bugs.winehq.org/show_bug.cgi?id=2400 > there is a working patch there... but some people claim its not very > good since it hardwires the key to code. > somebody should really look into this already... half of solution is > already there :) Sorry ... I did a search and found nothing so I have already opened a bug. Anyway, they already marked it as duplicated. Well, I was taking a look into it but I am going to need some explanations. If someone could provide (or point me out) I will be very thankful. 1) Does X send two separate sequences of keys for some type of keys (<del> for example)? 2) The translation from keycode to virtual key in wine is a little bit difficult to understand (at a first glance). Is there an email or any documentation explaining that (besides the source code ;-))? Otherwise it will take some weeks just to understand how it works 8-( .... 3) The patch proposed at bug #2400 works very well, however it seems to be not in a correct place (at first glance) .... 4) There is a "gap" in the nonchar_key_scan[] array just at the VK_SEPARATOR equivalent position (0xFFAC) on the nonchar_key_vkey[] position (see the question mark below - as in source code): static const WORD nonchar_key_vkey[256]= { ..... 0, 0, 0, 0, 0, 0, 0, 0, /* FFA8 */ VK_SEPARATOR, VK_SUBTRACT, VK_DECIMAL, VK_DIVIDE, ...... }; static const WORD nonchar_key_scan[256]= { ...... 0x00, 0x00, 0x37, 0x4e, /* ? */ 0, 0x4a, 0x53, 0x135, /*FFA8 */ ...... }; The VK_SEPARATOR is the <del> and/or <,> key at the numeric pad. Any relation with the problem? Thanks. --------------------------------------------------------- Ulisses de Sousa Penna Analista Consultor - Banco do Brasil Fone: +55-61-3310-6320 Fax: +55-61-3310-6435 ---------------------------------------------------------

1 0

Re: opengl: Sync a dibsection to its pixmap before drawing to it via opengl
by Alexandre Julliard Feb. 1, 2006

Feb. 1, 2006

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > --- a/dlls/opengl32/wgl.c > +++ b/dlls/opengl32/wgl.c > @@ -54,7 +54,8 @@ enum x11drv_escape_codes > X11DRV_END_EXPOSURES, /* end graphics exposures */ > X11DRV_GET_DCE, /* get the DCE pointer */ > X11DRV_SET_DCE, /* set the DCE pointer */ > - X11DRV_GET_GLX_DRAWABLE /* get current glx drawable for a DC */ > + X11DRV_GET_GLX_DRAWABLE, /* get current glx drawable for a DC */ > + X11DRV_SYNC_PIXMAP /* sync the dibsection to its pixmap */ It seems to me that GET_GLX_DRAWABLE is already doing pretty much the same thing, couldn't you reuse that instead of adding another escape? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Call DDE callback without holding a DDE critical section
by Alexandre Julliard Feb. 1, 2006

Feb. 1, 2006

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + count = WDML_CritSect.RecursionCount; > + for (i = 0; i < count; i++) > + LeaveCriticalSection(&WDML_CritSect); You don't want to do that sort of thing. You should fix the callers to not hold the crit section, instead of silently releasing it behind their backs. -- Alexandre Julliard julliard(a)winehq.org

1 0

wined3d: Fixed render states
by Louis. Lenders Feb. 1, 2006

Feb. 1, 2006

> It would be good if someone with an ATI card could download the > point_sprite_bug sample mentioned on that page and test it out to see if > it is still an issue. I tested it and this is what i get: the app starts up and looks just as the picture on the website If i push the spacebar i get i completely black screen. Pushing again brings up the correct "picture" again I have ATI RADEON 9600 XT Generic, on fedora core 3 with livna drivers. Hope this info is of any use to you... ___________________________________________________________ Win a BlackBerry device from O2 with Yahoo!. Enter now. http://www.yahoo.co.uk/blackberry

1 0

Re: richedit: Show context menu on right click
by Robert Shearman Feb. 1, 2006

Feb. 1, 2006

Kevin Koltzau wrote: >+ case WM_RBUTTONDOWN: >+ SetFocus(hWnd); >+ ME_ShowContextMenu(editor, wParam, (short)LOWORD(lParam), (short)HIWORD(lParam)); >+ break; > > It's better to use WM_CONTEXTMENU instead of WM_RBUTTONDOWN. That way the context menu is also displayed when using the keyboard (Shift-F10). -- Rob Shearman

1 0

New developer
by Segin Feb. 1, 2006

Feb. 1, 2006

Hello! I am new to developing Wine, however, I am not new to using it (I know quite a bit about it already). I want to know what resources would I want to look at, please nothing obvious (bugzilla, MSDN, etc.), and what I can do to contribute. Thanks.

2 1

[RESEND] [dplay] add dx8 lobby header
by Raphael Feb. 1, 2006

Feb. 1, 2006

Hi, Changelog: - new file dplobby8.h Now is only missing DirectPlayNATHelp (dpnathlp.h) Regards, Raphael

1 0

Re: wined3d: Implemented WINED3DRS_EDGEANTIALIAS
by H. Verbeet Feb. 1, 2006

Feb. 1, 2006

> case WINED3DRS_EDGEANTIALIAS : > + { > + if(Value) { > + glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); > + glEnable(GL_BLEND); > + checkGLcall("glEnable(GL_BLEND)"); > + glEnable(GL_LINE_SMOOTH); > + checkGLcall("glEnable(GL_LINE_SMOOTH)"); > + } else { > + glDisable(GL_BLEND); > + checkGLcall("glDisable(GL_BLEND)"); > + glDisable(GL_LINE_SMOOTH); > + checkGLcall("glDisable(GL_LINE_SMOOTH)"); > + } Just thought of this, but eg. WINED3DRS_ALPHABLENDENABLE also disables / enables GL_BLEND.

1 0