- Wine-Devel - list.winehq.org

[rpcrt4] Properly created named pipes
by Thomas Weidenmueller Jan. 16, 2006

Jan. 16, 2006

Created the named pipes with the FILE_FLAG_OVERLAPPED flag, otherwise the call to ConnectNamedPipe() will block the server thread if no connection can be established, which causes the rpc server to dead-lock during startup. - Thomas Index: dlls/rpcrt4/rpc_binding.c =================================================================== RCS file: /home/wine/wine/dlls/rpcrt4/rpc_binding.c,v retrieving revision 1.39 diff -u -r1.39 rpc_binding.c --- dlls/rpcrt4/rpc_binding.c 6 Sep 2005 10:26:14 -0000 1.39 +++ dlls/rpcrt4/rpc_binding.c 16 Jan 2006 23:00:15 -0000 @@ -142,7 +142,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname); @@ -166,7 +166,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname);

1 0

Re: Loader Optimization
by Alexandre Julliard Jan. 16, 2006

Jan. 16, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > ChangeLog: > Optimize for the case where a DLL with no path is requested and it is > already loaded. This change is correct since RtlDosSearchPath_U did not > change the path being looked at - if libname contains no path then > file_part will be the same as libname. Yes, but the current code checks for the full name first and your patch doesn't, so it will change the behavior if we have two modules with the same base name. This will need some test cases. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: translation of wine/programs/wcmd/Ru.rc
by Phil Krylov Jan. 16, 2006

Jan. 16, 2006

On Mon, 16 Jan 2006 18:00:04 +0300 Roman <murzik_007(a)sertolovo.ru> wrote: > I've translaten most of the messages There are some typos: +из другого bat-файла. При по завершении вывываемого командного файла, управление возвращается\n\ should be: +из другого bat-файла. По завершении вызываемого командного файла управление возвращается\n\ And this: +ECHO ON все последующие команды будут выведены на экран\n\ Should be: +ECHO ON включает вывод всех последующих команд на экран\n\ And this: +ECHO OFF отменяет режим ECHO ON (по-умолчанию ECHO is OFF).\n\ Should be: +ECHO OFF отменяет режим ECHO ON (по умолчанию используется режим ECHO OFF).\n\ And this is not translated at all: +The ECHO OFF command can be prevented from displaying by\n\ preceding it with an @ sign.\n" And this: +"Команда FOR дисползуется для выполнения команд для нескольких файлов.\n\ Should be: +"Команда FOR используется для выполнения команд для нескольких файлов.\n\ And this: +Синтаксис: FOR %переменная IN (set) DO команда\n\ Should be: +Синтаксис: FOR %переменная IN (набор) DO команда\n\ And this is partially untranslated: +но не может содержать пробелов (this is different from other operating\n\ +systems). And lots more. Please check your patch for typos and resend. -- Ph.

1 0

winbase.h dependency problems - dll separation issues
by Mike McCormack Jan. 16, 2006

Jan. 16, 2006

winbase.h shouldn't be included when compiling ntdll, as it is the header for kernel32.dll. The attached patch removes winbase.h from the server call headers, exposing a number of dependency problems in ntdll. wine_server_call_err seems to be misplaced in wine/server.h as it uses kernel32.SetLastError(), and it is the only function which requires winebase.h to be included. Perhaps it should be converted to a macro or only defined when winbase.h is already included, as I have done in this patch? Mike

2 1

Mandriva problems
by Krister Hallergard Jan. 16, 2006

Jan. 16, 2006

Have asked this question to several news groups without getting any response. Was suggested that I submit it to you Krister Hallergard Lytham UK Have problems to install quite a few programs with wine - Mandriva 2006 that I can install without problems with other distros (SuSE10.0, Fedora C4 and Kubuntu 5.10) on other partitions on the same machine. My main interest is to install Excel 97 to be able to acces my old wk4-files (I know I can convert them to xls-files to use with Open Office, but I dont want to do that, as I can install Excel on SuSE. Why is Mandriva so difficult?? Made a fresh Madriva installation and as first thing installed wine 0.9.5. When trying to install Excel 97 I get these error messages QUOTE: [krister(a)localhost disk1]$ wine install.exe wine: Unhandled exception (thread 000a), starting debugger... err:seh:EXC_DefaultHandling Unhandled exception code c0000005 flags 0 addr 0x7faa3b93 UNQUOTE Next I applied the suggestions in Frank´s corner to install Excel 97 and get this long debug message: QUOTE: [krister(a)localhost disk1]$ WINEDLLOVERRIDES="odccp32=n" wine INSTALL.EXE wine: Unhandled page fault on read access to 0x7fdd1a0a at address 0x11df:0x0000001a (thread 000a), starting debugger... WineDbg starting on pid 0x8 fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image Z:\mnt\cdrom\DISK1\INSTALL.EXE Unhandled exception: page fault on read access to 0x7fdd1a0a in 16-bit code (11df:001a). In 16 bit mode. Register dump: CS:11df SS:11ef DS:11ef ES:11c7 FS:003b GS:0033 IP:001a SP:5964 BP:0000 FLAGS:0202( - 00 - -RI1) AX:0000 BX:2400 CX:0800 DX:0000 SI:0000 DI:11ee Stack dump: 0x11ef:0x5964: 046c 101f 0000 0000 0000 0000 0000 0000 0x11ef:0x5974: 0000 0000 0000 0000 0000 0000 0000 0000 0x11ef:0x5984: 0000 0000 0000 0000 0000 0000 0000 0000 023d: sel=11ef base=7fde0f20 limit=0000619f 16-bit rw- 0238: sel=11c7 base=7fdc1690 limit=0000010f 16-bit rw- Backtrace: =>1 0x11df:0x001a (0x11df:0x001a) 0x11df:0x001a: xorw %bp,%bp Modules: Module Address Debug info Name (69 modules) ELF 0x7be82000-7bf00000 Deferred ntdll<elf> \-PE 0x7be90000-7bf00000 \ ntdll ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7eef7000-7ef2b000 Deferred uxtheme<elf> \-PE 0x7ef00000-7ef2b000 \ uxtheme ELF 0x7ef2b000-7eff9000 Deferred comctl32<elf> \-PE 0x7ef30000-7eff9000 \ comctl32 ELF 0x7eff9000-7f018000 Deferred iphlpapi<elf> \-PE 0x7f000000-7f018000 \ iphlpapi ELF 0x7f018000-7f060000 Deferred rpcrt4<elf> \-PE 0x7f030000-7f060000 \ rpcrt4 ELF 0x7f060000-7f0f9000 Deferred ole32<elf> \-PE 0x7f080000-7f0f9000 \ ole32 ELF 0x7f0f9000-7f158000 Deferred shlwapi<elf> \-PE 0x7f110000-7f158000 \ shlwapi ELF 0x7f158000-7f22b000 Deferred shell32<elf> \-PE 0x7f170000-7f22b000 \ shell32 ELF 0x7f22b000-7f23f000 Deferred lz32<elf> \-PE 0x7f230000-7f23f000 \ lz32 ELF 0x7f36b000-7f380000 Deferred midimap<elf> \-PE 0x7f370000-7f380000 \ midimap ELF 0x7f492000-7f4b6000 Deferred msacm32<elf> \-PE 0x7f4a0000-7f4b6000 \ msacm32 ELF 0x7f4b6000-7f4cf000 Deferred msacm<elf> \-PE 0x7f4c0000-7f4cf000 \ msacm ELF 0x7f4cf000-7f517000 Deferred wineoss<elf> \-PE 0x7f4e0000-7f517000 \ wineoss ELF 0x7f517000-7f59e000 Deferred winmm<elf> \-PE 0x7f520000-7f59e000 \ winmm ELF 0x7f59e000-7f601000 Deferred winedos<elf> \-PE 0x7f5b0000-7f601000 \ winedos ELF 0x7f601000-7f60a000 Deferred libxcursor.so.1 ELF 0x7f60a000-7f627000 Deferred imm32<elf> \-PE 0x7f610000-7f627000 \ imm32 ELF 0x7f627000-7f644000 Deferred ximcp.so.2 ELF 0x7f644000-7f6ae000 Deferred libgl.so.1 ELF 0x7f6ae000-7f77a000 Deferred libx11.so.6 ELF 0x7f77a000-7f792000 Deferred libice.so.6 ELF 0x7f792000-7f81c000 Deferred winex11<elf> \-PE 0x7f7a0000-7f81c000 \ winex11 ELF 0x7f81c000-7f83c000 Deferred libexpat.so.0 ELF 0x7f83c000-7f86c000 Deferred libfontconfig.so.1 ELF 0x7f86c000-7f87f000 Deferred libz.so.1 ELF 0x7f87f000-7f8e8000 Deferred libfreetype.so.6 ELF 0x7f8fd000-7f93f000 Deferred advapi32<elf> \-PE 0x7f910000-7f93f000 \ advapi32 ELF 0x7f93f000-7f9d4000 Deferred gdi32<elf> \-PE 0x7f950000-7f9d4000 \ gdi32 ELF 0x7f9d4000-7fb10000 Deferred user32<elf> \-PE 0x7f9f0000-7fb10000 \ user32 ELF 0x7fc27000-7fc2a000 Deferred iso8859-1.so ELF 0x7fc61000-7fd70000 Deferred kernel32<elf> \-PE 0x7fc80000-7fd70000 \ kernel32 ELF 0x7fe83000-7fe87000 Deferred libxrandr.so ELF 0x7fe87000-7fe90000 Deferred libxrender.so.1 ELF 0x7fe90000-7fe9b000 Deferred libnss_files.so.2 ELF 0x7fe9b000-7feb0000 Deferred winevdm<elf> \-PE 0x7fea0000-7feb0000 \ install ELF 0x7feb0000-7fed5000 Deferred libm.so.6 ELF 0x7fed5000-7ffcb000 Deferred libwine_unicode.so.1 ELF 0x7ffcb000-7ffce000 Deferred xlcdef.so.2 ELF 0x7ffce000-7ffdc000 Deferred libxext.so.6 ELF 0xb7e42000-b7e4b000 Deferred libsm.so.6 ELF 0xb7e4c000-b7e50000 Deferred libdl.so.2 ELF 0xb7e50000-b7f7e000 Deferred libc.so.6 ELF 0xb7f7e000-b7f90000 Deferred libpthread.so.0 ELF 0xb7f91000-b7fab000 Deferred libwine.so.1 ELF 0xb7fab000-b7fb0000 Deferred libxxf86vm.so.1 ELF 0xb7fc1000-b7fd8000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\mnt\cdrom\DISK1\INSTALL.EXE 0000000a 0 <== 00000009 0 WineDbg terminated on pid 0x8 UNQUOTE Can anyone help me!?

1 0

Re: [MSACM] add file name trace to acmDriverAdd
by Alex Villacís Lasso Jan. 16, 2006

Jan. 16, 2006

Robert Reif wrote: > This patch justs adds some debugging information. > > Loading a native acm driver using acmDriverAdd seems to be broken. > Passing the driver name to MSACM_RegisterDriver gets further along > but doesn't fix the problem. > >------------------------------------------------------------------------ > > > > I am currently in the process of posting a working acmDriverAdd[AW] implementation (without any winmm hacks). Is this patch related to the SJphone report earlier? I am currently downloading said software to test it. Alex Villacís Lasso

1 0

Re: MSACM: implement acmDriverPriority with driver priority/enabled saving
by Alex Villacís Lasso Jan. 16, 2006

Jan. 16, 2006

Alex Villacís Lasso wrote: > This patch implements acmDriverPriority(), including saving the > priority order and the enabled/disabled status of each global driver > to HKCU\\Software\\Microsoft\\Multimedia\\Audio Compression > Manager\\Priority v4.00 . Also included the foundation for broadcast > notifications on driver priority reorder, including a counter instead > of a BOOL flag for deferred notifications (as requested by Eric Pouech). > > Changelog: > * Implementation of acmDriverPriority() with registry saving > * Foundation for notification broadcasts with support for deferred > notification. > > Alex Villacís Lasso > Any comments on this patch? Alex Villacís Lasso

1 0

Re: MSACM: local drivers must not contribute to ACM_METRIC_COUNT_DRIVERS count
by Alex Villacís Lasso Jan. 16, 2006

Jan. 16, 2006

Alex Villacís Lasso wrote: > This distinction makes a difference when local drivers can be loaded. > > Changelog: > * Exclude local drivers from count when > acmMetrics(ACM_METRIC_COUNT_DRIVERS) is computed Please disregard this patch, the original behavior was correct. Alex Villacís Lasso

1 0

Re: MSACM: return failure rather than assert with nAvgBytesPerSec == 0
by Alex Villacís Lasso Jan. 16, 2006

Jan. 16, 2006

Alex Villacís Lasso wrote: > This check is necessary until local codec loading is in CVS. Failure > scenario fixed is: app instructs to load local ACM codec, fails, > doesn't notice failure, requests codec info, fails, again doesn't > notice failure, submits zeroed structure to PCM converter --> > assertion failed. > > Changelog: > * Check for nAvgBytesPerSec == 0 in PCM converter instead of allowing > assertion to fail. > > Alex Villacís Lasso > >------------------------------------------------------------------------ > >--- wine-0.9.5-cvs/dlls/msacm/pcmconverter.c 2005-11-28 15:57:25.000000000 -0500 >+++ wine-0.9.5-cvs-patch/dlls/msacm/pcmconverter.c 2006-01-09 21:17:07.000000000 -0500 >@@ -945,12 +945,20 @@ > switch (adss->fdwSize) { > case ACM_STREAMSIZEF_DESTINATION: > /* cbDstLength => cbSrcLength */ >+ if (!adsi->pwfxDst->nAvgBytesPerSec) { >+ ERR("adsi->pwfxDst->nAvgBytesPerSec == %lu\n", adsi->pwfxDst->nAvgBytesPerSec); >+ return MMSYSERR_INVALPARAM; >+ } > adss->cbSrcLength = PCM_round(adss->cbDstLength & dstMask, > adsi->pwfxSrc->nAvgBytesPerSec, > adsi->pwfxDst->nAvgBytesPerSec) & srcMask; > break; > case ACM_STREAMSIZEF_SOURCE: > /* cbSrcLength => cbDstLength */ >+ if (!adsi->pwfxSrc->nAvgBytesPerSec) { >+ ERR("adsi->pwfxSrc->nAvgBytesPerSec == %lu\n", adsi->pwfxSrc->nAvgBytesPerSec); >+ return MMSYSERR_INVALPARAM; >+ } > adss->cbDstLength = PCM_round(adss->cbSrcLength & srcMask, > adsi->pwfxDst->nAvgBytesPerSec, > adsi->pwfxSrc->nAvgBytesPerSec) & dstMask; > > >------------------------------------------------------------------------ > > > > Any comment on this patch? Alex Villacís Lasso

1 0

compilation error: Undefined reference to strncmpW
by Peter Lemenkov Jan. 16, 2006

Jan. 16, 2006

Hello, All! ============================= ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./shlwapi.spec assoc.o clist.o istream.o msgbox.o ordinal.o path.o reg.o regstream.o shlwapi_main.o stopwatch.o string.o thread.o url.o wsprintf.o shlwapi.res -o shlwapi.dll.so -L../../dlls -L../../dlls/oleaut32 -L../../dlls/ole32 -L../../dlls/user32 -L../../dlls/gdi32 -L../../dlls/advapi32 -L../../dlls/kernel32 -L../../dlls/ntdll -loleaut32 -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -Wb,-doleaut32 -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port string.o: In function `StrStrW':/home/petro/work/projects/wine/dlls/shlwapi/string.c:531: undefined reference to `strncmpW' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [shlwapi.dll.so] Error 2 make[2]: Leaving directory `/home/petro/work/projects/wine/dlls/shlwapi' make[1]: *** [shlwapi] Error 2 make[1]: Leaving directory `/home/petro/work/projects/wine/dlls' make: *** [dlls] Error 2 [petro(a)Petro wine]$ ============================ -- With best regards, Peter Lemenkov.

2 1