- Wine-Devel - list.winehq.org

Need help to fix a failing test
by Kai Blin Jan. 10, 2006

Jan. 10, 2006

Hi folks, As far as I can see, secur32 tests are failing on all windows platforms right now. (http://test.winehq.org/data/200601101000/) Now, this seems to be due to the following: main.c:475: Test failed: cbMaxToken for NTLM is 1904, not 12000. I'm pretty sure that I got the 12000 from my win2k system when I compiled the test code there using the platform sdk that was current this july. Now, I have no clue where the 1904 comes from, but if windows really uses a cbMaxToken of 1904, I need to fix that in my code (I couldn't use the 12000 I thought I had to implement before due to implementation restrictions. I can easily work with 1904, if those are correct.) Still, I'm sure I didn't pull the 12000 out of my sleeve. Could I ask someone who runs msvc and a platform sdk to build the secur32 tests, run them on any windows box and send the results to me? Thanks in advance, Kai -- Kai Blin, (blin at gmx dot net) Are you mentally here at Pizza Hut??

1 0

Re: RESEND: winecfg: Added "Use PRIMARY selection" option
by Alexandre Julliard Jan. 10, 2006

Jan. 10, 2006

Phil Krylov <phil(a)newstar.rinet.ru> writes: > ChangeLog: > > Added support for "Use PRIMARY selection" clipboard option. I don't think we want a new property sheet page for that, it should go with the other X11 options. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: WineDbg: Implemented harware assisted breakpoints.
by Eric Pouech Jan. 10, 2006

Jan. 10, 2006

Eric Pouech wrote: > one can now set a hardware breakpoint in winedbg (it will not insert an > INT 3 command in the code, but rather use the x86 debug registers). > handy for debugging trashed code for example > > all the syntaxic forms of the 'break' command can be used for this new > hbreak command. > (only works on x86 for now) > > ChangeLog: > Implemented harware assisted breakpoints > merci de ne pas appliquer tel quel. J'ai une nouvelle version moins buggée. A+ -- Eric Pouech

1 0

RFC: implementation of driver functionality in msacm (RESEND)
by Alex Villacís Lasso Jan. 10, 2006

Jan. 10, 2006

(resent because previous attempt never appeared in wine-devel) This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several because I would like comments on some choices I made while adding features. The following is the list of features added by the patch: * Implementation of acmDriverAddW(), and delegation of acmDriverAddA() to acmDriverAddW() * Working implementation of modes of operation of acmDriverAdd[AW]: add driver by new registry entry (ACM_DRIVERADDF_NAME), add (local) driver by combination of hModule/acmDriverProc (ACM_DRIVERADDF_FUNCTION), add notification window for event broadcasts (ACM_DRIVERADDF_NOTIFYHWND) * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes * Fix for implementation quirks of acmDriverMessage() in order to allow native codecs to display configuration dialogs * Working implementation of acmDriverPriority(), with support of delayed notification broadcasts (for one process only). Includes saving new priorities and enabled status to registry * Loading of codec priorities and enabled status from registry * Support for ACM_METRIC_DRIVER_SUPPORT in acmMetrics() I must note that in order to provide support for acmDriverAddW() in ACM_DRIVERADDF_FUNCTION mode, it is necessary to treat an application-supplied module with an application-supplied driverProc as a full-blown winmm driver. Therefore, the patch includes a new procedure in winmm called wineAddDriver(), that instructs winmm to build a hDrvr from a supplied hModule/driverProc pair, rather than loading both from a DLL, as OpenDriver() does. This allows the rest of the code to continue using SendDriverMessage() as usual. Alex Villacís Lasso

2 2

Starter projects for new Wine contributors?
by Dan Kegel Jan. 10, 2006

Jan. 10, 2006

Hi all! I'm looking for suggestions for starter projects for new contributors that would take something like a week to do, and wouldn't require much knowledge of Wine ahead of time. http://wiki.winehq.org/TodoList is the place we've gathered that stuff, but nothing there really grabs me. I suppose the tasks http://wiki.winehq.org/CrossCallsWtoA http://wiki.winehq.org/ConstifyData http://wiki.winehq.org/SpecDiscrepencies might qualify. Do they still need doing? http://winehq.org/site/fun_projects has some cool stuff on it, particularly the idea of using Mono's libgdiplus to implement gdi+ in Wine. (That's probably more than a week's worth of work, though.) http://wiki.winehq.org/SummerOfCode has very cool stuff in it, but that's all about 100x times harder than what I'm looking for. And then there's riched20. It's missing quite a few little features; see the 11 open bugs here: http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-richedit&bug… Might some of those be doable in a couple days? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 4

static COM VTables?
by Stefan Dösinger Jan. 10, 2006

Jan. 10, 2006

Hello, I just read the "constify data" todo, and I thought it would be good to make the VTables in my ddraw implementation const. The old ddraw implementation also declares them static. Is there any advantage in it? My C book just says that they can only be referenced from the local module, which is correct. But are there any other effects? Stefan

2 1

RFC: implementation of driver functionality in msacm
by Alex Villacís Lasso Jan. 10, 2006

Jan. 10, 2006

This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several because I would like comments on some choices I made while adding features. The following is the list of features added by the patch: * Implementation of acmDriverAddW(), and delegation of acmDriverAddA() to acmDriverAddW() * Working implementation of modes of operation of acmDriverAdd[AW]: add driver by new registry entry (ACM_DRIVERADDF_NAME), add (local) driver by combination of hModule/acmDriverProc (ACM_DRIVERADDF_FUNCTION), add notification window for event broadcasts (ACM_DRIVERADDF_NOTIFYHWND) * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes * Fix for implementation quirks of acmDriverMessage() in order to allow native codecs to display configuration dialogs * Working implementation of acmDriverPriority(), with support of delayed notification broadcasts (for one process only). Includes saving new priorities and enabled status to registry * Loading of codec priorities and enabled status from registry * Support for ACM_METRIC_DRIVER_SUPPORT in acmMetrics() I must note that in order to provide support for acmDriverAddW() in ACM_DRIVERADDF_FUNCTION mode, it is necessary to treat an application-supplied module with an application-supplied driverProc as a full-blown winmm driver. Therefore, the patch includes a new procedure in winmm called wineAddDriver(), that instructs winmm to build a hDrvr from a supplied hModule/driverProc pair, rather than loading both from a DLL, as OpenDriver() does. This allows the rest of the code to continue using SendDriverMessage() as usual. Alex Villacís Lasso

1 0

test exploit for WMF / SETABORTPROC vulnerability
by Marcus Meissner Jan. 10, 2006

Jan. 10, 2006

Hi, If someone needs an exploit for the WMF / SETABORTPROC vulnerability that works under WINE (<0.9.5) to verify fixed packages, feel free to mail me offline. Ciao, Marcus

1 0

Re: COMCTL32: Invalidate the entire progress bar any time it changes.
by Dmitry Timoshkov Jan. 10, 2006

Jan. 10, 2006

"Mike McCormack" <mike(a)codeweavers.com> wrote: > This is an old patch, but the code that is in comctl32 now is wrong. > This fixes it, and there's no known regressions. Unfortunately there's > no way to fix this "efficiently". > > Mike > > > ChangeLog: > Invalidate the entire progress bar any time it changes. > Fixes the progress bar so it paints properly in InstallShield. My (old) tests show that native comctl32 invalidates the entire progress bar once it changes, so that change is OK. But it's smart enough to not invalidate the background if new bar position is larger than an old one, that reduces the flicker. -- Dmitry.

1 0

Loader Optimization Benchmarks
by Robert Shearman Jan. 10, 2006

Jan. 10, 2006

Hi, I thought it would be good to post some benchmarks for the patch I just sent to wine-patches: http://www.winehq.org/pipermail/wine-patches/2006-January/023323.html I tested the loader code using the following in both cases: int i; DWORD dwTicksAfter; DWORD dwTicksBefore = GetTickCount(); for (i = 0; i < 1000; i++) LoadLibrary("ole32"); dwTicksAfter = GetTickCount(); trace("time taken = %ld ms\n", dwTicksAfter - dwTicksBefore); Before the patch: time taken = 658 ms time taken = 661 ms time taken = 661 ms time taken = 658 ms time taken = 659 ms After the patch was applied: time taken = 12 ms time taken = 12 ms time taken = 12 ms time taken = 13 ms time taken = 12 ms So it should be obvious that there are some very real gains from using this patch in the test case. You might think that an application loading a DLL 1000 times is very unlikely, but bear in mind that the ole32 marshal tests load ole32 76 times. It is therefore conceivable that something more complex like InstallShield could load ole32 over 100 times. -- Rob Shearman

1 0