- Wine-Devel - list.winehq.org

Re: winspool: Add Documentation for the Port-Functions
by James Hawkins Dec. 5, 2005

Dec. 5, 2005

On 12/5/05, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > /****************************************************************** > * DeletePortA [WINSPOOL.@] > * > + * Delete a specific Port (ANSI) > + * > + * See DeletePortW. > + * ... > /****************************************************************** > * DeletePortW [WINSPOOL.@] > * > + * Delete a specific Port (UNICODE) > + * The (ANSI) and (UNICODE) are superfluous. For the ansi version, all you need is the 'See DeletePortW' instead of reusing 'Delete a specific port' as well. -- James Hawkins

1 0

Re: ddraw: make some driver info not const
by Vitaliy Margolen Dec. 5, 2005

Dec. 5, 2005

Friday, December 2, 2005, 11:46:39 AM, Rein Klazes wrote: > Hi, [skip] > Making this information not const makes the application proceed further. > Changelog: > dlls/ddraw : ddraw_hal.c, ddraw_user.c > Make some driver info not const, some applications want to modify it. This is wrong. No user program should modify our internal data. I think you need to copy this data into heap before passing it to the app. You should make simple test to check if the data returned on windows is within heap or not. Vitaliy

4 4

dsound buffer underrun
by Tomas Carnecky Dec. 5, 2005

Dec. 5, 2005

I'm still having problems with the sound, something in the dsound mixer is wrong. I've created a trace (+dsound): first comes this, that shows that sdound detected a possible underrun and sets probably_valid_to to -1. trace:dsound:DSOUND_MixOne (0x55952b88,54684,54684,49392) trace:dsound:DSOUND_MixOne buf_writepos=8192, primary_writepos=54684 trace:dsound:DSOUND_MixOne buf_done=0, primary_done=0 trace:dsound:DSOUND_MixOne buf_mixpos=8192, primary_mixpos=54684, mixlen=49392 trace:dsound:DSOUND_MixOne looping=1, startpos=0, leadin=0 trace:dsound:DSOUND_MixOne streaming buffer probably_valid_to=8192, probably_valid_left=0 warn:dsound:DSOUND_MixOne probably_valid_to now within writelead, possible streaming underrun trace:dsound:DSOUND_MixOne remaining mixlen=49392 next time wine enters DSOUND_MixOne() this occurs: trace:dsound:DSOUND_MixOne (0x55952b88,54684,63504,49392) trace:dsound:DSOUND_MixOne buf_writepos=17012, primary_writepos=63504 trace:dsound:DSOUND_MixOne buf_done=7804, primary_done=40572 trace:dsound:DSOUND_MixOne buf_mixpos=24816, primary_mixpos=19404, mixlen=49392 trace:dsound:DSOUND_MixOne looping=1, startpos=0, leadin=0 trace:dsound:DSOUND_MixOne streaming buffer probably_valid_to=-1, probably_valid_left=32768 trace:dsound:DSOUND_MixOne clipping to probably_valid_left=32768 fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=32768 < primary_done=40572) now wine clips mixlen to probably_valid_left which is smaller than primary_done. I don't know what primary_done, mixlen, probably_valid_left and probably_valid_to mean, but somthing with those variables is wrong. the full log is in the attachment tom

1 0

Re: Allow out-of-tree builds against configured source tree
by Alexandre Julliard Dec. 5, 2005

Dec. 5, 2005

Pavel Roskin <proski(a)gnu.org> writes: > * Make.rules.in: Change include path to prefer include files in > the output tree over those in the source tree. This allows > compiling Wine outside the source tree even if Wine was already > compiled in the source tree, possibly with different options. You really don't want to do that, that's a recipe for trouble. Make will check the source dir for dependencies so if you have objects in there it won't rebuild things properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [MSI] DllCanUnloadNow try2
by Dmitry Timoshkov Dec. 5, 2005

Dec. 5, 2005

"Christian Gmeiner" <christian.gmeiner(a)students.fh-vorarlberg.ac.at> wrote: > +/********************************************************************** > + * Dll lifetime tracking declaration > + */ > +void LockModule(void) > +{ > + InterlockedIncrement(&dll_count); > +} > + > +void UnlockModule(void) > +{ > + InterlockedDecrement(&dll_count); > +} Since these 2 are used from inside single source file they can (and should) be made static. -- Dmitry.

2 1

Missing includes in dlls/wininet/netconnection.c
by Pavel Roskin Dec. 5, 2005

Dec. 5, 2005

Hello, Robert! I'm sorry, but you keep breaking Wine for me. The latest change in dlls/wininet/netconnection.c (revision 1.18) doesn't compile. Two files need to be included - errno.h for error names and stdio.h for perror(). Actually, I think perror() should be avoided - Wine has its own error reporting mechanisms. But to be fair, there are instances of perror() in the current Wine code. -- Regards, Pavel Roskin

1 0

A better workaround for compiling on FC4/x86_64
by Pavel Roskin Dec. 5, 2005

Dec. 5, 2005

Hello! When trying to set up printing from Wine on Fedora Core 4 for x86_64, I have discovered that Wine fails to find many libraries, including libcups. It turns out that the development packages on Fedora Core 4 don't always provide *.so symlinks for 32-bit libraries. So I wrote this script. The script creates all missing links in one directory (/usr/local/lib is the default). Not only was libcups found next time, but also the old workaround with imake has become unneeded. The configure script runs out-of-box and finds X11 libraries. I'm posting the script here in hope that it will be useful for some Wine users. I'm not sure it it merits inclusion in Wine, but I would not object. -- Regards, Pavel Roskin

2 2

[RESEND] riched20: register ListBox & ComboBox classes
by Cihan Altinay Dec. 5, 2005

Dec. 5, 2005

Another attempt to get some feedback for this patch... Hi, > This patch partially implements the undocumented REExtendedRegisterClass() > function by registering the two missing classes. That way MS Office 2003 and > probably other programs that rely on these classes display dialogs > completely which were empty before. > > Changelog: > Cihan Altinay <cihan(a)uq.edu.au> > Partially implement REExtendedRegisterClass() to register missing window > classes so that applications relying on them don't get confused. > It seems this patch was ignored and I would appreciate some comments because I haven't done much wine development yet (and probably made a lot of mistakes). Basically, I did some reverse engineering to see what is going on under Windows and implemented the (de)registration of the two classes accordingly. The effect of the patch can be seen in the attached screenshots which is the Options dialog of MS PowerPoint 2003. I agree that a patch that makes the controls actually work would be better :-) Cheers, Cihan

2 2

make errors in $WINE/dlls/wininet/netconnection.c
by Colin Wright Dec. 4, 2005

Dec. 4, 2005

After a clean and cvs -PAd I get the following errors during make netconnection.c: In function `sock_get_error': netconnection.c:205: error: `EINTR' undeclared (first use in this function) netconnection.c:205: error: (Each undeclared identifier is reported only once netconnection.c:205: error: for each function it appears in.) netconnection.c:206: error: `EBADF' undeclared (first use in this function) netconnection.c:207: error: `EPERM' undeclared (first use in this function) netconnection.c:208: error: `EACCES' undeclared (first use in this function) netconnection.c:209: error: `EFAULT' undeclared (first use in this function) netconnection.c:210: error: `EINVAL' undeclared (first use in this function) netconnection.c:211: error: `EMFILE' undeclared (first use in this function) netconnection.c:212: error: `EWOULDBLOCK' undeclared (first use in this function) netconnection.c:213: error: `EINPROGRESS' undeclared (first use in this function) netconnection.c:214: error: `EALREADY' undeclared (first use in this function) netconnection.c:215: error: `ENOTSOCK' undeclared (first use in this function) netconnection.c:216: error: `EDESTADDRREQ' undeclared (first use in this function) netconnection.c:217: error: `EMSGSIZE' undeclared (first use in this function) netconnection.c:218: error: `EPROTOTYPE' undeclared (first use in this function) netconnection.c:219: error: `ENOPROTOOPT' undeclared (first use in this function) netconnection.c:220: error: `EPROTONOSUPPORT' undeclared (first use in this function) netconnection.c:221: error: `ESOCKTNOSUPPORT' undeclared (first use in this function) netconnection.c:222: error: `EOPNOTSUPP' undeclared (first use in this function) netconnection.c:223: error: `EPFNOSUPPORT' undeclared (first use in this function) netconnection.c:224: error: `EAFNOSUPPORT' undeclared (first use in this function) netconnection.c:225: error: `EADDRINUSE' undeclared (first use in this function) netconnection.c:226: error: `EADDRNOTAVAIL' undeclared (first use in this function) netconnection.c:227: error: `ENETDOWN' undeclared (first use in this function) netconnection.c:228: error: `ENETUNREACH' undeclared (first use in this function) netconnection.c:229: error: `ENETRESET' undeclared (first use in this function) netconnection.c:230: error: `ECONNABORTED' undeclared (first use in this function) netconnection.c:231: error: `EPIPE' undeclared (first use in this function) netconnection.c:232: error: `ECONNRESET' undeclared (first use in this function) netconnection.c:233: error: `ENOBUFS' undeclared (first use in this function) netconnection.c:234: error: `EISCONN' undeclared (first use in this function) netconnection.c:235: error: `ENOTCONN' undeclared (first use in this function) netconnection.c:236: error: `ESHUTDOWN' undeclared (first use in this function) netconnection.c:237: error: `ETOOMANYREFS' undeclared (first use in this function) netconnection.c:238: error: `ETIMEDOUT' undeclared (first use in this function) netconnection.c:239: error: `ECONNREFUSED' undeclared (first use in this function) netconnection.c:240: error: `ELOOP' undeclared (first use in this function) netconnection.c:241: error: `ENAMETOOLONG' undeclared (first use in this function) netconnection.c:242: error: `EHOSTDOWN' undeclared (first use in this function) netconnection.c:243: error: `EHOSTUNREACH' undeclared (first use in this function) netconnection.c:244: error: `ENOTEMPTY' undeclared (first use in this function) netconnection.c:260: error: `errno' undeclared (first use in this function) netconnection.c:260: warning: implicit declaration of function `perror' netconnection.c: In function `NETCON_create': netconnection.c:279: error: `errno' undeclared (first use in this function) netconnection.c: In function `NETCON_close': netconnection.c:315: error: `errno' undeclared (first use in this function) netconnection.c: At top level: netconnection.c:321: error: syntax error before '*' token netconnection.c: In function `NETCON_connect': netconnection.c:436: error: `errno' undeclared (first use in this function) netconnection.c: In function `NETCON_send': netconnection.c:461: error: `errno' undeclared (first use in this function) netconnection.c: In function `NETCON_recv': netconnection.c:495: error: `errno' undeclared (first use in this function) netconnection.c: In function `NETCON_getNextLine': netconnection.c:585: error: `errno' undeclared (first use in this function) netconnection.c: At top level: netconnection.c:322: warning: `check_hostname' defined but not used Although I've probably wasting my time and there's simply a missing header file or netconnection.c shouldn't even be there I've found that the constants EINTR, EBADF, EPERM, EACCES, EFAULT, EINVAL, EMFILE, EPIPE, ENAMETOOLONG and ENOTEMPTY are all defined in $WINE/include/msvcrt/errno.h and the rest only have WSA\1 constants in $WINE/include/winsock.h. -- Colin Wright cdonline(a)tesco.net

2 2

Re: CVSROOT/. loginfo
by Ron Jensen Dec. 4, 2005

Dec. 4, 2005

Alexandre, Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch. Thankyou, Ron Jensen On Fri, 2005-12-02 at 09:43 -0600, Alexandre Julliard wrote: > ChangeSet ID: 21634 > CVSROOT: /opt/cvs-commit > Module name: CVSROOT > Changes by: julliard(a)winehq.org 2005/12/02 09:43:52 > > Modified files: > . : loginfo > > Log message: > Don't send mail to wine-cvs for the wine module, this will be done > from the git repository. > > Patch: http://cvs.winehq.org/patch.py?id=21634 > > Old revision New revision Changes Path > 1.50 1.51 +2 -1 CVSROOT/loginfo > > Index: CVSROOT/loginfo > diff -u -p CVSROOT/loginfo:1.50 CVSROOT/loginfo:1.51 > --- CVSROOT/loginfo:1.50 2 Dec 2005 15:43:52 -0000 > +++ CVSROOT/loginfo 2 Dec 2005 15:43:52 -0000 > @@ -28,7 +28,8 @@ > # Use this for testing > ^test /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m testing(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -S -s %p %s > > +^wine /usr/bin/perl $CVSROOT/CVSROOT/log_accum -f $CVSROOT/CVSROOT/commitlog -S -s %p %s > + > # All others go to wine-cvs > -^wine /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m wine-cvs(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -L 200 -p -S -s %p %s > DEFAULT /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m wine-cvs(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -P winehq -L 200 -p -c -S -s %p %s > > >

5 6