- Wine-Devel - list.winehq.org

Re: button.c: misplacement of checkboxes with empty label fixed, found one mistypo...
by Paul Millar Oct. 19, 2005

Oct. 19, 2005

Hi Markus, Please send patches included as in-line text (being careful to avoid line-wraps). This helps for reviewing patches. The changelog entry normally goes before the patch, not included as part of the patch. Cheers, Paul. On Wednesday 19 Oct 2005 12:18, you wrote: > dlls/user/button.c: Misplacement of checkboxes with empty label fixed, > found one mistypo... > > Markus Gömmel > m.goemmel(a)compulab.de > > PS: This is my first patch, so please let me know if I did something > wrong... > > > begin 666 patch.diff > M/R!O=70*/R!P871C:"YD:69F"C\@=&]T86PM,#4Q,#$X+F1I9F8*26YD97(a)Z > M($-H86YG94QO9PH]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T] > M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]"E)#4R!F:6QE.B O > M:&]M92]W:6YE+W=I;F4O0VAA;F=E3&]G+'8*<F5T<FEE=FEN9R!R979I<VEO > M;B Q+CDX"F1I9F8(a)+74@+74(a)+7 @+7(Q+CDX($-H86YG94QO9PHM+2T(a)0VAA > M;F=E3&]G"3,P(%-E<" R,# U(#$R.C R.C,X("TP,# P"3$N.3@**RLK($-H > M86YG94QO9PDQ."!/8W0@,C P-2 Q-CHQ,#HU-2 M,# P, I 0" M,2PS("LQ > M+#<@0$ **PHK"2H(a)9&QL<R]U<V5R+V)U='1O;BYC.B!-87)K=7,@1V]E;6UE > M;" \;2YG;V5M;65L0&-O;7!U;&%B+F1E/@HK"4UI<W!L86-E;65N="!O9B!C > M:&5C:V)O>&5S('=I=&@@96UP='D@;&%B96P(a)9FEX960**PH(a)+2TM+2TM+2TM > M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM > M+2TM+2TM+2TM+0H@,C P-2TP.2TS," @06QE>&%N9')E($IU;&QI87)D(" \ > M:G5L;&EA<F1 =VEN96AQ+F-O;3X*( I);F1E>#H(a)9&QL<R]U<V5R+V)U='1O > M;BYC"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T] > M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T*4D-3(&9I;&4Z("]H;VUE+W=I > M;F4O=VEN92]D;&QS+W5S97(O8G5T=&]N+F,L=@IR971R:65V:6YG(')E=FES > M:6]N(#$N.0ID:69F("UU("UU("UP("UR,2XY(&)U='1O;BYC"BTM+2!D;&QS > M+W5S97(O8G5T=&]N+F,),3(@4V5P(#(P,#4@,3(Z,C Z,S@@+3 P,# ),2XY > M"BLK*R!D;&QS+W5S97(O8G5T=&]N+F,),3@@3V-T(#(P,#4@,38Z,3 Z-3<@ > M+3 P,# *0$ @+3DQ-"PX("LY,30L,3,@0$ @<W1A=&EC('9O:60(a)0T)?4&%I > M;G0H($A73D0@:'=N9"P(a)2$1#(&A$0PH@(" @(&-L:65N=" ](')T97AT.PH@ > M(" @(&1T1FQA9W,@/2!"55143TY?0V%L8TQA8F5L4F5C="AH=VYD+"!H1$,L > M("9R=&5X="D["B @(" @"BT@(" @<F)O>"YT;W @/2!R=&5X="YT;W ["BT@ > M(" @<F)O>"YB;W1T;VT@/2!R=&5X="YB;W1T;VT["BL@(" @+RH(a)3VYL>2!A > M9&IU<W0@<F)O>"!W:&5N(')T97AT(&ES('9A;&ED("HO"BL@(" @:68@*&1T > M1FQA9W,@(3T@*%5)3E0I+3%,*0HK(" @('L**PER8F]X+G1O<" ](')T97AT > M+G1O<#L**PER8F]X+F)O='1O;2 ](')T97AT+F)O='1O;3L**R @("!]"BL* > M(" @(" O*B!$<F%W('1H92!C:&5C:RUB;W@@8FET;6%P("HO"B @(" @:68@ > M*&%C=&EO;B ]/2!/1$%?1%)!5T5.5$E212!\?"!A8W1I;VX@/3T(a)3T1!7U-% > M3$5#5"D*(" @("!["D! ("TY-#8L-R K.34Q+#<@0$ @<W1A=&EC('9O:60@ > M0T)?4&%I;G0H($A73D0@:'=N9"P(a)2$1#(&A$0PH@"0ER8F]X+G1O<" ](')B > M;W(a)N8F]T=&]M("T(a)8VAE8VM";WA(96EG:'0["B )(" @('T(a)96QS92!["B ) > M"7)B;W(a)N8F]T=&]M("L]("UD96QT82\R("L@,3L*+0D)<F)O>"YT;W @/2!R > M8F]X+F)O='1O;2 M/2!C:&5C:T)O>$AE:6=H=#L**PD)<F)O>"YT;W @/2!R > M8F]X+F)O='1O;2 M(&-H96-K0F]X2&5I9VAT.PH@"2 @("!]"B )?2!E;'-E > H('L(a)+RH@1&5F875L=" J+PH@"2 @("!I9B H9&5L=&$@/B P*2!["@`` > ` > end

1 0

Re: fix for #3219
by Hans Leidekker Oct. 19, 2005

Oct. 19, 2005

On Wednesday 19 October 2005 09:19, Vijay Kiran Kamuju wrote: > - /* MS mangled names always begin with '?' */ > - if (*sym->current != '?') return FALSE; > + /* MS mangled names always begin with '?' > + if (*sym->current != '?') return FALSE; */ It's better to remove code then disabling it this way. We can always refer to CVS history. -Hans

2 1

Querying the id of an icon
by Michael Jung Oct. 19, 2005

Oct. 19, 2005

Hi, if I understand correctly, integer identifiers (MAKEINTRESOURCE) passed to LoadIcon actually identify an icon directory. LoadIcon tries to find the icon in the directory, which best matches the current display device characteristics. Does anybody know how I can query the identifier of the returned icon? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Downloading Mozilla ActiveX
by Vitaliy Margolen Oct. 19, 2005

Oct. 19, 2005

At present Wine asks the use it he/she wants to download and install Mozilla ActiveX. But it doesn't work and doesn't tell the user that it didn't work. This is not right. We either should say that download/install failed, or don't show this message in the first place, unless we fix it. I would consider this as a major inconvenience for users that is not acceptable for 0.9 release. One of the possible solutions was to download it from SF. But that required some html scraping. That what I thought so too. Attached is the script that SuSE uses to download core fonts from sf.net in an automated fashion. Could we adapt that script and use it? Or program that logic into Wine to do the same? -- Best regards, Vitaliy

6 12

Re: x11drv: allow removing of managed_prop
by Fabian Bieler Oct. 18, 2005

Oct. 18, 2005

On Wednesday 19 October 2005 02:02, Fabian Bieler wrote: > This patch removes window decorations in kde from windows which are not > initially created with WS_POPUP style or similar but later altered via > SetWindowLong. > > Examples for this are tooltips in wxwindows apps like vlc > http://www.videolan.org/vlc/download-windows.html > or tooltips, equalizer window and playlist window in winamp 5 > http://download.nullsoft.com/winamp/client/winamp51_lite.exe Sorry, This one is better ;-)

2 1

Re: listview: infoPtr might be invalid after WM_NOTIFY
by Robert Shearman Oct. 18, 2005

Oct. 18, 2005

Michael Jung wrote: >Hello Alexandre, Dimi and Phil, > >This is a patch for the infoPtr problem in comctl32's listview.c. I guess it >matches your suggestion on IRC? I've only changed the minimum necessary to >get rid of the file dialog crash. If that's the correct approach in your >opinion, I will continue to work on this. I will be on vacation for three >weeks, though, starting from Friday. > >Dimi, if you think this is ugly, or if you are working on a better solution, >please do protest. > >Changelog: > infoPtr might be invalid after a WM_NOTIFY message was sent, since the >application might have destroyed the listview. Pass around hwnd instead and >call GetWindowLongPtr, if we have to access the listview instance data. >Spotted by Phil Krylov. > > Since this was a behaviour in our file open dialog, did we even verify that this was a listview bug or is it that destroying the listview in the middle of a notification is something that you shouldn't do? If the latter, then one could easily modify the file dialog to post a message to itself to destroy the listview after the listview has finished processing the message that caused the notification. -- Rob Shearman

4 3

dlls/wined3d/device.c: IWineD3DDeviceImpl_CreateQuery lost detection of unimplemented query type
by Christoph Frick Oct. 18, 2005

Oct. 18, 2005

hi list, as the game Live For Speed refuses to work for me with the 20050930 since i have installed the new nvidia drivers 7something I did lots of comparing between 20050830 and 20050930 and found that the swtich-statement for IWineD3DDeviceImpl_CreateQuery is no longer detecting unimplemented types and won't start complaining about them (FIXME(...)). Maybe this is intentional therefor this patch to the developer list because the d3d hackers sure know better than me or at least can test against recent games. Before the change the known, but not implemented got a warning - not they are silently ignored. Therefor i moved the check against WINED3DQUERYTYPE_OCCLUSION on top (add a warn here, that the opengl driver does not support the query) and let everything else fall again in the default: case. -- cu --- dlls/wined3d/device.c.orig 2005-10-17 21:18:14.000000000 +0200 +++ dlls/wined3d/device.c 2005-10-17 21:22:16.000000000 +0200 @@ -1060,6 +1060,13 @@ HRESULT hr = D3DERR_NOTAVAILABLE; /* Lie and say everything is good (we can return ok fake data from a stub) */ switch(Type) { + case WINED3DQUERYTYPE_OCCLUSION: + TRACE("(%p) occlusion query\n", This); + if (GL_SUPPORT(ARB_OCCLUSION_QUERY) || GL_SUPPORT(NV_OCCLUSION_QUERY)) + hr = D3D_OK; + else + WARN("Not supported: ARB_OCCLUSION_QUERY/NV_OCCLUSION_QUERY\n"); + break; case WINED3DQUERYTYPE_VCACHE: case WINED3DQUERYTYPE_RESOURCEMANAGER: case WINED3DQUERYTYPE_VERTEXSTATS: @@ -1073,12 +1080,6 @@ case WINED3DQUERYTYPE_PIXELTIMINGS: case WINED3DQUERYTYPE_BANDWIDTHTIMINGS: case WINED3DQUERYTYPE_CACHEUTILIZATION: - break; - case WINED3DQUERYTYPE_OCCLUSION: - TRACE("(%p) occlusion query\n", This); - if (GL_SUPPORT(ARB_OCCLUSION_QUERY) || GL_SUPPORT(NV_OCCLUSION_QUERY)) - hr = D3D_OK; - break; default: FIXME("(%p) Unhandled query type %d\n",This , Type); }

2 1

Re: Correctly unicodify winmm/mmio.c
by Eric Pouech Oct. 18, 2005

Oct. 18, 2005

Vincent Béron wrote: > Changelog: > Correctly unicodify winmm/mmio.c. don't apply this patch, it's plain wrong. the A<->W message mapping isn't implemented yet, and all our internal handlers are still ANSI. The steps to go are (in order): - implement A<->W message mapping for MMIO - translate our internal handlers to unicode - then apply this patch A+ -- Eric Pouech

3 2

Re: Unicodify hhctrl.ocx HtmlHelpW
by James Hawkins Oct. 17, 2005

Oct. 17, 2005

On 17 Oct 2005 20:02:16 -0400, Vincent Béron <vberon(a)mecano.gme.usherb.ca> wrote: > Changelog: > Unicodify HtmlHelpW in hhctrl.ocx > We should leave the message out completely at this point. The integral components of HTML Help have been implemented, and at least HH_DISPLAY_TOPIC needs to call doWinMain. This will give hhctrl.ocx and mshtml/shdocvw much needed testing. Unless I get a lot of objections to this, I'll send the patch in shortly. -- James Hawkins

1 0

Fwd: Re: [kernel] correct OpenFile test
by Oliver Stieber Oct. 17, 2005

Oct. 17, 2005

-- Maxime Bellengé <maxime.bellenge(a)wanadoo.fr> wrote: > > Hello, > > You can try this application installer : > http://jatennis.free.fr/jatinst32.php > I've had a look and the installer is failing because of the result returned by : 0009:Call version.VerFindFileA(00000000,0040b4ec "JaTennis32.exe",0040e268 "c:\\Windows",00417bf4 "Z:\\var\\work\\crosovergames\\downloads\\bugs\\OpenFile regression\\",004179e4,7babfe0c,00417af0,7babfe10) ret=0040143d VerFindFileA then goes on to call OpenFile, so I expect that the error is VerFindFileA is testing the result of OpenFile against FALSE instead of using TRUE or HFILE_ERROR. .... VerFindFileA is returing 2 (VFF_FILEINUSE) if OpenFile returns HFILE_ERROR, but it's returning 0 if OpenFile returns FALSE. I think it's a good idea to revert OpenFile and fix VerFindFileA. Oliver. > With the OF_EXIST flag: > > if OpenFile returns HFILE_ERROR , the installers fails > > if OpenFile returns FALSE, the installers works very well like on > windows. > > Maxime > > On Mon, 2005-10-17 at 15:20 +0100, Oliver Stieber wrote: > > --- Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > > > > "Oliver Stieber" <oliver_stieber(a)yahoo.co.uk> wrote: > > > > > > > This patch corrects the test for OpenFile with a style of OF_EXIST. The test should > fail if > > > the > > > > function returns anything other than HFILE_ERROR as a failure. This is based on > > > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/… > and > > > > debugging 'No One Lives Forever Demo' (ftp://ftp.lith.com/pub/nolf/NOLFDemo.zip) > > > > > > Did you run the test on a real Windows machine or just have read MSDN? > > > > I've haven't run it on a real Windows machine as my windows install is broken at the moment. > > Returning HFILE_ERROR is the only thing that fixes 'No One Lives Forever Demo' so I'm puzzled > as > > to why the test is incorrect in the first place. (Also I haven't debugged the No One Lives > Forever > > Demo to verify that it is doing a cmp eax, HFILE_ERROR, but I can do). > > > > Oliver. > > > > > > > > -- > > > Dmitry. > > > > > > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

1 0