- Wine-Devel - list.winehq.org

[TRY2] printer dialog fixes part1 + french
by Vijay Kiran Kamuju Oct. 11, 2005

Oct. 11, 2005

Hi jernst, Please change the return types of the CheckPrinterSetup function to TRUE/FALSE You made changes similar to me, thanks ;) Thanks, Vijay

1 0

wine-faq mailing list
by Dimi Paun Oct. 10, 2005

Oct. 10, 2005

It's time to put it out of its misery. There's basically no traffic on that list, and the 1 question/quarter I get there is not appropriate for that forum. Can we please kill it? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

5 5

Re: Listview: refcount the infoPtr (Dropped patch)
by Troy Rollo Oct. 10, 2005

Oct. 10, 2005

On Tue, 27 Sep 2005 08:00, Dimi Paun wrote: > Do we need to do this for other controls too? > > ChangeLog > Add refcounting to the listview to support destroying of > the control from within notification messages. <http://www.winehq.org/pipermail/wine-patches/2005-September/021003.html> This patch does not appear to have gone in, but it fixes a SEGV that occurs quite frequently when you double-click on a folder in the file open dialog. Is there a (good) reason it hasn't gone in?

1 0

Re: [ddraw] Fix bug 3487 take 2
by Christian Costa Oct. 10, 2005

Oct. 10, 2005

Peter Berg Larsen wrote: > > Walking backwards the bug was introduced in > > http://www.winehq.org/pipermail/wine-patches/2002-November/004161.html > > and altered in > > http://www.winehq.org/pipermail/wine-patches/2004-March/010091.html > > which states > >> Apps should initialize correctly the dwSize member of ddraw structures. >> However some of them do not do this and Windows seems to handle that >> case without crashing. >> Here is a patch that prevents clearing more that the struct size. >> This fixes the bug 2070. > > > So here is better patch that does not open 2070 again. > > > Changelog: > Bug in copying structs if to == from as to was memset first. > > diff -u Wine-20050930/dlls/ddraw/ddraw_private.h > Wine-20050930my/dlls/ddraw/ddraw_private.h > --- Wine-20050930/dlls/ddraw/ddraw_private.h 2005-07-24 > 18:17:29.000000000 +0200 > +++ Wine-20050930my/dlls/ddraw/ddraw_private.h 2005-10-09 > 04:50:59.000000000 +0200 > @@ -41,18 +41,22 @@ > (x)->dwSize = sizeof(*x); \ > } while (0) > > +/* __tosize can be set too large by some programs */ > #define DD_STRUCT_COPY_BYSIZE(to,from) \ > do { \ > - DWORD __size = (to)->dwSize; \ > - DWORD __copysize = __size; \ > - DWORD __resetsize = __size; \ > - if (__resetsize > sizeof(*to)) \ > - __resetsize = sizeof(*to); \ > - memset(to,0,__resetsize); \ > - if ((from)->dwSize < __size) \ > - __copysize = (from)->dwSize; \ > - memcpy(to,from,__copysize); \ > - (to)->dwSize = __size;/*restore size*/ \ > + DWORD __tosize = (to)->dwSize; \ > + DWORD __fromsize = (from)->dwSize; \ > + if ((to) == (from)) \ > + break; \ > + if (__tosize > sizeof(*(to))) \ > + ERR("To struct's size too large"); \ > + if (__fromsize > sizeof(*(from))) \ > + ERR("From struct's size too large");\ > + if (__fromsize > __tosize) \ > + ERR("Copying too large struct"); \ > + memcpy(to,from,__fromsize); \ > + memset(to+__fromsize,0,sizeof(*(to))-__fromsize); \ > + (to)->dwSize = __tosize;/*restore size*/\ > } while (0) > > #define MAKE_FOURCC(a,b,c,d) ((a << 0) | (b << 8) | (c << 16) | (d << > 24)) > > > > This does not work if the destination size is smaller than the struct size or source size is greater than destination size. Even worst, if source size is greater than struct size, sizeof(*(to))-__fromsize is < 0. Why don't you just add the "if (to = from) break;" statement ? Christian

3 5

Re: WINE Regression due to patch applied Feb 22, 2005 10:50 CDT
by Krzysztof Foltman Oct. 10, 2005

Oct. 10, 2005

> The patch that changed these files is: > ChangeSet ID: 16245 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2005/02/22 09:50:14 That patch isn't directly responsible for the bug, it has probably just revealed it. The bugfix will be sent as soon as the previous bugfixes are accepted. It looks more or less like this: Index: editor.c =================================================================== RCS file: /home/wine/wine/dlls/riched20/editor.c,v retrieving revision 1.59 diff -u -r1.59 editor.c --- editor.c 3 Oct 2005 18:45:39 -0000 1.59 +++ editor.c 9 Oct 2005 15:00:34 -0000 @@ -2062,10 +2075,10 @@ if (item->member.run.nFlags & MERF_ENDPARA) { - *buffer++ = '\r'; + *buffer = '\r'; if (bCRLF) { - *buffer = '\n'; + *(++buffer) = '\n'; nWritten++; } assert(nLen == 1); Check it out, it works for me. Krzysztof

3 4

Re: winecfg: Set autodetect windows version to what it realy is - win2k
by Alexandre Julliard Oct. 10, 2005

Oct. 10, 2005

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > changelog: > winecfg: > Set autodetect windows version to what it really is - win2k The autodetect option should really be removed. -- Alexandre Julliard julliard(a)winehq.org

2 1

COMCTL32 - TreeView control not correctly updated with COMCTL32.OCX (was: Re: comctl32.dll: Running siap and modules under wine, first steps)
by Alex Villacís Lasso Oct. 10, 2005

Oct. 10, 2005

This SIAP application is revealing more problems with Wine. This time it is the reason for the original complaint: Mr. Maximiliano Curia reported that in the version of Wine he could test, the treeview control in the middle of the screen was not updated correctly. The treeview control should have looked like this: +---------------------------------+ |Persona Física | | | | | +- Datos identificatorios | | | | | | | +- Nombre y otros datos | | | +- Domicilio | | | +- Actividades | | +- Datos comerciales | | | | | | | +- Datos de interés fiscal| | | +- Claves bancarias | | +- Responsable por deuda ajena | +---------------------------------+ Don't mind the actual meaning of the text in the nodes. The problem is that for Mr. Curia, the treeview control actually shows up like this: +---------------------------------+ |Persona Física | | | | | | | | | | | | | | | | | | | | | | | +---------------------------------+ That is, the treeview control only shows the first line of the tree. After some digging in the treeview control, I saw that the code in the control tries to save some drawing by querying the update region of the control window. When the WM_PAINT message indicates a non-null HDC in wParam, the code fetches the update region for the control window. If I understand the intent of the code correctly, the WM_PAINT message can be sent to the control with an wParam of the HDC of an offscreen bitmap, in order to draw the tree into it. When the update region of the control is NULL, the code fetches the BITMAP structure of the target HDC in order to clip the drawing to the dimensions of the target bitmap. The problem is that, in the case of the treeview managed by COMCTL32.OCX, for some as yet undiscovered reason, the control *always* has a null update region, except for the very first rendering (which is overwritten by a second rendering with the problematic null region). No matter how the window is uncovered, the update region remains null. Therefore, the control believes that the target is an offscreen bitmap, even for the rendering to the screen. It then fetches the default bitmap selected, which is an 1x1 dummy bitmap, gets a 1x1 target region, and believes that only 1 pixel should be updated. Only the very first item gets redrawn because of this. The following patch works around this issue. However, this is not a proper fix, because the control window should have been properly invalidated in the first place, and the control should therefore have a proper update region. I am not really sure whether the root cause is in the treeview code or in the region updating code. I am inclined to the former, because the same treeview control seems to work correctly in regedit.exe: --- wine-20050930-cvs/dlls/comctl32/treeview.c 2005-09-12 17:34:07.000000000 -0500 +++ wine-20050930-cvs-patch/dlls/comctl32/treeview.c 2005-10-02 22:08:08.000000000 -0500 @@ -2790,6 +2790,8 @@ RECT rect = *rc; TREEVIEW_ITEM *wineItem; + TRACE("refreshing on (%ld,%ld)-(%ld,%ld)\n", rect.left, rect.top, rect.right, rect.bottom); + if (infoPtr->clientHeight == 0 || infoPtr->clientWidth == 0) { TRACE("empty window\n"); @@ -2859,6 +2861,12 @@ rc.left = 0; rc.top = 0; rc.right = bitmap.bmWidth; rc.bottom = bitmap.bmHeight; + if (bitmap.bmWidth == 1 && + bitmap.bmHeight == 1 && + bitmap.bmWidthBytes == 2) { + ERR("failed to recover a valid update region, using GetClientRect()\n"); + GetClientRect(infoPtr->hwnd, &rc); + } TREEVIEW_EraseBackground(infoPtr, (HDC)wParam); } } The sample (VisualBasic) code and executable have been uploaded as testcases for the following bug report: http://bugs.winehq.org/show_bug.cgi?id=3476 BTW: what happened to the patch that fixes the DBGRID32.OCX control? (Subject: OLEAUT32: add additional condition for creation of interface) On an (hopefully) unrelated note, the user32 tests are failing, at least on my machine: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so sysparams.c && touch sysparams.ok sysparams.c:1182: Test failed: lfHeight: got -16 instead of 0 sysparams.c:1183: Test failed: lfWidth: got 0 instead of 400 sysparams.c:1185: Test failed: lfWeight: got 400 instead of 7471169 sysparams.c:1186: Test failed: lfItalic: got 0 instead of 105 sysparams.c:1187: Test failed: lfStrikeOut: got 0 instead of 97 sysparams.c:1190: Test failed: lfOutPrecision: got 0 instead of 108 sysparams.c:1193: Test failed: lfQuality: got 0 instead of 32 make: *** [sysparams.ok] Error 7 ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so win.c && touch win.ok fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE win.c:2213: Test failed: message 0200 available win.c:2221: Test failed: message 000f available win.c:2229: Test failed: message 000f available win.c:2240: Test failed: message 000f available win.c:2248: Test failed: message 000f available win.c:2256: Test failed: message 000f available win.c:693: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000000, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c80000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c80000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c40000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c40000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c20000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c20000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c10000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c10000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14d00000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14d00000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14e00000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14e00000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000200, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000200, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c40000:0x00000300, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c40000:0x00000300, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000080, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000080, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c40000:0x00000180, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c40000:0x00000180, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000000, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c40000:0x00000100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c40000:0x00000100, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x94000000:0x00040000, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00040000, menu=1 win.c:693: Test failed: window rect does not match: style:exstyle=0x14c40000:0x00040100, menu=1 win.c:718: Test failed: synthetic rect does not match: style:exstyle=0x14c40000:0x00040100, menu=1 make: *** [win.ok] Error 42 make: Debido a los errores, el objetivo `test' no se reconstruyó.

1 1

Too dumb to 'make' documentation
by Molle Bestefich Oct. 10, 2005

Oct. 10, 2005

Hi ho. I get this error when doing 'make' in wine docs under 'en': =================================== docbook2txt winedev-guide.sgml Using catalogs: /etc/sgml/sgml-docbook-3.1.cat Using stylesheet: /usr/share/sgml/docbook/utils-0.6.12/docbook-utils.dsl#html Working on: /root/wine-docs/en/winedev-guide.sgml Unknown option -force_html make: *** [winedev-guide.txt] Error 9 =================================== Eep. Anyone got a solution?

2 3

MS Office 95/97 needs native odbccp32.dll
by Michael Kaufmann Oct. 10, 2005

Oct. 10, 2005

Hi, The MS Office 95/97 setup program fails when using the built-in odbccp32.dll. A native version of this dll is on the installation media. Since 2005-07-08, Wine doesn't use this file because of this patch: http://cvs.winehq.org/patch.py?id=18748 I think that we have three options: - Change Wine's default configuration and make it use the native odbccp32.dll - Add a remark in the application DB to Office 95/97, Access 95/97, Excel 95/97 (also Word 95/97, Powerpoint 95/97?) that users should use winecfg to change "odbccp32" to "native, builtin" - Implement the needed functions in odbccp32.dll See also bug 3268: http://bugs.winehq.org/show_bug.cgi?id=3268 PS: odbccp32.dll is missing on Wine's status page. Regards Michael

2 2

Re: fix bug 3536
by Kai Blin Oct. 10, 2005

Oct. 10, 2005

* Vijay Kiran Kamuju <infyquest(a)gmail.com> [10/10/05, 14:48:48]: > 342a343,344 > > {"PHT", > > {'P','h','i','l','i','p','p','i','n','e',' ','T','i','m','e','\0'}, -480, 0}, Please stick to the diff -u format. It doesn't matter much for a patch of this size, but larger patches are much more readable. Cheers, Kai -- Kai Blin, (blin at gmx dot net) Men of peace usually are [brave]. -- Spock, "The Savage Curtain", stardate 5906.5

2 1