- Wine-Devel - list.winehq.org

Re: Relax Marlett LOGFONT specification
by Huw Davies Sept. 10, 2005

Sept. 10, 2005

On Fri, Sep 09, 2005 at 12:46:10PM +0100, Richard Cohen wrote: > Index: dlls/user/uitools.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/uitools.c,v > retrieving revision 1.7 > diff -u -p -r1.7 uitools.c > --- dlls/user/uitools.c 7 Jul 2005 18:24:12 -0000 1.7 > +++ dlls/user/uitools.c 9 Sep 2005 11:41:49 -0000 > @@ -926,9 +926,9 @@ static BOOL UITOOLS95_DrawFrameCaption(H > return FALSE; > } > > - hf = CreateFontW(-SmallDiam, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, > - SYMBOL_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, > - DEFAULT_QUALITY, FIXED_PITCH|FF_DONTCARE, glyphFontName); > + hf = CreateFontW(-SmallDiam, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, > + DEFAULT_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, > + DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, glyphFontName); > alignsave = SetTextAlign(dc, TA_TOP|TA_LEFT); > bksave = SetBkMode(dc, TRANSPARENT); > clrsave = GetTextColor(dc); We shouldn't need to do this. Fixing marlett.ttf would be the right thing to do. I'll try to look at this next week (but feel free to beat me to it!). Huw.

2 1

patches
by Ivan Leo Puoti Sept. 10, 2005

Sept. 10, 2005

Is anything wrong with these? http://www.winehq.com/pipermail/wine-patches/2005-September/020521.html http://www.winehq.com/pipermail/wine-patches/2005-September/020550.html Ivan

1 0

Re: dlls/x11drv/mouse.c
by Alexandre Julliard Sept. 9, 2005

Sept. 9, 2005

Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: > We had a XFlush call in X11DRV_SetCursorPos before but it was removed for > some reason. This restores the call and fixes a regression in JInitiator > where the mouse position was being reported incorrectly. This sounds like it's just masking the problem. Do you know precisely why the mouse position is incorrect? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: shell32: correct a failing test
by Saulius Krasuckas Sept. 9, 2005

Sept. 9, 2005

* On Fri, 2 Sep 2005, Juan Lang wrote: > > This test was failing after the first time on Windows, so (hopefully) > fix it. > > ChangeLog: fix a test failing on Windows. Reported by Katerina Nizhnik. Unfortunately, this code pops up some window: --- wine/dlls/shell32/tests/shellpath.c 2005/08/16 16:00:07 1.11 +++ wine/dlls/shell32/tests/shellpath.c 2005/09/03 09:37:15 1.12 ... + shFileOp.pFrom = modifiedPath; + shFileOp.fFlags = FOF_NOCONFIRMATION | FOF_NOERRORUI | + FOF_SILENT; + SHFileOperationA(&shFileOp); which says: | Favorites is a Windows system folder and is required for Windows to run | properly. It cannot be deleted. And then exception of an access violation is thrown from the SHLWAPI.DLL. This happens on WinME. It seems here the flag FOF_NOERRORUI is ignored. I can't test this on other platforms and am going out of city for a weekend. Anyone feel free to fix it. :-P

1 0

Re: dll/winmm/playsound.c
by Robert Shearman Sept. 9, 2005

Sept. 9, 2005

Ulrich Czekalla wrote: >fccType may be NULL or contain non-printable characters. Show output as hex >instead of characters. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Display fccType as hex instead of characters in trace output > > >------------------------------------------------------------------------ > >Index: dlls/winmm/playsound.c >=================================================================== >RCS file: /home/wine/wine/dlls/winmm/playsound.c,v >retrieving revision 1.17 >diff -u -p -r1.17 playsound.c >--- dlls/winmm/playsound.c 13 Jul 2005 11:59:15 -0000 1.17 >+++ dlls/winmm/playsound.c 8 Sep 2005 14:42:09 -0000 >@@ -328,7 +328,7 @@ static DWORD WINAPI proc_PlaySound(LPVOI > if (mmioDescend(hmmio, &mmckInfo, &ckMainRIFF, MMIO_FINDCHUNK)) > goto errCleanUp; > >- TRACE("Chunk Found ckid=%.4s fccType=%.4s cksize=%08lX \n", >+ TRACE("Chunk Found ckid=%.4s fccType=%08x cksize=%08lX \n", > (LPSTR)&mmckInfo.ckid, (LPSTR)&mmckInfo.fccType, mmckInfo.cksize); > > lpWaveFormat = HeapAlloc(GetProcessHeap(), 0, mmckInfo.cksize); >@@ -349,7 +349,7 @@ static DWORD WINAPI proc_PlaySound(LPVOI > if (mmioDescend(hmmio, &mmckInfo, &ckMainRIFF, MMIO_FINDCHUNK)) > goto errCleanUp; > >- TRACE("Chunk Found ckid=%.4s fccType=%.4s cksize=%08lX\n", >+ TRACE("Chunk Found ckid=%.4s fccType=%08x cksize=%08lX\n", > (LPSTR)&mmckInfo.ckid, (LPSTR)&mmckInfo.fccType, mmckInfo.cksize); > > I think these formats should be %04x as fccType is 2 bytes, not 4 bytes. -- Rob Shearman

3 2

Problem detecting libxslt
by Vincent Béron Sept. 9, 2005

Sept. 9, 2005

Hi Mike, Doing ./configure on a RH8 box I get the following: checking libxslt/transform.h presence... yes configure: WARNING: libxslt/transform.h: present but cannot be compiled configure: WARNING: libxslt/transform.h: check for missing prerequisite headers? configure: WARNING: libxslt/transform.h: see the Autoconf documentation configure: WARNING: libxslt/transform.h: section "Present But Cannot Be Compiled" configure: WARNING: libxslt/transform.h: proceeding with the preprocessor's result configure: WARNING: libxslt/transform.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## The problem looks to come from my transform.h needing xsltInternals.h being included first. I added an #ifdef HAVE_LIBXSLT_PATTERN_H include to the AC_CHECK_HEADERS which defines HAVE_LIBXSLT, as that file does #include "xsltInternals.h". I don't think we should directly include xsltInternals.h. Could you please comment if the attached patch is correct or not? I'll send it to wine-patches if acceptable. Thank you, Vincent

3 2

Re: kernel: Forward Atom APIs to ntdll
by Dmitry Timoshkov Sept. 9, 2005

Sept. 9, 2005

"James Hawkins" <truiken(a)gmail.com> wrote: > + if (!table) > { > - req->atom = atom; > - req->table = table; > - wine_server_set_reply( req, full_name, sizeof(full_name) ); > - if (!wine_server_call_err( req )) > + ATOM_BASIC_INFORMATION *abi; > + > + size = sizeof(*abi) + MAX_ATOM_LEN * sizeof(WCHAR); > + abi = HeapAlloc(GetProcessHeap(), 0, size); Using HeapAlloc will considerably slowdown the function, you can safely allocate the necessary buffer on the stack. The same for GetAtomNameW. -- Dmitry.

1 0

appdb developers please read
by Ivan Leo Puoti Sept. 8, 2005

Sept. 8, 2005

Hello, if you look at http://www.winehq.com/pipermail/wine-devel/2005-September/039837.html you'll see there was a project at some point to make a decent patch management system, but apparently due to the complexity of it and Newman being constantly overloaded with work, it never got anywhere, do you guys think it's doable/would you be willing to volunteer to build something of the sort? It would make wine development easier quicker (No more wondering "should I ask Alexandre about that patch? Is it too soon? should I wait a little longer? should I rewrite it? to be or not to be?") and would be great value for the project as it would probably make it easier for new developers to join. Ivan.

5 8

winnt32.exe on AMD64
by Tom Kennedy Sept. 8, 2005

Sept. 8, 2005

All I have install Wine one an AMD 64 bit system running Redhat 3 update 2. I am trying to run the winnt32.exe prgram and I am getting the following load error. root(a)cert-amd1 ~]# wine "y:\amd64\winnt32.exe" Trying to load PE image for unsupported architecture (Unknown-8664) wine: could not load L"Y:\\amd64\\winnt32.exe" as Win32 binary [root(a)cert-amd1 ~]# I assue the 32 in the name of the executabel means it is a 32 bit binary, but wine is telling me it is not. Any clues as to why I am getting this error message. Thanks. Tom

2 1

Re: DSOUND: tolerate inexact conversion between different frequencies
by Robert Reif Sept. 8, 2005

Sept. 8, 2005

Alex Villacís Lasso wrote: > During the winealsa tests, I am frequently annoyed by the following: > say, in playing a 11050Hz secondary buffer with an 8000Hz primary > buffer, the number of samples are converted form secondary->primary > and back. In the process, the number of consumed samples in the > secondary buffer drifts by a few frames from the actual value, and > this triggers the warning about "problem with underflow detection". > This patch allows a tolerance of up to 4 bytes before issuing the > message. > > Alex Villacís Lasso Or you could keep track of the round off errors (fractions) like winex does.

1 0