- Wine-Devel - list.winehq.org

Re: [commdlg] Create interface for path related operations
by Robert Shearman Aug. 13, 2005

Aug. 13, 2005

Troy Rollo wrote: >This patch creates an interface for path name related operations (including >things such as finding the file name part, extension, identifying the path >separator character, qualifying file names, changing directories, verifying >file existence) used by the file open dialogs that depend on the path being a >Win32 path name, thus making the file dialog code less dependent on the >structure of path names. > >ChangeLog: > Create an interface for path related operations used by the file dialogs > to reduce their dependency on Win32 format paths. > > Why do you want to do that? -- Rob Shearman

2 1

SHGetPathFromIDList problem
by Ge van Geldorp Aug. 13, 2005

Aug. 13, 2005

Since this patch: http://www.winehq.org/hypermail/wine-cvs/2005/06/0338.html SHGetPathFromIDList() seems broken. The problem is that files stored in the Desktop directory don't get the path to the Desktop directory prepended. I've tried to fix it in the attached patch and added a testcase, but the shell COM interfaces easily confuse me, so perhaps someone with a better understanding of this stuff should look it over before I submit it to wine-patches. Ge van Geldorp. Index: dlls/shell32/pidl.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/pidl.c,v retrieving revision 1.133 diff -u -r1.133 pidl.c --- dlls/shell32/pidl.c 8 Jul 2005 14:18:32 -0000 1.133 +++ dlls/shell32/pidl.c 12 Aug 2005 15:04:05 -0000 @@ -1242,6 +1242,7 @@ BOOL WINAPI SHGetPathFromIDListW(LPCITEMIDLIST pidl, LPWSTR pszPath) { HRESULT hr; + BOOL result; LPCITEMIDLIST pidlLast; LPSHELLFOLDER psfFolder; DWORD dwAttributes; @@ -1258,13 +1259,34 @@ dwAttributes = SFGAO_FILESYSTEM; hr = IShellFolder_GetAttributesOf(psfFolder, 1, &pidlLast, &dwAttributes); - if (FAILED(hr) || !(dwAttributes & SFGAO_FILESYSTEM)) return FALSE; + if (FAILED(hr) || !(dwAttributes & SFGAO_FILESYSTEM)) { + IShellFolder_Release(psfFolder); + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } hr = IShellFolder_GetDisplayNameOf(psfFolder, pidlLast, SHGDN_FORPARSING, &strret); - if (FAILED(hr)) return FALSE; - - hr = StrRetToBufW(&strret, pidlLast, pszPath, MAX_PATH); IShellFolder_Release(psfFolder); + if (FAILED(hr)) { + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } + + /* Check for a PIDL rooted at desktop level */ + if (_ILIsValue(pidl) || _ILIsFolder(pidl)) { + result = SHGetSpecialFolderPathW(NULL, pszPath, CSIDL_DESKTOPDIRECTORY, FALSE); + if (! result) { + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } + PathAddBackslashW(pszPath); + } else { + pszPath[0] = '\0'; + } + + hr = StrRetToBufW(&strret, pidlLast, pszPath + lstrlenW(pszPath), + MAX_PATH - lstrlenW(pszPath)); + ILFree((LPITEMIDLIST) pidlLast); TRACE_(shell)("-- %s, 0x%08lx\n",debugstr_w(pszPath), hr); return SUCCEEDED(hr); Index: dlls/shell32/tests/shlfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shlfolder.c,v retrieving revision 1.29 diff -u -r1.29 shlfolder.c --- dlls/shell32/tests/shlfolder.c 12 Aug 2005 10:33:37 -0000 1.29 +++ dlls/shell32/tests/shlfolder.c 12 Aug 2005 15:04:06 -0000 @@ -584,6 +584,11 @@ WCHAR wszMyComputer[] = { ':',':','{','2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-', 'A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D','}',0 }; + WCHAR wszFileName[MAX_PATH]; + LPITEMIDLIST pidlTestFile; + HANDLE hTestFile; + static WCHAR wszTestFile[] = { + 'w','i','n','e','t','e','s','t','.','f','o','o',0 }; if(!pSHGetSpecialFolderPathW) return; @@ -604,15 +609,52 @@ hr = IShellFolder_ParseDisplayName(psfDesktop, NULL, NULL, wszMyComputer, NULL, &pidlMyComputer, NULL); ok (SUCCEEDED(hr), "Desktop's ParseDisplayName failed to parse MyComputer's CLSID! hr = %08lx\n", hr); - IShellFolder_Release(psfDesktop); - if (FAILED(hr)) return; + if (FAILED(hr)) { + IShellFolder_Release(psfDesktop); + return; + } SetLastError(0xdeadbeef); result = SHGetPathFromIDListW(pidlMyComputer, wszPath); ok (!result, "SHGetPathFromIDList succeeded where it shouldn't!\n"); ok (GetLastError()==0xdeadbeef, "SHGetPathFromIDList shouldn't set last error! Last error: %08lx\n", GetLastError()); + if (result) { + IShellFolder_Release(psfDesktop); + return; + } IMalloc_Free(ppM, pidlMyComputer); + + result = pSHGetSpecialFolderPathW(NULL, wszFileName, CSIDL_DESKTOPDIRECTORY, FALSE); + ok(result, "SHGetSpecialFolderPathW failed! Last error: %08lx\n", GetLastError()); + if (!result) { + IShellFolder_Release(psfDesktop); + return; + } + PathAddBackslashW(wszFileName); + lstrcatW(wszFileName, wszTestFile); + hTestFile = CreateFileW(wszFileName, GENERIC_WRITE, 0, NULL, CREATE_NEW, 0, NULL); + ok(hTestFile != INVALID_HANDLE_VALUE, "CreateFileW failed! Last error: %08lx\n", GetLastError()); + if (hTestFile == INVALID_HANDLE_VALUE) { + IShellFolder_Release(psfDesktop); + return; + } + CloseHandle(hTestFile); + + hr = IShellFolder_ParseDisplayName(psfDesktop, NULL, NULL, wszTestFile, NULL, &pidlTestFile, NULL); + ok (SUCCEEDED(hr), "Desktop's ParseDisplayName failed to parse filename hr = %08lx\n", hr); + IShellFolder_Release(psfDesktop); + DeleteFileW(wszFileName); + if (FAILED(hr)) { + IMalloc_Free(ppM, pidlTestFile); + return; + } + + result = SHGetPathFromIDListW(pidlTestFile, wszPath); + ok(result, "SHGetPathFromIDListW failed! Last error: %08lx\n", GetLastError()); + IMalloc_Free(ppM, pidlTestFile); + if (!result) return; + ok(0 == lstrcmpW(wszFileName, wszPath), "SHGetPathFromIDListW returned incorrect path for file placed on desktop\n"); } static void test_EnumObjects_and_CompareIDs(void)

2 1

World of Warcraft
by cyrix12＠cox.net Aug. 13, 2005

Aug. 13, 2005

It's me again. The latest WoW patch (1.5.1) broke stuff again, and now I'm unable to click on anything outside of menu items in game. The issue seems to be related to camera angle, as I am able to click on items/people when I have my camera positioned just right. It's basically unplayable at the moment though. Anyway, I'd appreciate it if one of the OpenGL/D3D guys (it's most likely something that would be easily fixed by one of you) could take a look at it if they have some free time. Thanks again, Darckness

10 21

Help please
by Fabio Duarte Vilas Boas Aug. 13, 2005

Aug. 13, 2005

i got a problem with the "wine". when i minimize this program it goes to the corner __________________________________________________ Converse com seus amigos em tempo real com o Yahoo! Messenger http://br.download.yahoo.com/messenger/

1 0

Unsubscribe me from mailing list.
by Setul Patel Aug. 13, 2005

Aug. 13, 2005

Please unsubscribe my email id: setulkumarpatel(a)gmail.com from yours mailing list. Thanking you. Setul Patel

1 0

How dumb the directory of configuration of wine of $HOME/.wine for $HOME/.my-config?
by Fabio Duarte Vilas Boas Aug. 12, 2005

Aug. 12, 2005

How dumb the directory of configuration of wine of $HOME/.wine for $HOME/.my-config? _______________________________________________________ Yahoo! Acesso Grátis - Internet rápida e grátis. Instale o discador agora! http://br.acesso.yahoo.com/

6 7

compile error in current cvs
by Stefan Leichter Aug. 12, 2005

Aug. 12, 2005

Hello, current cvs does not compile for me. Im on SuSE 9.0. gcc -c -I../../../wine/dlls/msxml3 -I. -I../../../wine/include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o msxml3.dll.dbg.o msxml3.dll.dbg.c ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ../../../wine/ dlls/msxml3/msxml3.spec domdoc.o element.o factory.o main.o node.o nodemap.o msxml3.dll.dbg.o -o msxml3.dll.so -L../../dlls -L../../dlls/ oleaut32 -L../../dlls/advapi32 -L../../dlls/kernel32 -L../../dlls/ntdll -loleaut32 -ladvapi32 -lkernel32 -lntdll -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port domdoc.o(.text+0xfd2): In function `domdoc_get_documentElement': /usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/msxml3/domdoc.c:518: undefined reference to `xmlDocGetRootElement' domdoc.o(.text+0x1457): In function `doread': /usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/msxml3/domdoc.c:671: undefined reference to `xmlParseMemory' main.o(.text+0x77): In function `DllMain': /usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/msxml3/main.c:54: undefined reference to `xmlCleanupParser' main.o(.text+0x88):/usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/ msxml3/main.c:48: undefined reference to `xmlInitParser' node.o(.text+0x21e): In function `xmlnode_Release': /usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/msxml3/node.c:128: undefined reference to `xmlFreeDoc' nodemap.o(.text+0x388): In function `xmlnodemap_getNamedItem': /usr/src/wine/wine-build2/dlls/msxml3/../../../wine/dlls/msxml3/nodemap.c:158: undefined reference to `xmlHasNsProp' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [msxml3.dll.so] Fehler 2 make[2]: Leaving directory `/usr/src/wine/wine-build2/dlls/msxml3' make[1]: *** [msxml3] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build2/dlls' make: *** [dlls] Fehler 2 My installed xml rpm are: libxml2-2.5.10-36 libxml-1.8.17-372 libxml2-devel-2.5.10-36 Bye Stefan

2 6

Winecfg and port access
by Christian Schmitz Aug. 12, 2005

Aug. 12, 2005

Hi all: I am using TopMax software (a chip programmer) with old wine version (with config file). I try the new wine but i not find where grant the FULL parallel port access to the TopMax program Where is the new config file for touch manually? or How i can make for grant port access (standard 378-37f) Thanks in advance Christian Schmitz -- En un mundo sin fronteras.... ¿Quién necesita Puertas y Ventanas? EN INGLES: In a world without frontiers, who needs Gates and Windows

2 1

Re: [DSHOW] Beginning of winestreambase lib (take 2)
by Christian Costa Aug. 12, 2005

Aug. 12, 2005

Christian Costa wrote: > > Hi, > > This time, with winestrmbase renamed to winestreambase as suggested by > Dimi. > > Changelog: > Add winestreambase library and make quartz use it. > > Christian Costa titan.costa(a)wanadoo.fr > This patch has not be applied yet. Is there anything wrong with it? I was also considering turning it into a dll rather than a static lib. Do you think it's a good idea? Christian

2 2

wine functions in chroot?
by Fabio Duarte Vilas Boas Aug. 12, 2005

Aug. 12, 2005

wine functions in chroot? _______________________________________________________ Yahoo! Acesso Grátis - Internet rápida e grátis. Instale o discador agora! http://br.acesso.yahoo.com/

2 1