- Wine-Devel - list.winehq.org

Re: Fix Using DDraw to Access the Desktop
by Christian Costa Aug. 4, 2005

Aug. 4, 2005

Hi Rob (and Lionel), While debugging a game where there is the same problem, I did exactly the same fix. However, although this works, it is horribly slow. Do you have the same issue? Maybe this is the reason this was commented out. I wonder if SYNC_UPDATE and OWN_WINDOW stuff has been written to workaround this. There is not comment about that and the code is from transgaming and rather old so I don't know. Lionel do you remember something about that? Robert Shearman wrote: > Hi, > > Previously, using ddraw to write to a small area of the desktop (or > even none at all) would cause the screen to go black because the > contents of the screen wasn't copied to the surface before the surface > was copied back to the screen. This patch fixes that. > > Changelog: > Copy the current contents of the DC to the surface on locking so that > when it is used to write to the desktop then the previous contents > plus the updates are correctly written out. > >------------------------------------------------------------------------ > >Index: dlls/ddraw/surface_user.c >=================================================================== >RCS file: /home/wine/wine/dlls/ddraw/surface_user.c,v >retrieving revision 1.1 >diff -u -p -r1.1 surface_user.c >--- dlls/ddraw/surface_user.c 5 Jun 2005 17:50:49 -0000 1.1 >+++ dlls/ddraw/surface_user.c 25 Jul 2005 14:45:32 -0000 >@@ -47,6 +47,7 @@ static void User_destroy_own_window(IDir > static DWORD CALLBACK User_update_thread(LPVOID); > #endif > static void User_copy_to_screen(IDirectDrawSurfaceImpl* This, LPCRECT rc); >+static void User_copy_from_screen(IDirectDrawSurfaceImpl* This, LPCRECT rc); > > static HWND get_display_window(IDirectDrawSurfaceImpl* This, LPPOINT pt); > >@@ -224,10 +225,8 @@ static void User_DirectDrawSurface_wait_ > void User_DirectDrawSurface_lock_update(IDirectDrawSurfaceImpl* This, > LPCRECT pRect, DWORD dwFlags) > { >-#if 0 > if (!(dwFlags & DDLOCK_WRITEONLY)) > User_copy_from_screen(This, pRect); >-#endif > if (dwFlags & DDLOCK_WAIT) User_DirectDrawSurface_wait_update(This); > > if (pRect) { >@@ -594,7 +593,6 @@ static void User_copy_to_screen(IDirectD > } > } > >-#if 0 > static void User_copy_from_screen(IDirectDrawSurfaceImpl* This, LPCRECT rc) > { > if (This->surface_desc.ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) >@@ -603,6 +601,13 @@ static void User_copy_from_screen(IDirec > HWND hDisplayWnd = get_display_window(This, &offset); > HDC hDisplayDC = GetDC(hDisplayWnd); > RECT drawrect; >+ HDC hSurfaceDC; >+ >+ if (FAILED(This->get_dc(This, &hSurfaceDC))) >+ { >+ ReleaseDC(hDisplayWnd, hDisplayDC); >+ return; >+ } > > drawrect.left = 0; > drawrect.right = This->surface_desc.dwWidth; >@@ -611,7 +616,7 @@ static void User_copy_from_screen(IDirec > if (rc) > IntersectRect(&drawrect,&drawrect,rc); > >- BitBlt(This->hDC, >+ BitBlt(hSurfaceDC, > drawrect.left, drawrect.top, > drawrect.right-drawrect.left, drawrect.bottom-drawrect.top, > hDisplayDC, >@@ -621,7 +626,6 @@ static void User_copy_from_screen(IDirec > ReleaseDC(hDisplayWnd, hDisplayDC); > } > } >-#endif > > static const IDirectDrawSurface7Vtbl User_IDirectDrawSurface7_VTable = > { > >

1 0

threats from MS over Wine's CD/DVD recognition??
by johan kdks Aug. 4, 2005

Aug. 4, 2005

My friend has a Linux PC and when he inserts a CD or DVD, it popups up the cover art automatically and displays all sorts of extended data, like the actors in the film, the studio that released the cd, etc. And we tried 100 or so discs and it recognized every one perfectly, just as good as Windows XP Media Center does, and it even seems to cache the entries since the 2nd time you insert the disc the recognition is instant (first time takes a few seconds). None of the other Linux media players I've used do this--they all use freedb which doesn't work for DVD's, doesn't have extended attributes, and doesn't display any cover art. I've been poking around all day to figure out how it's done. Someone said it seems this Linux project is pulling the data from Microsoft's Windows media server, like XP MC. If that's true, I'm sure Bill isn't too happy. But anyway I figured that code must have been lifted from Wine--part of your "emulation". But I've been digging into Wine and it seems Wine doesn't do this either, at least not anymore. In fact it's conspicuously missing since Wine is a Windows emulator, and under Windows you put a movie in the drive and see the cover art and all the info on the disc, and with Wine you don't. Was this in Wine at some point, and then got yanked because of threats from Microsoft? I actually see no reference to it anywhere. If it's another one of those modules like libdvdcss that every needs to have, but nobody wants to host, it's buried so far underground I can't find it. If Plutohome.org is going to have to pull it soon, somebody should mirror that stuff soon so it doesn't get lost. -- _______________________________________________ NEW! Lycos Dating Search. The only place to search multiple dating sites at once. http://datingsearch.lycos.com

3 2

ownerdraw paint recursion in listbox
by Alexander Yaworsky Aug. 4, 2005

Aug. 4, 2005

Hello, recently i tried to install some application and it hung when i tried to select options. It uses listbox with ownerdraw items with checkboxes. When listbox is initially painted everything is ok. But when i try to select other item, an extra WM_PAINT is sent to listbox when application draws item. This causes infinite recursion. I've been implemented a simple workaround adding boolean to listbox structure but i have doubts. I briefly looked at some other controls and had not noticed similar countermeasures. Have somebody ever seen such behaviour? It would be interesting to test other controls sending WM_PAINT from ownerdraw handler but i'm short of time to do it soon. Should this workaround implemented in this way or something is wrong deeper with WM_PAINT handling? Thanks.

2 7

x11drv glx deadlocks.
by Oliver Stieber Aug. 3, 2005

Aug. 3, 2005

Hi, Somewhere between 20-07-2005 and 26-07-2005 I've been getting deadlocks when I call some glx functions e.g. glXMakeCurrent, I've tracked to problem down to a deadlock, prior to calling glXMakeCurrent wined3d calls wine_tsx11_lock_ptr, but the call to glXMakeCurrent is raising an event in x11drv on a different thread that then tries to call wine_tsx11_lock_ptr, resulting in a deadlock. I've looked through the patches send in between 20-07-2005 and 26-07-2005 but nothing looked obvious. Should I be calling wine_tsx11_lock_ptr before glXMakeCurrent? or should I try to find out what patch caused the problem? ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

2 2

fr-025
by Andreas Schneider Aug. 3, 2005

Aug. 3, 2005

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, fr-25 doesn't display only a white bar in the middle. You can see the "demo" on the top, where normally a black bar is. And in the middle you se some colored vertical stripes. fixme:d3d:IWineD3DDeviceImpl_SetRenderState (0x403b50a0)->(161,1) not handled yet fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 fixme:d3d:IWineD3DStateBlockImpl_Apply Unrecognized state block type 0 This is the output which loops. -- andreas - -- http://www.linux-gamers.net - your online gaming resource -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFC8NmVf94+j/M+P8YRAr3VAJ9QNCaK/vjcE53NQXi3+BqeFoIIQgCff//3 6ytQscKf03IRxeSIRSoDDiM= =Ov44 -----END PGP SIGNATURE-----

2 1

WRT: Links and Timeout
by Detlef Riekenberg Aug. 3, 2005

Aug. 3, 2005

Hi Francois and Paul. On the WRT-Page "http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php", the link for "current status of Wine's conformance tests" is dead ("http://fgouget.free.fr/wine/tests-en.shtml"). Do you think, some Download-Links to "http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/" and "winetest-latest.exe" / "winetest-latest.exe.sig" on the main WRT-Page are useful ? winetest-latest.exe hung on my machine wine with a MessageBox ("\wrt/ddraw_test.exe ddrawmodes" timed out) while the console gave me: -- cut -- fixme:ddraw:Main_DirectDraw_SetCooperative Level (0x7bc3d0c0)->(000b0044,00000051) fixme:xrandr:X11DRV_XRandR_SetCurrentMode Cannot change screen BPP from 32 to 16 fixme:xrandr:X11DRV_XRandR_SetCur rentMode Cannot change screen BPP from 32 to 16 fixme:xrandr:X11DRV_XRandR_SetCur rentMode Cannot change screen BPP from 32 to 16 fixme:xrandr:X11DRV_XRandR_SetCur rentMode Cannot change screen BPP from 32 to 16 fixme:ddraw:Main_DirectDraw_SetCo operativeLevel (0x7bc3d0c0)->(000 b0044,00000051) -- cut -- - copied from the console with line-splitting - the forward-slash in the MessageBox looks not like windows :-) My Desktop-Menu (Gnome 2.10.0 / Ubuntu 5.04) moved from the left edge to the right half of the Desktop-Menubar during the Test. (xorg 6.8.2-10 with nvidia-glx 1.0.7174-0ubuntu1 at 1152*864/32) -- By By ... ... Detlef

3 4

Re: DSOUND: prevent assertion in mixer.c
by Felix Nawothnig Aug. 3, 2005

Aug. 3, 2005

Alex Villacís Lasso wrote: > wine-pthread: mixer.c:386: DSOUND_MixInBuffer: Assertion > `adjusted_remainder >= 0' failed. > wine: Unhandled exception (thread 000a), starting debugger... > WineDbg starting on pid 0x8 I guess this is preluded by some "length not a multiple of block size" errors? I've been experiencing those errors with the same failed assertion in another game and came up with a similar patch but didn't submit since I think this just hides another bug as it should *not* happen that buf_mixpos becomes greater than buflen (and this >= above should probably be ==) at any time. IMHO you should at least add an ERR to that branch. > --- wine-20050725-cvs/dlls/dsound/mixer.c 2005-06-21 04:43:29.000000000 -0500 > +++ wine-20050725-cvs-patch/dlls/dsound/mixer.c 2005-08-01 02:16:42.000000000 -0500 > @@ -491,6 +491,7 @@ > if (dsb->leadin && (dsb->startpos <= dsb->buf_mixpos)) > dsb->leadin = FALSE; /* HACK: see above */ > } > + else dsb->buf_mixpos = 0; /* %= dsb->buflen; */ And shouldn't it be "%= dsb->buflen;"? I'd think that this causes looping until new stuff is mixed in... Felix

2 4

Re: Move Win16 relay messages to the relay16 channel
by Marcus Meissner Aug. 3, 2005

Aug. 3, 2005

On Mon, Aug 01, 2005 at 01:57:27PM +0100, Richard Cohen wrote: > Changelog: > Move Win16 relay messages to their own channel (relay16) Why? Ciao, Marcus

5 12

Benchmark's on the Wiki
by Tom Wickline Aug. 3, 2005

Aug. 3, 2005

Hello, I put the Benchmark results that I posted to wine-devel back in April on the Wiki. http://wiki.winehq.org/BenchMark I would appreciate any constitutive criticism to improve this page. Tom

14 35

Re: Remove Win16 CurrentDirectory hack
by Alexandre Julliard Aug. 3, 2005

Aug. 3, 2005

Richard Cohen <richard(a)daijobu.co.uk> writes: > The Win32 CurrentDirectory is more likely to be correct, and this > fixes some Win16 installers. No it's not correct, the current directory needs to be per-task for Win16 apps. -- Alexandre Julliard julliard(a)winehq.org

2 1