- Wine-Devel - list.winehq.org

Re: [PATCH v2 7/8] ntoskrnl: Set device ContainerID from driver
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118793 Your paranoid android. === debian11 (32 bit report) === ntoskrnl.exe: driver_pnp.c:703: Test failed: Got 1 remove events.

1 0

Re: [PATCH 1/1] po: Update Dutch translation
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118786 Your paranoid android. === debian11 (build log) === error: patch failed: po/nl.po:16050 Task: Patch failed to apply === debian11 (build log) === error: patch failed: po/nl.po:16050 Task: Patch failed to apply

1 0

Re: [PATCH v2 5/8] imm32: Don't allow disabling other thread's IME by thread ID.
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118782 Your paranoid android. === w1064_2qxl (64 bit report) === imm32: imm32.c:1351: Test failed: Expected no IME windows

1 0

[tools] testbot/web: Directly report multiple special job errors using AddError().
by Francois Gouget July 12, 2022

July 12, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/admin/SpecialJobs.pl | 36 +++++++++++--------------------- 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/testbot/web/admin/SpecialJobs.pl b/testbot/web/admin/SpecialJobs.pl index d8294c1aaf..066c41be33 100644 --- a/testbot/web/admin/SpecialJobs.pl +++ b/testbot/web/admin/SpecialJobs.pl @@ -158,7 +158,6 @@ sub OnSubmit($) { my ($self) = @_; my $VMKey; - my @Errors = (); # Update Build VMs $VMKey = $self->{JobTemplates}->{Build}->{VMKey}; @@ -166,9 +165,8 @@ sub OnSubmit($) { $VMKey = undef if ($VMKey eq "*All Build VMs"); my $VMs = GetReconfigVMs($VMKey, "build"); - push @Errors, "Found no build VM to update" if (!@$VMs); - my $ErrMessage = AddReconfigJob($VMs, $VMKey, "build"); - push @Errors, $ErrMessage if (defined $ErrMessage); + $self->AddError("Found no build VM to update") if (!@$VMs); + $self->AddError(AddReconfigJob($VMs, $VMKey, "build")); } # Run 32 bit WineTest @@ -183,9 +181,8 @@ sub OnSubmit($) foreach my $BaseJob (@BaseJobs) { my $VMs = GetWindowsTestVMs($VMKey, "exe32", $BaseJob); - push @Errors, "Found no $BaseJob VM to run WineTest on" if (!@$VMs); - my $ErrMessage = AddWindowsTestJob($VMs, $VMKey, "exe32", $BaseJob, "winetest-latest.exe"); - push @Errors, $ErrMessage if (defined $ErrMessage); + $self->AddError("Found no $BaseJob VM to run WineTest on") if (!@$VMs); + $self->AddError(AddWindowsTestJob($VMs, $VMKey, "exe32", $BaseJob, "winetest-latest.exe")); } } @@ -201,9 +198,8 @@ sub OnSubmit($) undef; $VMKey = undef if ($VMKey eq "*All Base and WineTest VMs"); my $VMs = GetWindowsTestVMs($VMKey, "exe64", $BaseJob); - push @Errors, "Found no 64 bit VM to run WineTest on" if (!@$VMs); - my $ErrMessage = AddWindowsTestJob($VMs, $VMKey, "exe64", $BaseJob, "winetest64-latest.exe"); - push @Errors, $ErrMessage if (defined $ErrMessage); + $self->AddError("Found no 64 bit VM to run WineTest on") if (!@$VMs); + $self->AddError(AddWindowsTestJob($VMs, $VMKey, "exe64", $BaseJob, "winetest64-latest.exe")); } # Update Wine VMs @@ -212,9 +208,8 @@ sub OnSubmit($) { $VMKey = undef if ($VMKey eq "*All Wine VMs"); my $VMs = GetReconfigVMs($VMKey, "wine"); - push @Errors, "Found no Wine VM to update" if (!@$VMs); - my $ErrMessage = AddReconfigJob($VMs, $VMKey, "wine"); - push @Errors, $ErrMessage if (defined $ErrMessage); + $self->AddError("Found no Wine VM to update") if (!@$VMs); + $self->AddError(AddReconfigJob($VMs, $VMKey, "wine")); } # Run WineTest on Wine @@ -223,21 +218,14 @@ sub OnSubmit($) { $VMKey = undef if ($VMKey eq "*All Wine VMs"); my $VMs = GetWineTestVMs($VMKey); - push @Errors, "Found no Wine VM to run WineTest on" if (!@$VMs); - my $ErrMessage = AddWineTestJob($VMs, $VMKey); - push @Errors, $ErrMessage if (defined $ErrMessage); + $self->AddError("Found no Wine VM to run WineTest on") if (!@$VMs); + $self->AddError(AddWineTestJob($VMs, $VMKey)); } # Notify engine - my $ErrMessage = RescheduleJobs(); - push @Errors, $ErrMessage if (defined $ErrMessage); - - if (@Errors) - { - $self->AddError(join("\n", @Errors)); - return undef; - } + $self->AddError(RescheduleJobs()); + return undef if ($self->GetErrMessage()); exit($self->Redirect("/")); } -- 2.30.2

1 0

[tools] testbot/cgi: Report all of a form's invalid fields at once.
by Francois Gouget July 12, 2022

July 12, 2022

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index c299d54b4a..d6ded1b07b 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -599,6 +599,7 @@ sub Validate($) { my ($self) = @_; + my $Ret = 1; foreach my $PropertyDescriptor (@{$self->GetPropertyDescriptors()}) { my $Value = $self->GetParam($PropertyDescriptor->GetName()); @@ -606,11 +607,11 @@ sub Validate($) if ($ErrMessage) { $self->AddError($ErrMessage, $PropertyDescriptor->GetName()); - return !1; + $Ret = !1; } } - return 1; + return $Ret; } sub SaveProperty($$$) -- 2.30.2

1 0

[tools] testbot/web: Highlight both the 32 and 64-bit checkboxes in case of error.
by Francois Gouget July 12, 2022

July 12, 2022

The comment was wrong since the code explicitly checks that both ShowRun32 and ShowRun64 are true. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/Submit.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index 4368aeeb30..2e6c3cc7fb 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -410,8 +410,7 @@ sub Validate($) !$self->{Run32} and $self->{ShowRun32} and !$self->{Run64} and $self->{ShowRun64}) { - # Don't set ErrField since Run32 and Run64 may be hidden - $self->AddError("You must at least pick one of the 32 or 64 bit tests to run on the selected Windows VMs."); + $self->AddError("You must at least pick one of the 32 or 64 bit tests to run on the selected Windows VMs.", "Run32", "Run64"); return undef; } -- 2.30.2

1 0

Re: [PATCH 6/7] ntoskrnl: Set device ContainerID from driver
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118767 Your paranoid android. === debian11 (32 bit report) === ntoskrnl.exe: driver_pnp.c:703: Test failed: Got 1 remove events.

1 0

Re: [PATCH v2 2/2] win32u/window: Ignore SetWindowPos() for message-only windows.
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118755 Your paranoid android. === w10pro64 (32 bit report) === user32: win.c:4558: Test failed: hwnd 00020266/00020266 message 0200 win.c:4563: Test failed: hwnd 00020266/00020266 message 0203 win.c:4567: Test failed: message 0202 available === w10pro64_en_AE_u8 (64 bit report) === user32: win.c:4558: Test failed: hwnd 0000000000BA0324/0000000000BA0324 message 0200 win.c:4563: Test failed: hwnd 0000000000BA0324/0000000000BA0324 message 0203 win.c:4567: Test failed: message 0202 available === debian11 (32 bit report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered === debian11 (32 bit French report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered === debian11 (32 bit Hebrew:Israel report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered === debian11 (32 bit Chinese:China report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered === debian11 (32 bit WoW report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered === debian11 (64 bit WoW report) === user32: win.c:8906: Test failed: WM_KILLFOCUS message was delivered

1 0

Re: [PATCH v2 1/2] user32/tests: Check that a message window brought topmost does not defocus other windows.
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118754 Your paranoid android. === w1064_adm (64 bit report) === user32: win.c:2688: Test failed: style 0x200000: expected !100 win.c:2688: Test failed: style 0x300000: expected !100 === debian11 (32 bit report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Arabic:Morocco report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit German report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit French report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Hebrew:Israel report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Hindi:India report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Japanese:Japan report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Chinese:China report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit WoW report) === user32: win.c:9332: Test failed: Expect width 100, got 1030. win.c:9333: Test failed: Expect height 100, got 743. win.c:8936: Test failed: Last error unexpectedly set to 0 === debian11 (64 bit WoW report) === user32: win.c:8936: Test failed: Last error unexpectedly set to 0

1 0

Re: [PATCH 1/1] dlls/ddraw/tests: fix missing bits from long type conversion
by Marvin July 12, 2022

July 12, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118746 Your paranoid android. === w8adm (32 bit report) === ddraw: ddraw7.c:18873: Test failed: Got unexpected color 0x00000040. === w1064v1809 (32 bit report) === ddraw: ddraw7.c:18873: Test failed: Got unexpected color 0x00000040.

1 0