- Wine-Devel - list.winehq.org

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests
by Paul Vriens June 30, 2005

June 30, 2005

>> ChangeLog: Fix bug that left mouse buttons swapped after tests >> >> Ivan. > > I think your patch causes test to fail on Wine, Ivan. My try goes next. > > > ChangeLog: > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > - Break from the loop to restore SM_SWAPBUTTON metrics. > - SetLastError() to see if restoration changes it. > > > Index: dlls/user/tests/sysparams.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/tests/sysparams.c,v > retrieving revision 1.38 > diff -p -u -r1.38 sysparams.c > --- dlls/user/tests/sysparams.c 20 Jun 2005 15:36:17 -0000 1.38 > +++ dlls/user/tests/sysparams.c 30 Jun 2005 07:36:40 -0000 > @@ -1011,7 +1011,7 @@ static void test_SPI_SETMOUSEBUTTONSWAP( > rc=SystemParametersInfoA( SPI_SETMOUSEBUTTONSWAP, vals[i], 0, > SPIF_UPDATEINIFILE | SPIF_SENDCHANGE ); > if (!test_error_msg(rc!=vals[i],"SPI_{GET,SET}MOUSEBUTTONSWAP")) > - return; > + break; It's nice to break but the the end-result will be that the test fails on all windows versions I could my hands on and that the previous setting is restored. Not very useful it seams. Cheers, Paul.

2 1

Question about deadlock in winmm
by Vitaliy Margolen June 30, 2005

June 30, 2005

Lately I'm seeing a lot of deadlocks in wine's sound system. Most notably winealsa. But the code in question affects all (in my case oss since it's working better for me then others). I'm not sure what exactly happens (deadlock because of race condition or else) but code bellow deadlocks with other heap functions (like GetHeap). Removing HeapValidate didn't cause any problems for as of yet. And I haven't seen a single deadlock here at all. Is there are reasons we perform this heap validation here? Could someone comment on this? If someone interested I could reproduce backtrace of the deadlock. -- Best regards, Vitaliy Index: dlls/winmm/lolvldrv.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/lolvldrv.c,v retrieving revision 1.68 diff -u -p -r1.68 lolvldrv.c --- dlls/winmm/lolvldrv.c 22 Jun 2005 11:59:43 -0000 1.68 +++ dlls/winmm/lolvldrv.c 29 Jun 2005 14:54:42 -0000 @@ -441,7 +441,7 @@ LPWINE_MLD MMDRV_Get(HANDLE _hndl, UINT hndl = hndl & ~0x8000; if (hndl < sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0])) { mld = MM_MLDrvs[hndl]; - if (!mld || !HeapValidate(GetProcessHeap(), 0, mld) || mld->type != type) + if (!mld || mld->type != type) mld = NULL; } hndl = hndl | 0x8000;

1 0

Re: Fix ntdll compilation in Darwin
by Dmitry Timoshkov June 30, 2005

June 30, 2005

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > Index: dlls/ntdll/cdrom.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v > retrieving revision 1.59 > diff -p -u -r1.59 cdrom.c > --- dlls/ntdll/cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 > +++ dlls/ntdll/cdrom.c 30 Jun 2005 11:27:41 -0000 > @@ -75,6 +75,11 @@ > # include <sys/scsiio.h> > #endif > > +#ifdef __APPLE__ > +# include <IOKit/IOKitLib.h> > +# include <IOKit/scsi/SCSICmds_REQUEST_SENSE_Defs.h> > +#endif > + > #define NONAMELESSUNION > #define NONAMELESSSTRUCT > #include "ntstatus.h" > @@ -1418,6 +1423,8 @@ static NTSTATUS CDROM_ScsiPassThroughDir > > #ifdef SENSEBUFLEN > if (pPacket->SenseInfoLength > SENSEBUFLEN) > +#elif defined( __APPLE__ ) > + if (pPacket->SenseInfoLength > kSenseDefaultSize) > #else > if (pPacket->SenseInfoLength > sizeof(struct request_sense)) > #endif Please do not introduce even more platform dependent #ifdefs into cdrom.c, currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/ (__NetBSD__). Add proper configure checks for headers and structures your platform needs. -- Dmitry.

2 2

Delays in FileOpen
by Uwe Bonnes June 30, 2005

June 30, 2005

Hallo (Michael?), File Open Dialogs for me have some noticable initial delay when starting up. For example, try in internet explorer "Save under". I don't remember seeing that delay some time before. Dif recent shfolder changes cause that delay? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests
by Ivan Leo Puoti June 30, 2005

June 30, 2005

Saulius Krasuckas wrote: >>ChangeLog: Fix bug that left mouse buttons swapped after tests >> >>Ivan. > > > I think your patch causes test to fail on Wine, Ivan. My try goes next. Maybe that isn't a bad thing, the results from the latest build of winetest shows this test fails on windows 2000, windows nt, windows me, and windows 98se, so I somewhat doubt the wine behaviour is correct. Ivan.

2 1

Fwd: Anybody looking for a pet Wine project?
by Vijay Kiran Kamuju June 30, 2005

June 30, 2005

---------- Forwarded message ---------- From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Jun 30, 2005 3:42 PM Subject: Re: Anybody looking for a pet Wine project? To: Mike McCormack <mike(a)codeweavers.com> typelib info of hhctrl.ocx of winxp (used pe explorer) -------------------------------------------------------------------------- //HHCtrl 4.0 Type Library //Version: 4.0 HHCTRLLib; GUID = {ADB880A2-D8FF-11CF-9377-00AA003B7A11}; //Event interface for HHCtrl Dispatch _HHCtrlEvents; GUID = {ADB880A3-D8FF-11CF-9377-00AA003B7A11}; function Click(out ParamString: BSTR); stdcall; //HHCtrl Class CoClass HHCtrl; GUID = {52A2AAAE-085D-4187-97EA-8C30DB990436}; //IHHCtrl Interface Dispatch IHHCtrl; GUID = {ADB880A1-D8FF-11CF-9377-00AA003B7A11}; function QueryInterface(riid: ^GUID; out ppvObj: ^^VOID); stdcall; function AddRef: UI4; stdcall; function Release: UI4; stdcall; function GetTypeInfoCount(out pctinfo: ^UINT); stdcall; function GetTypeInfo(itinfo: UINT; lcid: UI4; out pptinfo: ^^VOID); stdcall; function GetIDsOfNames(riid: ^GUID; rgszNames: ^^I1; cNames: UINT; lcid: UI4; out rgdispid: ^I4); stdcall; function Invoke(dispidMember: I4; riid: ^GUID; lcid: UI4; wFlags: UI2; pdispparams: ^DISPPARAMS; out pvarResult: ^Variant; out pexcepinfo: ^EXCEPINFO; out puArgErr: ^UINT); stdcall; property-put Image(: BSTR); stdcall; property-get Image: BSTR; stdcall; //Click method function Click; stdcall; //Click method function HHClick; stdcall; //Print method function Print; stdcall; //syncURL method function syncURL(out pszUrl: BSTR); stdcall; //TCard method function TCard(out wParam: UINT_PTR; out lParam: LONG_PTR); stdcall; //Text Popup method function TextPopup(out pszText: BSTR; out pszFont: BSTR; out horzMargins: INT; out vertMargins: INT; out clrForeground: UI4; out clrBackground: UI4); stdcall; Alias UINT_PTR; UI4 Alias LONG_PTR; I4 //Deprecated HHCtrl Class 2 CoClass OldHHCtrl2; GUID = {41B23C28-488E-4E5C-ACE2-BB0BBABE99E8}; //Deprecated HHCtrl Class 1 CoClass OldHHCtrl1; GUID = {ADB880A6-D8FF-11CF-9377-00AA003B7A11}; On 6/30/05, Mike McCormack <mike(a)codeweavers.com> wrote: > > Hi All, > > If anybody is looking for a small project, I've got just the thing for you! > > hh.exe and hhctrl.ocx are two components of the Microsoft HTML help > engine. hh.exe is a small wrapper around hhctrl.ocx, which is the HTML > help viewer. > > hhctrl.ocx embeds IE and feeds it HTML documents decoded from .chm files > with itss.dll (the Infotech storage system). Implementing hhctrl.ocx > would make an excellent test case for IE embedding that Jacek is working > on, and for itss.dll. > > So most of the components are already in place (or will be soon) to make > HTML help work... any takers to fill in the dots? > > The reward is, like most of Wine code, to say "I made that work" :) > > Let me know if you're interested. > > Mike > > >

1 0

Using ReactOS Registry format
by James Liggett June 30, 2005

June 30, 2005

Brad, Last night Martin Fuchs suggested that we look into using ReactOS's registry format in order to be compatible with Windows registry databases. I have the latest release of ReactOS running on QEMU on my box, so I checked it out. Basically, they're using the same regedit program from Wine, missing find command and all (Which I too feel is a pain in the neck). I looked at the config stuff, and I found what looked like some binary database files for each of the main registry sections. Unfortunately, there's no documentation at all on any of this on their website. If we decide to go this route, we may be in for a hell of a lot of work. But, I do agree with all of your points. I think the current system could use some improvement, especially in the area of searching. Let me know what you think of all this. Kind Regards, James Liggett

8 11

Re: [MSXML] : add declarations for XMLDOM
by Mike McCormack June 30, 2005

June 30, 2005

Hi Vijay, Vijay Kiran Kamuju wrote: > I am sending a new patch for th XMLDOM stuff > ChangeLog > ---------------- > add definitions and declarations for XMLDOM stuff Thanks for sending the patch in. After looking through it, here are my notes: * try cut it up into small bits, the smaller the better. Alexandre checks every line before applying a patch, so if you reduce the size of you patches, you'll reduce Alexandre's work and increase the chance that they go into Wine. So I'd suggest cut this patch up into two patches, one to add the DISPIDs and one to add the interface code. * you should add your own copyright line, instead of adding to the end of mine. eg. * Copyright (C) 2005 Mike McCormack * Copyright (c) 2005 Vijay Kiran Kamuju looks like good, Mike

1 0

Re: Fix libGL.a check on configure
by Alexandre Julliard June 30, 2005

June 30, 2005

Anderson Lizardo <andersonlizardo(a)yahoo.com.br> writes: > Hi, > > Changelog: > > Fixed the libGL.a configure check for systems where > /usr/X11R6/lib/libGL.so is a symbolic link. > > > PS.: I've not used a simple "test -e" because > http://www.winehq.org/hypermail/wine-patches/2002/01/0206.html says this > does not work on Solaris. My guess is that if test -e doesn't work, test -L won't work either... -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: ntdll: Fix add_access_ace
by Mike McCormack June 29, 2005

June 29, 2005

Hi James, James Hawkins wrote: > These changes make the advapi32 tests pass as well. > > Changelog > * Fix calculation of generic pointers. > * Minor cleanups. Thanks for the fixes. This makes Office 2003 work again for me. > if ((DWORD)(pAceHeader + dwAceSize) > (DWORD)(pAcl + pAcl->AclSize)) > return STATUS_ALLOTTED_SPACE_EXCEEDED; I think you might have missed one here. The above pointer arithmetic seems like it will make the wrong calculation. Maybe something like the following would work better: if ( &((char*)pAceHeader)[dwAceSize] > &((char*)pAcl)[pAcl->AclSize] ) Mike

1 0