- Wine-Devel - list.winehq.org

Re: shell32: fix infinite loop in SHGetPathFromIDListW
by Vitaliy Margolen June 25, 2005

June 25, 2005

Thank you. This patch does fix the infinite loop bug. Vitaliy Margolen Saturday, June 25, 2005, 5:14:27, Michael Jung wrote: > Hi, > With a seemingly unrelated change in his local tree Vigaliy Margolen triggered > an infinite loop in SHGetPathFromIDList (which was introduced by one of my > patches): > SHGetPathFromIDList (pidl.c:1256) calls SHBindToParent, which calls Desktop->>BindToObject (pidl.c:1315), which calls SHELL32_BindToChild > (shfldr_desktop.c:348), which binds to MyComputer (shlfolder.c:289) and then calls MyComputer->>BindToObject (shlfolder.c:314), which calls > SHELL32_BindToChild (shfldr_mycomp.c:346), which calls > SHELL32_GetCustomFolderAttribute (shlfolder.c:299), which calls > SHGetPathFromIDList (shlfolder.c:91). Phew. > Since the path is already known in SHELL32_BindToChild, we can break the loop > easily. > I don't understand, why we don't see a stack overflow with wine cvs, but the > size of a +shell log shrinks 90% with this patch applied compared to cvs. So > we do have the loop, but it is terminated somehow before the stack overflows. > Changelog: > Fix a lurking infinite loop in SHGetPathFromIDList. > Bye,

1 0

loop in SHGetPathFromIDList
by Michael Jung June 24, 2005

June 24, 2005

Hi Vitaliy, your patch to shlfolder.c is what produces the loop. It is the line, which I commented out below: if (dwAttributes & FILE_ATTRIBUTE_DIRECTORY) ;//*pdwAttributes |= (SFGAO_FOLDER | SFGAO_HASSUBFOLDER | SFGAO_FILESYSANCESTOR); else *pdwAttributes &= ~(SFGAO_FOLDER | SFGAO_HASSUBFOLDER | SFGAO_FILESYSANCESTOR); It works fine if the line is commented out. I don't understand at the moment why this is the fact, but the loop seems in fact to be a problem with SHGetPathFromIDList. I didn't figure it out tonight, but I will investigate this further over the weekend. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

X11 -- how do you prevent window from closing if user closes it
by Peter Quiring June 24, 2005

June 24, 2005

I trying to use X11 and let's say I create a text editor. Let's say the user is using the text editor, makes some changes and then clicks on the [X] to close the window before saving changes. I want to popup a "are you sure" before the window is closed but X11 doesn't allow this. How does Wine go about this problem? In Windows this is easy, in the WindowProc() just ignore WM_CLOSE. FYI :Porting some code over to Linux and need a little help. Thanks.

3 2

Re: cabinet.dll status ?
by Gerold J. Wucherpfennig June 24, 2005

June 24, 2005

On Friday 24 June 2005 14:32, Tom Wickline wrote: > Hello Gerold, > > I currently list cabinet.dll at 80% completion can you let me know > what you feel > the current status should be? > > Would you like for me to add you as the current worker? I just looked > through CVS and seem to be the main developer now for cabinet.dll > > http://www.winehq.org/site/status_dlls > > Thanks, > Tom Hi Tom, I thank you very much for asking me about cabinet.dll. :) I would really like to be added as the current worker. :) My personal opinion about the completition status, not specifically about cabinet.dll, is that the status should be roughly equal to the amount of code that is implemented compared to the 100% of code . Right now the status based on the percieved amount of usage of the respective API functions. That of course is a bit optimistic, because API functions that are used most will be implemented first and the amount of work that is required to complete the remaining API functions may be underestimated. Regarding cabinet.dll: circa half of the required code and half of the required functions is in CVS right now. Nevertheless I think that you should keep the current completition status as it is right now, because first it would look strange when the status would decrease and second I hope that my current patch will be committed soon which will put the completition status to what it is listed right now. Regards, Gerold

1 0

very old com tech spec doc
by Vijay Kiran Kamuju June 24, 2005

June 24, 2005

very old com tech spec doc. have a look http://www.geocities.com/infyquest/comspec10.zip

1 0

Re: shell32: Implement SHGetPathFromIDList based on GetDisplayNameOf
by Vitaliy Margolen June 24, 2005

June 24, 2005

Alexandre, could you back this patch out? This patch broke shell ParseDisplayName (created call loop) from IShellFolder_ParseDisplayName to SHELL32_ParseNextElement back to IShellFolder_ParseDisplayName Vitaliy Margolen Tuesday, June 14, 2005, 14:08:31, Vitaliy Margolen wrote: > Changelog: > Implement SHGetPathFromIDList based on GetDisplayNameOf > Bye,

2 3

winecfg's registry convience functions
by Michael Jung June 23, 2005

June 23, 2005

I would like to add a checkbox control ("Show host filesystem") to winecfg to allow the user to easily (un-)register the unixfs shell namespace extension. So winecfg would have to query and create/delete the "HKLM\Software\Microsoft\CurrentVersion\Explorer\MyComputer\Namespace\{UNIXFS-CLSID}" key. There are helper functions in winecfg.c to cache registry values for later application, iff the user clicks "Apply" or "Ok". However, those seem to work only for keys rooted at the config key "HKCU\Software\Wine". My question is: Am I doomed to implement the caching on my own for this key, should I generalize the helper functions, or do you think this configuration option should'nt be in winecfg at all? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 7

Cross-compiling with winelib
by Eric Frias June 23, 2005

June 23, 2005

We're working on setting up an environment to cross-compile a winelib application (initially from x86 linux to sparc solaris). To do this, we need a cross-compiling version of winebuild which will generate the assembly code for the target architecture instead of the build architecture. I see two basic ways we can accomplish this. We could either use autoconf's --target flag to specify the target architecture, and then replace all of the "#ifdef __sparc__" statements in winebuild with "#ifdef __target_arch_sparc". I came across an autoconf macro (http://autoconf-archive.cryp.to/ac_create_target_h.html) that would generate the appropriate defines. The other way we could approach the problem is to modify winebuild to always generate assembly code for all of the architectures, pushing the #ifdefs down into the .spec.c file. I'm inclined to stick with the first option, since it looks like less work and less chance of introducing errors, but I wanted to run it by the list before starting work. Would a patch like this be accepted into wine? Do you know of any other gotchas we should be aware of? Thanks, Eric

2 2

Re: COMDLG32: PageSetupDlg improvements
by Alexandre Julliard June 23, 2005

June 23, 2005

Vitaly Lipatov <lav(a)etersoft.ru> writes: > +#define CALLANYPAINTHOOK(msg, wParam, lParam) \ > + (((pda->dlga->Flags & PSD_ENABLEPAGEPAINTHOOK) && \ > + pda->dlga->lpfnPagePaintHook(hWnd,msg,wParam,lParam)) || \ > + PRINTDLG_DefaultPagePaintHook(hWnd,msg,wParam,lParam)) It would be a lot cleaner to always call your DefaultPagePaintHook function and have it call the user's hook first if it's set. > + if (CALLANYPAINTHOOK(WM_PSD_PAGESETUPDLG, MAKELONG(papersize, orientation), (LPARAM)pda)) > + return FALSE; The LPARAM should probably be pda->dlga here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: Implement ImpersonateNamedPipeClient
by Dmitry Timoshkov June 23, 2005

June 23, 2005

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * Implement ImpersonateNamedPipeClient. > @@ -871,9 +871,13 @@ BOOL WINAPI InitializeAcl(PACL acl, DWOR > > BOOL WINAPI ImpersonateNamedPipeClient( HANDLE hNamedPipe ) > { > - FIXME("%p - stub\n", hNamedPipe); > + PIO_STATUS_BLOCK pio = NULL; > > - return FALSE; > + TRACE("(%p)\n", hNamedPipe); > + > + return set_ntstatus( NtFsControlFile(hNamedPipe, NULL, NULL, NULL, pio, > + CTL_CODE(FILE_DEVICE_NAMED_PIPE, 7, METHOD_BUFFERED, FILE_ANY_ACCESS), > + NULL, 0, NULL, 0) ); > } What's the purpose of introducing PIO_STATUS_BLOCK pio if you don't actually use it? -- Dmitry.

1 0