- Wine-Devel - list.winehq.org

Re: advapi32: Implement IsTokenRestricted
by Thomas Weidenmueller June 17, 2005

June 17, 2005

James Hawkins wrote: > I'm not exactly sure whether the LPVOID param of > NtQueryInformationToken should be a BOOLEAN value or a DWORD like > NumRestrictedSids (it isn't documented), but because we just want to > know whether there exists at least one, the BOOLEAN does the trick > until we know how to handle TokenRestrictedSids. TokenRestrictedSids basically returns a TOKEN_GROUPS structure, the first member GroupCount indicates the number of restricted SIDs. Here's how i'd implement it: http://svn.reactos.com/viewcvs/trunk/reactos/lib/advapi32/token/token.c?rev… Best Regards, Thomas

1 0

Re: right shift count warning fixes
by Mike McCormack June 17, 2005

June 17, 2005

Mike McCormack wrote: > > I get 3 warnings, when compiling Wine without any extra -W flags. They > are all of the following kind: > > config.c: In function `init_server_dir': > config.c:125: warning: right shift count >= width of type This occured because I configured wine as follows: CFLAGS="-Werror" ./configure This causes some of the configure tests which produce warnings to fail, and thus misconfigure Wine. Bad idea :) Mike

1 0

winecfg version breakage
by Juan Lang June 17, 2005

June 17, 2005

First post! Now that winecfg writes to the registry (yay!), we can't set the Windows version. winecfg writes the version to HKCU\\Software\\Wine\\Version. ntdll looks for it in HKLM\\Software\\Wine\\Wine\\Config\\Version. Ordinarily I'd just send a patch, but I don't know where the config is supposed to end up when it's all done. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Nested __TRY blocks?
by Juan Lang June 16, 2005

June 16, 2005

Are we allowed to use a __TRY block in a function that's called by a function with its own __TRY block for the same exception? Any other restrictions on __TRY/__EXCEPT I should know about? No returning or gotos out of each block, right? Thanks, --Juan __________________________________ Discover Yahoo! Stay in touch with email, IM, photo sharing and more. Check it out! http://discover.yahoo.com/stayintouch.html

2 1

Windows Icons under konqueror.
by Oliver Stieber June 16, 2005

June 16, 2005

Hi, Quite a while ago I mentioned that I had a plugin for KDE so that the correct icons for windows applications (and the icons in dlls) are displayed in the file explorer. A few people seemed interested so I've put the plugin up on KDE apps. http://www.kde-apps.org/content/show.php?content=25430 ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

1 0

Re: fix some -Wstrict-prototypes warning
by Dimi Paun June 16, 2005

June 16, 2005

> next patch in series to remove -Wstrict-prototypes warnings. Will we be able to ever turn this on by default? If so, how far away are we? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

Re: wine/programs/winecfg x11drvdlg.c winecfg.h wi ...
by Dimi Paun June 16, 2005

June 16, 2005

> Log message: > Fixed registry paths to edit the real config, and removed the startup > warning message. > > Patch: http://cvs.winehq.org/patch.py?id=18225 Joy!!! Way to go Alexandre, this was a long time comming. Glad to see we're within the deadlines :) Brian, now we can update the User Guide too, and get the stuff you wrote some time ago into the official docs. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

bug in winetest gui
by Ivan Leo Puoti June 16, 2005

June 16, 2005

On some systems the tag window is created as modal, but doesn't get focus until the user clicks on the dialogue box or the winetest window. I've found this on windows server 2003 service pack 1, Michael Jung has confirmed this happens on windows server 2003 and windows xp service pack 2. I don't see why Microsoft would change an old and tested function like DialogBoxParam, but something is going wrong. Michael also reported focus stays on the about box in the wine test window, so this windows isn't disabled properly. For some reason I can't get winetest to cross compile here, as I can't try fixing it myself I thought I'd might as well report it. BTW the tag box takes focus correctly on nt 4.0 sp6 Ivan.

3 4

Re: [ntdll/tests/info.c] ProcessBasicInformation
by Felix Nawothnig June 16, 2005

June 16, 2005

Paul Vriens wrote: > Changelog > W2K3 returns STATUS_INVALID_HANDLE instead of STATUS_ACCESS_VIOLATION If no apps depends on it returning STATUS_ACCESS_VIOLATION - should we maybe do this too? Seems more clean to me since we don't actually catch page faults and passing (void*)1 will crash it anyway. Just a thought. -Felix

1 0

SHELL32/tests: trim extraneous backslash (fwd)
by Saulius Krasuckas June 16, 2005

June 16, 2005

Is there something wrong in the patch or should I only resync it to current CVS, as it applies not cleanly: patching file dlls/shell32/tests/shlfileop.c patching file dlls/shell32/tests/shlfolder.c Hunk #1 succeeded at 388 (offset 41 lines). ? ---------- Forwarded message ---------- Date: Wed, 15 Jun 2005 16:34:40 +0300 (EEST) To: wine-patches(a)winehq.org When tests starts in lets say 'C:\', some SHELL32 functions are passed 'C:\\testdir'. Then some f-ns fail, while other start lagging horribly. ChangeLog: Saulius Krasuckas <saulius.krasuckas(a)ieee.org> Trim backslash when current dir is a root of the drive. Index: dlls/shell32/tests/shlfileop.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shlfileop.c,v retrieving revision 1.19 diff -w -p -u -r1.19 shlfileop.c --- dlls/shell32/tests/shlfileop.c 1 Jun 2005 11:04:26 -0000 1.19 +++ dlls/shell32/tests/shlfileop.c 15 Jun 2005 13:29:48 -0000 @@ -64,7 +64,14 @@ BOOL file_exists(const CHAR *name) /* initializes the tests */ void init_shfo_tests(void) { + char *tail; + + /* shouldn't we cd to %TEMP% to don't leave + trash in a case test caughts some exception? */ GetCurrentDirectoryA(MAX_PATH, CURR_DIR); + tail = CURR_DIR + lstrlenA(CURR_DIR) - 1; + if(*tail=='\\') *tail=0; + createTestFile(".\\test1.txt"); createTestFile(".\\test2.txt"); createTestFile(".\\test3.txt"); Index: dlls/shell32/tests/shlfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shlfolder.c,v retrieving revision 1.12 diff -w -p -u -r1.12 shlfolder.c --- dlls/shell32/tests/shlfolder.c 14 Jun 2005 19:18:26 -0000 1.12 +++ dlls/shell32/tests/shlfolder.c 15 Jun 2005 13:29:48 -0000 @@ -347,12 +347,15 @@ START_TEST(shlfolder) { ITEMIDLIST *newPIDL; IShellFolder *IDesktopFolder, *testIShellFolder; + char *tail; char cCurrDirA [MAX_PATH] = {0}; WCHAR cCurrDirW [MAX_PATH]; static const WCHAR cTestDirW[] = {'\\','t','e','s','t','d','i','r',0}; HRESULT hr; GetCurrentDirectoryA(MAX_PATH, cCurrDirA); + tail = cCurrDirA + lstrlenA(cCurrDirA) - 1; + if(*tail=='\\') *tail=0; MultiByteToWideChar(CP_ACP, 0, cCurrDirA, -1, cCurrDirW, MAX_PATH); strcatW(cCurrDirW, cTestDirW);

1 0