- Wine-Devel - list.winehq.org

Re: Optionally map the unix filesystem instead of drive letters into the shell namespace
by Michael Jung June 1, 2005

June 1, 2005

Hi Michael, On Friday 27 May 2005 03:03, Michael Lin wrote: > Just a few things with this approach. > As I mentioned before .. with a global flag in the registry. > User can't run a winelib application with unix path and a Windows > application on Wine with dos path at the same time. Please consider the configure based global flag only an option. That's actually what I said several times. It could be a per application option as well. And there is no problem in activating it via a wine-specific API, which would override the config on a per process basis. > Ok ... I know your approach is base everything on dos path and the > global flag is simply a display mode. > But what about the parsing of the file name editbox in the file dialog? > The user is browsing unix file system, but does the user enter unix or > dos path? > I believe I can modify your solution to accept unix file path, but it > have to accept dos path as well. Modifying shfldr_unixfs to parse unix path in addition to dos paths is trivial: Just remove the (pUnixFolder->m_dwPathMode == PATHMODE_UNIX) test in line 339. The real problem is the test for invalid chars in the filedialog, which '/' is one of. The solution is obvious: If wine is configured to display unix paths, then accept '/' as a valid char in paths in comdlg32. You will have to do this for your solution as well, don't you? > Then there is also the issue of having to have the unix root mapped to a > dos drive. That's true. Actually, we are tackling two slightly different problems here: I would like to have existend applications, for which I don't have the source, to display unix paths instead of dos paths in their file dialogs. So I want MS Office to display unix paths in it's file dialogs. IMHO there is not way to achieve this without the requirement to map one of the dos drives to '/'. At least not if the user should be able to access every file on his filesystem. This solution can also be applied to winelib applications. If you want to use the native posix file functions (which, frankly, I don't see a reason to do, because the user doesn't care how filenames look in the core dump, but only how they look on the screen) then just map the paths coming out of the file dialog to unix with the wine_nt_to_unix_path function. I do understand that there are some shortcomings of this approach for winelib applications, which can not possibly be addressed this way. But it seems equaly obvious to me that your approach can never achieve the goal I laid out above (To make native apps display the unix paths in file dialogs). So perhaps there might be demand for both solutions. Or perhaps I'm totaly off the point and the only person on the planet who likes to see unix paths in his native windows applications on wine. Which would mean your solution might be the only one people are interested in. What I meant to say is, please fell free to implement your solution the way you like it and let the wine community decide on it. But please don't modify shfldr_unixfs in a way that breaks my solution (Conceptually, that is. Bugs, of course, are unavoidable.) > Troy, Alexandre and I have been discussing other possible solutions to > this problem offline. I don't want to offend, but I think this just isn't fair. I have contributed a lot of my free time working on this stuff, and I think I would have deserved to be informed on discussions and decisions in this matter. Above that, this kind of discussion should take place on wine-devel, so that the community at large can take part in it. To me this gives the impression that you avoided discussing it on wine-devel, because you didn't want to be convinced. Sorry. Ok, nuff said, going back to the technological stuff. > One solution I have implemented and waiting on Alexandre's verdict is > the following. > > Create a new library called wineunixfs. All additional entry point > should be in that library. > All exported function call should be of the same signiture as one in the > core library such as GetOpenFileNameA(), GetOpenFileNameW() etc. > To use the library, simply let winelib application link it before all > the other core libraries. > > My Changes to the core libraries are contained within shell32. There is > only one extra exported functions SHUnixFSGetDesktopFolder() being > added. This function return the desktop folder in unix mode. > > Currenlt wineunixfs duplicates filedlg.c, filedlgbrowser.* and their > dependent files from commdlg. > I have attached the diff file for the rest of the changes that's on the > core libraries. I'm not the one to judge, but in my opinion this is pretty heavy weight. Ciao, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 3

Re: Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs
by Robert Shearman June 1, 2005

June 1, 2005

Evan Deaubl wrote: >ChangeLog: > * Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs > > I cleaned up the patch a little. Does this still work for you? Changelog: Evan Deaubl <wine(a)warpedview.com> Robert Shearman <rob(a)codeweavers.com> - Implement RtlGetControlSecurityDescriptor - Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs -- Rob Shearman

2 1

Borland C++ 4.5
by Andrew Neil Ramage May 31, 2005

May 31, 2005

When I tried to install BC++ 4.5, the installation proceeded normally. However, when I clicked "Finish", it trashed my X server, causing the system to stop responding to key presses and the mouse. I could not even kill the X server, and so had to pull the power cord out. Is this a known problem, and will I still be able to use my Development identity ? -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

7 9

Re: wine/dlls/setupapi parser.c
by Robert Shearman May 31, 2005

May 31, 2005

Alexandre Julliard wrote: >Index: wine/dlls/setupapi/parser.c >diff -u -p wine/dlls/setupapi/parser.c:1.15 wine/dlls/setupapi/parser.c:1.16 >--- wine/dlls/setupapi/parser.c:1.15 Tue May 31 17:10:06 2005 >+++ wine/dlls/setupapi/parser.c Tue May 31 17:10:06 2005 >@@ -852,7 +852,9 @@ static DWORD parse_buffer( struct inf_fi > struct parser parser; > const WCHAR *pos = buffer; > >- parser.start = buffer; >+ if (*pos == 0xfeff) pos++; /* skip Unicode BOM signature */ >+ >+ parser.start = pos; > parser.end = end; > parser.file = file; > parser.line = NULL; > This shouldn't be necessary. The Unicode BOM (or Zero Width Non-Breaking Space) has CT_CTYPE1 of C1_SPACE | C1_BLANK so it should be skipped just like any other whitespace character. -- Rob Shearman

2 1

Re: Default setting for RelayExclude
by Mike Hearn May 31, 2005

May 31, 2005

On Thu, 26 May 2005 01:15:45 +0100, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Default setting for RelayExclude Alexandre, any reason this didn't get in? thanks -mike

2 2

Re: Fix implicit loading of 16bit GDI & USER
by Alexandre Julliard May 31, 2005

May 31, 2005

Richard Cohen <richard(a)daijobu.co.uk> writes: > Changelog > Implicitly loaded 16bit GDI & USER need an EXE extension This is wrong, the EXE extension is present in the module filename, the loader shouldn't need to know about it. The problem is probably that GDI isn't pre-loaded, which is the case for 32-bit apps now that GDI no longer needs the local heap. What app is causing the problem? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [Fwd: Re: Extending File Dialog to include unix file paths]
by Michael Lin May 31, 2005

May 31, 2005

Hi Alexandre, I haven't got a reply from you on this issue yet. Please let me know what you think of the patch. Thanks, Michael Michael Lin wrote: > Hi Alexandre, > > I have made the changes as you suggested to put all the entry point in > one single library. > > Basically, I have created a new library called wineunixfs. > It currently contain modified version of filedlg.c and > filedlgbrowser.* and all their dependent files from commdlg. > > I have attached the diff file for the rest of the changes that's on > the core libraries. > I didn't attach the files in wineunixfs as you seems ok with > duplicating code there and modify it there. > > Most of the changes are contained within shell32 libraries to make it > aware of whether it is in unix or dos path mode. > There is only one exported function been added and that is > SHUnixFSGetDesktopFolder() in shell32. > > Could you please take a look at the patch and let me know if this is > "clean" and acceptable. > > Thanks, > Michael >

2 1

Re: tab: Shift selected tab text up instead of down [RESEND]
by Mike McCormack May 31, 2005

May 31, 2005

> + if (iItem == infoPtr->iSelected) > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) - infoPtr->uVItemPadding) / 2; > + else > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) + infoPtr->uVItemPadding) / 2; Wouldn't it be clearer as: center_offset_v = (drawRect->bottom - drawRect->top) + (rcText.bottom - rcText.top); if (iItem == infoPtr->iSelected) center_offset_v -= infoPtr->uVItemPadding; else center_offset_v += infoPtr->uVItemPadding; center_offset_v /= 2; That breaks up the long lines, and eliminates the common sub-expressions... Mike

1 0

generic.ppd isn't installed anymore
by Vincent Béron May 31, 2005

May 31, 2005

Hi, wineps/generic.ppd isn't installed anymore since a couple weeks ago (didn't had time yet to pinpoint exact patch). I think it's because only __install-lib__ and __install-dev__ is done in dlls/ now, and not __install__, which is the target actually installing wineps/generic.ppd. A quick'n dirty way is to run make -C dlls/wineps install after make install but it should really be fixed properly I guess. Vincent

1 0

Re: wine/dlls/x11drv keyboard.c
by Francois Gouget May 31, 2005

May 31, 2005

On Sun, 29 May 2005, Alexandre Julliard wrote: [...] > Log message: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Fix Estonian keyboard layout to better match the X11 one. I have noticed that we get a steady trickle of these. Shouldn't it be possible to get the definitions of all keyboards from the XFree sources and find some way to automatically import them? The other trickle we're seeing is with timezones. So in a similar way maybe we could get the data from the site below and import it all: http://www.timeanddate.com/library/abbreviations/timezones/ Would this make sense? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

3 2