- Wine-Devel - list.winehq.org

Re: Write problem with MS Office 2003
by Juan Lang May 26, 2005

May 26, 2005

Hi Stefan, --- Stefan D�siner <stefandoesinger(a)gmx.at> wrote: > How do I handle apidl == NULL? As far as I understand, apidl specifies a > list > of folders/files to be checked, right? If apidl == 0, what folder should > I > check. Is there some 'current folder' in the IShellFolder class? I > didn't > find any. Right, apidl can't be NULL if cidl is nonzero. If cidl is zero, you probably need the check to be in the caller. E.g. in shfldr_fs.c, the current folder is what calls SHELL32_GetItemAttributes, from IShellFolder_fnGetAttributesOf. Perhaps the dwAttributes member that's passed to InitializeEx sets the correct attributes for the current folder? I'm not sure. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new Resources site http://smallbusiness.yahoo.com/resources/

4 14

IShellFolder::GetDisplayNameOf vs. SHGetPathFromIDList
by Michael Jung May 26, 2005

May 26, 2005

Hi Alexandre, could you please give me a hint on this one: http://www.winehq.org/hypermail/wine-patches/2005/05/0567.html My guess is that you want me to write a test, showing that windows' comdlg32 does it this way. The problem is, I don't know how. We would have to temporarily register a shell namespace extension on Windows, then call one of the file dialogs and show that the GetDisplayNameOf method is called with the SHGDN_FORPARSING flag set, when the user selects a path from the extension. This would be a pretty complex test, which includes user interaction and thus doesn't fit into wine's test framework (or am I wrong?). Could you (or anybody on wine-devel) give me a hint? Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: MSXML: add some idl definitions (exposes a widl bug)
by Alexandre Julliard May 26, 2005

May 26, 2005

Mike McCormack <mike(a)codeweavers.com> writes: > This patch demonstrates a problem with widl. This following > declaration fails to parse correctly, as "async" is detected as a > keyword, and disallowed as the name of a method in an interface. > > [propget, id(DISPID_XMLDOM_DOCUMENT_ASYNC)] > HRESULT async( [out,retval] VARIANT_BOOL *isAsync ); > > For the moment, I've hacked this by renaming "async" to "async_". Yes, keyword handling is broken. You can probably work around it by adding async to the list of keywords supported by the ident: token, but it would certainly be nice to fix this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: docs/. configure.ac
by Francois Gouget May 26, 2005

May 26, 2005

Dimi Paun wrote: [...] > Modified files: > . : configure.ac > > Log message: > Francois Gouget <fgouget(a)codeweavers.com> > Warn the user if docbook2html is missing. Offer hints as to which > packages he needs to install. > > > Old revision New revision Changes Path > 1.2 1.3 +12 -0 docs/configure.ac Hmm, you forgot to regenerate the configure script. The problem is my autoconf version is a bit different which results in extra changes. So I prefer not to send my configure diff and let you regenerate it... -- Francois Gouget fgouget(a)codeweavers.com

2 1

Re: avoid msvfw32 crash
by Alexandre Julliard May 26, 2005

May 26, 2005

luis lenders <lgvlenders(a)yahoo.co.uk> writes: > Index: wine/dlls/msvideo/drawdib.c > =================================================================== > RCS file: /home/wine/wine/dlls/msvideo/drawdib.c,v > retrieving revision 1.24 > diff -u -p -r1.24 drawdib.c > --- wine/dlls/msvideo/drawdib.c 17 Jan 2005 15:33:43 -0000 1.24 > +++ wine/dlls/msvideo/drawdib.c 24 May 2005 19:09:28 -0000 > @@ -242,7 +242,10 @@ BOOL VFWAPI DrawDibBegin(HDRAWDIB hdd, > TRACE("Not compressed!\n"); > dwSize = lpbi->biSize + num_colours(lpbi)*sizeof(RGBQUAD); > whdd->lpbiOut = HeapAlloc(GetProcessHeap(), 0, dwSize); > - memcpy(whdd->lpbiOut, lpbi, dwSize); > + if (whdd->lpbiOut) > + memcpy(whdd->lpbiOut, lpbi, dwSize); > + else > + ret=FALSE; Sounds like we need a check that the number of colors is reasonable. The HeapAlloc shouldn't normally fail except if the size is bogus. -- Alexandre Julliard julliard(a)winehq.org

1 0

MSI gui questions
by Stefan Dösinger May 26, 2005

May 26, 2005

Hello, The native windows installer has support for a gui, but Wine's msi doesn't (yet). I had a look at this, and it seems that there are already some functions in dlls/msi/dialog.c which are for GUI handling. I had a look at the msi documentation in the MSDN. It appears to me that most dialogs are implemented in the msi file. Well, I tried to implement the PreActionDialog ACTION. I had no problem in adding a new function for that action. According to my observations, I have to call msi_dialog_create with the name of the dialog I want to create. Is there any reference about the dialogs' names? Do I have to write those dialogs(create the GUI), or is this done by the code in the .msi file? Thanks for your help, Stefan

2 1

Re: check for mkdir mode
by Dmitry Timoshkov May 26, 2005

May 26, 2005

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > +int sys_mkdir(const char *path, mode_t mode) > +{ > +#ifdef HAVE_MKDIR_MODE > + return mkdir(path, mode); > +#else > + return mkdir(path); > +#endif > +} Wouldn't it be better to emulate mkdir(path, mode); with mkdir(path); chmod(path, mode); -- Dmitry.

2 1

Wine on Sparc
by Chuck Hall May 26, 2005

May 26, 2005

Greetings, I have heard that people are using Wine on Solaris. I would like to know if they are using Wine on the SPARC version or the x86 version of Solaris? There does seem to be code within Wine to have it run on SPARC machines, but it currently does not seem to compile, at least on the Solaris version. I have attached a small patch that allows me to get throught the 'make depend' section of the compile. Since it is my first patch, please look at and let me know what I did wrong :) Have Fun! Chuck Hall

5 10

Question about advapi32/eventlog.c
by David Hemmo May 25, 2005

May 25, 2005

Hello The stubs in eventlog.c return an odd value (0xcafe4242) instead of NULL. For example, in RegisterEventSourceW, NULL would be an error and would mean the register did not work. The current value doesn't tell the application that it didn't work. Is there a reason ? Thanks David Hemmo

2 1

Re: Fix Sparse Warnings for server/ (Try 2)
by Alexandre Julliard May 25, 2005

May 25, 2005

Robert Shearman <rob(a)codeweavers.com> writes: > --- server/fd.c 24 Apr 2005 17:35:52 -0000 1.37 > +++ server/fd.c 24 May 2005 18:37:28 -0000 > @@ -898,18 +898,6 @@ static void remove_lock( struct file_loc > release_object( lock ); > } > > -/* remove all locks owned by a given process */ > -void remove_process_locks( struct process *process ) > -{ > - struct list *ptr; > - > - while ((ptr = list_head( &process->locks ))) > - { > - struct file_lock *lock = LIST_ENTRY( ptr, struct file_lock, proc_entry ); > - remove_lock( lock, 1 ); /* this removes it from the list */ > - } > -} > - Something's not right, that function should be used somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0