- Wine-Devel - list.winehq.org

Re: shell32/brsfolder.c
by Michael Jung April 12, 2005

April 12, 2005

Hi Wolfgang, On Tuesday 12 April 2005 22:30, you wrote: > As you might have guessed, I don't have too much knowledge about > Windows programming. All I wanted to do in the first place was getting > the DVD Shrink dialog to work ;-) I didn't mean to bash your patch. If DVD Shrink doesn't work as on Windows then obviously there something is not correctly implemented in wine. I'm not that familiar with the Windows API either, but I do have two more comments on your patch. > So in order to fix the DVD Shrink failure, only the following change is > needed: > > # -----8<-----(snip)---------- > @@ -100,6 +100,13 @@ > ILRemoveLastID(pidlParent); > pidlChild = ILClone(ILFindLastID(root)); > > + /* This is needed to avoid duplication of the Desktop GUID, > + when an empty PIDL is passed in! */ > + if (_ILIsDesktop(pidlChild)) { > + ILFree( pidlChild ); > + pidlChild = NULL; > + } > + > if (_ILIsDesktop(pidlParent)) { > hr = SHGetDesktopFolder(&lpsfParent); > } else { > # ----->8-----(snap)---------- > > I still like the BFFM_SETSELECTION feature though. You should probably split this up into two individual patches, then. This would make it easier to find misbehaving code later on. > + { > + /* Always show selection */ > + LONG_PTR dlg_style; > + dlg_style = GetWindowLongPtrW(hwndTreeView, GWL_STYLE); > + dlg_style |= TVS_SHOWSELALWAYS; > + SetWindowLongPtrW(hwndTreeView, GWL_STYLE, dlg_style ); > + } > + This probably belongs into the shell32_*.rc files (look for SHBRSFORFOLDER_MSGBOX). Unfortunately, you have to fix it for all the localized versions. I (and I'm sure all of the wine folks, too) do appreciate your effort. Please go ahead and submit to wine-patches. Alexandre will decide if it's ready for inclusion. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

[NtQuerySystemInformation #1] Fixes + tests (second round)
by Paul Vriens April 12, 2005

April 12, 2005

Hi, this is a second go at some unit tests and related fixes for NtQuerySystemInformation. The ultimate goal is to get SysInternal's Process Explorer running. I welcome suggestions and remarks. If none I will submit this to wine-patches and start the further works. The differences between this one and the first is that I've tried to get the needed length regardless of the passed Length. This is how SystemProcessInformation and some others work and how MSDN tells us it should be implemented. I've also found that M$ doesn't always do this. The patch after this one will add so more unit tests. For example SystemTimeOfDayInformation will always return STATUS_SUCCESS even if the given buffer is too small. Cheers, Paul Vriens. Changelog Start of unit tests for NtQuerySystemInformation Return STATUS_INVALID_INFO_CLASS for non-implemented classes Return len regardless of given Length Return STATUS_INFO_LENGTH_MISMATCH if given length is not sufficient Return STATUS_ACCESS_VIOLATION if no buffer given

1 0

shell32/brsfolder.c
by Michael Jung April 12, 2005

April 12, 2005

Hi Wolfgang, @@ -400,24 +423,41 @@ static LRESULT MsgNotify(HWND hWnd, UIN break; lptvid=(LPTV_ITEMDATA)pnmtv->itemNew.lParam; - if (SUCCEEDED(IShellFolder_BindToObject(lptvid->lpsfParent, lptvid->lpi,0, (REFIID)&IID_IShellFolder,(LPVOID *)&lpsf2))) - { FillTreeView( lpsf2, lptvid->lpifq, pnmtv->itemNew.hItem,lptvid->pEnumIL); + if ( _ILIsDesktop( lptvid->lpi )) + { + /* Always fill Desktop node without binding to object */ + FillTreeView( lptvid->lpsfParent, lptvid->lpifq, pnmtv->itemNew.hItem, lptvid->pEnumIL); + } + else if (SUCCEEDED(IShellFolder_BindToObject( + lptvid->lpsfParent, lptvid->lpifq, ^^^^^ In TV_ITEMDATA variables, lpsfParent is the IDL of the parent, lpi is the relative IDL to the child and lpifq is the fully qualified IDL to the child. So what you are doing here effectively is to concatenate the parent's IDL with the fully qualified IDL. Replacing this with "lptvid->lpi" fixes the problem in winecfg. There are several occurences of "_ILIsDesktop( lptvid->lpi )" in your patch, which semantically doesn't make much sense to me, since lpi is only the relative IDL. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Cross-building went wrong
by Paul Millar April 12, 2005

April 12, 2005

Hi all, [yawn] One of the new tests broke winetest build (see below). Anyone have a suitable patch against mingw that adds StgCreatePropSetStg? Cheers, Paul. [paul(a)quisquiliae tests]$ make i686-mingw32msvc-gcc marshal.o moniker.o propvariant.o stg_prop.o storage32.o testlist.o -o ole32_test.exe -loleaut32 -lole32 -luser32 -lkernel32 -lntdll -luuid stg_prop.o(.text+0xe8): In function `testProps': /home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:55: undefined reference to `StgCreatePropSetStg(a)12' stg_prop.o(.text+0xdef):/home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:217:undefined reference to `StgCreatePropSetStg(a)12' distcc[2034] ERROR: compile on localhost failed make: *** [ole32_test.exe] Error 1

1 0

Rough Draft
by Andrew Neil Ramage April 12, 2005

April 12, 2005

Rough Draft is a useful Windows word processor that natively saves files in .RTF format. Unfortunately, when installing it I got the following errors: fixme:richedit:RichEditANSIWndProc EM_AUTOURLDETECT: stub fixme:richedit:RichEditANSIWndProc WM_SETFONT: stub fixme:richedit:RichEditANSIWndProc EM_LIMITTEXT: stub fixme:richedit:RichEditANSIWndProc EM_EXLIMITTEXT: stub fixme:richedit:ME_ReleaseStyle all style references freed (good!) err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 4320 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 376 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects Anyone know why I get all the fixme's ? -- Andrew Beneath the noble bird Between the proudest words Behind the beauty, cracks appear Once with heads held high They sang out to the sky Why do their shadows bow in fear? Beneath, Between and Behind by Rush (Fly By Night, 1975) ---------------------------------------

2 1

Re: Fix for shell32.SHBrowseForFolder (proper Desktop tree + BFFM_SETSELECTION implemented)
by Michael Jung April 12, 2005

April 12, 2005

Hi Wolfgang, On Tuesday 12 April 2005 01:03, Wolfgang Scherer wrote: > Solution > -------- > Fix TreeView setup behavior. Implement BFFM_SETSELECTION > functionality. I've tried your patch and it breaks the SHBrowseForFolder usage in winecfg's drive mapping property sheet. I don't have time now, but will look into it soon (hopefully this evening). The last patch, which was applied to this code is http://www.winehq.org/hypermail/wine-cvs/2005/03/0017.html Would you mind to try if this one broke DVD Shrink 3.2? (patch -R) Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: lostwages/templates/en status_ui.template
by Jacek Caban April 12, 2005

April 12, 2005

Log message: Dimitrie O. Paun <dpaun(a)rogers.com <mailto:dpaun(a)rogers.com?Subject=Re:%20lostwages/templates/en%20status_ui.template>> * Work is ongoing on richedit * Audit of Syslink * We've done all we can on shdocvw.dll for now ... - <td class="pct25">25%: implement shdocvw.dll</td> + <td class="pct100">100%: We forward to Mozilla, but more work is needed on Mozilla for compatibility.</td> I completely disagree. We can do much more than there is done right now. shdocvw is more than WebBrowser control and we can inplement those areas, but WebBrowser needs a lot of work as well. Mozilla ActiveX Control seems not to be systematically developed and the compability we need is not their aim. We need an implementation of WebBrowser based on MSHTML, which will be possible when I finish my work on it. This way we'll be able to implement shdocvw correctly (eg. it'll be possible to implement Internet Explorer OLE Automation), but now it's far, far away from it and really far from 100% complete.

5 9

shell32, ntdll tests
by Aaron Arvey April 11, 2005

April 11, 2005

Is anyone currently working (or have feedback) on tests for ntdll/loader.c, ntdll/virtual.c, shell32/folder.c, shell32/shlexec.c, or shell32/shell_main.c? More specifically, is it worth the time to write tests for ntdll/loader.c and ntdll/virtual.c? It seems that these files would be used to load any program, so if there were any bugs, I'm guessing they would become apparent immediately and thus having formal tests would be somewhat pointless. Please correct (or reaffirm) me as I am going to write some tests in my spare time and I want to make sure that they'd be useful to the wine project. I'm looking at these specific files because they have code which is run by google's picasa 2, but not by the wine test suite. Thanks! Aaron

2 1

Re: OLEAUT32: Don't crash on divide by zero
by Marcus Meissner April 11, 2005

April 11, 2005

On Mon, Apr 11, 2005 at 12:47:22PM -0700, Daniel Remenak wrote: > Changelog: > Return DISP_E_DIVBYZERO instead of crashing when asked to divide a > variant by zero. You cannot really compare floats against 0 I think. Ciao, Marcus

2 1

CVS Checkout: Wineowner's lock???
by Jan Schiefer April 11, 2005

April 11, 2005

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 When I try to checkout wine's cvs I get: ... cvs server: [13:54:51] waiting for wineowner's lock in /home/wine/wine/dlls/shell32 I got no idea about his one...??? Greetings, Jan Schiefer! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCWshmzC00UKXFdVcRAqqeAJsGRLvbeb2Y+IA5DLyeFtqwiAdZXgCgl389 XguDPLoWPG0oHjKPldx1PSA= =8bZH -----END PGP SIGNATURE-----

1 0