- Wine-Devel - list.winehq.org

Re: winmm patch
by Dimitrie O. Paun March 20, 2005

March 20, 2005

On Sat, Mar 19, 2005 at 07:46:01PM -0600, Royce Mitchell III wrote: > Royce Mitchell III <royce3(a)ev1.net> > - fix warning that is really a bug - from looking at the code, wDevID > should be a UINT, not a UINT_16 ( perhaps these should be renamed? ) Please: 1. Send a diff -u (http://winehq.org/site/sending_patches) 2. Don't compress your submissions. -- Dimi.

1 0

Re: Correct calling conventions
by Marcus Meissner March 20, 2005

March 20, 2005

On Sat, Mar 19, 2005 at 08:30:44PM -0500, Vincent Béron wrote: > Changelog: > Use the correct calling convention in various places. The problem here is too, that these functions do not have prototypes in the correct headers, otherwise gcc would have already warned about them. Ciao, Marcus

2 1

winmm problems
by Robert Lunnon March 20, 2005

March 20, 2005

I am having some problems with the latest wine under Solaris and a small test game I use, (Little Fighter 2) , if I enable audio support the application seems to deadlock but without audio it runs OK. It doesn't matter what audio driver I select (libaudioio or arts). Since February, what changes have been made to the audio framework that might cause this behaviour? Bob

1 0

Four questions to dll/iphlpapi/* wrt lstrcpyA.
by Peter Berg Larsen March 20, 2005

March 20, 2005

Hi, I was looking at the Janitorial project of replacing strncpy with lstrcpyn{A,W}. I found the following code in iphlpapi a little strange. (Well, only question number 2, but then could as well ask about the 2 others.) I have marked where in the code the question belongs to with the question numbers. 1) I am wondering, why sizeof(ptr->Adaptername) is used instead of MAX_ADAPTER_NAME_LENGTH+1? Is there something special coded in the 3 last bytes, since they are hidden by the = '\0' the line below? if not then this be replaced with lstrcpyn(... , MAX_ADAPTER_NAME_LENGTH+1)? 2) Is 2a supposed to be saying 15 or is there someting about IpMask and Context that must be zero, when setting IpAddress, and IpMask? 3) Why suddenly the change to use memcpy? and not some strcpy function as the code above it? Peter typedef struct { char String[4 * 4]; } IP_ADDRESS_STRING, IP_MASK_STRING, ...; typedef struct _IP_ADDR_STRING { struct _IP_ADDR_STRING* Next; IP_ADDRESS_STRING IpAddress; IP_MASK_STRING IpMask; DWORD Context; } IP_ADDR_STRING, *PIP_ADDR_STRING; typedef struct _IP_ADAPTER_INFO { ... char AdapterName[MAX_ADAPTER_NAME_LENGTH + 4]; char Description[MAX_ADAPTER_DESCRIPTION_LENGTH + 4]; BYTE Address[MAX_ADAPTER_ADDRESS_LENGTH]; IP_ADDR_STRING IpAddressList; ... IP_ADDR_STRING PrimaryWinsServer; IP_ADDR_STRING SecondaryWinsServer; } IP_ADAPTER_INFO, *PIP_ADAPTER_INFO; ipenum.c: 936 char *toIPAddressString(unsigned int addr, char string[16]) { if (string) { struct in_addr iAddr; iAddr.s_addr = addr; /* extra-anal, just to make auditors happy */ strncpy(string, inet_ntoa(iAddr), 16); string[16] = '\0'; **** 2a **** } return string; } iphlpapi_main.c: 584 DWORD WINAPI GetAdaptersInfo(PIP_ADAPTER_INFO pAdapterInfo, PULONG pOutBufLen) { ... PIP_ADAPTER_INFO ptr = &pAdapterInfo[ndx]; ... 1) /* on Win98 this is left empty, but whatever */ strncpy(ptr->AdapterName, getInterfaceNameByIndex(table->indexes[ndx]), sizeof(ptr->AdapterName)); ptr->AdapterName[MAX_ADAPTER_NAME_LENGTH] = '\0'; ... 2) toIPAddressString(getInterfaceIPAddrByIndex(table->indexes[ndx]), ptr->IpAddressList.IpAddress.String); toIPAddressString(getInterfaceMaskByIndex(table->indexes[ndx]), ptr->IpAddressList.IpMask.String); ... 3) memcpy(ptr->PrimaryWinsServer.IpAddress.String, primaryWINS.String, sizeof(primaryWINS.String)); memcpy(ptr->SecondaryWinsServer.IpAddress.String, secondaryWINS.String, sizeof(secondaryWINS.String)); ... }

1 0

kde plugin
by Oliver Stieber March 20, 2005

March 20, 2005

Hi, I've got a plugin for KDE that displays icons and thumbnails for windows applications and dlls in Konqueror. I was intending to extend it to meta info and maybe a full kioslave for browsing windows PE files, but never got that far. At the moment it's a bit of a licensing nightmare, but I can package it up in a format that's ok for QT and Wine if anyone's interested. Oliver. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 3

Re: Theming for Wine via the registry
by Oliver Stieber March 20, 2005

March 20, 2005

--- Mike Hearn <mike(a)navi.cx> wrote: > On Sat, 2005-03-12 at 21:00 +0000, Oliver Stieber > wrote: > > > > > > Ah, that's different. That'd actually require > using > > > Gtk/Qt which we cannot > > > do, the best we can get is to look like them. > > > > > What's the problem, licensing, integration or > > thread-safety (I know QT isn't thread safe) > > Well all those *could* be problems, but the real > problem is that the > Windows widget toolkit and GTK/Qt are too different, > you can't map > between them. The only problem I can see would be drawing the widgets, I haven't looked deeply enough into QT or GTK to know if it's more on the 'impossible' side of difficult or not. Wrapping the event loop and passing events should be relatively easy. > > I may have a look at that too, it would be useful > if > > QT/GTK could use some of the existing Windows > > accessibility software. > > No, that's not what I meant. Implementing OLE > accessibility would mean > that Win32 apps on Wine appear to in native tools > like at-poke. It > wouldn't mean you could use win32 accessibility > software to access > native apps. > That doesn't sound too hard, I don't know how well defined Gnome and QT's accessibility interfaces are but I think QT's coming along quite well it would be nice is everything got Dbused though. Send instant messages to your online friends http://uk.messenger.yahoo.com

4 3

Re: dlls/advapi32/tests/security.c - Bugfix in test!
by Alexandre Julliard March 19, 2005

March 19, 2005

Jakob Eriksson <jakov(a)vmlinux.org> writes: > --- dlls/advapi32/tests/security.c 14 Mar 2005 17:20:58 -0000 1.12 > +++ dlls/advapi32/tests/security.c 16 Mar 2005 09:32:28 -0000 > @@ -289,8 +289,8 @@ > luid.LowPart = i; > cchName = sizeof(buf); > ret = pLookupPrivilegeNameA(NULL, &luid, buf, &cchName); > - ok( ret && GetLastError() != ERROR_NO_SUCH_PRIVILEGE, > - "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); > + if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) > + ok( ret, "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: Wine FAQ removed from the doc tarballs
by Hiji March 19, 2005

March 19, 2005

> I always find it annoying when I cannot go to > /usr/share/doc/<package> I suppose the other option is to provide all docs as a seperate package on a release basis (like any other package.) I could be wrong on this, but I don't think the docs are updated on a monthly basis. :) For example, a user could see that the newest Wine package released thus far is from March and the newest Wine docs package could be November of last year (arbitrary date). And if its only 23kb, it shouldn't be much of a problem for modem users; escpecially since it saves them from having to download an extra 23kb with every Wine release when they don't really need it. :) Hiji P.S. Looking at http://www.gimp.org/downloads/ , it looks like they are already doing something similar with their help files. They offer them as a seperate download. __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: RICHED20: remove casts and unused code
by Dimitrie O. Paun March 19, 2005

March 19, 2005

> +static inline char *RTFStrSave(char *s) Not a big deal, but the name is a bit uncommon. Wouldn't RTFStrDup() be a better/more recognizable name? -- Dimi.

1 0

Re: Wine FAQ removed from the doc tarballs
by Hiji March 19, 2005

March 19, 2005

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > On Fri, Mar 18, 2005 at 02:04:08PM +0100, Francois > Gouget wrote: > > But I don't see any reason not to put it in > wine-doc-html.tar.gz or > > wine-doc-txt.tar.gz. The idea of these tar files > is so that one can get > > all the Wine documentation with just one download > and the FAQ is part of > > the documentation. > > Yes, but I can not possibly see why would anyone > want to download and > read the FAQ like this. A FAQ is essentially a Web > type of document, > best view and browsed on the Web. By including it in > those packages, > we just make them bigger for 99.99% of the users > that don't care > about the FAQ, and those users are probably the ones > that have most > bandwidth restrictions anyway. > > But I'm not totally against it being there, if > people feel strongly > that we must, I'll go with the flow. As a web developer (and Wine user), I feel inclined to believe that all major documentation should be removed from the source. A README file pointing the user to the web site for the latest documentation would be most efficient and beneficial. Basically, by doing this, users will begin realizing that if they want documentation, WineHQ is the place to go. In a sense, it is streamlining information. Not only does this reduce user confusion, but it also minimizes the propagation of old documentation which no one will have the power to update. By not consolidating the documentation resource, there will eventually be a certain percentage of the Wine userbase trying to follow outdated Wine documents. Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2