- Wine-Devel - list.winehq.org

Q? system wide variables
by Oliver Stieber Jan. 30, 2005

Jan. 30, 2005

Hi, I need to track the 'fake' amount of video memory in total, allocated and left for Directx 9 and would like to track it across wine so that DDraw, DirectX, DxDiag and X11 driver can all sing from the same song sheet. What's the best place to do this? is the registry code fast enough or should I add a new function to the X11 driver so that I can request and release 'fake' video memory and make all other AvailableVideoMemory requests ask X11 driver? I would expect the use to be able to override by the initial amount, even if there's code that detects it since wine,X and openGL manage video memory differently to windows, direct draw and D3D. ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

5 5

Re: small fix SafeArryDestroy
by Rob Shearman Jan. 30, 2005

Jan. 30, 2005

Rein Klazes wrote: >Hi, > >Makes WJChess, a French made chess game, accept moves. > >Changelog: > dlls/oleaut32 : safearray.c > SafeArrayDestroy() returns success when called with a NULL > pointer. > > It would be nice to have a test for this as there are already a large number of SafeArray tests. Rob

1 0

ole:register_ifstub couldn't get IPSFactory buffer for interface
by Uwe Bonnes Jan. 29, 2005

Jan. 29, 2005

Hallo, trying to install the the German TAX software "Steuersparerklaerung 2005" the Installshield installer runs into: err:ole:register_ifstub couldn't get IPSFactory buffer for interface {00000131-0000-0000-c000-000000000046} and aborts. The IRemUnknown implementation seems to be brand new from Robert as of this monday. Is there any fix to get around above problem? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 7

Re: MSVCRT: Re-implement *printf
by Aneurin Price Jan. 29, 2005

Jan. 29, 2005

Changelog: > Re-implement all *printf functions in msvcrt.dll, according to > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html… > > and descriptions of appropriate functions. > This should fix, among other things, bugs 321 and 2075. > Nobody has any comments about this?

3 3

Re: [shlwapi/tests/shreg] Tests question
by Juan Lang Jan. 29, 2005

Jan. 29, 2005

> What's the best approach in this? > - fix Wine (but what should be the correct returned buffer?) Definitely fix Wine. Hopefully there isn't an app that depends on one behavior under Windows 98, and a different one under Windows XP. It's perhaps less likely because Wine's implementation isn't correct in either case? Pick one of the versions to match, document the difference with other versions. If needed later someone can change the function to check at runtime which version of Windows is being emulated, and match the behavior accordingly. See e.g. http://source.winehq.org/source/dlls/kernel/process.c#L2800 for where this is done. --Juan __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

2 2

Slick build output
by Jason But Jan. 29, 2005

Jan. 29, 2005

Hello all, Not really related to the actual wine development but more to the make/build/install environment. Remembering the most wine users will not necessarily be developers we should consider improving the output of running (./configure && make) to make it more user friendly. Hopefully it should also be less confronting and confusing to non developers. I propose something similar to the way the Linux kernel currently compiles. The included patch changes make so that a regular make will produce much nicer output while for those die-hards who prefer the original output this can be achieved by executing make VERBOSE=yes I personally prefer the neater output even for development work, the compile output doesn't scroll off the screen as quickly and warnings/errors can be more easily spotted. This patch doesn't do the complete job, instead only produces output for the compile (gcc) stages. In fact, (make install) will produce no output at all! If people think this is a good idea, simple extensions will lead to complete output, just add the necessary $(NICE_ECHO) " whatever" to the proper places in each Make*.in file I am willing to do this if it is deemed to be good. Jason

8 10

Re: [IWineD3d + d3d9] bogus query implemetation
by Juan Lang Jan. 29, 2005

Jan. 29, 2005

Hi Oliver, +HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, D3DQUERYTYPE Type, IWineD3DQuery** ppQuery){ + IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; + + if(NULL == ppQuery){ + /*Just a check to see if we support this type of query*/ + HRESULT hr = D3DERR_NOTAVAILABLE; + /*Lie and say everything is good (we can return ok fake data from a stub)*/ + switch(Type){ + case WINED3DQUERYTYPE_VCACHE: + hr = D3D_OK; + case WINED3DQUERYTYPE_RESOURCEMANAGER: + hr = D3D_OK; These are missing a break statement. Better style would be to take advantage of the fallthrough like so: + switch(Type){ + case WINED3DQUERYTYPE_VCACHE: + case WINED3DQUERYTYPE_RESOURCEMANAGER: (all the other WINED3DQUERYTYPE_ cases) + hr = D3D_OK; + break; +struct IWineD3DQueryImpl +{ + IWineD3DQueryVtbl *lpVtbl; + DWORD ref; /* Note: Ref counting not required */ + IWineD3DDeviceImpl *wineD3DDevice; + /* IWineD3DQuery fields */ + D3DQUERYTYPE type; + void *data; + int dataSize; + + +}; What's with the couple of blank lines in the struct declaration? Yeah, so I'm picky ;) +DWORD WINAPI IWineD3DQueryImpl_GetDataSize(IWineD3DQuery* iface){ + IWineD3DQueryImpl *This = (IWineD3DQueryImpl *)iface; + FIXME("(%p) : stub \n", This); + int dataSize = 0; + switch(This->type){ + case WINED3DQUERYTYPE_VCACHE: + dataSize = sizeof(D3DDEVINFO_VCACHE); + case WINED3DQUERYTYPE_RESOURCEMANAGER: Aren't these case statements missing a break statement too? --Juan __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

3 3

[AppDB] Beef up the Application Rating Guidelines
by Francois Gouget Jan. 29, 2005

Jan. 29, 2005

I feel that the current 'Maintainers Ratings System Help' is awfully vague and needs to be beefed up. So I'm attaching a proposal in which I tried to keep the original spirit but make things more precise. * First I'd like to rename this page from Maintainers Ratings System Help to Maintainer's Application Rating Guidelines - I added 'Application' to the title because that's what is being rated, not the maintainers. - I removed 'System' because it does not bring anything. - And I changed 'Help' to 'Guidelines' because this page does not juse tries to help maintainers give a random rating to an application, it tries to define which rating an application can have depending on how it runs. - Finally once the old ratnig system is removed we can remove "Maintainer's" since there will be only one left. * I've also reversed the order of the medals, because it seems a more logical progression and can simplify the explanations: in order to get a Silver medal you must pass all the criterias for a Bronze medal, plus some new ones. * I still feel there's a huge gap between 'Garbage' and 'Bronze' and that it would be interesting to have statistics about the percentage of applications that fail to install, and those that install but crash on startup, both cases which are included in the Garbage category along with those that install and start up but are still not usable. (Chocolate and Tin medals?) I'm attaching the full file as it's much easier to read than a diff. I'll send a diff to wine-patches once the final form has been reached. For reference the original can be found there: http://appdb.winehq.org/help/?topic=maintainer_ratings -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1

[AppDB] Proposed Maintainer Guide
by Francois Gouget Jan. 29, 2005

Jan. 29, 2005

The Application Database is missing a description of the job of an Application Maintainer. So I cleaned up the Maintainer Guide I posted earlier and prepared it for integration into the Application Database site. I attached it to this email for review. Let me know if there is anything missing, things to change, etc. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

2 1

[shlwapi/tests/shreg] Tests question
by Paul Vriens Jan. 29, 2005

Jan. 29, 2005

Hi, I've been testing some of these test extensively and can make them pass on all the windows versions I have running. Doing this however means it breaks the wine test. An example is: /* * string grows during expanding * dwSize is larger then the size of part before the backslash but smaller then the expanded string * if the unexpanded string fits into the buffer it can get cut when expanded */ strcpy(buf, sEmptyBuffer); dwSize = sExpLen2 - 4; dwType = -1; dwRet = SHQueryValueExA( hKey, "Test3", NULL, &dwType, buf, &dwSize); ok( (0 == strcmp("", buf)) | (0 == strcmp(sEnvvar2, buf)), "Buffer should be the first part of the string (win98) or empty otherwise, it's (%s)\n", buf); Wine returns a part of the expanded string here: (ImARatherLongButIndeedNeededString\sub) So Wine doesn't do what either win98/winnt/win2k/winxp does (all latest version of the OS's). What's the best approach in this? - fix Wine (but what should be the correct returned buffer?) - extend the ok, by the returned buffer that Wine gives and effectively ignore the differences. Cheers, Paul.

1 0