- Wine-Devel - list.winehq.org

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#4)
by Joris Huizer Jan. 17, 2005

Jan. 17, 2005

Hans Leidekker wrote: Well, if you really want to be sure no bad string overflows occur, this function is still not save: > +/*********************************************************************** > + * InternetTimeToSystemTimeW (WININET.@) > + */ > +BOOL WINAPI InternetTimeToSystemTimeW( LPCWSTR string, SYSTEMTIME* time, DWORD reserved ) > +{ > + unsigned int i; > + WCHAR *s = (LPWSTR)string; > + > + TRACE( "%s %p 0x%08lx\n", debugstr_w(string), time, reserved ); > + > + if (!string || !time || reserved != 0) return FALSE; > + > + /* Convert an RFC1123 time such as 'Fri, 07 Jan 2005 12:06:35 GMT' into > + * a SYSTEMTIME structure. > + */ > + > + while (*s && !isalphaW( *s )) s++; > + if (*s == '\0' || *(s + 1) == '\0' || *(s + 2) == '\0') return FALSE; > + time->wDayOfWeek = 7; > + > + for (i = 0; i < 7; i++) > + { > + if (toupperW( WININET_wkday[i][0] ) == toupperW( *s ) && > + toupperW( WININET_wkday[i][1] ) == toupperW( *(s + 1) ) && > + toupperW( WININET_wkday[i][2] ) == toupperW( *(s + 2) ) ) > + { > + time->wDayOfWeek = i; > + break; > + } > + } What happens if, the string ends with WININET_wkday[i][0] or WININET_wkday[i][1] ? > + > + if (time->wDayOfWeek > 6) return FALSE; > + while (*s && !isdigitW( *s )) s++; What happens if s just became NULL in this loop ? > + time->wDay = strtolW( s, &s, 10 ); > + > + while (*s && !isalphaW( *s )) s++; > + if (*s == '\0' || *(s + 1) == '\0' || *(s + 2) == '\0') return FALSE; > + time->wMonth = 0; > + > + for (i = 0; i < 12; i++) > + { > + if (toupperW( WININET_month[i][0]) == toupperW( *s ) && > + toupperW( WININET_month[i][1]) == toupperW( *(s + 1) ) && > + toupperW( WININET_month[i][2]) == toupperW( *(s + 2) ) ) > + { > + time->wMonth = i + 1; > + break; > + } > + } What happens if, the string ends with WININET_month[i][0] or WININET_month[i][1] ? > + if (time->wMonth == 0) return FALSE; > + > + while (*s && !isdigitW( *s )) s++; > + if (*s == '\0') return FALSE; > + time->wYear = strtolW( s, &s, 10 ); > + > + while (*s && !isdigitW( *s )) s++; > + if (*s == '\0') return FALSE; > + time->wHour = strtolW( s, &s, 10 ); > + > + while (*s && !isdigitW( *s )) s++; > + if (*s == '\0') return FALSE; > + time->wMinute = strtolW( s, &s, 10 ); > + > + while (*s && !isdigitW( *s )) s++; > + if (*s == '\0') return FALSE; > + time->wSecond = strtolW( s, &s, 10 ); > + > + time->wMilliseconds = 0; > + return TRUE; > +} Yes it's a pain, but if you want to be really strict on this, this is not save yet regards, Joris

3 4

Re: Janitorial : add missing declarations ( #3 )
by Alexandre Julliard Jan. 17, 2005

Jan. 17, 2005

Rémi Assailly <remi.assailly(a)free.fr> writes: > +/* USER */ > +extern DWORD X11DRV_MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *handles, > + DWORD timeout, DWORD mask, DWORD flags ); > +extern void X11DRV_InitKeyboard( BYTE *key_state_table ); > +extern UINT X11DRV_GetKeyboardLayoutList(INT size, HKL *hkl); > +extern HKL X11DRV_GetKeyboardLayout(DWORD dwThreadid); > +extern BOOL X11DRV_GetKeyboardLayoutName(LPWSTR name); > +extern HKL X11DRV_LoadKeyboardLayout(LPCWSTR name, UINT flags); > +extern BOOL X11DRV_UnloadKeyboardLayout(HKL hkl); > +extern HKL X11DRV_ActivateKeyboardLayout(HKL hkl, UINT flags); > +extern SHORT X11DRV_VkKeyScanEx(WCHAR wChar, HKL hkl); There's no need to add prototypes for the exported entry points, they are not called from anywhere inside the dll. It causes more work when changing the functions for no real benefit. -- Alexandre Julliard julliard(a)winehq.org

1 0

unsubscribe lexey
by Alexey A. Gaidioukov Jan. 17, 2005

Jan. 17, 2005

1 0

Re: more tests for tests.winehq.org
by Ferenc Wagner Jan. 17, 2005

Jan. 17, 2005

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > now we have fixed mingw to build the new test. So perform them after > building ;-) > > ChangeLog > --------------- > Include new tests Thanks for your work and attention! -- Feri.

1 0

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]
by Mike Hearn Jan. 17, 2005

Jan. 17, 2005

>>Well, apparently we don't use sched_yield, so the problem must >>> lie somewhere else. Maybe Con can help us out here? Alexandre says he >>> doesn't know what the issue is either and somebody needs to investigate. I >>> guess we do need to concern ourselves over the details :) > > > Interesting. Probably the most valuable information is that it seems to > work fine if we artificially limit the threads to exactly the same > timeslice _or_ we put them at such a low priority that they are forced > to be guaranteed to round robin one task at a time. This is the way 2.4 > used to work which is why with the new 2.6 schedulers which do far more > out-of-order rescheduling some applications have a problem; particularly > under load. I suspect it's actually the latter issue. Locking between > threads should prevent that being a problem, though. You already > mentioned that you dont use sched_yield() and I couldn't even begin to > look at the wine code myself so perhaps you know something more. Hi Con, One thought that occurred to me, and this is just a random theory, is that maybe the issue is not with the Wine code but the Win32 code run on top of it. Do you know how 2.6 scheduling compares with 2.4 and Windows (NT) scheduling? Could it be that some apps are written to expect Windows-style scheduling and fail to work if they don't get it? In case you hadn't noticed, I'm afraid I only have first-year CS knowledge of scheduling :/ thanks -mike

17 43

unsubscribe rajarani
by Ishaq M. Jan. 16, 2005

Jan. 16, 2005

Systems Engineer Onward Novell Software (I) Pvt.Ltd. ph +91(11)2905-2642 mobile:9810404350

1 0

DIB direct drawing - Bug 412: Implementing a DIB engine
by Alejandro Bonet Jan. 16, 2005

Jan. 16, 2005

Well, i'm a novice here (in wine and linux), but i think i could help with this task. I'm a good windows application developer (www.babel7.com) and i wrote two programs with some of the semantics you are looking for: painting over BMPs (or better DIBs). The 2 programs are for 256 colors and true RGB. They write on file BMPs. The painting functions were written to generate pie graphs, poligonals, rectangles, and so on, but they can be readapted to write on DIBs in memory. The sintax help (comm line wo parms) is in Spanish, but i will not ask for excuses for it. The use is very simple. I will rewrite an english sintax help if i begin with the task. You can download it and test if i could help. If yes, i will begin with the task... And time will say!! http://www.babel7.com/bmps.zip Regards... Aljandro Bonet Babel Informatica SL Madrid alex(a)winbabel.org

1 0

Mailing list statistics and graphs
by Mike McCormack Jan. 16, 2005

Jan. 16, 2005

Fellow bean counters! On the weekend I wrote a quick script to generate a graph of the number of patches committed to the Wine CVS per month. The script and the graph it generates are attached. Anybody think it would be interesting to have a page of similar graphs on WineHQ somewhere that's regenerated once a month? Some ideas: patches committed to winehq per month patches sent to wine-patches per month unique patch authors vs. months lines of code committed per month lines of code sent per month ... Mike Dept of Time Wasting and (Mostly) Useless Statistics #!/usr/bin/perl # filename : winestat.pl # author : Mike McCormack # # A script to generate a graph with the number of patches against Wine per month. use strict; sub make_stat($) { my $month=$_[0]; my $winepatches=0; my $appdbpatches=0; my $lostwagespatches=0; my $cmd = sprintf("wget -q -O - http://www.winehq.org/hypermail/wine-cvs/%d.%02d.txt",$month/12 + 2001,$month%12+1); #print "$cmd\n"; open(IN,"$cmd|") || die "failed to run wget\n"; while(<IN>) { #print $_; if ( s/^Subject: *// ) { #print $_; if ( /^wine/ ) { $winepatches++; } elsif ( /^lostwages/ ) { $lostwagespatches++; } elsif ( /^appdb/ ) { $appdbpatches++; } else { #print "unknown module $_\n"; } } } printf(OUT "%d %3d %3d %3d\n", $month, $winepatches, $lostwagespatches, $appdbpatches); close IN; } my $month; open(OUT, ">stat"); for($month=1; $month<=(12*4+1); $month++) { make_stat($month); } close OUT; # <mike_m> it'd be nice to figure out how to get the x axis to display the date nicely # <papineau> set xdata time open (GNUPLOT, "|gnuplot"); print GNUPLOT "set title \"Wine patches\"\n"; print GNUPLOT "set xlabel \"Months\"\n"; print GNUPLOT "set ylabel \"Number\"\n"; print GNUPLOT "set term png xffffff x000000 x404040 x0000c0 xffa500 x66cdaa xcdb5cd\n"; print GNUPLOT "set boxwidth 0.3\n"; print GNUPLOT "set output \"winestat.png\"\n"; print GNUPLOT "plot \"stat\" using 1:2 title \"Wine\" w boxes fs solid 1\n"; #print GNUPLOT "plot \"stat\" using 1:2 title \"Wine\" w boxes fs solid 1, \\\n"; #print GNUPLOT " \"stat\" using 1:3 title \"Appdb\" w boxes fs solid 2, \\\n"; #print GNUPLOT " \"stat\" using 1:4 title \"LostWages\" w boxes fs solid 3 \n"; close GNUPLOT;

1 0

Pirates! under wine
by Oliver Stieber Jan. 16, 2005

Jan. 16, 2005

Hi, I've been working on DirectX 9 over the past week and have managed to get Sid Meier's Pirates! http://www.atari.com/pirates/pirates/index.php working better than it does for me under cedega (see screenshot attached) along with quite a few demos using Directx 9. There's still quite a lot of work to do to get a full Directx 9 implementation but it shouldn't take too long to get Directx 9 in wine as functional as DirectX under cedega. I'm just doing a bit of housekeeping so the patches will be ready for next week along with a list of what's working and what's not. ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

4 6

Q HeapAlloc.
by Oliver Stieber Jan. 16, 2005

Jan. 16, 2005

Hi, I been having a problem where HeapAlloc is failing even though there's plenty of virtual memory left I've done a bit of digging but haven't been able to get to the bottom of it. First of all I've checked that HeapAlloc will go into swap by allocating a lot of 64meg blocks and writing to them to force linux to allocate them properly, and it works fine. Then I changed alloc.c so that CreateSubHeap writes the status returned by NtAllocateVirtualMemory and I get C00017 STATUS_NO_MEMORY. HEAP_CreateSubHeap Could not allocate 00410000 bytes reason: C00017 [STATUS_NO_MEMORY] an I double checked this by putting a malloc in just after the failure, which failed. So then I wrote a a small non-wine test program run as a seperate process to allocate ten times as much ram and ran it while just after the crash (while the debug box was still up) and it works fine. Any ideas? Top says Mem: 514916k total, 388032k used, 126884k free, 4244k buffers Swap: 401584k total, 251488k used, 150096k free, 62916k cached Virt : 2279m RES : 150m Shared: 807m Mem : 30.0% wine-preloader ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

3 5